148192 2015-08-19 14:33:04 -0700 Web Inspector: Unexpected node preview format for an element with newlines in className attribute 2015-08-19 15:33:23 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1119029 0 joepeck 2015-08-19 14:33:04 -0700 * SUMMARY Unexpected node preview format for an element with newlines in className attribute * STEPS TO REPRODUCE 1. js> div = document.createElement("div"); div.className = "one\ntwo"; [div] * EXPECTED <div class="one two"> (syntax highlighted) * ACTUAL <div class="one two"> (not syntax highlighted) 1119030 1 259407 joepeck 2015-08-19 14:36:03 -0700 Created attachment 259407 [PATCH] Proposed Fix Though this may not technically be not accurate for XML, I think this is fine. 1119032 2 259407 bburg 2015-08-19 14:46:41 -0700 Comment on attachment 259407 [PATCH] Proposed Fix r=me It's conceivable that other attributes might need the same sanitization. If we do that, then the sanitizer should be extracted. 1119060 3 259407 commit-queue 2015-08-19 15:33:20 -0700 Comment on attachment 259407 [PATCH] Proposed Fix Clearing flags on attachment: 259407 Committed r188656: <http://trac.webkit.org/changeset/188656> 1119061 4 commit-queue 2015-08-19 15:33:23 -0700 All reviewed patches have been landed. Closing bug. 259407 2015-08-19 14:36:03 -0700 2015-08-19 15:33:20 -0700 [PATCH] Proposed Fix preview.patch text/plain 1660 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDY0YjQ1NTkuLmEwMDhiZDcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA4LTE5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVW5leHBl Y3RlZCBub2RlIHByZXZpZXcgZm9ybWF0IGZvciBhbiBlbGVtZW50IHdpdGggbmV3bGluZXMgaW4g Y2xhc3NOYW1lIGF0dHJpYnV0ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQ4MTkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRTb3VyY2UuanM6CisgICAgICAg IChJbmplY3RlZFNjcmlwdC5wcm90b3R5cGUuX25vZGVQcmV2aWV3KToKKyAgICAgICAgUmVwbGFj ZSB3aGl0ZXNwYWNlIGJsb2NrcyB3aXRoIHNpbmdsZSBzcGFjZXMgdG8gcHJvZHVjZSBhIHNpbXBs ZXIgY2xhc3Mgc3RyaW5nIGZvciBwcmV2aWV3cy4KKwogMjAxNS0wOC0xOCAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IExpbmtz IGZvciBydWxlcyBpbiA8c3R5bGU+IGFyZSBpbmNvcnJlY3QsIGRvIG5vdCBhY2NvdW50IGZvciA8 c3R5bGU+IG9mZnNldCBpbiB0aGUgZG9jdW1lbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRTb3VyY2UuanMgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0U291cmNlLmpzCmluZGV4IDU1ODc0YTYu LmEyMDdjMzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSW5q ZWN0ZWRTY3JpcHRTb3VyY2UuanMKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rv ci9JbmplY3RlZFNjcmlwdFNvdXJjZS5qcwpAQCAtODExLDcgKzgxMSw3IEBAIEluamVjdGVkU2Ny aXB0LnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIGlmIChub2RlLmlkKQogICAgICAgICAgICAg ICAgIHJldHVybiAiPCIgKyBub2RlTmFtZSArICIgaWQ9XCIiICsgbm9kZS5pZCArICJcIj4iOwog ICAgICAgICAgICAgaWYgKG5vZGUuY2xhc3NMaXN0Lmxlbmd0aCkKLSAgICAgICAgICAgICAgICBy ZXR1cm4gIjwiICsgbm9kZU5hbWUgKyAiIGNsYXNzPVwiIiArIG5vZGUuY2xhc3NMaXN0LnRvU3Ry aW5nKCkgKyAiXCI+IjsKKyAgICAgICAgICAgICAgICByZXR1cm4gIjwiICsgbm9kZU5hbWUgKyAi IGNsYXNzPVwiIiArIG5vZGUuY2xhc3NMaXN0LnRvU3RyaW5nKCkucmVwbGFjZSgvXHMrLywgIiAi KSArICJcIj4iOwogICAgICAgICAgICAgaWYgKG5vZGVOYW1lID09PSAiaW5wdXQiICYmIG5vZGUu dHlwZSkKICAgICAgICAgICAgICAgICByZXR1cm4gIjwiICsgbm9kZU5hbWUgKyAiIHR5cGU9XCIi ICsgbm9kZS50eXBlICsgIlwiPiI7CiAgICAgICAgICAgICByZXR1cm4gIjwiICsgbm9kZU5hbWUg KyAiPiI7Cg==