148191 2015-08-19 14:24:22 -0700 Web Inspector: Uncaught exception in inspector page while handling event DOMStorage.domStorageItemRemoved 2015-08-19 15:30:17 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1119017 0 joepeck 2015-08-19 14:24:22 -0700 * SUMMARY Occasionally I see this uncaught exception: CONSOLE ERROR Uncaught exception in inspector page while handling event DOMStorage.domStorageItemRemoved: TypeError: null is not an object (evaluating 'this._domStorageForIdentifier(storageId).itemRemoved') * STEPS TO REPRODUCE 1. Inspect twitter.com 2. Navigate to daringfireball.net 3. Navigate back to twitter.com 4. Navigate forward to daringfireball.net => uncaught exception * EXCEPTION CONSOLE ERROR Uncaught exception in inspector page while handling event DOMStorage.domStorageItemRemoved: TypeError: null is not an object (evaluating 'this._domStorageForIdentifier(storageId).itemRemoved') itemRemoved@WebInspectorUI.framework/Resources/Controllers/StorageManager.js:114:49 domStorageItemRemoved@WebInspectorUI.framework/Resources/Protocol/DOMStorageObserver.js:50:48 dispatchEvent@WebInspectorUI.framework/Resources/Protocol/InspectorBackend.js:380:42 _dispatchEvent@WebInspectorUI.framework/Resources/Protocol/InspectorBackend.js:279:32 dispatch@WebInspectorUI.framework/Resources/Protocol/InspectorBackend.js:87:32 dispatchNextQueuedMessageFromBackend@WebInspectorUI.framework/Resources/Protocol/MessageDispatcher.js:42:34 * NOTES - StorageManager had already reset its domStorageObjects - The domStorageItemRemoved has a storageId of {securityOrigin:"twitter.com", localStorage:true}, key = "ScribeTransport"} but the StorageManager only has local + session storages for daringfireball.net 1119022 1 259405 joepeck 2015-08-19 14:26:16 -0700 Created attachment 259405 [PATCH] Proposed Fix 1119031 2 259405 bburg 2015-08-19 14:45:04 -0700 Comment on attachment 259405 [PATCH] Proposed Fix r=me Good catch! 1119056 3 259405 commit-queue 2015-08-19 15:30:13 -0700 Comment on attachment 259405 [PATCH] Proposed Fix Clearing flags on attachment: 259405 Committed r188655: <http://trac.webkit.org/changeset/188655> 1119057 4 commit-queue 2015-08-19 15:30:17 -0700 All reviewed patches have been landed. Closing bug. 259405 2015-08-19 14:26:16 -0700 2015-08-19 15:30:13 -0700 [PATCH] Proposed Fix storage.patch text/plain 2827 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDcyYzRiNWYuLjI2ZDU0YTAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDE1LTA4LTE5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVW5jYXVn aHQgZXhjZXB0aW9uIGluIGluc3BlY3RvciBwYWdlIHdoaWxlIGhhbmRsaW5nIGV2ZW50IERPTVN0 b3JhZ2UuZG9tU3RvcmFnZUl0ZW1SZW1vdmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNDgxOTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvU3RvcmFnZU1h bmFnZXIuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU3RvcmFnZU1hbmFnZXIucHJvdG90eXBl Lml0ZW1zQ2xlYXJlZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU3RvcmFnZU1hbmFnZXIucHJv dG90eXBlLml0ZW1SZW1vdmVkKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TdG9yYWdlTWFuYWdl ci5wcm90b3R5cGUuaXRlbUFkZGVkKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TdG9yYWdlTWFu YWdlci5wcm90b3R5cGUuaXRlbVVwZGF0ZWQpOgorICAgICAgICBDaGVjayBpZiB0aGUgRE9NU3Rv cmFnZSBmb3IgdGhlIGlkZW50aWZpZXIgYWN0dWFsbHkgZXhpc3RzLgorICAgICAgICBEdWUgdG8g aG93IHRoZSBiYWNrZW5kIGVtaXRzIGV2ZW50cywgdGhlIHBhZ2UgbWF5IGhhdmUgYWxyZWFkeQor ICAgICAgICBuYXZpZ2F0ZWQgd2hlbiB3ZSBnZXQgYSBzdG9yYWdlIHVwZGF0ZSBmb3IgdGhlIHBy ZXZpb3VzIHBhZ2UuCisgICAgICAgIEluIHRoYXQgY2FzZSwgd2UgZG9uJ3Qgd2FudCB0byBjcmVh dGUgYSBET01TdG9yYWdlIGZvciB0aGUKKyAgICAgICAgcHJldmlvdXMgcGFnZSBpZiBpdCBkb2Vz bid0IGV4aXN0LgorCisyMDE1LTA4LTE5ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBs ZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogVW5jYXVnaHQgRXhjZXB0aW9ucyByZWdh cmRpbmcgUHNldWRvRWxlbWVudHMgLyBUZW1wbGF0ZUNvbnRlbnQKICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODE5MAogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9TdG9yYWdlTWFuYWdl ci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL1N0 b3JhZ2VNYW5hZ2VyLmpzCmluZGV4IDY1NWEwYTMuLjgxOThlOGQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL1N0b3JhZ2VNYW5hZ2Vy LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJz L1N0b3JhZ2VNYW5hZ2VyLmpzCkBAIC0xMDYsMjIgKzEwNiwzMCBAQCBXZWJJbnNwZWN0b3IuU3Rv cmFnZU1hbmFnZXIgPSBjbGFzcyBTdG9yYWdlTWFuYWdlciBleHRlbmRzIFdlYkluc3BlY3Rvci5P YmplY3QKIAogICAgIGl0ZW1zQ2xlYXJlZChzdG9yYWdlSWQpCiAgICAgewotICAgICAgICB0aGlz Ll9kb21TdG9yYWdlRm9ySWRlbnRpZmllcihzdG9yYWdlSWQpLml0ZW1zQ2xlYXJlZChzdG9yYWdl SWQpOworICAgICAgICBsZXQgZG9tU3RvcmFnZSA9IHRoaXMuX2RvbVN0b3JhZ2VGb3JJZGVudGlm aWVyKHN0b3JhZ2VJZCk7CisgICAgICAgIGlmIChkb21TdG9yYWdlKQorICAgICAgICAgICAgZG9t U3RvcmFnZS5pdGVtc0NsZWFyZWQoc3RvcmFnZUlkKTsKICAgICB9CiAKICAgICBpdGVtUmVtb3Zl ZChzdG9yYWdlSWQsIGtleSkKICAgICB7Ci0gICAgICAgIHRoaXMuX2RvbVN0b3JhZ2VGb3JJZGVu dGlmaWVyKHN0b3JhZ2VJZCkuaXRlbVJlbW92ZWQoa2V5KTsKKyAgICAgICAgbGV0IGRvbVN0b3Jh Z2UgPSB0aGlzLl9kb21TdG9yYWdlRm9ySWRlbnRpZmllcihzdG9yYWdlSWQpOworICAgICAgICBp ZiAoZG9tU3RvcmFnZSkKKyAgICAgICAgICAgIGRvbVN0b3JhZ2UuaXRlbVJlbW92ZWQoa2V5KTsK ICAgICB9CiAKICAgICBpdGVtQWRkZWQoc3RvcmFnZUlkLCBrZXksIHZhbHVlKQogICAgIHsKLSAg ICAgICAgdGhpcy5fZG9tU3RvcmFnZUZvcklkZW50aWZpZXIoc3RvcmFnZUlkKS5pdGVtQWRkZWQo a2V5LCB2YWx1ZSk7CisgICAgICAgIGxldCBkb21TdG9yYWdlID0gdGhpcy5fZG9tU3RvcmFnZUZv cklkZW50aWZpZXIoc3RvcmFnZUlkKTsKKyAgICAgICAgaWYgKGRvbVN0b3JhZ2UpCisgICAgICAg ICAgICBkb21TdG9yYWdlLml0ZW1BZGRlZChrZXksIHZhbHVlKTsKICAgICB9CiAKICAgICBpdGVt VXBkYXRlZChzdG9yYWdlSWQsIGtleSwgb2xkVmFsdWUsIHZhbHVlKQogICAgIHsKLSAgICAgICAg dGhpcy5fZG9tU3RvcmFnZUZvcklkZW50aWZpZXIoc3RvcmFnZUlkKS5pdGVtVXBkYXRlZChrZXks IG9sZFZhbHVlLCB2YWx1ZSk7CisgICAgICAgIGxldCBkb21TdG9yYWdlID0gdGhpcy5fZG9tU3Rv cmFnZUZvcklkZW50aWZpZXIoc3RvcmFnZUlkKTsKKyAgICAgICAgaWYgKGRvbVN0b3JhZ2UpCisg ICAgICAgICAgICBkb21TdG9yYWdlLml0ZW1VcGRhdGVkKGtleSwgb2xkVmFsdWUsIHZhbHVlKTsK ICAgICB9CiAKICAgICBpbnNwZWN0RGF0YWJhc2UoaWQpCg==