148190 2015-08-19 14:00:03 -0700 Web Inspector: Uncaught Exceptions regarding PseudoElements / TemplateContent 2015-09-01 11:14:34 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck webkit-unassigned bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1119008 0 joepeck 2015-08-19 14:00:03 -0700 * SUMMARY Uncaught Exceptions regarding PseudoElements / TemplateContent. * STEPS TO REPRODUCE 1. Inspect twitter.com 2. Navigate around twitter.com 3. Reload => uncaught exceptions in inspector * ERRORS Resources/Protocol/InspectorBackend.js:281:26: CONSOLE ERROR Uncaught exception in inspector page while handling event DOM.pseudoElementRemoved: TypeError: null is not an object (evaluating 'this._children.length') _renumber@WebInspectorUI.framework/Resources/Models/DOMNode.js:559:44 Resources/Protocol/InspectorBackend.js:281:26: CONSOLE ERROR Uncaught exception in inspector page while handling event DOM.childNodeRemoved: TypeError: node.templateContent is not a function. (In 'node.templateContent()', 'node.templateContent' is undefined) _unbind@WebInspectorUI.framework/Resources/Controllers/DOMTreeManager.js:292:33 1119009 1 259402 joepeck 2015-08-19 14:01:29 -0700 Created attachment 259402 [PATCH] Proposed Fix 1119013 2 259402 bburg 2015-08-19 14:06:41 -0700 Comment on attachment 259402 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=259402&action=review r=me > Source/WebInspectorUI/ChangeLog:14 > + exists, it may be null. So separate the two pathes. paths* > Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js:289 > + for (let i = 0; node.children && i < node.children.length; ++i) This could be for (let .. of ..), since it doesn't mutate node.children. > Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js:296 > + let pseudoElements = node.pseudoElements(); No need for a local. 1119097 3 259430 joepeck 2015-08-19 17:02:11 -0700 Created attachment 259430 [PATCH] For Landing 1119121 4 259430 commit-queue 2015-08-19 17:37:30 -0700 Comment on attachment 259430 [PATCH] For Landing Clearing flags on attachment: 259430 Committed r188670: <http://trac.webkit.org/changeset/188670> 1122596 5 joepeck 2015-09-01 11:14:34 -0700 This landed, see above comment. 259402 2015-08-19 14:01:29 -0700 2015-08-19 17:01:58 -0700 [PATCH] Proposed Fix fixes.patch text/plain 3118 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGRjYzVjNTMuLjcyYzRiNWYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE1LTA4LTE5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVW5jYXVn aHQgRXhjZXB0aW9ucyByZWdhcmRpbmcgUHNldWRvRWxlbWVudHMgLyBUZW1wbGF0ZUNvbnRlbnQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODE5MAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlcklu dGVyZmFjZS9Db250cm9sbGVycy9ET01UcmVlTWFuYWdlci5qczoKKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5ET01UcmVlTWFuYWdlci5wcm90b3R5cGUuX3VuYmluZCk6CisgICAgICAgIEl0ZXJhdGUg b3ZlciB0aGUgdmFsdWVzIGluIHRoZSBtYXAsIG5vdCB0aGUgaXRlcmF0b3IgcGFpcnMuCisKKyAg ICAgICAgKiBVc2VySW50ZXJmYWNlL01vZGVscy9ET01Ob2RlLmpzOgorICAgICAgICBXaGVuIHJl bW92aW5nIGEgcHNldWRvIGVsZW1lbnQsIGRvbid0IGFzc3VtZSB0aGlzLl9jaGlsZHJlbgorICAg ICAgICBleGlzdHMsIGl0IG1heSBiZSBudWxsLiBTbyBzZXBhcmF0ZSB0aGUgdHdvIHBhdGhlcy4K KworMjAxNS0wOC0xOSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAg ICAgICAgIFdlYiBJbnNwZWN0b3I6IFVuY2F1Z2h0IEV4Y2VwdGlvbiB3aGlsZSBoYW5kbGluZyBl dmVudCBET00ucHNldWRvRWxlbWVudFJlbW92ZWQgcmVsb2FkaW5nIHR3aXR0ZXIgcGFnZXMKICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODE4MAogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVy cy9ET01UcmVlTWFuYWdlci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L0NvbnRyb2xsZXJzL0RPTVRyZWVNYW5hZ2VyLmpzCmluZGV4IDYzNzJjMGEuLjhhYzg5ZjkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJz L0RPTVRyZWVNYW5hZ2VyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL0NvbnRyb2xsZXJzL0RPTVRyZWVNYW5hZ2VyLmpzCkBAIC0yODYsMTQgKzI4NiwxNSBAQCBX ZWJJbnNwZWN0b3IuRE9NVHJlZU1hbmFnZXIgPSBjbGFzcyBET01UcmVlTWFuYWdlciBleHRlbmRz IFdlYkluc3BlY3Rvci5PYmplY3QKIAogICAgICAgICBkZWxldGUgdGhpcy5faWRUb0RPTU5vZGVb bm9kZS5pZF07CiAKLSAgICAgICAgZm9yICh2YXIgaSA9IDA7IG5vZGUuY2hpbGRyZW4gJiYgaSA8 IG5vZGUuY2hpbGRyZW4ubGVuZ3RoOyArK2kpCisgICAgICAgIGZvciAobGV0IGkgPSAwOyBub2Rl LmNoaWxkcmVuICYmIGkgPCBub2RlLmNoaWxkcmVuLmxlbmd0aDsgKytpKQogICAgICAgICAgICAg dGhpcy5fdW5iaW5kKG5vZGUuY2hpbGRyZW5baV0pOwogCi0gICAgICAgIGlmIChub2RlLnRlbXBs YXRlQ29udGVudCgpKQotICAgICAgICAgICAgdGhpcy5fdW5iaW5kKG5vZGUudGVtcGxhdGVDb250 ZW50KCkpOworICAgICAgICBsZXQgdGVtcGxhdGVDb250ZW50ID0gbm9kZS50ZW1wbGF0ZUNvbnRl bnQoKTsKKyAgICAgICAgaWYgKHRlbXBsYXRlQ29udGVudCkKKyAgICAgICAgICAgIHRoaXMuX3Vu YmluZCh0ZW1wbGF0ZUNvbnRlbnQpOwogCi0gICAgICAgIHZhciBwc2V1ZG9FbGVtZW50cyA9IG5v ZGUucHNldWRvRWxlbWVudHMoKTsKLSAgICAgICAgZm9yICh2YXIgcHNldWRvRWxlbWVudCBvZiBw c2V1ZG9FbGVtZW50cykKKyAgICAgICAgbGV0IHBzZXVkb0VsZW1lbnRzID0gbm9kZS5wc2V1ZG9F bGVtZW50cygpOworICAgICAgICBmb3IgKGxldCBwc2V1ZG9FbGVtZW50IG9mIHBzZXVkb0VsZW1l bnRzLnZhbHVlcygpKQogICAgICAgICAgICAgdGhpcy5fdW5iaW5kKHBzZXVkb0VsZW1lbnQpOwog CiAgICAgICAgIC8vIEZJWE1FOiBIYW5kbGUgc2hhZG93IHJvb3RzLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0RPTU5vZGUuanMgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvRE9NTm9kZS5qcwppbmRleCBj Y2Y4OTY2Li5kMDZjMzU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9Nb2RlbHMvRE9NTm9kZS5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9Nb2RlbHMvRE9NTm9kZS5qcwpAQCAtNTI5LDEzICs1MjksMTQgQEAgV2ViSW5z cGVjdG9yLkRPTU5vZGUgPSBjbGFzcyBET01Ob2RlIGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVj dAogICAgIF9yZW1vdmVDaGlsZChub2RlKQogICAgIHsKICAgICAgICAgLy8gRklYTUU6IEhhbmRs ZSByZW1vdmFsIGlmIHRoaXMgaXMgYSBzaGFkb3cgcm9vdC4KLSAgICAgICAgaWYgKG5vZGUuaXNQ c2V1ZG9FbGVtZW50KCkpCisgICAgICAgIGlmIChub2RlLmlzUHNldWRvRWxlbWVudCgpKSB7CiAg ICAgICAgICAgICB0aGlzLl9wc2V1ZG9FbGVtZW50cy5kZWxldGUobm9kZS5wc2V1ZG9UeXBlKCkp OwotICAgICAgICBlbHNlCisgICAgICAgICAgICBub2RlLnBhcmVudE5vZGUgPSBudWxsOworICAg ICAgICB9IGVsc2UgewogICAgICAgICAgICAgdGhpcy5fY2hpbGRyZW4uc3BsaWNlKHRoaXMuX2No aWxkcmVuLmluZGV4T2Yobm9kZSksIDEpOwotCi0gICAgICAgIG5vZGUucGFyZW50Tm9kZSA9IG51 bGw7Ci0gICAgICAgIHRoaXMuX3JlbnVtYmVyKCk7CisgICAgICAgICAgICBub2RlLnBhcmVudE5v ZGUgPSBudWxsOworICAgICAgICAgICAgdGhpcy5fcmVudW1iZXIoKTsKKyAgICAgICAgfQogICAg IH0KIAogICAgIF9zZXRDaGlsZHJlblBheWxvYWQocGF5bG9hZHMpCg== 259430 2015-08-19 17:02:11 -0700 2015-08-19 17:37:30 -0700 [PATCH] For Landing for-landing-1.patch text/plain 3067 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGRjYzVjNTMuLjU3ZWI3YzEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE1LTA4LTE5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVW5jYXVn aHQgRXhjZXB0aW9ucyByZWdhcmRpbmcgUHNldWRvRWxlbWVudHMgLyBUZW1wbGF0ZUNvbnRlbnQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODE5MAor CisgICAgICAgIFJldmlld2VkIGJ5IEJyaWFuIEJ1cmcuCisKKyAgICAgICAgKiBVc2VySW50ZXJm YWNlL0NvbnRyb2xsZXJzL0RPTVRyZWVNYW5hZ2VyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9y LkRPTVRyZWVNYW5hZ2VyLnByb3RvdHlwZS5fdW5iaW5kKToKKyAgICAgICAgSXRlcmF0ZSBvdmVy IHRoZSB2YWx1ZXMgaW4gdGhlIG1hcCwgbm90IHRoZSBpdGVyYXRvciBwYWlycy4KKworICAgICAg ICAqIFVzZXJJbnRlcmZhY2UvTW9kZWxzL0RPTU5vZGUuanM6CisgICAgICAgIFdoZW4gcmVtb3Zp bmcgYSBwc2V1ZG8gZWxlbWVudCwgZG9uJ3QgYXNzdW1lIHRoaXMuX2NoaWxkcmVuCisgICAgICAg IGV4aXN0cywgaXQgbWF5IGJlIG51bGwuIFNvIHNlcGFyYXRlIHRoZSB0d28gcGF0aHMuCisKKzIw MTUtMDgtMTkgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAg ICBXZWIgSW5zcGVjdG9yOiBVbmNhdWdodCBFeGNlcHRpb24gd2hpbGUgaGFuZGxpbmcgZXZlbnQg RE9NLnBzZXVkb0VsZW1lbnRSZW1vdmVkIHJlbG9hZGluZyB0d2l0dGVyIHBhZ2VzCiAgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDgxODAKIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvRE9N VHJlZU1hbmFnZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250 cm9sbGVycy9ET01UcmVlTWFuYWdlci5qcwppbmRleCA2MzcyYzBhLi40YjVkOTEwIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9ET01U cmVlTWFuYWdlci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9D b250cm9sbGVycy9ET01UcmVlTWFuYWdlci5qcwpAQCAtMjg2LDE0ICsyODYsMTQgQEAgV2ViSW5z cGVjdG9yLkRPTVRyZWVNYW5hZ2VyID0gY2xhc3MgRE9NVHJlZU1hbmFnZXIgZXh0ZW5kcyBXZWJJ bnNwZWN0b3IuT2JqZWN0CiAKICAgICAgICAgZGVsZXRlIHRoaXMuX2lkVG9ET01Ob2RlW25vZGUu aWRdOwogCi0gICAgICAgIGZvciAodmFyIGkgPSAwOyBub2RlLmNoaWxkcmVuICYmIGkgPCBub2Rl LmNoaWxkcmVuLmxlbmd0aDsgKytpKQorICAgICAgICBmb3IgKGxldCBpID0gMDsgbm9kZS5jaGls ZHJlbiAmJiBpIDwgbm9kZS5jaGlsZHJlbi5sZW5ndGg7ICsraSkKICAgICAgICAgICAgIHRoaXMu X3VuYmluZChub2RlLmNoaWxkcmVuW2ldKTsKIAotICAgICAgICBpZiAobm9kZS50ZW1wbGF0ZUNv bnRlbnQoKSkKLSAgICAgICAgICAgIHRoaXMuX3VuYmluZChub2RlLnRlbXBsYXRlQ29udGVudCgp KTsKKyAgICAgICAgbGV0IHRlbXBsYXRlQ29udGVudCA9IG5vZGUudGVtcGxhdGVDb250ZW50KCk7 CisgICAgICAgIGlmICh0ZW1wbGF0ZUNvbnRlbnQpCisgICAgICAgICAgICB0aGlzLl91bmJpbmQo dGVtcGxhdGVDb250ZW50KTsKIAotICAgICAgICB2YXIgcHNldWRvRWxlbWVudHMgPSBub2RlLnBz ZXVkb0VsZW1lbnRzKCk7Ci0gICAgICAgIGZvciAodmFyIHBzZXVkb0VsZW1lbnQgb2YgcHNldWRv RWxlbWVudHMpCisgICAgICAgIGZvciAobGV0IHBzZXVkb0VsZW1lbnQgb2Ygbm9kZS5wc2V1ZG9F bGVtZW50cygpLnZhbHVlcygpKQogICAgICAgICAgICAgdGhpcy5fdW5iaW5kKHBzZXVkb0VsZW1l bnQpOwogCiAgICAgICAgIC8vIEZJWE1FOiBIYW5kbGUgc2hhZG93IHJvb3RzLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0RPTU5vZGUuanMg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvRE9NTm9kZS5qcwpp bmRleCBjY2Y4OTY2Li5kMDZjMzU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9Nb2RlbHMvRE9NTm9kZS5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9Nb2RlbHMvRE9NTm9kZS5qcwpAQCAtNTI5LDEzICs1MjksMTQgQEAg V2ViSW5zcGVjdG9yLkRPTU5vZGUgPSBjbGFzcyBET01Ob2RlIGV4dGVuZHMgV2ViSW5zcGVjdG9y Lk9iamVjdAogICAgIF9yZW1vdmVDaGlsZChub2RlKQogICAgIHsKICAgICAgICAgLy8gRklYTUU6 IEhhbmRsZSByZW1vdmFsIGlmIHRoaXMgaXMgYSBzaGFkb3cgcm9vdC4KLSAgICAgICAgaWYgKG5v ZGUuaXNQc2V1ZG9FbGVtZW50KCkpCisgICAgICAgIGlmIChub2RlLmlzUHNldWRvRWxlbWVudCgp KSB7CiAgICAgICAgICAgICB0aGlzLl9wc2V1ZG9FbGVtZW50cy5kZWxldGUobm9kZS5wc2V1ZG9U eXBlKCkpOwotICAgICAgICBlbHNlCisgICAgICAgICAgICBub2RlLnBhcmVudE5vZGUgPSBudWxs OworICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgdGhpcy5fY2hpbGRyZW4uc3BsaWNlKHRo aXMuX2NoaWxkcmVuLmluZGV4T2Yobm9kZSksIDEpOwotCi0gICAgICAgIG5vZGUucGFyZW50Tm9k ZSA9IG51bGw7Ci0gICAgICAgIHRoaXMuX3JlbnVtYmVyKCk7CisgICAgICAgICAgICBub2RlLnBh cmVudE5vZGUgPSBudWxsOworICAgICAgICAgICAgdGhpcy5fcmVudW1iZXIoKTsKKyAgICAgICAg fQogICAgIH0KIAogICAgIF9zZXRDaGlsZHJlblBheWxvYWQocGF5bG9hZHMpCg==