148165 2015-08-18 22:22:53 -0700 REGRESSION (r188581): Web Inspector: Option-Enter no longer inserts a new line in the console 2015-08-19 00:11:51 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev nvasilyev bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1118834 0 nvasilyev 2015-08-18 22:22:53 -0700 Regression from: Web Inspector: Option-Enter should commit console command without erasing the prompt https://bugs.webkit.org/show_bug.cgi?id=148123 1118835 1 webkit-bug-importer 2015-08-18 22:23:02 -0700 <rdar://problem/22338630> 1118841 2 nvasilyev 2015-08-18 22:37:28 -0700 Shift-Enter and Control-Enter insert a line break. Option-Enter used to insert a line break, but since r188581 it evaluates a command and keeps it in the prompt. Command-Enter forces execution, e.g. "1+" would show an error. Here is what I think we should do: — Shift-Enter, Control-Enter, and Option-Enter should all insert a line break, as it was before r188581. — Command-Enter should force execution AND keep the command in the prompt If somebody uses force execution, sees a syntax error, it's very likely they would press Up and edit the previous command. We may as well save that Up keypress and not erase the prompt. In fact, this is exactly how it works in Firebug multiline console — Command-Enter forces execution and keeps the command in the prompt. 1118843 3 259359 nvasilyev 2015-08-18 22:48:43 -0700 Created attachment 259359 Patch 1118864 4 259359 commit-queue 2015-08-19 00:11:45 -0700 Comment on attachment 259359 Patch Clearing flags on attachment: 259359 Committed r188635: <http://trac.webkit.org/changeset/188635> 1118865 5 commit-queue 2015-08-19 00:11:51 -0700 All reviewed patches have been landed. Closing bug. 259359 2015-08-18 22:48:43 -0700 2015-08-19 00:11:45 -0700 Patch patch.txt text/plain 2321 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDAzNWNkM2YuLjJlMzM3ZTAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTA4LTE4ICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIxODg1ODEp OiBXZWIgSW5zcGVjdG9yOiBPcHRpb24tRW50ZXIgbm8gbG9uZ2VyIGluc2VydHMgYSBuZXcgbGlu ZSBpbiB0aGUgY29uc29sZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTQ4MTY1CisKKyAgICAgICAgTWFrZSBPcHRpb24tRW50ZXIgaW5zZXJ0IGEgbmV3 IGxpbmUsIGFzIGl0IHdhcyBiZWZvcmUgcjE4ODU4MS4KKyAgICAgICAgTWFrZSBDb21tYW5kLUVu dGVyIGtlZXAgZXhlY3V0ZWQgY29tbWFuZCBpbiB0aGUgcHJvbXB0LgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9D b25zb2xlUHJvbXB0LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvbnNvbGVQcm9tcHQpOiBE ZWxldGVkLgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvbnNvbGVQcm9tcHQucHJvdG90eXBlLl9o YW5kbGVDb21tYW5kRW50ZXJLZXkpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvbnNvbGVQcm9t cHQucHJvdG90eXBlLl9oYW5kbGVPcHRpb25FbnRlcktleSk6IERlbGV0ZWQuCisgICAgICAgIChX ZWJJbnNwZWN0b3IuQ29uc29sZVByb21wdC5wcm90b3R5cGUuX2hhbmRsZUNvbW1hbmRPcHRpb25F bnRlcktleSk6IERlbGV0ZWQuCisKIDIwMTUtMDgtMTggIERldmluIFJvdXNzbyAgPGRyb3Vzc29A YXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEFkZCBwcm9wZXIgZm9ybWF0dGlu ZyBmb3IgZWRpdGluZyBzdHlsZXMgaW4gdGhlIFZpc3VhbCBQYW5lbApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29uc29sZVByb21wdC5qcyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnNvbGVQcm9tcHQu anMKaW5kZXggYjRjN2IzNy4uODBmNDk0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29uc29sZVByb21wdC5qcworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db25zb2xlUHJvbXB0LmpzCkBAIC01MSw4 ICs1MSw2IEBAIFdlYkluc3BlY3Rvci5Db25zb2xlUHJvbXB0ID0gY2xhc3MgQ29uc29sZVByb21w dCBleHRlbmRzIFdlYkluc3BlY3Rvci5PYmplY3QKICAgICAgICAgICAgICJDdHJsLU4iOiB0aGlz Ll9oYW5kbGVOZXh0S2V5LmJpbmQodGhpcyksCiAgICAgICAgICAgICAiRW50ZXIiOiB0aGlzLl9o YW5kbGVFbnRlcktleS5iaW5kKHRoaXMpLAogICAgICAgICAgICAgIkNtZC1FbnRlciI6IHRoaXMu X2hhbmRsZUNvbW1hbmRFbnRlcktleS5iaW5kKHRoaXMpLAotICAgICAgICAgICAgIkFsdC1FbnRl ciI6IHRoaXMuX2hhbmRsZU9wdGlvbkVudGVyS2V5LmJpbmQodGhpcyksCi0gICAgICAgICAgICAi Q21kLUFsdC1FbnRlciI6IHRoaXMuX2hhbmRsZUNvbW1hbmRPcHRpb25FbnRlcktleS5iaW5kKHRo aXMpLAogICAgICAgICAgICAgIlRhYiI6IHRoaXMuX2hhbmRsZVRhYktleS5iaW5kKHRoaXMpLAog ICAgICAgICAgICAgIkVzYyI6IHRoaXMuX2hhbmRsZUVzY2FwZUtleS5iaW5kKHRoaXMpCiAgICAg ICAgIH07CkBAIC0zMDQsMTYgKzMwMiw2IEBAIFdlYkluc3BlY3Rvci5Db25zb2xlUHJvbXB0ID0g Y2xhc3MgQ29uc29sZVByb21wdCBleHRlbmRzIFdlYkluc3BlY3Rvci5PYmplY3QKIAogICAgIF9o YW5kbGVDb21tYW5kRW50ZXJLZXkoY29kZU1pcnJvcikKICAgICB7Ci0gICAgICAgIHRoaXMuX2hh bmRsZUVudGVyS2V5KGNvZGVNaXJyb3IsIHRydWUpOwotICAgIH0KLQotICAgIF9oYW5kbGVPcHRp b25FbnRlcktleShjb2RlTWlycm9yKQotICAgIHsKLSAgICAgICAgdGhpcy5faGFuZGxlRW50ZXJL ZXkoY29kZU1pcnJvciwgZmFsc2UsIHRydWUpOwotICAgIH0KLQotICAgIF9oYW5kbGVDb21tYW5k T3B0aW9uRW50ZXJLZXkoY29kZU1pcnJvcikKLSAgICB7CiAgICAgICAgIHRoaXMuX2hhbmRsZUVu dGVyS2V5KGNvZGVNaXJyb3IsIHRydWUsIHRydWUpOwogICAgIH0KIAo=