148154 2015-08-18 17:25:46 -0700 REGRESSION(r188548): [GTK] Build broken. 2015-09-07 04:38:22 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 148093 1 clopez clopez andersca ap cgarcia commit-queue darin mrobinson ossy sam zan oldest_to_newest 1118729 0 clopez 2015-08-18 17:25:46 -0700 r188548 <http://trac.webkit.org/r188548> broke the GTK build. This was unnoticed until http://trac.webkit.org/changeset/188589 because WTR was not being built. The build error is: [12/157] Linking CXX executable bin/WebKitTestRunner FAILED: : && /usr/lib/ccache/clang++ -std=c++11 -fcolor-diagnostics -Qunused-arguments -O3 -DNDEBUG -fno-exceptions -fno-strict-aliasing -fno-rtti -L/home/clopez/webkit/webkit/WebKitBuild/DependenciesGTK/Root/lib64 -fuse-ld=gold -Wl,--disable-new-dtags @CMakeFiles/WebKitTestRunner.rsp -o bin/WebKitTestRunner && : Tools/WebKitTestRunner/CMakeFiles/WebKitTestRunner.dir/TestController.cpp.o:/home/clopez/webkit/.ccache/tmp/TestContro.tmp.trinity.14155.ii:function WTR::TestController::ensureViewSupportsOptionsForTest(WTR::TestInvocation const&): error: undefined reference to 'WTR::TestController::updatePlatformSpecificViewOptionsForTest(WTR::ViewOptions&, WTR::TestInvocation const&) const' Tools/WebKitTestRunner/CMakeFiles/WebKitTestRunner.dir/TestController.cpp.o:/home/clopez/webkit/.ccache/tmp/TestContro.tmp.trinity.14155.ii:function WTR::TestController::viewOptionsForTest(WTR::TestInvocation const&) const: error: undefined reference to 'WTR::TestController::updatePlatformSpecificViewOptionsForTest(WTR::ViewOptions&, WTR::TestInvocation const&) const' clang: error: linker command failed with exit code 1 (use -v to see invocation) ninja: build stopped: subcommand failed. https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Build%29/builds/61366/steps/compile-webkit/logs/stdio 1118741 1 259332 clopez 2015-08-18 17:42:38 -0700 Created attachment 259332 Patch 1118745 2 259334 clopez 2015-08-18 17:45:04 -0700 Created attachment 259334 Patch Fix typo in changelog. 1118747 3 259334 mrobinson 2015-08-18 17:46:38 -0700 Comment on attachment 259334 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259334&action=review > Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp:135 > +#if USE(COORDINATED_GRAPHICS) > + if (test.urlContains("sticky/") || test.urlContains("sticky\\")) > + return true; > +#endif Why USE(COORDINATED_GRAPHICS) here? 1118748 4 clopez 2015-08-18 17:49:23 -0700 (In reply to comment #3) > Comment on attachment 259334 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=259334&action=review > > > Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp:135 > > +#if USE(COORDINATED_GRAPHICS) > > + if (test.urlContains("sticky/") || test.urlContains("sticky\\")) > > + return true; > > +#endif > > Why USE(COORDINATED_GRAPHICS) here? No idea, i just copied this from http://trac.webkit.org/changeset/188548/trunk/Tools/WebKitTestRunner/efl/TestControllerEfl.cpp Do you think I should remove that #ifdef and always return false? or just remove the #ifdef but keep the 'test.urlContains("sticky")' check? 1118749 5 mrobinson 2015-08-18 17:52:54 -0700 It looks like this originated from the deleted code and shouldn't be applied to WebKitGTK+: http://trac.webkit.org/changeset/188548/trunk/Tools/WebKitTestRunner/TestController.cpp 1118754 6 259336 clopez 2015-08-18 18:13:23 -0700 Created attachment 259336 Patch 1118766 7 259336 clopez 2015-08-18 18:38:00 -0700 Comment on attachment 259336 Patch Clearing flags on attachment: 259336 Committed r188620: <http://trac.webkit.org/changeset/188620> 1118767 8 clopez 2015-08-18 18:38:08 -0700 All reviewed patches have been landed. Closing bug. 259332 2015-08-18 17:42:38 -0700 2015-08-18 17:44:58 -0700 Patch bug-148154-20150819024233.patch text/plain 1954 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4NTgxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZGRjNTA0NWUzOWNjYWYwYTQ3MmY3MDI1MGJhMWIzZTM4 M2Q4NjU5MS4uNzEwODI0YjM4NGQzYjVjYjMyOTA0MTdjZDIwMWU1MmI2ZmMxOWYzOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE1LTA4LTE4ICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjE4ODU0OCk6IFtHVEtdIEJ1aWxkIGJyb2tl bi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODE1 NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2Vi S2l0VGVzdFJ1bm5lci9ndGsvVGVzdENvbnRyb2xsZXJHdGsuY3BwOgorICAgICAgICAoV1RSOjpz aG91bGRVc2VGaXhlZExheW91dCk6CisgICAgICAgIChXVFI6OlRlc3RDb250cm9sbGVyOjp1cGRh dGVQbGF0Zm9ybVNwZWNpZmljVmlld09wdGlvbnNGb3JUZXN0KToKKyAgICAgICAgcjE0ODE1NCBh ZGRlZCB0aGlzIGNvZGUgb24gVGVzdENvbnRyb2xsZXJFZmwuY3BwIGJ1dCBub3Qgb24KKyAgICAg ICAgVGVzdENvbnRyb2xsZXJHdGsuY3BwLiBUaGlzIGZpeGVzIHRoZSBidWlsZCBmb3IgdGhlIEdU SyBwb3J0LgorCiAyMDE1LTA4LTE3ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0 Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTg4NTM5LCByMTg4NTQ0 LCByMTg4NTUyLCBhbmQKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZ3RrL1Rl c3RDb250cm9sbGVyR3RrLmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZ3RrL1Rlc3RDb250 cm9sbGVyR3RrLmNwcAppbmRleCA1MGZiZmE5MGNiYjdhYzBjNTk5MWU3ZDA1ZDM2OTUyOTYxZGM3 NjNhLi5jMzUxNTg5MTY0YjdhMzY4OWRlNjkyNTczMjMwYmY5MDdlZmU2MWMxIDEwMDY0NAotLS0g YS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2d0ay9UZXN0Q29udHJvbGxlckd0ay5jcHAKKysrIGIv VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9ndGsvVGVzdENvbnRyb2xsZXJHdGsuY3BwCkBAIC0yOCw2 ICsyOCw3IEBACiAjaW5jbHVkZSAiVGVzdENvbnRyb2xsZXIuaCIKIAogI2luY2x1ZGUgIlBsYXRm b3JtV2ViVmlldy5oIgorI2luY2x1ZGUgIlRlc3RJbnZvY2F0aW9uLmgiCiAjaW5jbHVkZSA8Z3Rr L2d0ay5oPgogI2luY2x1ZGUgPHd0Zi9QbGF0Zm9ybS5oPgogI2luY2x1ZGUgPHd0Zi9nbGliL0dN YWluTG9vcFNvdXJjZS5oPgpAQCAtMTI2LDQgKzEyNywxOCBAQCB2b2lkIFRlc3RDb250cm9sbGVy OjpwbGF0Zm9ybVJlc2V0UHJlZmVyZW5jZXNUb0NvbnNpc3RlbnRWYWx1ZXMoKQogICAgIG1fbWFp bldlYlZpZXctPmRpc21pc3NBbGxQb3B1cE1lbnVzKCk7CiB9CiAKK3N0YXRpYyBib29sIHNob3Vs ZFVzZUZpeGVkTGF5b3V0KGNvbnN0IFRlc3RJbnZvY2F0aW9uJiB0ZXN0KQoreworI2lmIFVTRShD T09SRElOQVRFRF9HUkFQSElDUykKKyAgICBpZiAodGVzdC51cmxDb250YWlucygic3RpY2t5LyIp IHx8IHRlc3QudXJsQ29udGFpbnMoInN0aWNreVxcIikpCisgICAgICAgIHJldHVybiB0cnVlOwor I2VuZGlmCisgICAgcmV0dXJuIGZhbHNlOworfQorCit2b2lkIFRlc3RDb250cm9sbGVyOjp1cGRh dGVQbGF0Zm9ybVNwZWNpZmljVmlld09wdGlvbnNGb3JUZXN0KFZpZXdPcHRpb25zJiB2aWV3T3B0 aW9ucywgY29uc3QgVGVzdEludm9jYXRpb24mIHRlc3QpIGNvbnN0Cit7CisgICAgdmlld09wdGlv bnMudXNlRml4ZWRMYXlvdXQgPSBzaG91bGRVc2VGaXhlZExheW91dCh0ZXN0KTsKK30KKwogfSAv LyBuYW1lc3BhY2UgV1RSCg== 259334 2015-08-18 17:45:04 -0700 2015-08-18 18:13:15 -0700 Patch bug-148154-20150819024459.patch text/plain 1954 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4NTgxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZGRjNTA0NWUzOWNjYWYwYTQ3MmY3MDI1MGJhMWIzZTM4 M2Q4NjU5MS4uYzk1YjBjMDNjNWRmMTJiYTJhMGVlZjIzNWI5ZTc4NjhkY2MyYmNiZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE1LTA4LTE4ICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjE4ODU0OCk6IFtHVEtdIEJ1aWxkIGJyb2tl bi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODE1 NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2Vi S2l0VGVzdFJ1bm5lci9ndGsvVGVzdENvbnRyb2xsZXJHdGsuY3BwOgorICAgICAgICAoV1RSOjpz aG91bGRVc2VGaXhlZExheW91dCk6CisgICAgICAgIChXVFI6OlRlc3RDb250cm9sbGVyOjp1cGRh dGVQbGF0Zm9ybVNwZWNpZmljVmlld09wdGlvbnNGb3JUZXN0KToKKyAgICAgICAgcjE4ODU0OCBh ZGRlZCB0aGlzIGNvZGUgb24gVGVzdENvbnRyb2xsZXJFZmwuY3BwIGJ1dCBub3Qgb24KKyAgICAg ICAgVGVzdENvbnRyb2xsZXJHdGsuY3BwLiBUaGlzIGZpeGVzIHRoZSBidWlsZCBmb3IgdGhlIEdU SyBwb3J0LgorCiAyMDE1LTA4LTE3ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0 Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTg4NTM5LCByMTg4NTQ0 LCByMTg4NTUyLCBhbmQKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZ3RrL1Rl c3RDb250cm9sbGVyR3RrLmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZ3RrL1Rlc3RDb250 cm9sbGVyR3RrLmNwcAppbmRleCA1MGZiZmE5MGNiYjdhYzBjNTk5MWU3ZDA1ZDM2OTUyOTYxZGM3 NjNhLi5jMzUxNTg5MTY0YjdhMzY4OWRlNjkyNTczMjMwYmY5MDdlZmU2MWMxIDEwMDY0NAotLS0g YS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2d0ay9UZXN0Q29udHJvbGxlckd0ay5jcHAKKysrIGIv VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9ndGsvVGVzdENvbnRyb2xsZXJHdGsuY3BwCkBAIC0yOCw2 ICsyOCw3IEBACiAjaW5jbHVkZSAiVGVzdENvbnRyb2xsZXIuaCIKIAogI2luY2x1ZGUgIlBsYXRm b3JtV2ViVmlldy5oIgorI2luY2x1ZGUgIlRlc3RJbnZvY2F0aW9uLmgiCiAjaW5jbHVkZSA8Z3Rr L2d0ay5oPgogI2luY2x1ZGUgPHd0Zi9QbGF0Zm9ybS5oPgogI2luY2x1ZGUgPHd0Zi9nbGliL0dN YWluTG9vcFNvdXJjZS5oPgpAQCAtMTI2LDQgKzEyNywxOCBAQCB2b2lkIFRlc3RDb250cm9sbGVy OjpwbGF0Zm9ybVJlc2V0UHJlZmVyZW5jZXNUb0NvbnNpc3RlbnRWYWx1ZXMoKQogICAgIG1fbWFp bldlYlZpZXctPmRpc21pc3NBbGxQb3B1cE1lbnVzKCk7CiB9CiAKK3N0YXRpYyBib29sIHNob3Vs ZFVzZUZpeGVkTGF5b3V0KGNvbnN0IFRlc3RJbnZvY2F0aW9uJiB0ZXN0KQoreworI2lmIFVTRShD T09SRElOQVRFRF9HUkFQSElDUykKKyAgICBpZiAodGVzdC51cmxDb250YWlucygic3RpY2t5LyIp IHx8IHRlc3QudXJsQ29udGFpbnMoInN0aWNreVxcIikpCisgICAgICAgIHJldHVybiB0cnVlOwor I2VuZGlmCisgICAgcmV0dXJuIGZhbHNlOworfQorCit2b2lkIFRlc3RDb250cm9sbGVyOjp1cGRh dGVQbGF0Zm9ybVNwZWNpZmljVmlld09wdGlvbnNGb3JUZXN0KFZpZXdPcHRpb25zJiB2aWV3T3B0 aW9ucywgY29uc3QgVGVzdEludm9jYXRpb24mIHRlc3QpIGNvbnN0Cit7CisgICAgdmlld09wdGlv bnMudXNlRml4ZWRMYXlvdXQgPSBzaG91bGRVc2VGaXhlZExheW91dCh0ZXN0KTsKK30KKwogfSAv LyBuYW1lc3BhY2UgV1RSCg== 259336 2015-08-18 18:13:23 -0700 2015-08-18 18:38:00 -0700 Patch bug-148154-20150819031319.patch text/plain 1427 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4NTgxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZGRjNTA0NWUzOWNjYWYwYTQ3MmY3MDI1MGJhMWIzZTM4 M2Q4NjU5MS4uNWNmNDM0OGZmMmQ2MTJlMTcyY2IxMjAzMmI2NDgzNDY0NmVkNjE2NyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE1LTA4LTE4ICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjE4ODU0OCk6IFtHVEtdIEJ1aWxkIGJyb2tl bi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODE1 NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2Vi S2l0VGVzdFJ1bm5lci9ndGsvVGVzdENvbnRyb2xsZXJHdGsuY3BwOgorICAgICAgICAoV1RSOjpU ZXN0Q29udHJvbGxlcjo6dXBkYXRlUGxhdGZvcm1TcGVjaWZpY1ZpZXdPcHRpb25zRm9yVGVzdCk6 CisgICAgICAgIEV2ZW4gaWYgd2UgZG9uJ3QgbmVlZCB0byBhZGQvb3ZlcnJpZGUgYW55IHNldHRp bmdzIGluIFZpZXdPcHRpb25zLAorICAgICAgICB3ZSBuZWVkIHRvIGRlZmluZSB0aGlzIGFzIGFu IGVtcHR5IGZ1bmN0aW9uIHRvIG1ha2UgaXQgYnVpbGQuCisKIDIwMTUtMDgtMTcgIENvbW1pdCBR dWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJv bGxpbmcgb3V0IHIxODg1MzksIHIxODg1NDQsIHIxODg1NTIsIGFuZApkaWZmIC0tZ2l0IGEvVG9v bHMvV2ViS2l0VGVzdFJ1bm5lci9ndGsvVGVzdENvbnRyb2xsZXJHdGsuY3BwIGIvVG9vbHMvV2Vi S2l0VGVzdFJ1bm5lci9ndGsvVGVzdENvbnRyb2xsZXJHdGsuY3BwCmluZGV4IDUwZmJmYTkwY2Ji N2FjMGM1OTkxZTdkMDVkMzY5NTI5NjFkYzc2M2EuLjY2NTUzMGUyNWY1YjA0MmEyNTY2YTVhMmE3 YWI0YzlmZDI0NmRiMTEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZ3RrL1Rl c3RDb250cm9sbGVyR3RrLmNwcAorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2d0ay9UZXN0 Q29udHJvbGxlckd0ay5jcHAKQEAgLTEyNiw0ICsxMjYsOCBAQCB2b2lkIFRlc3RDb250cm9sbGVy OjpwbGF0Zm9ybVJlc2V0UHJlZmVyZW5jZXNUb0NvbnNpc3RlbnRWYWx1ZXMoKQogICAgIG1fbWFp bldlYlZpZXctPmRpc21pc3NBbGxQb3B1cE1lbnVzKCk7CiB9CiAKK3ZvaWQgVGVzdENvbnRyb2xs ZXI6OnVwZGF0ZVBsYXRmb3JtU3BlY2lmaWNWaWV3T3B0aW9uc0ZvclRlc3QoVmlld09wdGlvbnMm LCBjb25zdCBUZXN0SW52b2NhdGlvbiYpIGNvbnN0Cit7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdU Ugo=