14815 2007-07-30 12:11:07 -0700 [gtk] API implementation: reload 2007-08-07 11:25:00 -0700 1 1 1 Unclassified WebKit WebKit API 523.x (Safari 3) All Linux RESOLVED FIXED P2 Normal --- 0 xan.lopez webkit-unassigned oldest_to_newest 3432 0 xan.lopez 2007-07-30 12:11:07 -0700 Add the webkit_gtk_page_reload method. 3433 1 15747 xan.lopez 2007-07-30 12:15:25 -0700 Created attachment 15747 Implement reload 3425 2 zecke 2007-07-30 12:54:09 -0700 Looks good two minor things: -As of yesterday we have decided to use the WebKit CodingStyle in the WebKit/Gtk API implementation. E.g use camelCase for variable names. This makes private_data -> privateData and frame_data -> frameData and we need to do that for the rest of the implementation as well (but in another patch) -Did you use WebKitTools/Scripts/prepare-ChangeLog to create the ChangeLog entry? 3424 3 zecke 2007-07-30 12:58:41 -0700 Oh one more CodingStyle issue (sorry): +webkit_gtk_page_reload (WebKitGtkPage *page); it should be WebKitGtkPage* page in both the header and the implementation. In theory the header could be different but currently all other methods use WebKitGtkPage*, we can decide to change that for the header but this would need to be handled in a different bug. 3423 4 xan.lopez 2007-07-30 13:06:44 -0700 (In reply to comment #2) > Looks good two minor things: > -As of yesterday we have decided to use the WebKit CodingStyle in the > WebKit/Gtk API implementation. E.g use camelCase for variable names. This makes > private_data -> privateData and frame_data -> frameData and we need to do that > for the rest of the implementation as well (but in another patch) ACK. > > -Did you use WebKitTools/Scripts/prepare-ChangeLog to create the ChangeLog > entry? Nope, is it mandatory as long as the output is OK? > +webkit_gtk_page_reload (WebKitGtkPage *page); it should be WebKitGtkPage* page > in both the header and the implementation. In theory the header could be > different but currently all other methods use WebKitGtkPage*, we can decide to > change that for the header but this would need to be handled in a different > bug. Ok, GTK+ uses the type *foo style, but I have no strong feelings about it. The only real benefit I can see is more clarity when declaring more than one variable in one line. 3380 5 zecke 2007-07-31 07:12:00 -0700 (In reply to comment #4) > (In reply to comment #2) > Nope, is it mandatory as long as the output is OK? > Well, the script creates "Reviewed by NOBODY (OOPS)" and webkit.org has a pre-commit hook to check ChangeLogs for OOPS. So If I forget to add my name to the line I'm going to commit a 'bad' changelog entry. Try the script, if you don't like it we can live with that. 3248 6 xan.lopez 2007-07-31 14:32:06 -0700 (In reply to comment #5) > Well, the script creates "Reviewed by NOBODY (OOPS)" and webkit.org has a > pre-commit hook to check ChangeLogs for OOPS. So If I forget to add my name to > the line I'm going to commit a 'bad' changelog entry. > Try the script, if you don't like it we can live with that. I know the script, I used to use it before I switched to git/git-svn for most things. These days I use moap changelog prepare or simply C-x 4 a in emacs, but anyway I don't if the only matter is the OOPS stuff that has an easy solution. I think the output from moap + the OOPS for unreviewed is identical to the stuff produced by prepare-Changelog. 3195 7 15747 mrowe 2007-08-01 20:19:27 -0700 Comment on attachment 15747 Implement reload +void webkit_gtk_page_reload (WebKitGtkPage *page) The whitespace in this line is inconsistent with other methods in the implementation file, and should be fixed by whoever lands this. It would also be preferable if you could leave the "Reviewed by NOBODY (OOPS!)" line intact in the ChangeLog. We have post-commit hooks that key off this to ensure that a reviewer is added. 3100 8 xan.lopez 2007-08-02 23:38:21 -0700 (In reply to comment #7) > (From update of attachment 15747 [edit]) > +void webkit_gtk_page_reload (WebKitGtkPage *page) > > The whitespace in this line is inconsistent with other methods in the > implementation file, and should be fixed by whoever lands this. > > It would also be preferable if you could leave the "Reviewed by NOBODY (OOPS!)" > line intact in the ChangeLog. We have post-commit hooks that key off this to > ensure that a reviewer is added. > Noted, thanks for the review. Can we get this in? 2892 9 alp 2007-08-07 11:25:00 -0700 Landed in r24911 15747 2007-07-30 12:15:25 -0700 2007-08-01 20:19:27 -0700 Implement reload webkitpagereload.diff text/plain 1909 xan.lopez SW5kZXg6IGd0ay9BcGkvd2Via2l0Z3RrcGFnZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gZ3RrL0FwaS93 ZWJraXRndGtwYWdlLmNwcAkocmV2aXNpb24gMjQ3NzgpCisrKyBndGsvQXBpL3dlYmtpdGd0a3Bh Z2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNTEsNiArMzUxLDEzIEBAIHZvaWQgd2Via2l0X2d0 a19wYWdlX29wZW4oV2ViS2l0R3RrUGFnZSoKICAgICBmcmFtZV9kYXRhLT5mcmFtZS0+bG9hZGVy KCktPmxvYWQoUmVzb3VyY2VSZXF1ZXN0KEtVUkwoc3RyaW5nKSkpOwogfQogCit2b2lkIHdlYmtp dF9ndGtfcGFnZV9yZWxvYWQgKFdlYktpdEd0a1BhZ2UgKnBhZ2UpCit7CisgICAgV2ViS2l0R3Rr UGFnZVByaXZhdGUqIHBhZ2VfZGF0YSA9IFdFQktJVF9HVEtfUEFHRV9HRVRfUFJJVkFURShwYWdl KTsKKyAgICBXZWJLaXRHdGtGcmFtZVByaXZhdGUqIGZyYW1lX2RhdGEgPSBXRUJLSVRfR1RLX0ZS QU1FX0dFVF9QUklWQVRFKHBhZ2VfZGF0YS0+bWFpbl9mcmFtZSk7CisgICAgZnJhbWVfZGF0YS0+ ZnJhbWUtPmxvYWRlcigpLT5yZWxvYWQoKTsKK30KKwogdm9pZCB3ZWJraXRfZ3RrX3BhZ2VfbG9h ZF9zdHJpbmcoV2ViS2l0R3RrUGFnZSogcGFnZSwgY29uc3QgZ2NoYXIqIGNvbnRlbnQsIGNvbnN0 IGdjaGFyKiBjb250ZW50X21pbWVfdHlwZSwgY29uc3QgZ2NoYXIqIGNvbnRlbnRfZW5jb2Rpbmcs IGNvbnN0IGdjaGFyKiBiYXNlX3VybCkKIHsKICAgICBXZWJLaXRHdGtQYWdlUHJpdmF0ZSogcGFn ZV9kYXRhID0gV0VCS0lUX0dUS19QQUdFX0dFVF9QUklWQVRFKHBhZ2UpOwpJbmRleDogZ3RrL0Fw aS93ZWJraXRndGtwYWdlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gZ3RrL0FwaS93ZWJraXRndGtwYWdlLmgJ KHJldmlzaW9uIDI0Nzc4KQorKysgZ3RrL0FwaS93ZWJraXRndGtwYWdlLmgJKHdvcmtpbmcgY29w eSkKQEAgLTE0MCw2ICsxNDAsOSBAQCBXRUJLSVRfR1RLX0FQSSB2b2lkCiB3ZWJraXRfZ3RrX3Bh Z2Vfb3BlbiAoV2ViS2l0R3RrUGFnZSogcGFnZSwgY29uc3QgZ2NoYXIqIHVybCk7CiAKIFdFQktJ VF9HVEtfQVBJIHZvaWQKK3dlYmtpdF9ndGtfcGFnZV9yZWxvYWQgKFdlYktpdEd0a1BhZ2UgKnBh Z2UpOworCitXRUJLSVRfR1RLX0FQSSB2b2lkCiB3ZWJraXRfZ3RrX3BhZ2VfbG9hZF9zdHJpbmcg KFdlYktpdEd0a1BhZ2UqIHBhZ2UsIGNvbnN0IGdjaGFyKiBjb250ZW50LCBjb25zdCBnY2hhciog Y29udGVudF9taW1lX3R5cGUsIGNvbnN0IGdjaGFyKiBjb250ZW50X2VuY29kaW5nLCBjb25zdCBn Y2hhciogYmFzZV91cmwpOwogCiBXRUJLSVRfR1RLX0FQSSB2b2lkCkluZGV4OiBDaGFuZ2VMb2cK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDc3OCkKKysrIENoYW5nZUxvZwko d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDA3LTA3LTMwICBYYW4gTG9wZXogIDx4 YW5AZ25vbWUub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5ID8/PworCisgICAgICAgIGh0dHA6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODE1CisgICAgICAgIFtndGtdIEFQ SSBpbXBsZW1lbnRhdGlvbjogcmVsb2FkCisKKyAgICAgICAgKiBndGsvQXBpL3dlYmtpdGd0a3Bh Z2UuY3BwOiBJbXBsZW1lbnQgdGhlIHdlYmtpdF9ndGtfcGFnZV9yZWxvYWQoKSBtZXRob2QuCisK IDIwMDctMDctMzAgIERpZWdvIEVzY2FsYW50ZSBVcnJlbG8gIDxkaWVnb2VAZ25vbWUub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0uCg==