148149 2015-08-18 15:57:15 -0700 Fix a rare flakiness in svg/animations/svgPreserveAspectRatio-animation-1.html 2015-08-18 17:44:00 -0700 1 1 1 Unclassified WebKit SVG WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sabouhallawa sabouhallawa commit-queue thorton zimmermann oldest_to_newest 1118671 0 sabouhallawa 2015-08-18 15:57:15 -0700 https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&showExpectations=true&revision=188590&tests=svg%2Fanimations%2FsvgPreserveAspectRatio-animation-1.html FAIL rootSVGElement.preserveAspectRatio.animVal.align should be 2. Was 7. FAIL rootSVGElement.preserveAspectRatio.animVal.meetOrSlice should be 1. Was 2. shows that the test is somehow flaky. After looking at the failure results. Here is what is happening: 1. The preserveAspectRatio of the SVG root element is set initially to "xMaxYMin meet". 2. An animation element is created to animate the preserveAspectRatio from "xMinYMin meet" to "xMaxYMid slice" in 4s. 3. The script svg/animations/resources/SVGAnimationTestCase.js fakes the animation to able to sample the changes in the animated attributes. It works by splitting the animation period in two halves. The first half the attribute value is set to the from-value and the second half the attribute value is set to the to-value. In this test case the animation period is 4s. So the first two second preserveAspectRatio = "xMinYMin meet" and the last two seconds preserveAspectRatio from "xMaxYMid slice". 4. We are sampling the animation exactly at the 2.0 seconds which is the time the change in the animated value happens. The expected file is assuming preserveAspectRatio to be the from-value ("xMinYMin meet" or "2 1"). But the failure results shows that its value is the to-value ("xMaxYMid slice" or "7 2"). 1118673 1 259306 sabouhallawa 2015-08-18 15:59:59 -0700 Created attachment 259306 Patch 1118742 2 259306 commit-queue 2015-08-18 17:43:56 -0700 Comment on attachment 259306 Patch Clearing flags on attachment: 259306 Committed r188613: <http://trac.webkit.org/changeset/188613> 1118743 3 commit-queue 2015-08-18 17:44:00 -0700 All reviewed patches have been landed. Closing bug. 259306 2015-08-18 15:59:59 -0700 2015-08-18 17:43:56 -0700 Patch bug-148149-20150818160001.patch text/plain 3288 sabouhallawa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE4ODYwNSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE1LTA4LTE4ICBTYWlkIEFib3UtSGFsbGF3 YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IGEgcmFyZSBmbGFraW5l c3MgaW4gc3ZnL2FuaW1hdGlvbnMvc3ZnUHJlc2VydmVBc3BlY3RSYXRpby1hbmltYXRpb24tMS5o dG1sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDgx NDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAg ICAgIERvIG5vdCBzYW1wbGUgdGhlIFNWRyBhbmltYXRpb24gYXQgdGhlIG1pZGRsZSBvZiB0aGUg YW5pbWF0aW9uIHBlcmlvZC4gQXQKKyAgICAgICAgdGhhdCB0aW1lLCB0aGUgU1ZHIGFuaW1hdGlv biB0ZXN0IHNjcmlwdCBjaGFuZ2VzIHRoZSB2YWx1ZSBvZiB0aGUgYW5pbWF0ZWQKKyAgICAgICAg YXR0cmlidXRlIGZyb20gdGhlIGZyb20tdmFsdWUgdG8gdGhlIHRvLXZhbHVlLiBJdCBpcyBzYWZl ciB0byBzYW1wbGUKKyAgICAgICAgaW1tZWRpYXRlbHkgYmVmb3JlIGFuZCBhZnRlciB0aGUgbWlk ZGxlIG9mIHRoZSBhbmltYXRpb24gcGVyaW9kLgorCisgICAgICAgICogc3ZnL2FuaW1hdGlvbnMv c2NyaXB0LXRlc3RzL3N2Z1ByZXNlcnZlQXNwZWN0UmF0aW8tYW5pbWF0aW9uLTEuanM6CisgICAg ICAgICogc3ZnL2FuaW1hdGlvbnMvc3ZnUHJlc2VydmVBc3BlY3RSYXRpby1hbmltYXRpb24tMS1l eHBlY3RlZC50eHQ6CisKIDIwMTUtMDgtMTggIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBh cHBsZS5jb20+CiAKICAgICAgICAgd2lsbC1jaGFuZ2U6IGJhY2tmYWNlLXZpc2liaWxpdHkgc2hv dWxkIG5vdCBjYXVzZSBzdGFja2luZyBjb250ZXh0CkluZGV4OiBMYXlvdXRUZXN0cy9zdmcvYW5p bWF0aW9ucy9zdmdQcmVzZXJ2ZUFzcGVjdFJhdGlvLWFuaW1hdGlvbi0xLWV4cGVjdGVkLnR4dAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9zdmcvYW5pbWF0aW9ucy9zdmdQcmVzZXJ2ZUFzcGVj dFJhdGlvLWFuaW1hdGlvbi0xLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMTg4Mjc1KQorKysgTGF5 b3V0VGVzdHMvc3ZnL2FuaW1hdGlvbnMvc3ZnUHJlc2VydmVBc3BlY3RSYXRpby1hbmltYXRpb24t MS1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTE3LDYgKzE3LDEwIEBAIFBBU1Mgcm9v dFNWR0VsZW1lbnQucHJlc2VydmVBc3BlY3RSYXRpby4KIFBBU1Mgcm9vdFNWR0VsZW1lbnQucHJl c2VydmVBc3BlY3RSYXRpby5hbmltVmFsLm1lZXRPclNsaWNlIGlzIFNWR1ByZXNlcnZlQXNwZWN0 UmF0aW8uU1ZHX01FRVRPUlNMSUNFX1NMSUNFCiBQQVNTIHJvb3RTVkdFbGVtZW50LnByZXNlcnZl QXNwZWN0UmF0aW8uYmFzZVZhbC5hbGlnbiBpcyBTVkdQcmVzZXJ2ZUFzcGVjdFJhdGlvLlNWR19Q UkVTRVJWRUFTUEVDVFJBVElPX1hNQVhZTUlOCiBQQVNTIHJvb3RTVkdFbGVtZW50LnByZXNlcnZl QXNwZWN0UmF0aW8uYmFzZVZhbC5tZWV0T3JTbGljZSBpcyBTVkdQcmVzZXJ2ZUFzcGVjdFJhdGlv LlNWR19NRUVUT1JTTElDRV9NRUVUCitQQVNTIHJvb3RTVkdFbGVtZW50LnByZXNlcnZlQXNwZWN0 UmF0aW8uYW5pbVZhbC5hbGlnbiBpcyBTVkdQcmVzZXJ2ZUFzcGVjdFJhdGlvLlNWR19QUkVTRVJW RUFTUEVDVFJBVElPX1hNQVhZTUlECitQQVNTIHJvb3RTVkdFbGVtZW50LnByZXNlcnZlQXNwZWN0 UmF0aW8uYW5pbVZhbC5tZWV0T3JTbGljZSBpcyBTVkdQcmVzZXJ2ZUFzcGVjdFJhdGlvLlNWR19N RUVUT1JTTElDRV9TTElDRQorUEFTUyByb290U1ZHRWxlbWVudC5wcmVzZXJ2ZUFzcGVjdFJhdGlv LmJhc2VWYWwuYWxpZ24gaXMgU1ZHUHJlc2VydmVBc3BlY3RSYXRpby5TVkdfUFJFU0VSVkVBU1BF Q1RSQVRJT19YTUFYWU1JTgorUEFTUyByb290U1ZHRWxlbWVudC5wcmVzZXJ2ZUFzcGVjdFJhdGlv LmJhc2VWYWwubWVldE9yU2xpY2UgaXMgU1ZHUHJlc2VydmVBc3BlY3RSYXRpby5TVkdfTUVFVE9S U0xJQ0VfTUVFVAogUEFTUyByb290U1ZHRWxlbWVudC5wcmVzZXJ2ZUFzcGVjdFJhdGlvLmFuaW1W YWwuYWxpZ24gaXMgU1ZHUHJlc2VydmVBc3BlY3RSYXRpby5TVkdfUFJFU0VSVkVBU1BFQ1RSQVRJ T19YTUFYWU1JTgogUEFTUyByb290U1ZHRWxlbWVudC5wcmVzZXJ2ZUFzcGVjdFJhdGlvLmFuaW1W YWwubWVldE9yU2xpY2UgaXMgU1ZHUHJlc2VydmVBc3BlY3RSYXRpby5TVkdfTUVFVE9SU0xJQ0Vf TUVFVAogUEFTUyByb290U1ZHRWxlbWVudC5wcmVzZXJ2ZUFzcGVjdFJhdGlvLmJhc2VWYWwuYWxp Z24gaXMgU1ZHUHJlc2VydmVBc3BlY3RSYXRpby5TVkdfUFJFU0VSVkVBU1BFQ1RSQVRJT19YTUFY WU1JTgpJbmRleDogTGF5b3V0VGVzdHMvc3ZnL2FuaW1hdGlvbnMvc2NyaXB0LXRlc3RzL3N2Z1By ZXNlcnZlQXNwZWN0UmF0aW8tYW5pbWF0aW9uLTEuanMKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvc3ZnL2FuaW1hdGlvbnMvc2NyaXB0LXRlc3RzL3N2Z1ByZXNlcnZlQXNwZWN0UmF0aW8tYW5p bWF0aW9uLTEuanMJKHJldmlzaW9uIDE4ODI3NSkKKysrIExheW91dFRlc3RzL3N2Zy9hbmltYXRp b25zL3NjcmlwdC10ZXN0cy9zdmdQcmVzZXJ2ZUFzcGVjdFJhdGlvLWFuaW1hdGlvbi0xLmpzCSh3 b3JraW5nIGNvcHkpCkBAIC01MSw3ICs1MSw4IEBAIGZ1bmN0aW9uIGV4ZWN1dGVUZXN0KCkgewog ICAgIGNvbnN0IGV4cGVjdGVkVmFsdWVzID0gWwogICAgICAgICAvLyBbYW5pbWF0aW9uSWQsIHRp bWUsIHNhbXBsZUNhbGxiYWNrXQogICAgICAgICBbImFuaW1hdGlvbiIsIDAuMCwgICBzYW1wbGUx XSwKLSAgICAgICAgWyJhbmltYXRpb24iLCAyLjAsICAgc2FtcGxlMl0sCisgICAgICAgIFsiYW5p bWF0aW9uIiwgMS45OTksIHNhbXBsZTJdLAorICAgICAgICBbImFuaW1hdGlvbiIsIDIuMDAxLCBz YW1wbGUzXSwKICAgICAgICAgWyJhbmltYXRpb24iLCAzLjk5OSwgc2FtcGxlM10sCiAgICAgICAg IFsiYW5pbWF0aW9uIiwgNC4wMDEsIHNhbXBsZTFdCiAgICAgXTsK