148142 2015-08-18 14:26:16 -0700 Add metadata to Dashboard.Repository for SCM type. 2015-09-14 10:59:48 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 jmarcell webkit-unassigned adele ap bburg dbates dean_johnson jake.nielsen.webkit jmarcell oldest_to_newest 1118631 0 jmarcell 2015-08-18 14:26:16 -0700 Add metadata to Dashboard.Repository for SCM type. 1118633 1 259297 jmarcell 2015-08-18 14:29:59 -0700 Created attachment 259297 Patch 1118635 2 259297 jmarcell 2015-08-18 14:33:56 -0700 Comment on attachment 259297 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259297&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:28 > + GIT: 1 Should this be GIT in all caps? For that matter, is SVN an appropriate key for Subversion? > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:32 > + SCMTypes: SCMTypes, I defined SCMTypes outside of Dashboard so that I could refer to it in the Dashboard.Repository section. But I also want to refer to them as Dashboard.SCMTypes.SVN, etc., so I added a key "SCMTypes" here. I don't really like this, but I'm open to other suggestions. 1121501 3 jmarcell 2015-08-27 17:13:16 -0700 We went with this instead: https://bugs.webkit.org/attachment.cgi?id=259779 1125648 4 259297 ossy 2015-09-14 10:59:48 -0700 Comment on attachment 259297 Patch Cleared review? from attachment 259297 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 259297 2015-08-18 14:29:59 -0700 2015-09-14 10:59:48 -0700 Patch bug-148142-20150818142957.patch text/plain 1911 jmarcell ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0ZmEz YjhmN2RhYThhOTg1YjA4YjZjZmU1MGVmYWI0N2JlMTVlNDZiLi4zMDNlNDc5OWUxZWYyY2UzMmY3 YTRkNmNjNDRjM2QyNzEwNDU5MzBjIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTUtMDgtMTggIEphc29uIE1hcmNl bGwgIDxqbWFyY2VsbEBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIG1ldGFkYXRhIHRvIERhc2hi b2FyZC5SZXBvc2l0b3J5IGZvciBTQ00gdHlwZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODE0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9y Zy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvRGFzaGJvYXJkLmpzOiBBZGRl ZAorICAgICAgICBtZXRhZGF0YSB0byBEYXNoYm9hcmQuUmVwb3NpdG9yeSBmb3IgU0NNIHR5cGUu CisKIDIwMTUtMDgtMTcgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAg ICBSZXBsYWNlIGFsbCByZW1haW5pbmcgdXNlcyBvZiBXVEY6Ok11dGV4IHdpdGggV1RGOjpMb2Nr CmRpZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNv bmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9EYXNoYm9hcmQuanMgYi9Ub29scy9C dWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNo Ym9hcmQvU2NyaXB0cy9EYXNoYm9hcmQuanMKaW5kZXggY2Q1NzVhNjhlOTdkMTUwYjc2MTQwYzE3 ZGIxOTg5MjJjNzZmNGFmNC4uYzcyNzE1ZDM0ZmE1ZWNmYzdmMDg4MjNmNTUwNTg5OGM3NjMxNTBl MCAxMDA2NDQKLS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1j b25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvRGFzaGJvYXJkLmpzCisrKyBiL1Rv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1s L2Rhc2hib2FyZC9TY3JpcHRzL0Rhc2hib2FyZC5qcwpAQCAtMjMsNyArMjMsMTMgQEAKICAqIFRI RSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KICAqLwogCitTQ01UeXBlcyA9IHsKKyAgICBT Vk46IDAsCisgICAgR0lUOiAxCit9OworCiBEYXNoYm9hcmQgPSB7CisgICAgU0NNVHlwZXM6IFND TVR5cGVzLAogICAgIFBsYXRmb3JtOiB7CiAgICAgICAgIE1hY09TWEVsQ2FwaXRhbjogeyBuYW1l OiAibWFjLW9zLXgtZWxjYXBpdGFuIiwgcmVhZGFibGVOYW1lOiAiT1MgWCBFbCBDYXBpdGFuIiwg b3JkZXI6IDkgfSwKICAgICAgICAgTWFjT1NYWW9zZW1pdGU6IHsgbmFtZTogIm1hYy1vcy14LXlv c2VtaXRlIiwgcmVhZGFibGVOYW1lOiAiT1MgWCBZb3NlbWl0ZSIsIG9yZGVyOiAxMCB9LApAQCAt MzcsOCArNDMsOCBAQCBEYXNoYm9hcmQgPSB7CiAgICAgfSwKICAgICBCcmFuY2g6IHt9LAogICAg IFJlcG9zaXRvcnk6IHsKLSAgICAgICAgT3BlblNvdXJjZTogeyBuYW1lOiAib3BlblNvdXJjZSIs IG9yZGVyOiAwIH0sCi0gICAgICAgIEludGVybmFsOiB7IG5hbWU6ICJpbnRlcm5hbCIsIG9yZGVy OiAxIH0sCisgICAgICAgIE9wZW5Tb3VyY2U6IHsgbmFtZTogIm9wZW5Tb3VyY2UiLCBTQ01UeXBl OiBTQ01UeXBlcy5TVk4sIG9yZGVyOiAwIH0sCisgICAgICAgIEludGVybmFsOiB7IG5hbWU6ICJp bnRlcm5hbCIsIFNDTVR5cGU6IFNDTVR5cGVzLlNWTiwgb3JkZXI6IDEgfSwKICAgICB9LAogICAg IGdldCBzb3J0ZWRQbGF0Zm9ybXMoKQogICAgIHsK