148127 2015-08-18 04:48:46 -0700 [CMake] REGRESSION(r188540): WebKitTestRunner is not longer built and all the tests (layout and perf) fail. 2015-08-18 17:27:36 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P1 Critical --- 1 clopez achristensen achristensen bfulgham calvaris mcatanzaro ossy pnormand oldest_to_newest 1118503 0 clopez 2015-08-18 04:48:46 -0700 Since r188540 WebKitTestRunner is not longer built and all the perf and layout tests fail. $ find WebKitBuild/Release/ -type f -executable WebKitBuild/Release/CMakeFiles/3.0.2/CMakeDetermineCompilerABI_C.bin WebKitBuild/Release/CMakeFiles/3.0.2/CMakeDetermineCompilerABI_CXX.bin WebKitBuild/Release/CMakeFiles/3.0.2/CompilerIdCXX/a.out WebKitBuild/Release/CMakeFiles/3.0.2/CompilerIdC/a.out WebKitBuild/Release/bin/WebKitNetworkProcess WebKitBuild/Release/bin/jsc WebKitBuild/Release/bin/WebKitDatabaseProcess WebKitBuild/Release/bin/WebKitPluginProcess WebKitBuild/Release/bin/WebKitPluginProcess2 WebKitBuild/Release/bin/LLIntOffsetsExtractor WebKitBuild/Release/bin/WebKitWebProcess WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18.2.4 WebKitBuild/Release/lib/libwebkit2gtkinjectedbundle.so WebKitBuild/Release/lib/libgtest.so WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.10.0 $ Tools/Scripts/run-webkit-tests --gtk Using port 'gtk-wk2' Test configuration: <, x86, release> Placing test results in /home/gardener/WebKit/WebKitBuild/Release/layout-test-results Baseline search path: gtk -> wk2 -> generic Using Release build Pixel tests disabled Regular timeout: 6000, slow test timeout: 30000 Command line: /home/gardener/WebKit/Tools/jhbuild/jhbuild-wrapper --gtk run /home/gardener/WebKit/WebKitBuild/Release/bin/WebKitTestRunner - --lint-test-files warnings: LayoutTests/platform/gtk/TestExpectations:565 Path does not exist. css3/masking/mask-svg-clipped-fragmentId.html LayoutTests/platform/gtk/TestExpectations:938 Path does not exist. platform/gtk/editing/pasteboard/middle-button-paste.html LayoutTests/platform/gtk/TestExpectations:1135 Path does not exist. css3/masking/mask-svg-invalid-fragmentId.html LayoutTests/platform/gtk/TestExpectations:1163 Duplicate or ambiguous entry lines LayoutTests/platform/gtk/TestExpectations:1161 and LayoutTests/platform/gtk/TestExpectations:1163. media/video-controller-child-rate.html LayoutTests/platform/gtk/TestExpectations:1738 Path does not exist. platform/gtk/accessibility/object-attributes.html LayoutTests/platform/gtk/TestExpectations:1739 Path does not exist. platform/gtk/accessibility/title-and-alt.html LayoutTests/platform/gtk/TestExpectations:2358 Path does not exist. fast/forms/input-auto-fill-button.html Found 39949 tests; running 35578, skipping 4371. WebKitTestRunner was not found at /home/gardener/WebKit/WebKitBuild/Release/bin/WebKitTestRunner Build check failed $ Tools/Scripts/run-perf-tests --platform gtk --release WebKitTestRunner was not found at /home/gardener/WebKit/WebKitBuild/Release/bin/WebKitTestRunner Build not up to date for /home/gardener/WebKit/WebKitBuild/Release/bin/WebKitTestRunner This affects at least the GTK port, and probably also the EFL one (not checked). The bots seems to be working because a clean build was still not triggered, so they are using the WebKitTestRunner from r188540-- however the perf bot is already crashing for all tests. 1118572 1 259284 achristensen 2015-08-18 11:41:04 -0700 Created attachment 259284 Patch 1118573 2 achristensen 2015-08-18 11:41:27 -0700 Woah, my bad. Does this fix it? 1118578 3 259285 achristensen 2015-08-18 11:54:40 -0700 Created attachment 259285 Patch 1118589 4 achristensen 2015-08-18 12:09:38 -0700 http://trac.webkit.org/changeset/188589 1118717 5 clopez 2015-08-18 17:11:35 -0700 (In reply to comment #4) > http://trac.webkit.org/changeset/188589 And this broke the GTK build :( [12/157] Linking CXX executable bin/WebKitTestRunner FAILED: : && /usr/lib/ccache/clang++ -std=c++11 -fcolor-diagnostics -Qunused-arguments -O3 -DNDEBUG -fno-exceptions -fno-strict-aliasing -fno-rtti -L/home/clopez/webkit/webkit/WebKitBuild/DependenciesGTK/Root/lib64 -fuse-ld=gold -Wl,--disable-new-dtags @CMakeFiles/WebKitTestRunner.rsp -o bin/WebKitTestRunner && : Tools/WebKitTestRunner/CMakeFiles/WebKitTestRunner.dir/TestController.cpp.o:/home/clopez/webkit/.ccache/tmp/TestContro.tmp.trinity.14155.ii:function WTR::TestController::ensureViewSupportsOptionsForTest(WTR::TestInvocation const&): error: undefined reference to 'WTR::TestController::updatePlatformSpecificViewOptionsForTest(WTR::ViewOptions&, WTR::TestInvocation const&) const' Tools/WebKitTestRunner/CMakeFiles/WebKitTestRunner.dir/TestController.cpp.o:/home/clopez/webkit/.ccache/tmp/TestContro.tmp.trinity.14155.ii:function WTR::TestController::viewOptionsForTest(WTR::TestInvocation const&) const: error: undefined reference to 'WTR::TestController::updatePlatformSpecificViewOptionsForTest(WTR::ViewOptions&, WTR::TestInvocation const&) const' clang: error: linker command failed with exit code 1 (use -v to see invocation) ninja: build stopped: subcommand failed. https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Build%29/builds/61366/steps/compile-webkit/logs/stdio 1118732 6 clopez 2015-08-18 17:27:36 -0700 Ok.... The build error is unrelated to this CMake issue. Your last patch fixed the CMake issue that uncovered the build error caused by r188548 that was previously unnoticed Reported the build error here: https://bugs.webkit.org/show_bug.cgi?id=148154 Closing this 259284 2015-08-18 11:41:04 -0700 2015-08-18 11:54:37 -0700 Patch bug-148127-20150818114101.patch text/plain 1104 achristensen SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE4ODU4 NSkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE1LTA4 LTE4ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgW0NNYWtlXSBSRUdSRVNTSU9OKHIxODg1NDApOiBXZWJLaXRUZXN0UnVubmVyIGlzIG5vdCBs b25nZXIgYnVpbHQgYW5kIGFsbCB0aGUgdGVzdHMgKGxheW91dCBhbmQgcGVyZikgZmFpbC4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODEyNworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQ01ha2VMaXN0 cy50eHQ6CisgICAgICAgIFRPT0xTX0RJUiBoYXNuJ3QgYmVlbiBzZXQgeWV0IHNpbmNlIGl0cyBk ZWZpbmluZyBoYXMgYmVlbiBtb3ZlZCB0byBXZWJLaXRGUy4gCisKIDIwMTUtMDgtMTcgIEFsZXgg Q2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBbV2luIENN YWtlXSBBbGxvdyBXZWJLaXRMaWJyYXJpZXMgZGlyZWN0b3J5IHRvIGJlIHNldCBmcm9tIHRoZSBj b21tYW5kIGxpbmUKSW5kZXg6IENNYWtlTGlzdHMudHh0Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIENNYWtlTGlz dHMudHh0CShyZXZpc2lvbiAxODg1NTkpCisrKyBDTWFrZUxpc3RzLnR4dAkod29ya2luZyBjb3B5 KQpAQCAtNyw3ICs3LDcgQEAgaWYgKE5PVCBERUZJTkVEIEVOQUJMRV9XRUJLSVQpCiAgICAgc2V0 KEVOQUJMRV9XRUJLSVQgT04pCiBlbmRpZiAoKQogCi1pZiAoTk9UIERFRklORUQgRU5BQkxFX1RP T0xTIEFORCBFWElTVFMgJHtUT09MU19ESVJ9KQoraWYgKE5PVCBERUZJTkVEIEVOQUJMRV9UT09M UyBBTkQgRVhJU1RTICR7Q01BS0VfU09VUkNFX0RJUn0vVG9vbHMpCiAgICAgc2V0KEVOQUJMRV9U T09MUyBPTikKIGVuZGlmICgpCiAK 259285 2015-08-18 11:54:40 -0700 2015-08-18 12:01:58 -0700 Patch bug-148127-20150818115438.patch text/plain 1106 achristensen SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE4ODU4 NSkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE1LTA4 LTE4ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgW0NNYWtlXSBSRUdSRVNTSU9OKHIxODg1NDApOiBXZWJLaXRUZXN0UnVubmVyIGlzIG5vdCBs b25nZXIgYnVpbHQgYW5kIGFsbCB0aGUgdGVzdHMgKGxheW91dCBhbmQgcGVyZikgZmFpbC4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODEyNworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQ01ha2VMaXN0 cy50eHQ6CisgICAgICAgIFRPT0xTX0RJUiBoYXNuJ3QgYmVlbiBzZXQgeWV0IHNpbmNlIGl0cyBk ZWZpbmluZyBoYXMgYmVlbiBtb3ZlZCB0byBXZWJLaXRGUy4gCisKIDIwMTUtMDgtMTcgIEFsZXgg Q2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBbV2luIENN YWtlXSBBbGxvdyBXZWJLaXRMaWJyYXJpZXMgZGlyZWN0b3J5IHRvIGJlIHNldCBmcm9tIHRoZSBj b21tYW5kIGxpbmUKSW5kZXg6IENNYWtlTGlzdHMudHh0Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIENNYWtlTGlz dHMudHh0CShyZXZpc2lvbiAxODg1NTkpCisrKyBDTWFrZUxpc3RzLnR4dAkod29ya2luZyBjb3B5 KQpAQCAtNyw3ICs3LDcgQEAgaWYgKE5PVCBERUZJTkVEIEVOQUJMRV9XRUJLSVQpCiAgICAgc2V0 KEVOQUJMRV9XRUJLSVQgT04pCiBlbmRpZiAoKQogCi1pZiAoTk9UIERFRklORUQgRU5BQkxFX1RP T0xTIEFORCBFWElTVFMgJHtUT09MU19ESVJ9KQoraWYgKE5PVCBERUZJTkVEIEVOQUJMRV9UT09M UyBBTkQgRVhJU1RTICIke0NNQUtFX1NPVVJDRV9ESVJ9L1Rvb2xzIikKICAgICBzZXQoRU5BQkxF X1RPT0xTIE9OKQogZW5kaWYgKCkKIAo=