148126 2015-08-18 04:40:32 -0700 [EFL] Web Inspector: make to use StringBuilder in inspectorBaseURL 2015-08-18 21:23:28 -0700 1 1 1 Unclassified WebKit WebKit EFL Other All All RESOLVED FIXED P2 Normal --- 1 jincheol.jo jincheol.jo commit-queue gyuyoung.kim hyungwook.lee lucas.de.marchi oldest_to_newest 1118499 0 jincheol.jo 2015-08-18 04:40:32 -0700 It returns chararacters array in WebInspectorProxy::inspectorBaseURL. So I made to use StringBuilder like the others of WebInspectorProxy. 1118502 1 259262 jincheol.jo 2015-08-18 04:48:41 -0700 Created attachment 259262 Patch 1118509 2 259262 gyuyoung.kim 2015-08-18 06:17:00 -0700 Comment on attachment 259262 Patch There is no big benefit when using StringBuilder in this case though, it looks this patch is to be aligned with other similar EFL inspector functions. 1118808 3 259262 commit-queue 2015-08-18 21:23:24 -0700 Comment on attachment 259262 Patch Clearing flags on attachment: 259262 Committed r188625: <http://trac.webkit.org/changeset/188625> 1118809 4 commit-queue 2015-08-18 21:23:28 -0700 All reviewed patches have been landed. Closing bug. 259262 2015-08-18 04:48:41 -0700 2015-08-18 21:23:24 -0700 Patch bug-148126-20150818204839.patch text/plain 1398 jincheol.jo SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4ODU4MCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA4LTE4ICBKaW5jaGVv bCBKbyAgPGppbmNoZW9sLmpvQG5hdmVyY29ycC5jb20+CisKKyAgICAgICAgW0VGTF0gV2ViIElu c3BlY3RvcjogbWFrZSB0byB1c2UgU3RyaW5nQnVpbGRlciBpbiBpbnNwZWN0b3JCYXNlVVJMCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDgxMjYKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vz cy9lZmwvV2ViSW5zcGVjdG9yUHJveHlFZmwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJJbnNw ZWN0b3JQcm94eTo6aW5zcGVjdG9yQmFzZVVSTCk6CisgICAgICAgIChXZWJLaXQ6OldlYkluc3Bl Y3RvclByb3h5OjpwbGF0Zm9ybUluc3BlY3RlZFdpbmRvd0hlaWdodCk6CisKIDIwMTUtMDgtMTcg IEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBT cGVjdWxhdGl2ZSBHVEsgYnVpbGQgZml4IGFmdGVyIHIxODg1NTMKSW5kZXg6IFNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9lZmwvV2ViSW5zcGVjdG9yUHJveHlFZmwuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9lZmwvV2ViSW5zcGVjdG9yUHJveHlFZmwuY3BwCShy ZXZpc2lvbiAxODc4NDMpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZWZsL1dlYkluc3Bl Y3RvclByb3h5RWZsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTkwLDcgKzE5MCwxMCBAQCBTdHJp bmcgV2ViSW5zcGVjdG9yUHJveHk6Omluc3BlY3RvclRlc3RQCiAKIFN0cmluZyBXZWJJbnNwZWN0 b3JQcm94eTo6aW5zcGVjdG9yQmFzZVVSTCgpIGNvbnN0CiB7Ci0gICAgcmV0dXJuICJmaWxlOi8v IiArIFdlYkNvcmU6Omluc3BlY3RvclJlc291cmNlUGF0aCgpOworICAgIFN0cmluZ0J1aWxkZXIg YnVpbGRlcjsKKyAgICBidWlsZGVyLmFwcGVuZExpdGVyYWwoImZpbGU6Ly8iKTsKKyAgICBidWls ZGVyLmFwcGVuZChXZWJDb3JlOjppbnNwZWN0b3JSZXNvdXJjZVBhdGgoKSk7CisgICAgcmV0dXJu IGJ1aWxkZXIudG9TdHJpbmcoKTsKIH0KIAogdW5zaWduZWQgV2ViSW5zcGVjdG9yUHJveHk6OnBs YXRmb3JtSW5zcGVjdGVkV2luZG93SGVpZ2h0KCkK