148112 2015-08-17 17:30:24 -0700 [Win CMake] Allow WebKitLibraries directory to be set from the command line 2015-08-17 17:44:20 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 148111 1 achristensen achristensen oldest_to_newest 1118337 0 achristensen 2015-08-17 17:30:24 -0700 Environment variables aren't needed. Let's use WebKitLibraries/win as a fallback if nothing is given from the command line. This way, the internal build and the open source build can both work cleaner. 1118338 1 259215 achristensen 2015-08-17 17:34:55 -0700 Created attachment 259215 Patch 1118342 2 259215 bfulgham 2015-08-17 17:41:00 -0700 Comment on attachment 259215 Patch r=me. 1118345 3 achristensen 2015-08-17 17:44:20 -0700 http://trac.webkit.org/changeset/188560 259215 2015-08-17 17:34:55 -0700 2015-08-17 17:41:00 -0700 Patch bug-148112-20150817173454.patch text/plain 6132 achristensen SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE4ODU1 OCkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA4 LTE3ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgW1dpbiBDTWFrZV0gQWxsb3cgV2ViS2l0TGlicmFyaWVzIGRpcmVjdG9yeSB0byBiZSBzZXQg ZnJvbSB0aGUgY29tbWFuZCBsaW5lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDgxMTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zV2luLmNtYWtlOgorICAgICAgICBE b24ndCB1c2UgYW4gZW52aXJvbm1lbnQgdmFyaWFibGUgZm9yIFdFQktJVF9MSUJSQVJJRVNfRElS LiAgCisgICAgICAgIEluc3RlYWQsIHVzZSB0aGUgZGVmYXVsdCBsb2NhdGlvbiBpZiBub3RoaW5n IGlzIHBhc3NlZCBpbiBmcm9tIHRoZSBjb21tYW5kIGxpbmUuCisgICAgICAgIFRoaXMgd2F5IHdl IGNhbiBzZXQgaXQgZnJvbSB0aGUgY29tbWFuZCBsaW5lIGZvciB0aGUgQXBwbGVJbnRlcm5hbCBi dWlsZC4KKyAgICAgICAgQWxzbywgc2V0IHRoZSBvdXRwdXQgZGlyZWN0b3JpZXMgdG8gYmUgY29u c2lzdGVudCBiZXR3ZWVuIHRoZSBvbGQgYW5kIG5ldyBidWlsZCBzeXN0ZW1zIChhbmQgbmluamEp LgorCiAyMDE1LTA4LTE3ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5v cmc+CiAKICAgICAgICAgQnVpbGQgRGVidWcgU3VmZml4IG9uIFdpbmRvd3Mgd2l0aCBDTWFrZQpJ bmRleDogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg4NTU4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTUtMDgtMTcgIEFsZXggQ2hy aXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBbV2luIENNYWtl XSBBbGxvdyBXZWJLaXRMaWJyYXJpZXMgZGlyZWN0b3J5IHRvIGJlIHNldCBmcm9tIHRoZSBjb21t YW5kIGxpbmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE0ODExMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogUGxhdGZvcm1BcHBsZVdpbi5jbWFrZToKKyAgICAgICAgKiBQbGF0Zm9ybVdpbkNhaXJvLmNt YWtlOgorICAgICAgICBEb24ndCB1c2UgYW4gZW52aXJvbm1lbnQgdmFyaWFibGUgZm9yIFdFQktJ VF9MSUJSQVJJRVNfRElSLiAgCisKIDIwMTUtMDgtMTcgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hy aXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBCdWlsZCBEZWJ1ZyBTdWZmaXggb24gV2lu ZG93cyB3aXRoIENNYWtlCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUFwcGxlV2luLmNt YWtlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL1BsYXRmb3JtQXBwbGVXaW4uY21ha2UJ KHJldmlzaW9uIDE4ODU1OCkKKysrIFNvdXJjZS9XZWJDb3JlL1BsYXRmb3JtQXBwbGVXaW4uY21h a2UJKHdvcmtpbmcgY29weSkKQEAgLTEsNiArMSw2IEBACiBsaXN0KEFQUEVORCBXZWJDb3JlX0lO Q0xVREVfRElSRUNUT1JJRVMKLSAgICAiJEVOVntXRUJLSVRfTElCUkFSSUVTfS9pbmNsdWRlIgot ICAgICIkRU5We1dFQktJVF9MSUJSQVJJRVN9L2luY2x1ZGUvemxpYiIKKyAgICAiJHtXRUJLSVRf TElCUkFSSUVTX0RJUn0vaW5jbHVkZSIKKyAgICAiJHtXRUJLSVRfTElCUkFSSUVTX0RJUn0vaW5j bHVkZS96bGliIgogICAgICIke1dFQkNPUkVfRElSfS9sb2FkZXIvYXJjaGl2ZS9jZiIKICAgICAi JHtXRUJDT1JFX0RJUn0vcGxhdGZvcm0vZ3JhcGhpY3MvY2EiCiAgICAgIiR7V0VCQ09SRV9ESVJ9 L3BsYXRmb3JtL2dyYXBoaWNzL2NhL3dpbiIKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL1BsYXRmb3Jt V2luQ2Fpcm8uY21ha2UKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvUGxhdGZvcm1XaW5D YWlyby5jbWFrZQkocmV2aXNpb24gMTg4NTU3KQorKysgU291cmNlL1dlYkNvcmUvUGxhdGZvcm1X aW5DYWlyby5jbWFrZQkod29ya2luZyBjb3B5KQpAQCAtMSwxMCArMSwxMCBAQAogbGlzdChBUFBF TkQgV2ViQ29yZV9JTkNMVURFX0RJUkVDVE9SSUVTCiAgICAgIiR7REVSSVZFRF9TT1VSQ0VTX0RJ Un0vRm9yd2FyZGluZ0hlYWRlcnMvSmF2YVNjcmlwdENvcmUiCiAgICAgIiR7RGlyZWN0WF9JTkNM VURFX0RJUlN9IgotICAgICIkRU5We1dFQktJVF9MSUJSQVJJRVN9L2luY2x1ZGUiCi0gICAgIiRF TlZ7V0VCS0lUX0xJQlJBUklFU30vaW5jbHVkZS9jYWlybyIKLSAgICAiJEVOVntXRUJLSVRfTElC UkFSSUVTfS9pbmNsdWRlL1NRTGl0ZSIKLSAgICAiJEVOVntXRUJLSVRfTElCUkFSSUVTfS9pbmNs dWRlL3psaWIiCisgICAgIiR7V0VCS0lUX0xJQlJBUklFU19ESVJ9L2luY2x1ZGUiCisgICAgIiR7 V0VCS0lUX0xJQlJBUklFU19ESVJ9L2luY2x1ZGUvY2Fpcm8iCisgICAgIiR7V0VCS0lUX0xJQlJB UklFU19ESVJ9L2luY2x1ZGUvU1FMaXRlIgorICAgICIke1dFQktJVF9MSUJSQVJJRVNfRElSfS9p bmNsdWRlL3psaWIiCiAgICAgIiR7SkFWQVNDUklQVENPUkVfRElSfS93dGYvdGV4dCIKICAgICAi JHtXRUJDT1JFX0RJUn0vbG9hZGVyL2FyY2hpdmUvY2YiCiAgICAgIiR7V0VCQ09SRV9ESVJ9L3Bs YXRmb3JtL2NmIgpJbmRleDogU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdC9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4ODU1OCkKKysrIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTUtMDgtMTcg IEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBb V2luIENNYWtlXSBBbGxvdyBXZWJLaXRMaWJyYXJpZXMgZGlyZWN0b3J5IHRvIGJlIHNldCBmcm9t IHRoZSBjb21tYW5kIGxpbmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE0ODExMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogUGxhdGZvcm1XaW4uY21ha2U6CisgICAgICAgIERvbid0IHVzZSBhbiBlbnZp cm9ubWVudCB2YXJpYWJsZSBmb3IgV0VCS0lUX0xJQlJBUklFU19ESVIuICAKKwogMjAxNS0wOC0x NyAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAg IEJ1aWxkIERlYnVnIFN1ZmZpeCBvbiBXaW5kb3dzIHdpdGggQ01ha2UKSW5kZXg6IFNvdXJjZS9X ZWJLaXQvUGxhdGZvcm1XaW4uY21ha2UKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9QbGF0 Zm9ybVdpbi5jbWFrZQkocmV2aXNpb24gMTg4NTU4KQorKysgU291cmNlL1dlYktpdC9QbGF0Zm9y bVdpbi5jbWFrZQkod29ya2luZyBjb3B5KQpAQCAtMSw5ICsxLDkgQEAKIGlmICgke1dURl9QTEFU Rk9STV9XSU5fQ0FJUk99KQogICAgIGFkZF9kZWZpbml0aW9ucygtRFVTRV9DQUlSTz0xIC1EVVNF X0NVUkw9MSAtRFdFQktJVF9FWFBPUlRTPTEpCiAgICAgbGlzdChBUFBFTkQgV2ViS2l0X0lOQ0xV REVfRElSRUNUT1JJRVMKLSAgICAgICAgIiRFTlZ7V0VCS0lUX0xJQlJBUklFU30vaW5jbHVkZSIK LSAgICAgICAgIiRFTlZ7V0VCS0lUX0xJQlJBUklFU30vaW5jbHVkZS9jYWlybyIKLSAgICAgICAg IiRFTlZ7V0VCS0lUX0xJQlJBUklFU30vaW5jbHVkZS9zcWxpdGUiCisgICAgICAgICIke1dFQktJ VF9MSUJSQVJJRVNfRElSfS9pbmNsdWRlIgorICAgICAgICAiJHtXRUJLSVRfTElCUkFSSUVTX0RJ Un0vaW5jbHVkZS9jYWlybyIKKyAgICAgICAgIiR7V0VCS0lUX0xJQlJBUklFU19ESVJ9L2luY2x1 ZGUvc3FsaXRlIgogICAgICAgICAiJHtXRUJDT1JFX0RJUn0vcGxhdGZvcm0vZ3JhcGhpY3MvY2Fp cm8iCiAgICAgKQogICAgIGxpc3QoQVBQRU5EIFdlYktpdF9TT1VSQ0VTX0NsYXNzZXMKSW5kZXg6 IFNvdXJjZS9jbWFrZS9PcHRpb25zV2luLmNtYWtlCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9jbWFr ZS9PcHRpb25zV2luLmNtYWtlCShyZXZpc2lvbiAxODg1NTgpCisrKyBTb3VyY2UvY21ha2UvT3B0 aW9uc1dpbi5jbWFrZQkod29ya2luZyBjb3B5KQpAQCAtMTA3LDE4ICsxMDcsMjggQEAgZW5kaWYg KCkKIAogV0VCS0lUX09QVElPTl9FTkQoKQogCi1pbmNsdWRlX2RpcmVjdG9yaWVzKCIkRU5We1dF QktJVF9MSUJSQVJJRVN9L2luY2x1ZGUiKQoraWYgKE5PVCBXRUJLSVRfTElCUkFSSUVTX0RJUikK KyAgICBzZXQoV0VCS0lUX0xJQlJBUklFU19ESVIgIiR7Q01BS0VfU09VUkNFX0RJUn0vV2ViS2l0 TGlicmFyaWVzL3dpbiIpCitlbmRpZiAoKQorCitpbmNsdWRlX2RpcmVjdG9yaWVzKCIke1dFQktJ VF9MSUJSQVJJRVNfRElSfS9pbmNsdWRlIikKIGlmICgke01TVkNfQ1hYX0FSQ0hJVEVDVFVSRV9J RH0gU1RSRVFVQUwgIlg4NiIpCi0gICAgbGlua19kaXJlY3RvcmllcygiJEVOVntXRUJLSVRfTElC UkFSSUVTfS9saWIzMiIpCisgICAgbGlua19kaXJlY3RvcmllcygiJHtXRUJLSVRfTElCUkFSSUVT X0RJUn0vbGliMzIiKQogICAgIHNldChDTUFLRV9BUkNISVZFX09VVFBVVF9ESVJFQ1RPUlkgJHtD TUFLRV9CSU5BUllfRElSfS9saWIzMikKICAgICBzZXQoQ01BS0VfTElCUkFSWV9PVVRQVVRfRElS RUNUT1JZICR7Q01BS0VfQklOQVJZX0RJUn0vbGliMzIpCiAgICAgc2V0KENNQUtFX1JVTlRJTUVf T1VUUFVUX0RJUkVDVE9SWSAke0NNQUtFX0JJTkFSWV9ESVJ9L2JpbjMyKQogZWxzZSAoKQotICAg IGxpbmtfZGlyZWN0b3JpZXMoIiRFTlZ7V0VCS0lUX0xJQlJBUklFU30vbGliNjQiKQorICAgIGxp bmtfZGlyZWN0b3JpZXMoIiR7V0VCS0lUX0xJQlJBUklFU19ESVJ9L2xpYjY0IikKICAgICBzZXQo Q01BS0VfQVJDSElWRV9PVVRQVVRfRElSRUNUT1JZICR7Q01BS0VfQklOQVJZX0RJUn0vbGliNjQp CiAgICAgc2V0KENNQUtFX0xJQlJBUllfT1VUUFVUX0RJUkVDVE9SWSAke0NNQUtFX0JJTkFSWV9E SVJ9L2xpYjY0KQogICAgIHNldChDTUFLRV9SVU5USU1FX09VVFBVVF9ESVJFQ1RPUlkgJHtDTUFL RV9CSU5BUllfRElSfS9iaW42NCkKIGVuZGlmICgpCitzZXQoQ01BS0VfQVJDSElWRV9PVVRQVVRf RElSRUNUT1JZX0RFQlVHICIke0NNQUtFX0FSQ0hJVkVfT1VUUFVUX0RJUkVDVE9SWX0iKQorc2V0 KENNQUtFX0FSQ0hJVkVfT1VUUFVUX0RJUkVDVE9SWV9SRUxFQVNFICIke0NNQUtFX0FSQ0hJVkVf T1VUUFVUX0RJUkVDVE9SWX0iKQorc2V0KENNQUtFX0xJQlJBUllfT1VUUFVUX0RJUkVDVE9SWV9E RUJVRyAiJHtDTUFLRV9MSUJSQVJZX09VVFBVVF9ESVJFQ1RPUll9IikKK3NldChDTUFLRV9MSUJS QVJZX09VVFBVVF9ESVJFQ1RPUllfUkVMRUFTRSAiJHtDTUFLRV9MSUJSQVJZX09VVFBVVF9ESVJF Q1RPUll9IikKK3NldChDTUFLRV9SVU5USU1FX09VVFBVVF9ESVJFQ1RPUllfREVCVUcgIiR7Q01B S0VfUlVOVElNRV9PVVRQVVRfRElSRUNUT1JZfSIpCitzZXQoQ01BS0VfUlVOVElNRV9PVVRQVVRf RElSRUNUT1JZX1JFTEVBU0UgIiR7Q01BS0VfUlVOVElNRV9PVVRQVVRfRElSRUNUT1JZfSIpCiAK IGlmIChNU1ZDKQogICAgIGFkZF9kZWZpbml0aW9ucygK