148109 2015-08-17 17:01:25 -0700 Media Session: don't begin listening for interruptions when an interruption provider is created 2015-08-18 18:05:22 -0700 1 1 1 Unclassified WebKit Media Other All All RESOLVED FIXED InRadar P2 Normal --- 145411 1 mrajca webkit-unassigned conrad_shultz eric.carlson mrajca webkit-bug-importer oldest_to_newest 1118325 0 mrajca 2015-08-17 17:01:25 -0700 If we call beginListeningForInterruption in MediaSessionInterruptionProvider's constructor, the current class's implementation will get called, not implementations provided by subclasses (this makes sense since base classes are initialized before derived classes). To fix this, we let clients of MediaSessionInterruptionProvider start listening for interruptions instead. 1118327 1 webkit-bug-importer 2015-08-17 17:02:42 -0700 <rdar://problem/22317444> 1118330 2 259212 mrajca 2015-08-17 17:06:49 -0700 Created attachment 259212 Patch 1118515 3 259212 eric.carlson 2015-08-18 08:20:03 -0700 Comment on attachment 259212 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259212&action=review > Source/WebCore/Modules/mediasession/MediaSessionManager.cpp:48 > + m_interruptionProvider->beginListeningForInterruptions(); Shouldn't this and stopListeningForInterruptions be pure virtual? 1118752 4 mrajca 2015-08-18 18:04:13 -0700 (In reply to comment #3) > Comment on attachment 259212 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=259212&action=review > > > Source/WebCore/Modules/mediasession/MediaSessionManager.cpp:48 > > + m_interruptionProvider->beginListeningForInterruptions(); > > Shouldn't this and stopListeningForInterruptions be pure virtual? Yeah. That wasn't possible before since we were calling these in MediaSessionInterruptionProvider's constructor/destructor, but now that that responsibility has been demoted to the caller, I'll make the switch. 1118753 5 mrajca 2015-08-18 18:05:22 -0700 Committed r188615: <http://trac.webkit.org/changeset/188615> 259212 2015-08-17 17:06:49 -0700 2015-08-18 08:20:03 -0700 Patch bug-148109-20150817170648.patch text/plain 2644 mrajca U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4MzQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTdlMTljZTFmMDM3ZTg3 ZjEyNDEyNTdmNzcwYzEyNjFiYzM5YzhlNC4uNDczZjAyMzFjYjhhNzdiNzhlY2JkNjc3Y2EzYTJl MzkyZTQ5NzE5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTA4LTE3ICBNYXR0 IFJhamNhICA8bXJhamNhQGFwcGxlLmNvbT4KKworICAgICAgICBNZWRpYSBTZXNzaW9uOiBkb24n dCBiZWdpbiBsaXN0ZW5pbmcgZm9yIGludGVycnVwdGlvbnMgd2hlbiBhbiBpbnRlcnJ1cHRpb24g cHJvdmlkZXIgaXMgY3JlYXRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQ4MTA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgSWYgd2UgY2FsbCBgYmVnaW5MaXN0ZW5pbmdGb3JJbnRlcnJ1cHRpb25gIGlu IE1lZGlhU2Vzc2lvbkludGVycnVwdGlvblByb3ZpZGVyJ3MgY29uc3RydWN0b3IsIHRoZSBjdXJy ZW50CisgICAgICAgIGNsYXNzJ3MgaW1wbGVtZW50YXRpb24gd2lsbCBnZXQgY2FsbGVkLCBub3Qg aW1wbGVtZW50YXRpb25zIHByb3ZpZGVkIGJ5IHN1YmNsYXNzZXMgKHRoaXMgbWFrZXMgc2Vuc2Ug c2luY2UgYmFzZQorICAgICAgICBjbGFzc2VzIGFyZSBpbml0aWFsaXplZCBiZWZvcmUgZGVyaXZl ZCBjbGFzc2VzKS4gVG8gZml4IHRoaXMsIHdlIGxldCBjbGllbnRzIG9mCisgICAgICAgIE1lZGlh U2Vzc2lvbkludGVycnVwdGlvblByb3ZpZGVyIHN0YXJ0IGxpc3RlbmluZyBmb3IgaW50ZXJydXB0 aW9ucyBpbnN0ZWFkLgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYXNlc3Npb24vTWVkaWFTZXNz aW9uTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVNlc3Npb25NYW5hZ2VyOjpN ZWRpYVNlc3Npb25NYW5hZ2VyKToKKyAgICAgICAgKiBwbGF0Zm9ybS9tZWRpYXNlc3Npb24vTWVk aWFTZXNzaW9uSW50ZXJydXB0aW9uUHJvdmlkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVk aWFTZXNzaW9uSW50ZXJydXB0aW9uUHJvdmlkZXI6Ok1lZGlhU2Vzc2lvbkludGVycnVwdGlvblBy b3ZpZGVyKToKKwogMjAxNS0wOC0xMiAgTWF0dCBSYWpjYSAgPG1yYWpjYUBhcHBsZS5jb20+CiAK ICAgICAgICAgRml4ZWQgdGhlIFJlbGVhc2UgYnVpbGQgd2hlbiBNRURJQV9TRVNTSU9OIGlzIGVu YWJsZWQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc2Vzc2lvbi9N ZWRpYVNlc3Npb25NYW5hZ2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzZXNz aW9uL01lZGlhU2Vzc2lvbk1hbmFnZXIuY3BwCmluZGV4IDE5ZTczY2ZjZjNiNTE4YTcwOTdjNGVm YjY5OTA2ZGM4ODhhMDcwNTYuLjFjNDAwY2MyZDUxYWI2NDViODE4NmZhMTg1ODY4YmY2YzU4NjVj YTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzZXNzaW9uL01lZGlh U2Vzc2lvbk1hbmFnZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzZXNz aW9uL01lZGlhU2Vzc2lvbk1hbmFnZXIuY3BwCkBAIC00NSw2ICs0NSw3IEBAIE1lZGlhU2Vzc2lv bk1hbmFnZXI6Ok1lZGlhU2Vzc2lvbk1hbmFnZXIoKQogewogI2lmIFBMQVRGT1JNKE1BQykKICAg ICBtX2ludGVycnVwdGlvblByb3ZpZGVyID0gYWRvcHRSZWYobmV3IE1lZGlhU2Vzc2lvbkludGVy cnVwdGlvblByb3ZpZGVyTWFjKCp0aGlzKSk7CisgICAgbV9pbnRlcnJ1cHRpb25Qcm92aWRlci0+ YmVnaW5MaXN0ZW5pbmdGb3JJbnRlcnJ1cHRpb25zKCk7CiAjZW5kaWYKIH0KIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzZXNzaW9uL01lZGlhU2Vzc2lvbkludGVy cnVwdGlvblByb3ZpZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc2Vzc2lv bi9NZWRpYVNlc3Npb25JbnRlcnJ1cHRpb25Qcm92aWRlci5jcHAKaW5kZXggYzU1MmFiODM1YzJi YTVmNjRjYzZhZmQ3MDRhNjRhZWE1MDU4OTg1ZS4uMDczYzc3YTNmMmRkZTA2YTE4Yzk4ZTlmNjVj MDQ2MDAzNTFmNTIyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFz ZXNzaW9uL01lZGlhU2Vzc2lvbkludGVycnVwdGlvblByb3ZpZGVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXNlc3Npb24vTWVkaWFTZXNzaW9uSW50ZXJydXB0aW9uUHJv dmlkZXIuY3BwCkBAIC0zMyw3ICszMyw2IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIE1lZGlhU2Vz c2lvbkludGVycnVwdGlvblByb3ZpZGVyOjpNZWRpYVNlc3Npb25JbnRlcnJ1cHRpb25Qcm92aWRl cihNZWRpYVNlc3Npb25JbnRlcnJ1cHRpb25Qcm92aWRlckNsaWVudCYgY2xpZW50KQogICAgIDog bV9jbGllbnQoJmNsaWVudCkKIHsKLSAgICBiZWdpbkxpc3RlbmluZ0ZvckludGVycnVwdGlvbnMo KTsKIH0KIAogTWVkaWFTZXNzaW9uSW50ZXJydXB0aW9uUHJvdmlkZXI6On5NZWRpYVNlc3Npb25J bnRlcnJ1cHRpb25Qcm92aWRlcigpCg==