14810 2007-07-29 18:53:50 -0700 [gtk] [patch] Bad n_params on load_finished's g_signal_new in webkitgtkpage.cpp 2007-07-29 21:08:42 -0700 1 1 1 Unclassified WebKit WebKit API 523.x (Safari 3) PC Linux RESOLVED FIXED P2 Normal --- 0 diegoe webkit-unassigned diegoe oldest_to_newest 3476 0 diegoe 2007-07-29 18:53:50 -0700 In webkitgtkpage.cpp: --- gtk/Api/webkitgtkpage.cpp (revision 24766) +++ gtk/Api/webkitgtkpage.cpp (working copy) @@ -215,8 +215,8 @@ static void webkit_gtk_page_class_init(W NULL, NULL, webkit_gtk_marshal_VOID__OBJECT_BOOLEAN, - G_TYPE_NONE, 1, - WEBKIT_GTK_TYPE_FRAME); + G_TYPE_NONE, 2, + WEBKIT_GTK_TYPE_FRAME, G_TYPE_BOOLEAN); 3472 1 15736 diegoe 2007-07-29 19:39:31 -0700 Created attachment 15736 The patch with a corresponding changelog entry :) 3470 2 15736 alp 2007-07-29 20:09:17 -0700 Comment on attachment 15736 The patch with a corresponding changelog entry Thanks! Note that I've fixed up the ChangeLog entry a little to match formatting conventions and made the log a bit more descriptive before landing this patch. 3465 3 15737 diegoe 2007-07-29 20:48:45 -0700 Created attachment 15737 Fixes class_offset argument of various signals An updated version. 3466 4 15737 alp 2007-07-29 21:08:42 -0700 Comment on attachment 15737 Fixes class_offset argument of various signals This one fixes the remaining issues (except for one of the signals, the fix for which I've added to the patch). It also modifies the formatting of the previous ChangeLog entry by mistake, a change which I've removed. 15736 2007-07-29 19:39:31 -0700 2007-07-29 20:48:45 -0700 The patch with a corresponding changelog entry bwo_14810_marshal.diff text/plain 1062 diegoe SW5kZXg6IGd0ay9BcGkvd2Via2l0Z3RrcGFnZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gZ3RrL0FwaS93 ZWJraXRndGtwYWdlLmNwcAkocmV2aXNpb24gMjQ3NjYpCisrKyBndGsvQXBpL3dlYmtpdGd0a3Bh Z2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMTUsOCArMjE1LDggQEAgc3RhdGljIHZvaWQgd2Vi a2l0X2d0a19wYWdlX2NsYXNzX2luaXQoVwogICAgICAgICAgICAgTlVMTCwKICAgICAgICAgICAg IE5VTEwsCiAgICAgICAgICAgICB3ZWJraXRfZ3RrX21hcnNoYWxfVk9JRF9fT0JKRUNUX0JPT0xF QU4sCi0gICAgICAgICAgICBHX1RZUEVfTk9ORSwgMSwKLSAgICAgICAgICAgIFdFQktJVF9HVEtf VFlQRV9GUkFNRSk7CisgICAgICAgICAgICBHX1RZUEVfTk9ORSwgMiwKKyAgICAgICAgICAgIFdF QktJVF9HVEtfVFlQRV9GUkFNRSwgR19UWVBFX0JPT0xFQU4pOwogCiAgICAgd2Via2l0X2d0a19w YWdlX3NpZ25hbHNbVElUTEVfQ0hBTkdFRF0gPSBnX3NpZ25hbF9uZXcoInRpdGxlX2NoYW5nZWQi LAogICAgICAgICAgICAgR19UWVBFX0ZST01fQ0xBU1MocGFnZV9jbGFzcyksCkluZGV4OiBDaGFu Z2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDc2NikKKysrIENoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDExIEBACisyMDA3LTA3LTI5ICBEaWVnbyBF c2NhbGFudGUgVXJyZWxvIDxkaWVnb2VAZ25vbWUub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZ3RrL0FwaS93ZWJraXRndGtwYWdlLmNwcDoK KworCVVzZXMgYSBjb3JyZWN0IG5fcGFyYW1zIHZhbHVlIGFuZCB0aGUgY29ycmVzcG9uZGluZyB0 eXBlcyBmb3IgdGhlbS4KKwogMjAwNy0wNy0yOSAgQWRlbGUgUGV0ZXJzb24gIDxhZGVsZUBhcHBs ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSm9obi4K 15737 2007-07-29 20:48:45 -0700 2007-07-29 21:08:42 -0700 Fixes class_offset argument of various signals bwo_14810_marshal.diff text/plain 5569 diegoe SW5kZXg6IGd0ay9BcGkvd2Via2l0Z3RrZnJhbWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGd0ay9BcGkv d2Via2l0Z3RrZnJhbWUuY3BwCShyZXZpc2lvbiAyNDc2OCkKKysrIGd0ay9BcGkvd2Via2l0Z3Rr ZnJhbWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03NCw3ICs3NCw3IEBAIHN0YXRpYyB2b2lkIHdl YmtpdF9ndGtfZnJhbWVfY2xhc3NfaW5pdCgKICAgICB3ZWJraXRfZ3RrX2ZyYW1lX3NpZ25hbHNb Q0xFQVJFRF0gPSBnX3NpZ25hbF9uZXcoImNsZWFyZWQiLAogICAgICAgICAgICAgR19UWVBFX0ZS T01fQ0xBU1MoZnJhbWVfY2xhc3MpLAogICAgICAgICAgICAgKEdTaWduYWxGbGFncykoR19TSUdO QUxfUlVOX0xBU1QgfCBHX1NJR05BTF9BQ1RJT04pLAotICAgICAgICAgICAgTlVMTCwKKyAgICAg ICAgICAgIDAsCiAgICAgICAgICAgICBOVUxMLAogICAgICAgICAgICAgTlVMTCwKICAgICAgICAg ICAgIGdfY2Nsb3N1cmVfbWFyc2hhbF9WT0lEX19WT0lELApAQCAtODMsNyArODMsNyBAQCBzdGF0 aWMgdm9pZCB3ZWJraXRfZ3RrX2ZyYW1lX2NsYXNzX2luaXQoCiAgICAgd2Via2l0X2d0a19mcmFt ZV9zaWduYWxzW0xPQURfRE9ORV0gPSBnX3NpZ25hbF9uZXcoImxvYWRfZG9uZSIsCiAgICAgICAg ICAgICBHX1RZUEVfRlJPTV9DTEFTUyhmcmFtZV9jbGFzcyksCiAgICAgICAgICAgICAoR1NpZ25h bEZsYWdzKShHX1NJR05BTF9SVU5fTEFTVCB8IEdfU0lHTkFMX0FDVElPTiksCi0gICAgICAgICAg ICBOVUxMLAorICAgICAgICAgICAgMCwKICAgICAgICAgICAgIE5VTEwsCiAgICAgICAgICAgICBO VUxMLAogICAgICAgICAgICAgZ19jY2xvc3VyZV9tYXJzaGFsX1ZPSURfX0JPT0xFQU4sCkBAIC05 Myw3ICs5Myw3IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF9ndGtfZnJhbWVfY2xhc3NfaW5pdCgKICAg ICB3ZWJraXRfZ3RrX2ZyYW1lX3NpZ25hbHNbVElUTEVfQ0hBTkdFRF0gPSBnX3NpZ25hbF9uZXco InRpdGxlX2NoYW5nZWQiLAogICAgICAgICAgICAgR19UWVBFX0ZST01fQ0xBU1MoZnJhbWVfY2xh c3MpLAogICAgICAgICAgICAgKEdTaWduYWxGbGFncykoR19TSUdOQUxfUlVOX0xBU1QgfCBHX1NJ R05BTF9BQ1RJT04pLAotICAgICAgICAgICAgTlVMTCwKKyAgICAgICAgICAgIDAsCiAgICAgICAg ICAgICBOVUxMLAogICAgICAgICAgICAgTlVMTCwKICAgICAgICAgICAgIHdlYmtpdF9ndGtfbWFy c2hhbF9WT0lEX19TVFJJTkdfU1RSSU5HLApAQCAtMTAzLDcgKzEwMyw3IEBAIHN0YXRpYyB2b2lk IHdlYmtpdF9ndGtfZnJhbWVfY2xhc3NfaW5pdCgKICAgICB3ZWJraXRfZ3RrX2ZyYW1lX3NpZ25h bHNbSE9WRVJJTkdfT1ZFUl9MSU5LXSA9IGdfc2lnbmFsX25ldygiaG92ZXJpbmdfb3Zlcl9saW5r IiwKICAgICAgICAgICAgIEdfVFlQRV9GUk9NX0NMQVNTKGZyYW1lX2NsYXNzKSwKICAgICAgICAg ICAgIChHU2lnbmFsRmxhZ3MpKEdfU0lHTkFMX1JVTl9MQVNUIHwgR19TSUdOQUxfQUNUSU9OKSwK LSAgICAgICAgICAgIE5VTEwsCisgICAgICAgICAgICAwLAogICAgICAgICAgICAgTlVMTCwKICAg ICAgICAgICAgIE5VTEwsCiAgICAgICAgICAgICB3ZWJraXRfZ3RrX21hcnNoYWxfVk9JRF9fU1RS SU5HX1NUUklORywKSW5kZXg6IGd0ay9BcGkvd2Via2l0Z3RrcGFnZS5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gZ3RrL0FwaS93ZWJraXRndGtwYWdlLmNwcAkocmV2aXNpb24gMjQ3NjgpCisrKyBndGsvQXBp L3dlYmtpdGd0a3BhZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMDEsNyArMjAxLDcgQEAgc3Rh dGljIHZvaWQgd2Via2l0X2d0a19wYWdlX2NsYXNzX2luaXQoVwogICAgIHdlYmtpdF9ndGtfcGFn ZV9zaWduYWxzW0xPQURfUFJPR1JFU1NfQ0hBTkdFRF0gPSBnX3NpZ25hbF9uZXcoImxvYWRfcHJv Z3Jlc3NfY2hhbmdlZCIsCiAgICAgICAgICAgICBHX1RZUEVfRlJPTV9DTEFTUyhwYWdlX2NsYXNz KSwKICAgICAgICAgICAgIChHU2lnbmFsRmxhZ3MpKEdfU0lHTkFMX1JVTl9MQVNUIHwgR19TSUdO QUxfQUNUSU9OKSwKLSAgICAgICAgICAgIE5VTEwsCisgICAgICAgICAgICAwLAogICAgICAgICAg ICAgTlVMTCwKICAgICAgICAgICAgIE5VTEwsCiAgICAgICAgICAgICBnX2NjbG9zdXJlX21hcnNo YWxfVk9JRF9fSU5ULApAQCAtMjExLDE3ICsyMTEsMTcgQEAgc3RhdGljIHZvaWQgd2Via2l0X2d0 a19wYWdlX2NsYXNzX2luaXQoVwogICAgIHdlYmtpdF9ndGtfcGFnZV9zaWduYWxzW0xPQURfRklO SVNIRURdID0gZ19zaWduYWxfbmV3KCJsb2FkX2ZpbmlzaGVkIiwKICAgICAgICAgICAgIEdfVFlQ RV9GUk9NX0NMQVNTKHBhZ2VfY2xhc3MpLAogICAgICAgICAgICAgKEdTaWduYWxGbGFncykoR19T SUdOQUxfUlVOX0xBU1QgfCBHX1NJR05BTF9BQ1RJT04pLAorICAgICAgICAgICAgMCwKICAgICAg ICAgICAgIE5VTEwsCiAgICAgICAgICAgICBOVUxMLAotICAgICAgICAgICAgTlVMTCwKLSAgICAg ICAgICAgIHdlYmtpdF9ndGtfbWFyc2hhbF9WT0lEX19PQkpFQ1RfQk9PTEVBTiwKLSAgICAgICAg ICAgIEdfVFlQRV9OT05FLCAyLAotICAgICAgICAgICAgV0VCS0lUX0dUS19UWVBFX0ZSQU1FLCBH X1RZUEVfQk9PTEVBTik7CisgICAgICAgICAgICBnX2NjbG9zdXJlX21hcnNoYWxfVk9JRF9fT0JK RUNULAorICAgICAgICAgICAgR19UWVBFX05PTkUsIDEsCisgICAgICAgICAgICBXRUJLSVRfR1RL X1RZUEVfRlJBTUUpOwogCiAgICAgd2Via2l0X2d0a19wYWdlX3NpZ25hbHNbVElUTEVfQ0hBTkdF RF0gPSBnX3NpZ25hbF9uZXcoInRpdGxlX2NoYW5nZWQiLAogICAgICAgICAgICAgR19UWVBFX0ZS T01fQ0xBU1MocGFnZV9jbGFzcyksCiAgICAgICAgICAgICAoR1NpZ25hbEZsYWdzKShHX1NJR05B TF9SVU5fTEFTVCB8IEdfU0lHTkFMX0FDVElPTiksCi0gICAgICAgICAgICBOVUxMLAorICAgICAg ICAgICAgMCwKICAgICAgICAgICAgIE5VTEwsCiAgICAgICAgICAgICBOVUxMLAogICAgICAgICAg ICAgd2Via2l0X2d0a19tYXJzaGFsX1ZPSURfX1NUUklOR19TVFJJTkcsCkBAIC0yMzEsNyArMjMx LDcgQEAgc3RhdGljIHZvaWQgd2Via2l0X2d0a19wYWdlX2NsYXNzX2luaXQoVwogICAgIHdlYmtp dF9ndGtfcGFnZV9zaWduYWxzW0hPVkVSSU5HX09WRVJfTElOS10gPSBnX3NpZ25hbF9uZXcoImhv dmVyaW5nX292ZXJfbGluayIsCiAgICAgICAgICAgICBHX1RZUEVfRlJPTV9DTEFTUyhwYWdlX2Ns YXNzKSwKICAgICAgICAgICAgIChHU2lnbmFsRmxhZ3MpKEdfU0lHTkFMX1JVTl9MQVNUIHwgR19T SUdOQUxfQUNUSU9OKSwKLSAgICAgICAgICAgIE5VTEwsCisgICAgICAgICAgICAwLAogICAgICAg ICAgICAgTlVMTCwKICAgICAgICAgICAgIE5VTEwsCiAgICAgICAgICAgICB3ZWJraXRfZ3RrX21h cnNoYWxfVk9JRF9fU1RSSU5HX1NUUklORywKQEAgLTI0Miw3ICsyNDIsNyBAQCBzdGF0aWMgdm9p ZCB3ZWJraXRfZ3RrX3BhZ2VfY2xhc3NfaW5pdChXCiAgICAgd2Via2l0X2d0a19wYWdlX3NpZ25h bHNbU1RBVFVTX0JBUl9URVhUX0NIQU5HRURdID0gZ19zaWduYWxfbmV3KCJzdGF0dXNfYmFyX3Rl eHRfY2hhbmdlZCIsCiAgICAgICAgICAgICBHX1RZUEVfRlJPTV9DTEFTUyhwYWdlX2NsYXNzKSwK ICAgICAgICAgICAgIChHU2lnbmFsRmxhZ3MpKEdfU0lHTkFMX1JVTl9MQVNUIHwgR19TSUdOQUxf QUNUSU9OKSwKLSAgICAgICAgICAgIE5VTEwsCisgICAgICAgICAgICAwLAogICAgICAgICAgICAg TlVMTCwKICAgICAgICAgICAgIE5VTEwsCiAgICAgICAgICAgICBnX2NjbG9zdXJlX21hcnNoYWxf Vk9JRF9fU1RSSU5HLApAQCAtMjUyLDcgKzI1Miw3IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF9ndGtf cGFnZV9jbGFzc19pbml0KFcKICAgICB3ZWJraXRfZ3RrX3BhZ2Vfc2lnbmFsc1tJQ09ORF9MT0FE RURdID0gZ19zaWduYWxfbmV3KCJpY29uX2xvYWRlZCIsCiAgICAgICAgICAgICBHX1RZUEVfRlJP TV9DTEFTUyhwYWdlX2NsYXNzKSwKICAgICAgICAgICAgIChHU2lnbmFsRmxhZ3MpKEdfU0lHTkFM X1JVTl9MQVNUIHwgR19TSUdOQUxfQUNUSU9OKSwKLSAgICAgICAgICAgIE5VTEwsCisgICAgICAg ICAgICAwLAogICAgICAgICAgICAgTlVMTCwKICAgICAgICAgICAgIE5VTEwsCiAgICAgICAgICAg ICBnX2NjbG9zdXJlX21hcnNoYWxfVk9JRF9fVk9JRCwKQEAgLTI2MSw3ICsyNjEsNyBAQCBzdGF0 aWMgdm9pZCB3ZWJraXRfZ3RrX3BhZ2VfY2xhc3NfaW5pdChXCiAgICAgd2Via2l0X2d0a19wYWdl X3NpZ25hbHNbU0VMRUNUSU9OX0NIQU5HRURdID0gZ19zaWduYWxfbmV3KCJzZWxlY3Rpb25fY2hh bmdlZCIsCiAgICAgICAgICAgICBHX1RZUEVfRlJPTV9DTEFTUyhwYWdlX2NsYXNzKSwKICAgICAg ICAgICAgIChHU2lnbmFsRmxhZ3MpKEdfU0lHTkFMX1JVTl9MQVNUIHwgR19TSUdOQUxfQUNUSU9O KSwKLSAgICAgICAgICAgIE5VTEwsCisgICAgICAgICAgICAwLAogICAgICAgICAgICAgTlVMTCwK ICAgICAgICAgICAgIE5VTEwsCiAgICAgICAgICAgICBnX2NjbG9zdXJlX21hcnNoYWxfVk9JRF9f Vk9JRCwKSW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9u IDI0NzY4KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTAgQEAKKzIw MDctMDctMjkgIERpZWdvIEVzY2FsYW50ZSBVcnJlbG8gIDxkaWVnb2VAZ25vbWUub3JnPiAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGd0ay9BcGkv d2Via2l0Z3RrZnJhbWUuY3BwOgorICAgICAgICAqIGd0ay9BcGkvd2Via2l0Z3RrcGFnZS5jcHA6 IEZpeCBjbGFzc19vZmZzZXQgcGFyYW1ldGVyIG9mIHNpZ25hbHMuCisKIDIwMDctMDctMjkgIERp ZWdvIEVzY2FsYW50ZSBVcnJlbG8gIDxkaWVnb2VAZ25vbWUub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEFscCBUb2tlci4KQEAgLTUsOCArMTIsNyBAQAogICAgICAgICBodHRwOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDgxMAogICAgICAgICBCYWQgbl9wYXJhbXMgb24g bG9hZF9maW5pc2hlZCdzIGdfc2lnbmFsX25ldyBpbiB3ZWJraXRndGtwYWdlLmNwcAogCi0gICAg ICAgICogZ3RrL0FwaS93ZWJraXRndGtwYWdlLmNwcDogVXNlIGEgY29ycmVjdCBuX3BhcmFtcyB2 YWx1ZSBhbmQgdGhlIGNvcnJlc3BvbmRpbmcgdHlwZXMgZm9yCi0gICAgICAgIHRoZW0gaW4gdGhl ICJsb2FkX2ZpbmlzaGVkIiBzaWduYWwuCisgICAgICAgICogZ3RrL0FwaS93ZWJraXRndGtwYWdl LmNwcDogVXNlIGEgY29ycmVjdCBuX3BhcmFtcyB2YWx1ZSBhbmQgdGhlIGNvcnJlc3BvbmRpbmcg dHlwZXMgZm9yIHRoZW0gaW4gdGhlICJsb2FkX2ZpbmlzaGVkIiBzaWduYWwuCiAKIDIwMDctMDct MjkgIEFkZWxlIFBldGVyc29uICA8YWRlbGVAYXBwbGUuY29tPgogCg==