148090 2015-08-17 13:28:08 -0700 WTF::Condition should have a fast path for notifyOne/notifyAll that avoids calling unparkOne/unparkAll 2015-08-18 15:36:00 -0700 1 1 1 Unclassified WebKit Web Template Framework Other All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough basile_clement benjamin cmarcelo commit-queue ggaren mark.lam mhahnenb mmirman msaboff nrotem oliver saam sam oldest_to_newest 1118219 0 fpizlo 2015-08-17 13:28:08 -0700 Patch forthcoming. 1118609 1 259291 fpizlo 2015-08-18 12:50:30 -0700 Created attachment 259291 the patch 1118611 2 commit-queue 2015-08-18 12:53:18 -0700 Attachment 259291 did not pass style-queue: ERROR: Source/WTF/wtf/Condition.h:153: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1118616 3 259291 ggaren 2015-08-18 13:39:52 -0700 Comment on attachment 259291 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=259291&action=review r=me > Source/WTF/wtf/Condition.h:72 > + // Let everyone know that we will be waiting. Do this why we hold the queue lock, why => while > Source/WTF/wtf/Condition.h:167 > + // guaranteed to then notifyAll() anyway. So, if there is a race with some thread calling notifyAll => unparkAll. 1118632 4 fpizlo 2015-08-18 14:29:46 -0700 (In reply to comment #3) > Comment on attachment 259291 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=259291&action=review > > r=me > > > Source/WTF/wtf/Condition.h:72 > > + // Let everyone know that we will be waiting. Do this why we hold the queue lock, > > why => while > > > Source/WTF/wtf/Condition.h:167 > > + // guaranteed to then notifyAll() anyway. So, if there is a race with some thread calling > > notifyAll => unparkAll. Fixed, thanks! 1118662 5 fpizlo 2015-08-18 15:36:00 -0700 Landed in http://trac.webkit.org/changeset/188605 259291 2015-08-18 12:50:30 -0700 2015-08-18 13:39:52 -0700 the patch blah.patch text/plain 4556 fpizlo SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxODg1OTQpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDE1LTA4LTE4ICBGaWxpcCBQaXpsbyAgPGZwaXps b0BhcHBsZS5jb20+CisKKyAgICAgICAgV1RGOjpDb25kaXRpb24gc2hvdWxkIGhhdmUgYSBmYXN0 IHBhdGggZm9yIG5vdGlmeU9uZS9ub3RpZnlBbGwgdGhhdCBhdm9pZHMgY2FsbGluZyB1bnBhcmtP bmUvdW5wYXJrQWxsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNDgwOTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGlzIGNoYW5nZSBtYWtlcyBub3RpZnlPbmUoKS9ub3RpZnlBbGwoKSBibGF6aW5nIGZh c3Qgd2hlbiBub2JvZHkgaXMgd2FpdGluZywgYnkgdXNpbmcgdGhlCisgICAgICAgIHZhcmlvdXMg aG9va3MgdGhhdCBQYXJraW5nTG90IGdpdmVzIHVzIHRvIG1haW50YWluIGEgbV9oYXNXYWl0ZXJz IHZhcmlhYmxlLiBXaGVuIGl0J3MgZmFsc2UsIGl0CisgICAgICAgIG1lYW5zIHRoYXQgYW55IHVu cGFyayBvcGVyYXRpb24gd291bGQgc2ltcGx5IHJldHVybiBpbW1lZGlhdGVseS4KKworICAgICAg ICBUaGlzIGlzIGEgNDUlIHNwZWVkLXVwIGZvciB0aGUgMS1wcm9kdWNlci8xLWNvbnN1bWVyIHNj ZW5hcmlvIHdpdGggYSAxMDAtZWxlbWVudCBxdWV1ZSB3aGVuIHlvdQorICAgICAgICB1c2UgdGhl IG5vdGlmeU9uZSgpLXBlci1lbnF1ZXVlIHN0eWxlLiBXaGF0J3MgY29vbCBhYm91dCB0aGlzIGNo YW5nZSBpcyB0aGF0IHlvdSBjYW4gbm93IHNhZmVseQorICAgICAgICBjYWxsIG5vdGlmeU9uZSgp IChvciBub3RpZnlBbGwoKSkgb3V0IG9mIHBhcmFub2lhLCBqdXN0IGluIGNhc2Ugc29tZW9uZSBt aWdodCBiZSB3YWl0aW5nLiBJdCdzCisgICAgICAgIGZyZWUgdG8gZG8gc28gaWYgbm9ib2R5IGlz IHdhaXRpbmchCisKKyAgICAgICAgKiB3dGYvQ29uZGl0aW9uLmg6CisgICAgICAgIChXVEY6OkNv bmRpdGlvbjo6Q29uZGl0aW9uKToKKyAgICAgICAgKFdURjo6Q29uZGl0aW9uOjp3YWl0VW50aWwp OgorICAgICAgICAoV1RGOjpDb25kaXRpb246Om5vdGlmeU9uZSk6CisgICAgICAgIChXVEY6OkNv bmRpdGlvbjo6bm90aWZ5QWxsKToKKwogMjAxNS0wOC0xNyAgRmlsaXAgUGl6bG8gIDxmcGl6bG9A YXBwbGUuY29tPgogCiAgICAgICAgIFJlcGxhY2UgYWxsIHJlbWFpbmluZyB1c2VzIG9mIFdURjo6 TXV0ZXggd2l0aCBXVEY6OkxvY2sKSW5kZXg6IFNvdXJjZS9XVEYvd3RmL0NvbmRpdGlvbi5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL0NvbmRpdGlvbi5oCShyZXZpc2lvbiAxODg1OTQp CisrKyBTb3VyY2UvV1RGL3d0Zi9Db25kaXRpb24uaAkod29ya2luZyBjb3B5KQpAQCAtMzgsNyAr MzgsMTAgQEAgY2xhc3MgQ29uZGl0aW9uIHsKIHB1YmxpYzoKICAgICB0eXBlZGVmIFBhcmtpbmdM b3Q6OkNsb2NrIENsb2NrOwogICAgIAotICAgIENvbmRpdGlvbigpIHsgfQorICAgIENvbmRpdGlv bigpCisgICAgeworICAgICAgICBtX2hhc1dhaXRlcnMuc3RvcmUoZmFsc2UpOworICAgIH0KIAog ICAgIC8vIFdhaXQgb24gYSBwYXJraW5nIHF1ZXVlIHdoaWxlIHJlbGVhc2luZyB0aGUgZ2l2ZW4g bG9jay4gSXQgd2lsbCB1bmxvY2sgdGhlIGxvY2sganVzdCBiZWZvcmUKICAgICAvLyBwYXJraW5n LCBhbmQgcmVsb2NrIGl0IHVwb24gd2FrZXVwLiBSZXR1cm5zIHRydWUgaWYgd2Ugd29rZSB1cCBk dWUgdG8gc29tZSBjYWxsIHRvCkBAIC02NCw4ICs2NywxMyBAQCBwdWJsaWM6CiAgICAgICAgICAg ICByZXN1bHQgPSBmYWxzZTsKICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgIHJlc3VsdCA9 IFBhcmtpbmdMb3Q6OnBhcmtDb25kaXRpb25hbGx5KAotICAgICAgICAgICAgICAgICZtX2R1bW15 LAotICAgICAgICAgICAgICAgIFtdICgpIC0+IGJvb2wgeyByZXR1cm4gdHJ1ZTsgfSwKKyAgICAg ICAgICAgICAgICAmbV9oYXNXYWl0ZXJzLAorICAgICAgICAgICAgICAgIFt0aGlzXSAoKSAtPiBi b29sIHsKKyAgICAgICAgICAgICAgICAgICAgLy8gTGV0IGV2ZXJ5b25lIGtub3cgdGhhdCB3ZSB3 aWxsIGJlIHdhaXRpbmcuIERvIHRoaXMgd2h5IHdlIGhvbGQgdGhlIHF1ZXVlIGxvY2ssCisgICAg ICAgICAgICAgICAgICAgIC8vIHRvIHByZXZlbnQgcmFjZXMgd2l0aCBub3RpZnlPbmUoKS4KKyAg ICAgICAgICAgICAgICAgICAgbV9oYXNXYWl0ZXJzLnN0b3JlKHRydWUpOworICAgICAgICAgICAg ICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICAgICAgICAgICAgICB9LAogICAgICAgICAgICAgICAg IFsmbG9ja10gKCkgeyBsb2NrLnVubG9jaygpOyB9LAogICAgICAgICAgICAgICAgIHRpbWVvdXQp OwogICAgICAgICB9CkBAIC0xMjksMTggKzEzNywzOSBAQCBwdWJsaWM6CiAgICAgICAgIHJldHVy biB3YWl0Rm9yU2Vjb25kc0ltcGwobG9jaywgYWJzb2x1dGVUaW1lb3V0U2Vjb25kcyAtIG1vbm90 b25pY2FsbHlJbmNyZWFzaW5nVGltZSgpKTsKICAgICB9CiAKLSAgICAvLyBGSVhNRTogV2UgY291 bGQgcmVwbGFjZSB0aGUgZHVtbXkgYnl0ZSB3aXRoIGEgYm9vbGVhbiB0byB0ZWxsIHVzIGlmIHRo ZXJlIGlzIGFueW9uZSB3YWl0aW5nCi0gICAgLy8gcmlnaHQgbm93LiBUaGlzIGNvdWxkIGJlIHVz ZWQgdG8gaW1wbGVtZW50IGEgZmFzdCBwYXRoIGZvciBub3RpZnlPbmUoKSBhbmQgbm90aWZ5QWxs KCkuCi0gICAgLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODA5 MAotCisgICAgLy8gTm90ZSB0aGF0IHRoaXMgbWV0aG9kIGlzIGV4dHJlbWVseSBmYXN0IHdoZW4g bm9ib2R5IGlzIHdhaXRpbmcuIEl0IGlzIG5vdCBuZWNlc3NhcnkgdG8gdHJ5IHRvCisgICAgLy8g YXZvaWQgY2FsbGluZyB0aGlzIG1ldGhvZC4KICAgICB2b2lkIG5vdGlmeU9uZSgpCiAgICAgewot ICAgICAgICBQYXJraW5nTG90Ojp1bnBhcmtPbmUoJm1fZHVtbXkpOworICAgICAgICBpZiAoIW1f aGFzV2FpdGVycy5sb2FkKCkpIHsKKyAgICAgICAgICAgIC8vIEF0IHRoaXMgZXhhY3QgaW5zdGFu dCwgdGhlcmUgaXMgbm9ib2R5IHdhaXRpbmcgb24gdGhpcyBjb25kaXRpb24uIFRoZSB3YXkgdG8g dmlzdWFsaXplCisgICAgICAgICAgICAvLyB0aGlzIGlzIHRoYXQgaWYgdW5wYXJrT25lKCkgcmFu IHRvIGNvbXBsZXRpb24gd2l0aG91dCBvYnN0cnVjdGlvbnMgYXQgdGhpcyBtb21lbnQsIGl0Cisg ICAgICAgICAgICAvLyB3b3VsZG4ndCB3YWtlIGFueW9uZSB1cC4gSGVuY2UsIHdlIGhhdmUgbm90 aGluZyB0byBkbyEKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQorICAgICAgICAKKyAg ICAgICAgUGFya2luZ0xvdDo6dW5wYXJrT25lKAorICAgICAgICAgICAgJm1faGFzV2FpdGVycywK KyAgICAgICAgICAgIFt0aGlzXSAoYm9vbCwgYm9vbCBtYXlIYXZlTW9yZVRocmVhZHMpIHsKKyAg ICAgICAgICAgICAgICBpZiAoIW1heUhhdmVNb3JlVGhyZWFkcykKKyAgICAgICAgICAgICAgICAg ICAgbV9oYXNXYWl0ZXJzLnN0b3JlKGZhbHNlKTsKKyAgICAgICAgICAgIH0pOwogICAgIH0KICAg ICAKICAgICB2b2lkIG5vdGlmeUFsbCgpCiAgICAgewotICAgICAgICBQYXJraW5nTG90Ojp1bnBh cmtBbGwoJm1fZHVtbXkpOworICAgICAgICBpZiAoIW1faGFzV2FpdGVycy5sb2FkKCkpIHsKKyAg ICAgICAgICAgIC8vIFNlZSBhYm92ZS4KKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQor CisgICAgICAgIC8vIEl0J3MgdG90YWxseSBzYWZlIGZvciB1cyB0byBzZXQgdGhpcyB0byBmYWxz ZSB3aXRob3V0IGFueSBsb2NraW5nLCBiZWNhdXNlIHRoaXMgdGhyZWFkIGlzCisgICAgICAgIC8v IGd1YXJhbnRlZWQgdG8gdGhlbiBub3RpZnlBbGwoKSBhbnl3YXkuIFNvLCBpZiB0aGVyZSBpcyBh IHJhY2Ugd2l0aCBzb21lIHRocmVhZCBjYWxsaW5nCisgICAgICAgIC8vIHdhaXQoKSBqdXN0IGJl Zm9yZSB0aGlzIHN0b3JlIGhhcHBlbnMsIHRoYXQgdGhyZWFkIGlzIGd1YXJhbnRlZWQgdG8gYmUg YXdva2VuIGJ5IHRoZSBjYWxsIHRvCisgICAgICAgIC8vIHVucGFya0FsbCgpLCBiZWxvdy4KKyAg ICAgICAgbV9oYXNXYWl0ZXJzLnN0b3JlKGZhbHNlKTsKKyAgICAgICAgCisgICAgICAgIFBhcmtp bmdMb3Q6OnVucGFya0FsbCgmbV9oYXNXYWl0ZXJzKTsKICAgICB9CiAgICAgCiBwcml2YXRlOgpA QCAtMTk0LDcgKzIyMyw3IEBAIHByaXZhdGU6CiAgICAgICAgIHJldHVybiBDbG9jazo6bm93KCkg KyBteVJlbGF0aXZlVGltZW91dDsKICAgICB9CiAKLSAgICB1aW50OF90IG1fZHVtbXk7CisgICAg QXRvbWljPGJvb2w+IG1faGFzV2FpdGVyczsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdURgo=