148080 2015-08-17 10:16:47 -0700 Add performance tests for traversal of collections returned by getElementsByClassName() / getElementsByTagName() 2015-08-17 15:28:23 -0700 1 1 1 Unclassified WebKit DOM Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 110611 147980 1 cdumez cdumez barraclough commit-queue koivisto rniwa oldest_to_newest 1118138 0 cdumez 2015-08-17 10:16:47 -0700 Add performance tests for traversal of *uncached* collections returned by getElementsByClassName() / getElementsByTagName(). getElementsByClassName() / getElementsByTagName() will soon be updated to return an HTMLCollection instead of a NodeList and we need to make sure we don't regress performance in the process. 1118139 1 259159 cdumez 2015-08-17 10:18:54 -0700 Created attachment 259159 Patch 1118267 2 259159 commit-queue 2015-08-17 15:28:17 -0700 Comment on attachment 259159 Patch Clearing flags on attachment: 259159 Committed r188547: <http://trac.webkit.org/changeset/188547> 1118268 3 commit-queue 2015-08-17 15:28:23 -0700 All reviewed patches have been landed. Closing bug. 259159 2015-08-17 10:18:54 -0700 2015-08-17 15:28:17 -0700 Patch bug-148080-20150817101853.patch text/plain 3525 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4NTIzCmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDgyMzhjYTQ3MGY2 NTgzNGE1NzMxZGIxZTgwOGQwNDY5ZTZiYjRmMzEuLjJhNTc0ZjQyMzY5NzBhNmU5YjBhODhiMjk0 MWIxMzNlZTBkMjQ5ODUgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCisr KyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTUtMDgt MTcgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgcGVyZm9y bWFuY2UgdGVzdHMgZm9yIHRyYXZlcnNhbCBvZiBjb2xsZWN0aW9ucyByZXR1cm5lZCBieSBnZXRF bGVtZW50c0J5Q2xhc3NOYW1lKCkgLyBnZXRFbGVtZW50c0J5VGFnTmFtZSgpCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDgwODAKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgcGVyZm9ybWFuY2UgdGVz dHMgZm9yIHRyYXZlcnNhbCBvZiAqdW5jYWNoZWQqIGNvbGxlY3Rpb25zIHJldHVybmVkCisgICAg ICAgIGJ5IGdldEVsZW1lbnRzQnlDbGFzc05hbWUoKSAvIGdldEVsZW1lbnRzQnlUYWdOYW1lKCku IFRoZXNlIG1ldGhvZHMKKyAgICAgICAgd2lsbCBzb29uIGJlIHVwZGF0ZWQgdG8gcmV0dXJuIGFu IEhUTUxDb2xsZWN0aW9uIGluc3RlYWQgb2YgYQorICAgICAgICBOb2RlTGlzdCBhbmQgd2UgbmVl ZCB0byBtYWtlIHN1cmUgd2UgZG9uJ3QgcmVncmVzcyBwZXJmb3JtYW5jZSBpbiB0aGUKKyAgICAg ICAgcHJvY2Vzcy4KKworICAgICAgICAqIERPTS9nZXQtZWxlbWVudHMtYnktY2xhc3MtbmFtZS10 cmF2ZXJzYWwtdW5jYWNoZWQuaHRtbDogQWRkZWQuCisgICAgICAgICogRE9NL2dldC1lbGVtZW50 cy1ieS10YWctbmFtZS10cmF2ZXJzYWwtdW5jYWNoZWQuaHRtbDogQWRkZWQuCisKIDIwMTUtMDgt MTQgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgcGVyZm9y bWFuY2UgdGVzdHMgZm9yIE5vZGVMaXN0IGFuZCBIVE1MQ29sbGVjdGlvbiB0cmF2ZXJzYWwKZGlm ZiAtLWdpdCBhL1BlcmZvcm1hbmNlVGVzdHMvRE9NL2dldC1lbGVtZW50cy1ieS1jbGFzcy1uYW1l LXRyYXZlcnNhbC11bmNhY2hlZC5odG1sIGIvUGVyZm9ybWFuY2VUZXN0cy9ET00vZ2V0LWVsZW1l bnRzLWJ5LWNsYXNzLW5hbWUtdHJhdmVyc2FsLXVuY2FjaGVkLmh0bWwKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMWY4 MzdlODcxNDc4MjJiNDdjMWRmZjJjOTRkODRmZjNkZjZiYzc2OQotLS0gL2Rldi9udWxsCisrKyBi L1BlcmZvcm1hbmNlVGVzdHMvRE9NL2dldC1lbGVtZW50cy1ieS1jbGFzcy1uYW1lLXRyYXZlcnNh bC11bmNhY2hlZC5odG1sCkBAIC0wLDAgKzEsMjUgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+ Cis8aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi9yZXNvdXJjZXMvcnVubmVyLmpzIj48L3NjcmlwdD4K KzxzY3JpcHQ+CitmdW5jdGlvbiBydW5UZXN0KCkgeworICAgIFBlcmZUZXN0UnVubmVyLm1lYXN1 cmVSdW5zUGVyU2Vjb25kKHsKKyAgICAgICAgZGVzY3JpcHRpb246ICJUaGlzIGJlbmNobWFyayBj b3ZlcnMgJ2dldEVsZW1lbnRzQnlDbGFzc05hbWUnLiIsCisgICAgICAgIHJ1bjogZnVuY3Rpb24o KSB7CisgICAgICAgICAgICB2YXIgdGVzdERvY3VtZW50ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoInRlc3RGcmFtZSIpLmNvbnRlbnREb2N1bWVudDsKKyAgICAgICAgICAgIGZvciAodmFyIGkg PSAwOyBpIDwgMTA7IGkrKykgeworICAgICAgICAgICAgICAgIHZhciBlbGVtZW50cyA9IHRlc3RE b2N1bWVudC5nZXRFbGVtZW50c0J5Q2xhc3NOYW1lKCJleGFtcGxlIik7CisgICAgICAgICAgICAg ICAgLy8gRG8gbm90IGFjY2VzcyBsZW5ndGggc28gdGhhdCB3ZSBkbyBub3QgY2FjaGUgdGhlIGVs ZW1lbnRzLgorICAgICAgICAgICAgICAgIHZhciBqID0gMDsKKyAgICAgICAgICAgICAgICB3aGls ZSAoZWxlbWVudHMuaXRlbShqKyspKSB7IH0KKyAgICAgICAgICAgIH0KKyAgICAgICAgfQorICAg IH0pOworfQorPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9InJ1blRlc3QoKSI+Cis8 aWZyYW1lIGlkPSJ0ZXN0RnJhbWUiIHNyYz0iLi4vUGFyc2VyL3Jlc291cmNlcy9odG1sNS5odG1s IiBzdHlsZT0iZGlzcGxheTpub25lIiBzYW5kYm94PjwvaWZyYW1lPgorPC9ib2R5PgorPC9odG1s PgpkaWZmIC0tZ2l0IGEvUGVyZm9ybWFuY2VUZXN0cy9ET00vZ2V0LWVsZW1lbnRzLWJ5LXRhZy1u YW1lLXRyYXZlcnNhbC11bmNhY2hlZC5odG1sIGIvUGVyZm9ybWFuY2VUZXN0cy9ET00vZ2V0LWVs ZW1lbnRzLWJ5LXRhZy1uYW1lLXRyYXZlcnNhbC11bmNhY2hlZC5odG1sCm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmZj M2ZiNDA2MjlhZDczNWM1NGE1MzU0MWZjZGJlZTI3Y2YwZWQwOGYKLS0tIC9kZXYvbnVsbAorKysg Yi9QZXJmb3JtYW5jZVRlc3RzL0RPTS9nZXQtZWxlbWVudHMtYnktdGFnLW5hbWUtdHJhdmVyc2Fs LXVuY2FjaGVkLmh0bWwKQEAgLTAsMCArMSwyNSBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4K KzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uL3Jlc291cmNlcy9ydW5uZXIuanMiPjwvc2NyaXB0Pgor PHNjcmlwdD4KK2Z1bmN0aW9uIHJ1blRlc3QoKSB7CisgICAgUGVyZlRlc3RSdW5uZXIubWVhc3Vy ZVJ1bnNQZXJTZWNvbmQoeworICAgICAgICBkZXNjcmlwdGlvbjogIlRoaXMgYmVuY2htYXJrIGNv dmVycyAnZ2V0RWxlbWVudHNCeVRhZ05hbWUnLiIsCisgICAgICAgIHJ1bjogZnVuY3Rpb24oKSB7 CisgICAgICAgICAgICB2YXIgdGVzdERvY3VtZW50ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo InRlc3RGcmFtZSIpLmNvbnRlbnREb2N1bWVudDsKKyAgICAgICAgICAgIGZvciAodmFyIGkgPSAw OyBpIDwgMTA7IGkrKykgeworICAgICAgICAgICAgICAgIHZhciBlbGVtZW50cyA9IHRlc3REb2N1 bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgicCIpOworICAgICAgICAgICAgICAgIC8vIERvIG5v dCBhY2Nlc3MgbGVuZ3RoIHNvIHRoYXQgd2UgZG8gbm90IGNhY2hlIHRoZSBlbGVtZW50cy4KKyAg ICAgICAgICAgICAgICB2YXIgaiA9IDA7CisgICAgICAgICAgICAgICAgd2hpbGUgKGVsZW1lbnRz Lml0ZW0oaisrKSkgeyB9CisgICAgICAgICAgICB9CisgICAgICAgIH0KKyAgICB9KTsKK30KKzwv c2NyaXB0PgorPC9oZWFkPgorPGJvZHkgb25sb2FkPSJydW5UZXN0KCkiPgorPGlmcmFtZSBpZD0i dGVzdEZyYW1lIiBzcmM9Ii4uL1BhcnNlci9yZXNvdXJjZXMvaHRtbDUuaHRtbCIgc3R5bGU9ImRp c3BsYXk6bm9uZSIgc2FuZGJveD48L2lmcmFtZT4KKzwvYm9keT4KKzwvaHRtbD4K