148073 2015-08-16 19:22:42 -0700 Fix conversion-null warning in conversion.cpp of TestWebKitAPI 2015-08-18 18:25:42 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim ap commit-queue oldest_to_newest 1118074 0 gyuyoung.kim 2015-08-16 19:22:42 -0700 When building EFL port, there is conversion-null build warning. [5131/5306] Building CXX object Tools/TestWebKitAPI/CMakeFiles/TestWTF.dir/Tests/WTF/Condition.cpp.o ../../Tools/TestWebKitAPI/Tests/WTF/Condition.cpp: In member function ‘virtual void TestWebKitAPI::WTF_Condition_TimeoutTimesOut_Test::TestBody()’: ../../Tools/TestWebKitAPI/Tests/WTF/Condition.cpp:253:158: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null] EXPECT_EQ(false, result); ^ [5306/5306] Linking CXX executable bin/TestWebKitAPI/WebKit2/WillSendSubmitEvent 1118075 1 259134 gyuyoung.kim 2015-08-16 19:23:54 -0700 Created attachment 259134 Patch 1118349 2 259134 ap 2015-08-17 18:06:57 -0700 Comment on attachment 259134 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259134&action=review > Tools/TestWebKitAPI/Tests/WTF/Condition.cpp:253 > - EXPECT_EQ(false, result); > + EXPECT_EQ(result, false); According to documentation, the order is correct: EXPECT_EQ(expected, actual). This needs a different fix. 1118484 3 259258 gyuyoung.kim 2015-08-18 00:50:55 -0700 Created attachment 259258 Patch 1118485 4 gyuyoung.kim 2015-08-18 00:51:56 -0700 (In reply to comment #2) > Comment on attachment 259134 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=259134&action=review > > > Tools/TestWebKitAPI/Tests/WTF/Condition.cpp:253 > > - EXPECT_EQ(false, result); > > + EXPECT_EQ(result, false); > > According to documentation, the order is correct: EXPECT_EQ(expected, > actual). This needs a different fix. Yes, we should use EXPECT_FALSE|TRUE when checking boolean instead of EXPECT_EQ. 1118760 5 259258 commit-queue 2015-08-18 18:25:39 -0700 Comment on attachment 259258 Patch Clearing flags on attachment: 259258 Committed r188618: <http://trac.webkit.org/changeset/188618> 1118761 6 commit-queue 2015-08-18 18:25:42 -0700 All reviewed patches have been landed. Closing bug. 259134 2015-08-16 19:23:54 -0700 2015-08-18 00:50:49 -0700 Patch bug-148073-20150817112332.patch text/plain 1230 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4NTIwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTkxN2YzZmVjZmYxYzQ1OGI2ZjJhNmVkMDBlYjNjZjMz NjIyM2Q4Ni4uZmI0Mzc1MDdhMWU0ZWZmMGEyYmU3NmM2ODFlYjEzOGQwNTMzNDEwNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE1LTA4LTE2ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ad2Via2l0Lm9yZz4K KworICAgICAgICBGaXggY29udmVyc2lvbi1udWxsIHdhcm5pbmcgaW4gY29udmVyc2lvbi5jcHAg b2YgVGVzdFdlYktpdEFQSQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTQ4MDczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9Db25kaXRpb24uY3BwOiBDaGFuZ2Ug YXJndW1lbnQgb3JkZXIuCisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKToKKwogMjAxNS0w OC0xMSAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgW0NvY29hXSBB ZGQgcmVkaXJlY3Qgc3VwcG9ydCB0byBDdXN0b21Qcm90b2NvbE1hbmFnZXIKZGlmZiAtLWdpdCBh L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL0NvbmRpdGlvbi5jcHAgYi9Ub29scy9UZXN0 V2ViS2l0QVBJL1Rlc3RzL1dURi9Db25kaXRpb24uY3BwCmluZGV4IDQxMWJjZDQzNzA0MWUzNjNl ZjRmMTQxYWU3NGI0NmFiNjYxZDJlYTYuLjU1MTg1NDUwYzU5NDFjMjIxYjY1NGJmYjNiZjlmM2Mx NDg5YWZhZDkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL0NvbmRp dGlvbi5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvQ29uZGl0aW9uLmNw cApAQCAtMjUwLDcgKzI1MCw3IEBAIFRFU1QoV1RGX0NvbmRpdGlvbiwgVGltZW91dFRpbWVzT3V0 KQogICAgICAgICBsb2NrLCBzdGQ6OmNocm9ubzo6bWljcm9zZWNvbmRzKDEwMDAwKSwgW10gKCkg LT4gYm9vbCB7IHJldHVybiBmYWxzZTsgfSk7CiAgICAgbG9jay51bmxvY2soKTsKIAotICAgIEVY UEVDVF9FUShmYWxzZSwgcmVzdWx0KTsKKyAgICBFWFBFQ1RfRVEocmVzdWx0LCBmYWxzZSk7CiB9 CiAKIH0gLy8gbmFtZXNwYWNlIFRlc3RXZWJLaXRBUEkK 259258 2015-08-18 00:50:55 -0700 2015-08-18 18:25:39 -0700 Patch bug-148073-20150818165052.patch text/plain 1252 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4NTc5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZGRjNTA0NWUzOWNjYWYwYTQ3MmY3MDI1MGJhMWIzZTM4 M2Q4NjU5MS4uMTMzYjRkNmQ0Y2IzZjM5NDNmYWE4ZWI5ZWEyMmJhYjQ3MTFmNzRiNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE1LTA4LTE4ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ad2Via2l0Lm9yZz4K KworICAgICAgICBGaXggY29udmVyc2lvbi1udWxsIHdhcm5pbmcgaW4gY29udmVyc2lvbi5jcHAg b2YgVGVzdFdlYktpdEFQSQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTQ4MDczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9Db25kaXRpb24uY3BwOiBVc2UgRVhQ RUNUX0ZBTFNFIGluc3RlYWQgb2YgRVhQRUNUX0VRLgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6 VEVTVCk6CisKIDIwMTUtMDgtMTcgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQu b3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxODg1MzksIHIxODg1NDQs IHIxODg1NTIsIGFuZApkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYv Q29uZGl0aW9uLmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL0NvbmRpdGlvbi5j cHAKaW5kZXggNDExYmNkNDM3MDQxZTM2M2VmNGYxNDFhZTc0YjQ2YWI2NjFkMmVhNi4uN2Y2YzU3 ZGVmNDEyMGIyNjU2ZTRhZjJjODE2YmYwYjI4NjdmMTY5YyAxMDA2NDQKLS0tIGEvVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9XVEYvQ29uZGl0aW9uLmNwcAorKysgYi9Ub29scy9UZXN0V2ViS2l0 QVBJL1Rlc3RzL1dURi9Db25kaXRpb24uY3BwCkBAIC0yNTAsNyArMjUwLDcgQEAgVEVTVChXVEZf Q29uZGl0aW9uLCBUaW1lb3V0VGltZXNPdXQpCiAgICAgICAgIGxvY2ssIHN0ZDo6Y2hyb25vOjpt aWNyb3NlY29uZHMoMTAwMDApLCBbXSAoKSAtPiBib29sIHsgcmV0dXJuIGZhbHNlOyB9KTsKICAg ICBsb2NrLnVubG9jaygpOwogCi0gICAgRVhQRUNUX0VRKGZhbHNlLCByZXN1bHQpOworICAgIEVY UEVDVF9GQUxTRShyZXN1bHQpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBUZXN0V2ViS2l0QVBJCg==