<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>14807</bug_id>
          
          <creation_ts>2007-07-29 15:31:52 -0700</creation_ts>
          <short_desc>[gtk] API implementation: url and title</short_desc>
          <delta_ts>2009-03-16 15:39:24 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>523.x (Safari 3)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Gtk</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>19843</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Christian Dywan">christian</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>alp</cc>
    
    <cc>aroben</cc>
    
    <cc>gustavo</cc>
    
    <cc>pochu27</cc>
    
    <cc>xan.lopez</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>3491</commentid>
    <comment_count>0</comment_count>
    <who name="Christian Dywan">christian</who>
    <bug_when>2007-07-29 15:31:52 -0700</bug_when>
    <thetext>Currently the signal &quot;title-changed&quot; is emitted when either the url or the title has changed. Accordingly title and uri are provided as gchar* arguments. I suggest two changes.

1. For one we should split the signal into two separate signals, like &quot;uri-changed&quot; and &quot;title-changed&quot;. This makes a lot more sense to me.

2. Further more we should add a webkit_gtk_page_get_title and a webkit_gtk_page_get_uri, since we do not currently have any means of retrieving either the uri or the title directly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>3477</commentid>
    <comment_count>1</comment_count>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2007-07-29 18:01:45 -0700</bug_when>
    <thetext>(In reply to comment #0)
&gt; 2. Further more we should add a webkit_gtk_page_get_title and a
&gt; webkit_gtk_page_get_uri, since we do not currently have any means of retrieving
&gt; either the uri or the title directly.

I think this model might be too simple. The Mac/Windows APIs expose WebURLRequest and WebDataSource classes which can be queried for their URL/title, respectively. This is needed because a WebView can have more than one of each of these associated with it at a time. -[WebView provisionalDataSource] and -[WebView dataSource] expose WebDataSource&apos;s that represent the current and completed load, respectively. This is very useful when creating a window title like &quot;Loading -- Google&quot;, for example.

I think there are many benefits to mimicking the Mac/Windows API here.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>3473</commentid>
    <comment_count>2</comment_count>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2007-07-29 18:02:31 -0700</bug_when>
    <thetext>(In reply to comment #1)
&gt; -[WebView provisionalDataSource] and -[WebView dataSource]

Whoops. Make that -[WebFrame provisionalDataSource] and -[WebFrame dataSource]
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>3438</commentid>
    <comment_count>3</comment_count>
    <who name="Xan Lopez">xan.lopez</who>
    <bug_when>2007-07-30 11:36:35 -0700</bug_when>
    <thetext>(In reply to comment #1)
&gt; I think this model might be too simple. The Mac/Windows APIs expose
&gt; WebURLRequest and WebDataSource classes which can be queried for their
&gt; URL/title, respectively. This is needed because a WebView can have more than
&gt; one of each of these associated with it at a time. -[WebView
&gt; provisionalDataSource] and -[WebView dataSource] expose WebDataSource&apos;s that
&gt; represent the current and completed load, respectively. This is very useful
&gt; when creating a window title like &quot;Loading -- Google&quot;, for example.
&gt; 
&gt; I think there are many benefits to mimicking the Mac/Windows API here.

Are you simply suggesting to store the current and the &quot;in-progress&quot; title/url, or anything more sophisticated? Showing a temporary title like &quot;Loading -- Google&quot; and reverting to the old one (and old URL) in case of failure/cancellation would be certainly a nice touch.


</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>3419</commentid>
    <comment_count>4</comment_count>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2007-07-30 13:32:09 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; (In reply to comment #1)
&gt; Are you simply suggesting to store the current and the &quot;in-progress&quot; title/url,
&gt; or anything more sophisticated? Showing a temporary title like &quot;Loading --
&gt; Google&quot; and reverting to the old one (and old URL) in case of
&gt; failure/cancellation would be certainly a nice touch.

I&apos;m suggesting that you consider following the WebDataSource/WebURLRequest model of the Mac/Win APIs. There are many uses for these objects beyond just getting the title/URL.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>69321</commentid>
    <comment_count>5</comment_count>
    <who name="Alp Toker">alp</who>
    <bug_when>2008-02-03 23:52:38 -0800</bug_when>
    <thetext>(In reply to comment #4)
&gt; I&apos;m suggesting that you consider following the WebDataSource/WebURLRequest
&gt; model of the Mac/Win APIs. There are many uses for these objects beyond just
&gt; getting the title/URL.
&gt; 

So, to get things up to date:

We do have a simple equivalent to WebURLRequest now.

We still sorely lack a WebDataSource.

We could do with convenience web_view_get_title() and web_view_get_uri() functions. Or maybe web_view_get_main_title() and web_view_get_main_uri() would be more accurate. The Mac API has such convenience accessors now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>106891</commentid>
    <comment_count>6</comment_count>
      <attachid>27003</attachid>
    <who name="Christian Dywan">christian</who>
    <bug_when>2009-01-24 17:25:07 -0800</bug_when>
    <thetext>Created attachment 27003
Implement title and uri on the view

Our API is still inconsistent in such simple cases. The frame has URI and title accessors and properties, while the view has not. That leads to clumsy calls to webkit_web_view_get_main_frame where anything like a data source would be overkill. On top of that there are no property notifications at all, so the frame properties are even only half usable.

I suggest that we fix the frame properties and implement the very same properties on the view. Most of the webkit applications will find this enough for all they ever need. The attached patch does that.

Come to think of it, what about making URI writable? It&apos;s pure convenience but would allow for neat tricks like applying an initial location in g_object_new or loading a page inside a graphical interface builder.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>106955</commentid>
    <comment_count>7</comment_count>
      <attachid>27024</attachid>
    <who name="Christian Dywan">christian</who>
    <bug_when>2009-01-25 11:09:28 -0800</bug_when>
    <thetext>Created attachment 27024
Implement title and uri on the view #2

Updated. As suggested in bug 20306, this patch includes updating the URI also on navigation inside the same page. Plus it deprecates the &quot;title-changed&quot; signal which is now unneeded.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>106958</commentid>
    <comment_count>8</comment_count>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2009-01-25 11:56:26 -0800</bug_when>
    <thetext>(In reply to comment #7)
&gt; Created an attachment (id=27024) [review]
&gt; Implement title and uri on the view #2
&gt; 
&gt; Updated. As suggested in bug 20306, this patch includes updating the URI also
&gt; on navigation inside the same page. Plus it deprecates the &quot;title-changed&quot;
&gt; signal which is now unneeded.
&gt; 

I like the concept of using properties to notify of changes such as those. One thing that hit me while reading through the patch was that we might want to add some kind of DISABLE_DEPRECATED macro, and wrap signals and properties which we are &apos;deprecating&apos; now, while we still remember =D
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>113483</commentid>
    <comment_count>9</comment_count>
      <attachid>28553</attachid>
    <who name="Christian Dywan">christian</who>
    <bug_when>2009-03-12 13:59:45 -0700</bug_when>
    <thetext>Created attachment 28553
Implement title and uri on the view #3

Updated patch, now with version 1.1.2 tags and without the GtkLauncher bit.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>113817</commentid>
    <comment_count>10</comment_count>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2009-03-15 06:52:35 -0700</bug_when>
    <thetext>(In reply to comment #9)
&gt; Created an attachment (id=28553) [review]
&gt; Implement title and uri on the view #3
&gt; 
&gt; Updated patch, now with version 1.1.2 tags and without the GtkLauncher bit.
&gt; 

Looks good to me. I&apos;m in favor of r+&apos;ing =).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>113895</commentid>
    <comment_count>11</comment_count>
      <attachid>28553</attachid>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2009-03-16 10:54:39 -0700</bug_when>
    <thetext>Comment on attachment 28553
Implement title and uri on the view #3

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>113938</commentid>
    <comment_count>12</comment_count>
    <who name="Christian Dywan">christian</who>
    <bug_when>2009-03-16 15:39:24 -0700</bug_when>
    <thetext>2009-03-16  Christian Dywan  &lt;christian@twotoasts.de&gt;

        Reviewed by Adam Roben.

        [gtk] API implementation: url and title
        http://bugs.webkit.org/show_bug.cgi?id=14807

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchDidChangeLocationWithinPage):
        (WebKit::FrameLoaderClient::dispatchDidReceiveTitle):
        (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
        * webkit/webkitwebview.cpp:
        * webkit/webkitwebview.h: Implement &quot;title&quot; and &quot;uri&quot; properties as well
        as according functions. &quot;uri&quot; always reflects the current location
        including navigation inside the same page. title-changed is deprecated.

I adjusted the version tags while committing since we are targetting 1.1.4 now.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>27003</attachid>
            <date>2009-01-24 17:25:07 -0800</date>
            <delta_ts>2009-01-25 11:09:28 -0800</delta_ts>
            <desc>Implement title and uri on the view</desc>
            <filename>p.diff</filename>
            <type>text/plain</type>
            <size>7142</size>
            <attacher name="Christian Dywan">christian</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRH
dGsuY3BwIGIvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEd0ay5j
cHAKaW5kZXggMWI0MTBjNy4uNjhjYzZlYSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9XZWJDb3Jl
U3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEd0ay5jcHAKKysrIGIvV2ViS2l0L2d0ay9XZWJDb3Jl
U3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEd0ay5jcHAKQEAgLTU5NSwxMSArNTk1LDE4IEBAIHZv
aWQgRnJhbWVMb2FkZXJDbGllbnQ6OmRpc3BhdGNoRGlkU3RhcnRQcm92aXNpb25hbExvYWQoKQog
CiB2b2lkIEZyYW1lTG9hZGVyQ2xpZW50OjpkaXNwYXRjaERpZFJlY2VpdmVUaXRsZShjb25zdCBT
dHJpbmcmIHRpdGxlKQogewotICAgIGdfc2lnbmFsX2VtaXRfYnlfbmFtZShtX2ZyYW1lLCAidGl0
bGUtY2hhbmdlZCIsIHRpdGxlLnV0ZjgoKS5kYXRhKCkpOworICAgIFdlYktpdFdlYkZyYW1lUHJp
dmF0ZSogcHJpdiA9IG1fZnJhbWUtPnByaXY7CisgICAgZ19mcmVlKHByaXYtPnRpdGxlKTsKKyAg
ICBwcml2LT50aXRsZSA9IGdfc3RyZHVwKHRpdGxlLnV0ZjgoKS5kYXRhKCkpOworCisgICAgZ19z
aWduYWxfZW1pdF9ieV9uYW1lKG1fZnJhbWUsICJ0aXRsZS1jaGFuZ2VkIiwgcHJpdi0+dGl0bGUp
OworICAgIGdfb2JqZWN0X25vdGlmeShHX09CSkVDVChtX2ZyYW1lKSwgInRpdGxlIik7CiAKICAg
ICBXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3ID0gZ2V0Vmlld0Zyb21GcmFtZShtX2ZyYW1lKTsKLSAg
ICBpZiAobV9mcmFtZSA9PSB3ZWJraXRfd2ViX3ZpZXdfZ2V0X21haW5fZnJhbWUod2ViVmlldykp
CisgICAgaWYgKG1fZnJhbWUgPT0gd2Via2l0X3dlYl92aWV3X2dldF9tYWluX2ZyYW1lKHdlYlZp
ZXcpKSB7CiAgICAgICAgIGdfc2lnbmFsX2VtaXRfYnlfbmFtZSh3ZWJWaWV3LCAidGl0bGUtY2hh
bmdlZCIsIG1fZnJhbWUsIHRpdGxlLnV0ZjgoKS5kYXRhKCkpOworICAgICAgICBnX29iamVjdF9u
b3RpZnkoR19PQkpFQ1Qod2ViVmlldyksICJ0aXRsZSIpOworICAgIH0KIH0KIAogdm9pZCBGcmFt
ZUxvYWRlckNsaWVudDo6ZGlzcGF0Y2hEaWRDb21taXRMb2FkKCkKQEAgLTYwNywxNSArNjE0LDI4
IEBAIHZvaWQgRnJhbWVMb2FkZXJDbGllbnQ6OmRpc3BhdGNoRGlkQ29tbWl0TG9hZCgpCiAgICAg
LyogVXBkYXRlIHRoZSBVUkkgb25jZSBmaXJzdCBkYXRhIGhhcyBiZWVuIHJlY2VpdmVkLgogICAg
ICAqIFRoaXMgbWVhbnMgdGhlIFVSSSBpcyB2YWxpZCBhbmQgc3VjY2Vzc2Z1bGx5IGlkZW50aWZ5
IHRoZSBwYWdlIHRoYXQncyBnb2luZyB0byBiZSBsb2FkZWQuCiAgICAgICovCi0gICAgV2ViS2l0
V2ViRnJhbWVQcml2YXRlKiBmcmFtZURhdGEgPSBXRUJLSVRfV0VCX0ZSQU1FX0dFVF9QUklWQVRF
KG1fZnJhbWUpOwotICAgIGdfZnJlZShmcmFtZURhdGEtPnVyaSk7Ci0gICAgZnJhbWVEYXRhLT51
cmkgPSBnX3N0cmR1cChjb3JlKG1fZnJhbWUpLT5sb2FkZXIoKS0+dXJsKCkucHJldHR5VVJMKCku
dXRmOCgpLmRhdGEoKSk7CisgICAgZ19vYmplY3RfZnJlZXplX25vdGlmeShHX09CSkVDVChtX2Zy
YW1lKSk7CisKKyAgICBXZWJLaXRXZWJGcmFtZVByaXZhdGUqIHByaXYgPSBtX2ZyYW1lLT5wcml2
OworICAgIGdfZnJlZShwcml2LT51cmkpOworICAgIHByaXYtPnVyaSA9IGdfc3RyZHVwKGNvcmUo
bV9mcmFtZSktPmxvYWRlcigpLT51cmwoKS5wcmV0dHlVUkwoKS51dGY4KCkuZGF0YSgpKTsKKyAg
ICBnX2ZyZWUocHJpdi0+dGl0bGUpOworICAgIHByaXYtPnRpdGxlID0gTlVMTDsKKyAgICBnX29i
amVjdF9ub3RpZnkoR19PQkpFQ1QobV9mcmFtZSksICJ1cmkiKTsKKyAgICBnX29iamVjdF9ub3Rp
ZnkoR19PQkpFQ1QobV9mcmFtZSksICJ0aXRsZSIpOwogCiAgICAgZ19zaWduYWxfZW1pdF9ieV9u
YW1lKG1fZnJhbWUsICJsb2FkLWNvbW1pdHRlZCIpOwogCiAgICAgV2ViS2l0V2ViVmlldyogd2Vi
VmlldyA9IGdldFZpZXdGcm9tRnJhbWUobV9mcmFtZSk7Ci0gICAgaWYgKG1fZnJhbWUgPT0gd2Vi
a2l0X3dlYl92aWV3X2dldF9tYWluX2ZyYW1lKHdlYlZpZXcpKQorICAgIGlmIChtX2ZyYW1lID09
IHdlYmtpdF93ZWJfdmlld19nZXRfbWFpbl9mcmFtZSh3ZWJWaWV3KSkgeworICAgICAgICBnX29i
amVjdF9mcmVlemVfbm90aWZ5KEdfT0JKRUNUKHdlYlZpZXcpKTsKKyAgICAgICAgZ19vYmplY3Rf
bm90aWZ5KEdfT0JKRUNUKHdlYlZpZXcpLCAidXJpIik7CisgICAgICAgIGdfb2JqZWN0X25vdGlm
eShHX09CSkVDVCh3ZWJWaWV3KSwgInRpdGxlIik7CisgICAgICAgIGdfb2JqZWN0X3RoYXdfbm90
aWZ5KEdfT0JKRUNUKHdlYlZpZXcpKTsKICAgICAgICAgZ19zaWduYWxfZW1pdF9ieV9uYW1lKHdl
YlZpZXcsICJsb2FkLWNvbW1pdHRlZCIsIG1fZnJhbWUpOworICAgIH0KKworICAgIGdfb2JqZWN0
X3RoYXdfbm90aWZ5KEdfT0JKRUNUKG1fZnJhbWUpKTsKIH0KIAogdm9pZCBGcmFtZUxvYWRlckNs
aWVudDo6ZGlzcGF0Y2hEaWRGaW5pc2hEb2N1bWVudExvYWQoKQpkaWZmIC0tZ2l0IGEvV2ViS2l0
L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3
ZWJ2aWV3LmNwcAppbmRleCAzNThhY2U5Li4zM2QyZTllIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3Rr
L3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAorKysgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3
ZWJ2aWV3LmNwcApAQCAtMTM4LDYgKzEzOCw4IEBAIGVudW0gewogZW51bSB7CiAgICAgUFJPUF8w
LAogCisgICAgUFJPUF9USVRMRSwKKyAgICBQUk9QX1VSSSwKICAgICBQUk9QX0NPUFlfVEFSR0VU
X0xJU1QsCiAgICAgUFJPUF9QQVNURV9UQVJHRVRfTElTVCwKICAgICBQUk9QX0VESVRBQkxFLApA
QCAtMjc1LDYgKzI3NywxMiBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfZ2V0X3Byb3Bl
cnR5KEdPYmplY3QqIG9iamVjdCwgZ3VpbnQgcHJvcF9pZCwgR1ZhbHVlKgogICAgIFdlYktpdFdl
YlZpZXcqIHdlYlZpZXcgPSBXRUJLSVRfV0VCX1ZJRVcob2JqZWN0KTsKIAogICAgIHN3aXRjaChw
cm9wX2lkKSB7CisgICAgY2FzZSBQUk9QX1RJVExFOgorICAgICAgICBnX3ZhbHVlX3NldF9zdHJp
bmcodmFsdWUsIHdlYmtpdF93ZWJfdmlld19nZXRfdGl0bGUod2ViVmlldykpOworICAgICAgICBi
cmVhazsKKyAgICBjYXNlIFBST1BfVVJJOgorICAgICAgICBnX3ZhbHVlX3NldF9zdHJpbmcodmFs
dWUsIHdlYmtpdF93ZWJfdmlld19nZXRfdXJpKHdlYlZpZXcpKTsKKyAgICAgICAgYnJlYWs7CiAj
aWYgR1RLX0NIRUNLX1ZFUlNJT04oMiwxMCwwKQogICAgIGNhc2UgUFJPUF9DT1BZX1RBUkdFVF9M
SVNUOgogICAgICAgICBnX3ZhbHVlX3NldF9ib3hlZCh2YWx1ZSwgd2Via2l0X3dlYl92aWV3X2dl
dF9jb3B5X3RhcmdldF9saXN0KHdlYlZpZXcpKTsKQEAgLTE0NjAsNiArMTQ2OCwzNCBAQCBzdGF0
aWMgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfY2xhc3NfaW5pdChXZWJLaXRXZWJWaWV3Q2xhc3MqIHdl
YlZpZXdDbGFzcykKICAgICAgKiBwcm9wZXJ0aWVzCiAgICAgICovCiAKKyAgICAvKioKKyAgICAq
IFdlYktpdFdlYlZpZXc6dGl0bGU6CisgICAgKgorICAgICogUmV0dXJucyB0aGUgQHdlYl92aWV3
J3MgZG9jdW1lbnQgdGl0bGUuCisgICAgKgorICAgICogU2luY2U6IDEuMS4xCisgICAgKi8KKyAg
ICBnX29iamVjdF9jbGFzc19pbnN0YWxsX3Byb3BlcnR5KG9iamVjdENsYXNzLCBQUk9QX1RJVExF
LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ19wYXJhbV9zcGVjX3N0cmlu
ZygidGl0bGUiLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAiVGl0bGUiLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAiUmV0dXJucyB0aGUgQHdlYl92aWV3J3MgZG9jdW1lbnQgdGl0
bGUiLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBOVUxMLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBXRUJLSVRfUEFSQU1fUkVBREFCTEUpKTsKKworICAgIC8qKgorICAgICogV2Vi
S2l0V2ViVmlldzp1cmk6CisgICAgKgorICAgICogUmV0dXJucyB0aGUgY3VycmVudCBVUkkgb2Yg
dGhlIGNvbnRlbnRzIGRpc3BsYXllZCBieSB0aGUgQHdlYl92aWV3LgorICAgICoKKyAgICAqIFNp
bmNlOiAxLjEuMQorICAgICovCisgICAgZ19vYmplY3RfY2xhc3NfaW5zdGFsbF9wcm9wZXJ0eShv
YmplY3RDbGFzcywgUFJPUF9VUkksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICBnX3BhcmFtX3NwZWNfc3RyaW5nKCJ1cmkiLAorICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiVVJJIiwKKyAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIlJldHVybnMgdGhlIGN1cnJlbnQg
VVJJIG9mIHRoZSBjb250ZW50cyBkaXNwbGF5ZWQgYnkgdGhlIEB3ZWJfdmlldyIsCisgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIE5VTEwsCisg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFdF
QktJVF9QQVJBTV9SRUFEQUJMRSkpOworCiAjaWYgR1RLX0NIRUNLX1ZFUlNJT04oMiwxMCwwKQog
ICAgIC8qKgogICAgICogV2ViS2l0V2ViVmlldzpjb3B5LXRhcmdldC1saXN0OgpAQCAtMTg4OSw2
ICsxOTI1LDQyIEBAIFdlYktpdFdlYldpbmRvd0ZlYXR1cmVzKiB3ZWJraXRfd2ViX3ZpZXdfZ2V0
X3dpbmRvd19mZWF0dXJlcyhXZWJLaXRXZWJWaWV3KiB3ZWJWCiB9CiAKIC8qKgorICogd2Via2l0
X3dlYl92aWV3X2dldF90aXRsZToKKyAqIEB3ZWJfdmlldzogYSAjV2ViS2l0V2ViVmlldworICoK
KyAqIFJldHVybnMgdGhlIEB3ZWJfdmlldydzIGRvY3VtZW50IHRpdGxlCisgKgorICogU2luY2U6
IDEuMS4xCisgKgorICogUmV0dXJuIHZhbHVlOiB0aGUgdGl0bGUgb2YgQHdlYl92aWV3CisgKi8K
K0dfQ09OU1RfUkVUVVJOIGdjaGFyKiB3ZWJraXRfd2ViX3ZpZXdfZ2V0X3RpdGxlKFdlYktpdFdl
YlZpZXcqIHdlYlZpZXcpCit7CisgICAgZ19yZXR1cm5fdmFsX2lmX2ZhaWwoV0VCS0lUX0lTX1dF
Ql9WSUVXKHdlYlZpZXcpLCBOVUxMKTsKKworICAgIFdlYktpdFdlYlZpZXdQcml2YXRlKiBwcml2
ID0gd2ViVmlldy0+cHJpdjsKKyAgICByZXR1cm4gcHJpdi0+bWFpbkZyYW1lLT5wcml2LT50aXRs
ZTsKK30KKworLyoqCisgKiB3ZWJraXRfd2ViX3ZpZXdfZ2V0X3VyaToKKyAqIEB3ZWJfdmlldzog
YSAjV2ViS2l0V2ViVmlldworICoKKyAqIFJldHVybnMgdGhlIGN1cnJlbnQgVVJJIG9mIHRoZSBj
b250ZW50cyBkaXNwbGF5ZWQgYnkgdGhlIEB3ZWJfdmlldworICoKKyAqIFNpbmNlOiAxLjEuMQor
ICoKKyAqIFJldHVybiB2YWx1ZTogdGhlIFVSSSBvZiBAd2ViX3ZpZXcKKyAqLworR19DT05TVF9S
RVRVUk4gZ2NoYXIqIHdlYmtpdF93ZWJfdmlld19nZXRfdXJpKFdlYktpdFdlYlZpZXcqIHdlYlZp
ZXcpCit7CisgICAgZ19yZXR1cm5fdmFsX2lmX2ZhaWwoV0VCS0lUX0lTX1dFQl9WSUVXKHdlYlZp
ZXcpLCBOVUxMKTsKKworICAgIFdlYktpdFdlYlZpZXdQcml2YXRlKiBwcml2ID0gd2ViVmlldy0+
cHJpdjsKKyAgICByZXR1cm4gcHJpdi0+bWFpbkZyYW1lLT5wcml2LT51cmk7Cit9CisKKy8qKgog
ICogd2Via2l0X3dlYl92aWV3X3NldF9tYWludGFpbnNfYmFja19mb3J3YXJkX2xpc3Q6CiAgKiBA
d2ViX3ZpZXc6IGEgI1dlYktpdFdlYlZpZXcKICAqIEBmbGFnOiB0byB0ZWxsIHRoZSB2aWV3IHRv
IG1haW50YWluIGEgYmFjayBvciBmb3J3YXJkIGxpc3QKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsv
d2Via2l0L3dlYmtpdHdlYnZpZXcuaCBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcu
aAppbmRleCAyYmI4YzYxLi4yNGEwMTVkIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL3dlYmtpdC93
ZWJraXR3ZWJ2aWV3LmgKKysrIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5oCkBA
IC0xMjYsNiArMTI2LDEyIEBAIHdlYmtpdF93ZWJfdmlld19nZXRfdHlwZSAodm9pZCk7CiBXRUJL
SVRfQVBJIEd0a1dpZGdldCAqCiB3ZWJraXRfd2ViX3ZpZXdfbmV3ICh2b2lkKTsKIAorV0VCS0lU
X0FQSSBHX0NPTlNUX1JFVFVSTiBnY2hhciAqCit3ZWJraXRfd2ViX3ZpZXdfZ2V0X3RpdGxlICAg
ICAgICAgICAgICAgICAgICAgICAoV2ViS2l0V2ViVmlldyAgICAgICAgKndlYl92aWV3KTsKKwor
V0VCS0lUX0FQSSBHX0NPTlNUX1JFVFVSTiBnY2hhciAqCit3ZWJraXRfd2ViX3ZpZXdfZ2V0X3Vy
aSAgICAgICAgICAgICAgICAgICAgICAgICAoV2ViS2l0V2ViVmlldyAgICAgICAgKndlYl92aWV3
KTsKKwogV0VCS0lUX0FQSSB2b2lkCiB3ZWJraXRfd2ViX3ZpZXdfc2V0X21haW50YWluc19iYWNr
X2ZvcndhcmRfbGlzdCAoV2ViS2l0V2ViVmlldyAgICAgICAgKndlYl92aWV3LAogICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdib29sZWFuICAgICAgICAg
ICAgICBmbGFnKTsKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0d0a0xhdW5jaGVyL21haW4uYyBi
L1dlYktpdFRvb2xzL0d0a0xhdW5jaGVyL21haW4uYwppbmRleCA4ZWQyNjkwLi41OWYyMjMwIDEw
MDY0NAotLS0gYS9XZWJLaXRUb29scy9HdGtMYXVuY2hlci9tYWluLmMKKysrIGIvV2ViS2l0VG9v
bHMvR3RrTGF1bmNoZXIvbWFpbi5jCkBAIC0xODMsNiArMTgzLDggQEAgaW50CiBtYWluIChpbnQg
YXJnYywgY2hhciogYXJndltdKQogewogICAgIGd0a19pbml0ICgmYXJnYywgJmFyZ3YpOworICAg
IGlmICghZ190aHJlYWRfc3VwcG9ydGVkICgpKQorICAgICAgICBnX3RocmVhZF9pbml0IChOVUxM
KTsKIAogICAgIEd0a1dpZGdldCogdmJveCA9IGd0a192Ym94X25ldyAoRkFMU0UsIDApOwogICAg
IGd0a19ib3hfcGFja19zdGFydCAoR1RLX0JPWCAodmJveCksIGNyZWF0ZV90b29sYmFyICgpLCBG
QUxTRSwgRkFMU0UsIDApOwo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>27024</attachid>
            <date>2009-01-25 11:09:28 -0800</date>
            <delta_ts>2009-03-12 13:59:45 -0700</delta_ts>
            <desc>Implement title and uri on the view #2</desc>
            <filename>webviewtitle.diff</filename>
            <type>text/plain</type>
            <size>8002</size>
            <attacher name="Christian Dywan">christian</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRH
dGsuY3BwIGIvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEd0ay5j
cHAKaW5kZXggMWI0MTBjNy4uYmJhMGJjYSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9XZWJDb3Jl
U3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEd0ay5jcHAKKysrIGIvV2ViS2l0L2d0ay9XZWJDb3Jl
U3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEd0ay5jcHAKQEAgLTU3NCw3ICs1NzQsMTAgQEAgdm9p
ZCBGcmFtZUxvYWRlckNsaWVudDo6ZGlzcGF0Y2hXaWxsUGVyZm9ybUNsaWVudFJlZGlyZWN0KGNv
bnN0IEtVUkwmLCBkb3VibGUsIGQKIAogdm9pZCBGcmFtZUxvYWRlckNsaWVudDo6ZGlzcGF0Y2hE
aWRDaGFuZ2VMb2NhdGlvbldpdGhpblBhZ2UoKQogewotICAgIG5vdEltcGxlbWVudGVkKCk7Cisg
ICAgV2ViS2l0V2ViRnJhbWVQcml2YXRlKiBwcml2ID0gbV9mcmFtZS0+cHJpdjsKKyAgICBnX2Zy
ZWUocHJpdi0+dXJpKTsKKyAgICBwcml2LT51cmkgPSBnX3N0cmR1cChjb3JlKG1fZnJhbWUpLT5s
b2FkZXIoKS0+dXJsKCkucHJldHR5VVJMKCkudXRmOCgpLmRhdGEoKSk7CisgICAgZ19vYmplY3Rf
bm90aWZ5KEdfT0JKRUNUKG1fZnJhbWUpLCAidXJpIik7CiB9CiAKIHZvaWQgRnJhbWVMb2FkZXJD
bGllbnQ6OmRpc3BhdGNoV2lsbENsb3NlKCkKQEAgLTU5NSwxMSArNTk4LDE4IEBAIHZvaWQgRnJh
bWVMb2FkZXJDbGllbnQ6OmRpc3BhdGNoRGlkU3RhcnRQcm92aXNpb25hbExvYWQoKQogCiB2b2lk
IEZyYW1lTG9hZGVyQ2xpZW50OjpkaXNwYXRjaERpZFJlY2VpdmVUaXRsZShjb25zdCBTdHJpbmcm
IHRpdGxlKQogewotICAgIGdfc2lnbmFsX2VtaXRfYnlfbmFtZShtX2ZyYW1lLCAidGl0bGUtY2hh
bmdlZCIsIHRpdGxlLnV0ZjgoKS5kYXRhKCkpOworICAgIFdlYktpdFdlYkZyYW1lUHJpdmF0ZSog
cHJpdiA9IG1fZnJhbWUtPnByaXY7CisgICAgZ19mcmVlKHByaXYtPnRpdGxlKTsKKyAgICBwcml2
LT50aXRsZSA9IGdfc3RyZHVwKHRpdGxlLnV0ZjgoKS5kYXRhKCkpOworCisgICAgZ19zaWduYWxf
ZW1pdF9ieV9uYW1lKG1fZnJhbWUsICJ0aXRsZS1jaGFuZ2VkIiwgcHJpdi0+dGl0bGUpOworICAg
IGdfb2JqZWN0X25vdGlmeShHX09CSkVDVChtX2ZyYW1lKSwgInRpdGxlIik7CiAKICAgICBXZWJL
aXRXZWJWaWV3KiB3ZWJWaWV3ID0gZ2V0Vmlld0Zyb21GcmFtZShtX2ZyYW1lKTsKLSAgICBpZiAo
bV9mcmFtZSA9PSB3ZWJraXRfd2ViX3ZpZXdfZ2V0X21haW5fZnJhbWUod2ViVmlldykpCisgICAg
aWYgKG1fZnJhbWUgPT0gd2Via2l0X3dlYl92aWV3X2dldF9tYWluX2ZyYW1lKHdlYlZpZXcpKSB7
CiAgICAgICAgIGdfc2lnbmFsX2VtaXRfYnlfbmFtZSh3ZWJWaWV3LCAidGl0bGUtY2hhbmdlZCIs
IG1fZnJhbWUsIHRpdGxlLnV0ZjgoKS5kYXRhKCkpOworICAgICAgICBnX29iamVjdF9ub3RpZnko
R19PQkpFQ1Qod2ViVmlldyksICJ0aXRsZSIpOworICAgIH0KIH0KIAogdm9pZCBGcmFtZUxvYWRl
ckNsaWVudDo6ZGlzcGF0Y2hEaWRDb21taXRMb2FkKCkKQEAgLTYwNywxNSArNjE3LDI4IEBAIHZv
aWQgRnJhbWVMb2FkZXJDbGllbnQ6OmRpc3BhdGNoRGlkQ29tbWl0TG9hZCgpCiAgICAgLyogVXBk
YXRlIHRoZSBVUkkgb25jZSBmaXJzdCBkYXRhIGhhcyBiZWVuIHJlY2VpdmVkLgogICAgICAqIFRo
aXMgbWVhbnMgdGhlIFVSSSBpcyB2YWxpZCBhbmQgc3VjY2Vzc2Z1bGx5IGlkZW50aWZ5IHRoZSBw
YWdlIHRoYXQncyBnb2luZyB0byBiZSBsb2FkZWQuCiAgICAgICovCi0gICAgV2ViS2l0V2ViRnJh
bWVQcml2YXRlKiBmcmFtZURhdGEgPSBXRUJLSVRfV0VCX0ZSQU1FX0dFVF9QUklWQVRFKG1fZnJh
bWUpOwotICAgIGdfZnJlZShmcmFtZURhdGEtPnVyaSk7Ci0gICAgZnJhbWVEYXRhLT51cmkgPSBn
X3N0cmR1cChjb3JlKG1fZnJhbWUpLT5sb2FkZXIoKS0+dXJsKCkucHJldHR5VVJMKCkudXRmOCgp
LmRhdGEoKSk7CisgICAgZ19vYmplY3RfZnJlZXplX25vdGlmeShHX09CSkVDVChtX2ZyYW1lKSk7
CisKKyAgICBXZWJLaXRXZWJGcmFtZVByaXZhdGUqIHByaXYgPSBtX2ZyYW1lLT5wcml2OworICAg
IGdfZnJlZShwcml2LT51cmkpOworICAgIHByaXYtPnVyaSA9IGdfc3RyZHVwKGNvcmUobV9mcmFt
ZSktPmxvYWRlcigpLT51cmwoKS5wcmV0dHlVUkwoKS51dGY4KCkuZGF0YSgpKTsKKyAgICBnX2Zy
ZWUocHJpdi0+dGl0bGUpOworICAgIHByaXYtPnRpdGxlID0gTlVMTDsKKyAgICBnX29iamVjdF9u
b3RpZnkoR19PQkpFQ1QobV9mcmFtZSksICJ1cmkiKTsKKyAgICBnX29iamVjdF9ub3RpZnkoR19P
QkpFQ1QobV9mcmFtZSksICJ0aXRsZSIpOwogCiAgICAgZ19zaWduYWxfZW1pdF9ieV9uYW1lKG1f
ZnJhbWUsICJsb2FkLWNvbW1pdHRlZCIpOwogCiAgICAgV2ViS2l0V2ViVmlldyogd2ViVmlldyA9
IGdldFZpZXdGcm9tRnJhbWUobV9mcmFtZSk7Ci0gICAgaWYgKG1fZnJhbWUgPT0gd2Via2l0X3dl
Yl92aWV3X2dldF9tYWluX2ZyYW1lKHdlYlZpZXcpKQorICAgIGlmIChtX2ZyYW1lID09IHdlYmtp
dF93ZWJfdmlld19nZXRfbWFpbl9mcmFtZSh3ZWJWaWV3KSkgeworICAgICAgICBnX29iamVjdF9m
cmVlemVfbm90aWZ5KEdfT0JKRUNUKHdlYlZpZXcpKTsKKyAgICAgICAgZ19vYmplY3Rfbm90aWZ5
KEdfT0JKRUNUKHdlYlZpZXcpLCAidXJpIik7CisgICAgICAgIGdfb2JqZWN0X25vdGlmeShHX09C
SkVDVCh3ZWJWaWV3KSwgInRpdGxlIik7CisgICAgICAgIGdfb2JqZWN0X3RoYXdfbm90aWZ5KEdf
T0JKRUNUKHdlYlZpZXcpKTsKICAgICAgICAgZ19zaWduYWxfZW1pdF9ieV9uYW1lKHdlYlZpZXcs
ICJsb2FkLWNvbW1pdHRlZCIsIG1fZnJhbWUpOworICAgIH0KKworICAgIGdfb2JqZWN0X3RoYXdf
bm90aWZ5KEdfT0JKRUNUKG1fZnJhbWUpKTsKIH0KIAogdm9pZCBGcmFtZUxvYWRlckNsaWVudDo6
ZGlzcGF0Y2hEaWRGaW5pc2hEb2N1bWVudExvYWQoKQpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay93
ZWJraXQvd2Via2l0d2Vidmlldy5jcHAgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3
LmNwcAppbmRleCAzNThhY2U5Li5mYTBkNDBiIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL3dlYmtp
dC93ZWJraXR3ZWJ2aWV3LmNwcAorKysgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3
LmNwcApAQCAtMTM4LDYgKzEzOCw4IEBAIGVudW0gewogZW51bSB7CiAgICAgUFJPUF8wLAogCisg
ICAgUFJPUF9USVRMRSwKKyAgICBQUk9QX1VSSSwKICAgICBQUk9QX0NPUFlfVEFSR0VUX0xJU1Qs
CiAgICAgUFJPUF9QQVNURV9UQVJHRVRfTElTVCwKICAgICBQUk9QX0VESVRBQkxFLApAQCAtMjc1
LDYgKzI3NywxMiBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfZ2V0X3Byb3BlcnR5KEdP
YmplY3QqIG9iamVjdCwgZ3VpbnQgcHJvcF9pZCwgR1ZhbHVlKgogICAgIFdlYktpdFdlYlZpZXcq
IHdlYlZpZXcgPSBXRUJLSVRfV0VCX1ZJRVcob2JqZWN0KTsKIAogICAgIHN3aXRjaChwcm9wX2lk
KSB7CisgICAgY2FzZSBQUk9QX1RJVExFOgorICAgICAgICBnX3ZhbHVlX3NldF9zdHJpbmcodmFs
dWUsIHdlYmtpdF93ZWJfdmlld19nZXRfdGl0bGUod2ViVmlldykpOworICAgICAgICBicmVhazsK
KyAgICBjYXNlIFBST1BfVVJJOgorICAgICAgICBnX3ZhbHVlX3NldF9zdHJpbmcodmFsdWUsIHdl
YmtpdF93ZWJfdmlld19nZXRfdXJpKHdlYlZpZXcpKTsKKyAgICAgICAgYnJlYWs7CiAjaWYgR1RL
X0NIRUNLX1ZFUlNJT04oMiwxMCwwKQogICAgIGNhc2UgUFJPUF9DT1BZX1RBUkdFVF9MSVNUOgog
ICAgICAgICBnX3ZhbHVlX3NldF9ib3hlZCh2YWx1ZSwgd2Via2l0X3dlYl92aWV3X2dldF9jb3B5
X3RhcmdldF9saXN0KHdlYlZpZXcpKTsKQEAgLTExNTAsNiArMTE1OCw4IEBAIHN0YXRpYyB2b2lk
IHdlYmtpdF93ZWJfdmlld19jbGFzc19pbml0KFdlYktpdFdlYlZpZXdDbGFzcyogd2ViVmlld0Ns
YXNzKQogICAgICAqIEB0aXRsZTogdGhlIG5ldyB0aXRsZQogICAgICAqCiAgICAgICogV2hlbiBh
ICNXZWJLaXRXZWJGcmFtZSBjaGFuZ2VzIHRoZSBkb2N1bWVudCB0aXRsZSB0aGlzIHNpZ25hbCBp
cyBlbWl0dGVkLgorICAgICAqCisgICAgICogRGVwcmVjYXRlZDogMS4xLjE6IFVzZSAibm90aWZ5
Ojp0aXRsZSIgaW5zdGVhZC4KICAgICAgKi8KICAgICB3ZWJraXRfd2ViX3ZpZXdfc2lnbmFsc1tU
SVRMRV9DSEFOR0VEXSA9IGdfc2lnbmFsX25ldygidGl0bGUtY2hhbmdlZCIsCiAgICAgICAgICAg
ICBHX1RZUEVfRlJPTV9DTEFTUyh3ZWJWaWV3Q2xhc3MpLApAQCAtMTQ2MCw2ICsxNDcwLDM0IEBA
IHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld19jbGFzc19pbml0KFdlYktpdFdlYlZpZXdDbGFz
cyogd2ViVmlld0NsYXNzKQogICAgICAqIHByb3BlcnRpZXMKICAgICAgKi8KIAorICAgIC8qKgor
ICAgICogV2ViS2l0V2ViVmlldzp0aXRsZToKKyAgICAqCisgICAgKiBSZXR1cm5zIHRoZSBAd2Vi
X3ZpZXcncyBkb2N1bWVudCB0aXRsZS4KKyAgICAqCisgICAgKiBTaW5jZTogMS4xLjEKKyAgICAq
LworICAgIGdfb2JqZWN0X2NsYXNzX2luc3RhbGxfcHJvcGVydHkob2JqZWN0Q2xhc3MsIFBST1Bf
VElUTEUsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnX3BhcmFtX3NwZWNf
c3RyaW5nKCJ0aXRsZSIsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICJUaXRsZSIsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICJSZXR1cm5zIHRoZSBAd2ViX3ZpZXcncyBkb2N1bWVu
dCB0aXRsZSIsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIE5VTEwsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIFdFQktJVF9QQVJBTV9SRUFEQUJMRSkpOworCisgICAgLyoqCisgICAg
KiBXZWJLaXRXZWJWaWV3OnVyaToKKyAgICAqCisgICAgKiBSZXR1cm5zIHRoZSBjdXJyZW50IFVS
SSBvZiB0aGUgY29udGVudHMgZGlzcGxheWVkIGJ5IHRoZSBAd2ViX3ZpZXcuCisgICAgKgorICAg
ICogU2luY2U6IDEuMS4xCisgICAgKi8KKyAgICBnX29iamVjdF9jbGFzc19pbnN0YWxsX3Byb3Bl
cnR5KG9iamVjdENsYXNzLCBQUk9QX1VSSSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIGdfcGFyYW1fc3BlY19zdHJpbmcoInVyaSIsCisgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJVUkkiLAorICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiUmV0dXJucyB0aGUgY3Vy
cmVudCBVUkkgb2YgdGhlIGNvbnRlbnRzIGRpc3BsYXllZCBieSB0aGUgQHdlYl92aWV3IiwKKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgTlVM
TCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgV0VCS0lUX1BBUkFNX1JFQURBQkxFKSk7CisKICNpZiBHVEtfQ0hFQ0tfVkVSU0lPTigyLDEw
LDApCiAgICAgLyoqCiAgICAgKiBXZWJLaXRXZWJWaWV3OmNvcHktdGFyZ2V0LWxpc3Q6CkBAIC0x
ODg5LDYgKzE5MjcsNDIgQEAgV2ViS2l0V2ViV2luZG93RmVhdHVyZXMqIHdlYmtpdF93ZWJfdmll
d19nZXRfd2luZG93X2ZlYXR1cmVzKFdlYktpdFdlYlZpZXcqIHdlYlYKIH0KIAogLyoqCisgKiB3
ZWJraXRfd2ViX3ZpZXdfZ2V0X3RpdGxlOgorICogQHdlYl92aWV3OiBhICNXZWJLaXRXZWJWaWV3
CisgKgorICogUmV0dXJucyB0aGUgQHdlYl92aWV3J3MgZG9jdW1lbnQgdGl0bGUKKyAqCisgKiBT
aW5jZTogMS4xLjEKKyAqCisgKiBSZXR1cm4gdmFsdWU6IHRoZSB0aXRsZSBvZiBAd2ViX3ZpZXcK
KyAqLworR19DT05TVF9SRVRVUk4gZ2NoYXIqIHdlYmtpdF93ZWJfdmlld19nZXRfdGl0bGUoV2Vi
S2l0V2ViVmlldyogd2ViVmlldykKK3sKKyAgICBnX3JldHVybl92YWxfaWZfZmFpbChXRUJLSVRf
SVNfV0VCX1ZJRVcod2ViVmlldyksIE5VTEwpOworCisgICAgV2ViS2l0V2ViVmlld1ByaXZhdGUq
IHByaXYgPSB3ZWJWaWV3LT5wcml2OworICAgIHJldHVybiBwcml2LT5tYWluRnJhbWUtPnByaXYt
PnRpdGxlOworfQorCisvKioKKyAqIHdlYmtpdF93ZWJfdmlld19nZXRfdXJpOgorICogQHdlYl92
aWV3OiBhICNXZWJLaXRXZWJWaWV3CisgKgorICogUmV0dXJucyB0aGUgY3VycmVudCBVUkkgb2Yg
dGhlIGNvbnRlbnRzIGRpc3BsYXllZCBieSB0aGUgQHdlYl92aWV3CisgKgorICogU2luY2U6IDEu
MS4xCisgKgorICogUmV0dXJuIHZhbHVlOiB0aGUgVVJJIG9mIEB3ZWJfdmlldworICovCitHX0NP
TlNUX1JFVFVSTiBnY2hhciogd2Via2l0X3dlYl92aWV3X2dldF91cmkoV2ViS2l0V2ViVmlldyog
d2ViVmlldykKK3sKKyAgICBnX3JldHVybl92YWxfaWZfZmFpbChXRUJLSVRfSVNfV0VCX1ZJRVco
d2ViVmlldyksIE5VTEwpOworCisgICAgV2ViS2l0V2ViVmlld1ByaXZhdGUqIHByaXYgPSB3ZWJW
aWV3LT5wcml2OworICAgIHJldHVybiBwcml2LT5tYWluRnJhbWUtPnByaXYtPnVyaTsKK30KKwor
LyoqCiAgKiB3ZWJraXRfd2ViX3ZpZXdfc2V0X21haW50YWluc19iYWNrX2ZvcndhcmRfbGlzdDoK
ICAqIEB3ZWJfdmlldzogYSAjV2ViS2l0V2ViVmlldwogICogQGZsYWc6IHRvIHRlbGwgdGhlIHZp
ZXcgdG8gbWFpbnRhaW4gYSBiYWNrIG9yIGZvcndhcmQgbGlzdApkaWZmIC0tZ2l0IGEvV2ViS2l0
L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5oIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vi
dmlldy5oCmluZGV4IDJiYjhjNjEuLjI0YTAxNWQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvd2Vi
a2l0L3dlYmtpdHdlYnZpZXcuaAorKysgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3
LmgKQEAgLTEyNiw2ICsxMjYsMTIgQEAgd2Via2l0X3dlYl92aWV3X2dldF90eXBlICh2b2lkKTsK
IFdFQktJVF9BUEkgR3RrV2lkZ2V0ICoKIHdlYmtpdF93ZWJfdmlld19uZXcgKHZvaWQpOwogCitX
RUJLSVRfQVBJIEdfQ09OU1RfUkVUVVJOIGdjaGFyICoKK3dlYmtpdF93ZWJfdmlld19nZXRfdGl0
bGUgICAgICAgICAgICAgICAgICAgICAgIChXZWJLaXRXZWJWaWV3ICAgICAgICAqd2ViX3ZpZXcp
OworCitXRUJLSVRfQVBJIEdfQ09OU1RfUkVUVVJOIGdjaGFyICoKK3dlYmtpdF93ZWJfdmlld19n
ZXRfdXJpICAgICAgICAgICAgICAgICAgICAgICAgIChXZWJLaXRXZWJWaWV3ICAgICAgICAqd2Vi
X3ZpZXcpOworCiBXRUJLSVRfQVBJIHZvaWQKIHdlYmtpdF93ZWJfdmlld19zZXRfbWFpbnRhaW5z
X2JhY2tfZm9yd2FyZF9saXN0IChXZWJLaXRXZWJWaWV3ICAgICAgICAqd2ViX3ZpZXcsCiAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ2Jvb2xlYW4gICAg
ICAgICAgICAgIGZsYWcpOwpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvR3RrTGF1bmNoZXIvbWFp
bi5jIGIvV2ViS2l0VG9vbHMvR3RrTGF1bmNoZXIvbWFpbi5jCmluZGV4IDhlZDI2OTAuLjU5ZjIy
MzAgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0d0a0xhdW5jaGVyL21haW4uYworKysgYi9XZWJL
aXRUb29scy9HdGtMYXVuY2hlci9tYWluLmMKQEAgLTE4Myw2ICsxODMsOCBAQCBpbnQKIG1haW4g
KGludCBhcmdjLCBjaGFyKiBhcmd2W10pCiB7CiAgICAgZ3RrX2luaXQgKCZhcmdjLCAmYXJndik7
CisgICAgaWYgKCFnX3RocmVhZF9zdXBwb3J0ZWQgKCkpCisgICAgICAgIGdfdGhyZWFkX2luaXQg
KE5VTEwpOwogCiAgICAgR3RrV2lkZ2V0KiB2Ym94ID0gZ3RrX3Zib3hfbmV3IChGQUxTRSwgMCk7
CiAgICAgZ3RrX2JveF9wYWNrX3N0YXJ0IChHVEtfQk9YICh2Ym94KSwgY3JlYXRlX3Rvb2xiYXIg
KCksIEZBTFNFLCBGQUxTRSwgMCk7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>28553</attachid>
            <date>2009-03-12 13:59:45 -0700</date>
            <delta_ts>2009-03-16 10:54:39 -0700</delta_ts>
            <desc>Implement title and uri on the view #3</desc>
            <filename>p.diff</filename>
            <type>text/plain</type>
            <size>7541</size>
            <attacher name="Christian Dywan">christian</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRH
dGsuY3BwIGIvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEd0ay5j
cHAKaW5kZXggMmFiMzA1Ni4uOTYyZTcyOSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9XZWJDb3Jl
U3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEd0ay5jcHAKKysrIGIvV2ViS2l0L2d0ay9XZWJDb3Jl
U3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEd0ay5jcHAKQEAgLTU5OSw3ICs1OTksMTAgQEAgdm9p
ZCBGcmFtZUxvYWRlckNsaWVudDo6ZGlzcGF0Y2hXaWxsUGVyZm9ybUNsaWVudFJlZGlyZWN0KGNv
bnN0IEtVUkwmLCBkb3VibGUsIGQKIAogdm9pZCBGcmFtZUxvYWRlckNsaWVudDo6ZGlzcGF0Y2hE
aWRDaGFuZ2VMb2NhdGlvbldpdGhpblBhZ2UoKQogewotICAgIG5vdEltcGxlbWVudGVkKCk7Cisg
ICAgV2ViS2l0V2ViRnJhbWVQcml2YXRlKiBwcml2ID0gbV9mcmFtZS0+cHJpdjsKKyAgICBnX2Zy
ZWUocHJpdi0+dXJpKTsKKyAgICBwcml2LT51cmkgPSBnX3N0cmR1cChjb3JlKG1fZnJhbWUpLT5s
b2FkZXIoKS0+dXJsKCkucHJldHR5VVJMKCkudXRmOCgpLmRhdGEoKSk7CisgICAgZ19vYmplY3Rf
bm90aWZ5KEdfT0JKRUNUKG1fZnJhbWUpLCAidXJpIik7CiB9CiAKIHZvaWQgRnJhbWVMb2FkZXJD
bGllbnQ6OmRpc3BhdGNoV2lsbENsb3NlKCkKQEAgLTYyMCwxMSArNjIzLDE4IEBAIHZvaWQgRnJh
bWVMb2FkZXJDbGllbnQ6OmRpc3BhdGNoRGlkU3RhcnRQcm92aXNpb25hbExvYWQoKQogCiB2b2lk
IEZyYW1lTG9hZGVyQ2xpZW50OjpkaXNwYXRjaERpZFJlY2VpdmVUaXRsZShjb25zdCBTdHJpbmcm
IHRpdGxlKQogewotICAgIGdfc2lnbmFsX2VtaXRfYnlfbmFtZShtX2ZyYW1lLCAidGl0bGUtY2hh
bmdlZCIsIHRpdGxlLnV0ZjgoKS5kYXRhKCkpOworICAgIFdlYktpdFdlYkZyYW1lUHJpdmF0ZSog
cHJpdiA9IG1fZnJhbWUtPnByaXY7CisgICAgZ19mcmVlKHByaXYtPnRpdGxlKTsKKyAgICBwcml2
LT50aXRsZSA9IGdfc3RyZHVwKHRpdGxlLnV0ZjgoKS5kYXRhKCkpOworCisgICAgZ19zaWduYWxf
ZW1pdF9ieV9uYW1lKG1fZnJhbWUsICJ0aXRsZS1jaGFuZ2VkIiwgcHJpdi0+dGl0bGUpOworICAg
IGdfb2JqZWN0X25vdGlmeShHX09CSkVDVChtX2ZyYW1lKSwgInRpdGxlIik7CiAKICAgICBXZWJL
aXRXZWJWaWV3KiB3ZWJWaWV3ID0gZ2V0Vmlld0Zyb21GcmFtZShtX2ZyYW1lKTsKLSAgICBpZiAo
bV9mcmFtZSA9PSB3ZWJraXRfd2ViX3ZpZXdfZ2V0X21haW5fZnJhbWUod2ViVmlldykpCisgICAg
aWYgKG1fZnJhbWUgPT0gd2Via2l0X3dlYl92aWV3X2dldF9tYWluX2ZyYW1lKHdlYlZpZXcpKSB7
CiAgICAgICAgIGdfc2lnbmFsX2VtaXRfYnlfbmFtZSh3ZWJWaWV3LCAidGl0bGUtY2hhbmdlZCIs
IG1fZnJhbWUsIHRpdGxlLnV0ZjgoKS5kYXRhKCkpOworICAgICAgICBnX29iamVjdF9ub3RpZnko
R19PQkpFQ1Qod2ViVmlldyksICJ0aXRsZSIpOworICAgIH0KIH0KIAogdm9pZCBGcmFtZUxvYWRl
ckNsaWVudDo6ZGlzcGF0Y2hEaWRDb21taXRMb2FkKCkKQEAgLTYzMiwxNSArNjQyLDI4IEBAIHZv
aWQgRnJhbWVMb2FkZXJDbGllbnQ6OmRpc3BhdGNoRGlkQ29tbWl0TG9hZCgpCiAgICAgLyogVXBk
YXRlIHRoZSBVUkkgb25jZSBmaXJzdCBkYXRhIGhhcyBiZWVuIHJlY2VpdmVkLgogICAgICAqIFRo
aXMgbWVhbnMgdGhlIFVSSSBpcyB2YWxpZCBhbmQgc3VjY2Vzc2Z1bGx5IGlkZW50aWZ5IHRoZSBw
YWdlIHRoYXQncyBnb2luZyB0byBiZSBsb2FkZWQuCiAgICAgICovCi0gICAgV2ViS2l0V2ViRnJh
bWVQcml2YXRlKiBmcmFtZURhdGEgPSBXRUJLSVRfV0VCX0ZSQU1FX0dFVF9QUklWQVRFKG1fZnJh
bWUpOwotICAgIGdfZnJlZShmcmFtZURhdGEtPnVyaSk7Ci0gICAgZnJhbWVEYXRhLT51cmkgPSBn
X3N0cmR1cChjb3JlKG1fZnJhbWUpLT5sb2FkZXIoKS0+dXJsKCkucHJldHR5VVJMKCkudXRmOCgp
LmRhdGEoKSk7CisgICAgZ19vYmplY3RfZnJlZXplX25vdGlmeShHX09CSkVDVChtX2ZyYW1lKSk7
CisKKyAgICBXZWJLaXRXZWJGcmFtZVByaXZhdGUqIHByaXYgPSBtX2ZyYW1lLT5wcml2OworICAg
IGdfZnJlZShwcml2LT51cmkpOworICAgIHByaXYtPnVyaSA9IGdfc3RyZHVwKGNvcmUobV9mcmFt
ZSktPmxvYWRlcigpLT51cmwoKS5wcmV0dHlVUkwoKS51dGY4KCkuZGF0YSgpKTsKKyAgICBnX2Zy
ZWUocHJpdi0+dGl0bGUpOworICAgIHByaXYtPnRpdGxlID0gTlVMTDsKKyAgICBnX29iamVjdF9u
b3RpZnkoR19PQkpFQ1QobV9mcmFtZSksICJ1cmkiKTsKKyAgICBnX29iamVjdF9ub3RpZnkoR19P
QkpFQ1QobV9mcmFtZSksICJ0aXRsZSIpOwogCiAgICAgZ19zaWduYWxfZW1pdF9ieV9uYW1lKG1f
ZnJhbWUsICJsb2FkLWNvbW1pdHRlZCIpOwogCiAgICAgV2ViS2l0V2ViVmlldyogd2ViVmlldyA9
IGdldFZpZXdGcm9tRnJhbWUobV9mcmFtZSk7Ci0gICAgaWYgKG1fZnJhbWUgPT0gd2Via2l0X3dl
Yl92aWV3X2dldF9tYWluX2ZyYW1lKHdlYlZpZXcpKQorICAgIGlmIChtX2ZyYW1lID09IHdlYmtp
dF93ZWJfdmlld19nZXRfbWFpbl9mcmFtZSh3ZWJWaWV3KSkgeworICAgICAgICBnX29iamVjdF9m
cmVlemVfbm90aWZ5KEdfT0JKRUNUKHdlYlZpZXcpKTsKKyAgICAgICAgZ19vYmplY3Rfbm90aWZ5
KEdfT0JKRUNUKHdlYlZpZXcpLCAidXJpIik7CisgICAgICAgIGdfb2JqZWN0X25vdGlmeShHX09C
SkVDVCh3ZWJWaWV3KSwgInRpdGxlIik7CisgICAgICAgIGdfb2JqZWN0X3RoYXdfbm90aWZ5KEdf
T0JKRUNUKHdlYlZpZXcpKTsKICAgICAgICAgZ19zaWduYWxfZW1pdF9ieV9uYW1lKHdlYlZpZXcs
ICJsb2FkLWNvbW1pdHRlZCIsIG1fZnJhbWUpOworICAgIH0KKworICAgIGdfb2JqZWN0X3RoYXdf
bm90aWZ5KEdfT0JKRUNUKG1fZnJhbWUpKTsKIH0KIAogdm9pZCBGcmFtZUxvYWRlckNsaWVudDo6
ZGlzcGF0Y2hEaWRGaW5pc2hEb2N1bWVudExvYWQoKQpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay93
ZWJraXQvd2Via2l0d2Vidmlldy5jcHAgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3
LmNwcAppbmRleCA0NjEzOGVjLi4wM2VmYzBlIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL3dlYmtp
dC93ZWJraXR3ZWJ2aWV3LmNwcAorKysgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3
LmNwcApAQCAtMTQyLDYgKzE0Miw4IEBAIGVudW0gewogZW51bSB7CiAgICAgUFJPUF8wLAogCisg
ICAgUFJPUF9USVRMRSwKKyAgICBQUk9QX1VSSSwKICAgICBQUk9QX0NPUFlfVEFSR0VUX0xJU1Qs
CiAgICAgUFJPUF9QQVNURV9UQVJHRVRfTElTVCwKICAgICBQUk9QX0VESVRBQkxFLApAQCAtMjgx
LDYgKzI4MywxMiBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfZ2V0X3Byb3BlcnR5KEdP
YmplY3QqIG9iamVjdCwgZ3VpbnQgcHJvcF9pZCwgR1ZhbHVlKgogICAgIFdlYktpdFdlYlZpZXcq
IHdlYlZpZXcgPSBXRUJLSVRfV0VCX1ZJRVcob2JqZWN0KTsKIAogICAgIHN3aXRjaChwcm9wX2lk
KSB7CisgICAgY2FzZSBQUk9QX1RJVExFOgorICAgICAgICBnX3ZhbHVlX3NldF9zdHJpbmcodmFs
dWUsIHdlYmtpdF93ZWJfdmlld19nZXRfdGl0bGUod2ViVmlldykpOworICAgICAgICBicmVhazsK
KyAgICBjYXNlIFBST1BfVVJJOgorICAgICAgICBnX3ZhbHVlX3NldF9zdHJpbmcodmFsdWUsIHdl
YmtpdF93ZWJfdmlld19nZXRfdXJpKHdlYlZpZXcpKTsKKyAgICAgICAgYnJlYWs7CiAjaWYgR1RL
X0NIRUNLX1ZFUlNJT04oMiwxMCwwKQogICAgIGNhc2UgUFJPUF9DT1BZX1RBUkdFVF9MSVNUOgog
ICAgICAgICBnX3ZhbHVlX3NldF9ib3hlZCh2YWx1ZSwgd2Via2l0X3dlYl92aWV3X2dldF9jb3B5
X3RhcmdldF9saXN0KHdlYlZpZXcpKTsKQEAgLTEyMjUsNiArMTIzMyw4IEBAIHN0YXRpYyB2b2lk
IHdlYmtpdF93ZWJfdmlld19jbGFzc19pbml0KFdlYktpdFdlYlZpZXdDbGFzcyogd2ViVmlld0Ns
YXNzKQogICAgICAqIEB0aXRsZTogdGhlIG5ldyB0aXRsZQogICAgICAqCiAgICAgICogV2hlbiBh
ICNXZWJLaXRXZWJGcmFtZSBjaGFuZ2VzIHRoZSBkb2N1bWVudCB0aXRsZSB0aGlzIHNpZ25hbCBp
cyBlbWl0dGVkLgorICAgICAqCisgICAgICogRGVwcmVjYXRlZDogMS4xLjI6IFVzZSAibm90aWZ5
Ojp0aXRsZSIgaW5zdGVhZC4KICAgICAgKi8KICAgICB3ZWJraXRfd2ViX3ZpZXdfc2lnbmFsc1tU
SVRMRV9DSEFOR0VEXSA9IGdfc2lnbmFsX25ldygidGl0bGUtY2hhbmdlZCIsCiAgICAgICAgICAg
ICBHX1RZUEVfRlJPTV9DTEFTUyh3ZWJWaWV3Q2xhc3MpLApAQCAtMTUzNiw2ICsxNTQ2LDM0IEBA
IHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld19jbGFzc19pbml0KFdlYktpdFdlYlZpZXdDbGFz
cyogd2ViVmlld0NsYXNzKQogICAgICAqIHByb3BlcnRpZXMKICAgICAgKi8KIAorICAgIC8qKgor
ICAgICogV2ViS2l0V2ViVmlldzp0aXRsZToKKyAgICAqCisgICAgKiBSZXR1cm5zIHRoZSBAd2Vi
X3ZpZXcncyBkb2N1bWVudCB0aXRsZS4KKyAgICAqCisgICAgKiBTaW5jZTogMS4xLjIKKyAgICAq
LworICAgIGdfb2JqZWN0X2NsYXNzX2luc3RhbGxfcHJvcGVydHkob2JqZWN0Q2xhc3MsIFBST1Bf
VElUTEUsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnX3BhcmFtX3NwZWNf
c3RyaW5nKCJ0aXRsZSIsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICJUaXRsZSIsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICJSZXR1cm5zIHRoZSBAd2ViX3ZpZXcncyBkb2N1bWVu
dCB0aXRsZSIsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIE5VTEwsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIFdFQktJVF9QQVJBTV9SRUFEQUJMRSkpOworCisgICAgLyoqCisgICAg
KiBXZWJLaXRXZWJWaWV3OnVyaToKKyAgICAqCisgICAgKiBSZXR1cm5zIHRoZSBjdXJyZW50IFVS
SSBvZiB0aGUgY29udGVudHMgZGlzcGxheWVkIGJ5IHRoZSBAd2ViX3ZpZXcuCisgICAgKgorICAg
ICogU2luY2U6IDEuMS4yCisgICAgKi8KKyAgICBnX29iamVjdF9jbGFzc19pbnN0YWxsX3Byb3Bl
cnR5KG9iamVjdENsYXNzLCBQUk9QX1VSSSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIGdfcGFyYW1fc3BlY19zdHJpbmcoInVyaSIsCisgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJVUkkiLAorICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiUmV0dXJucyB0aGUgY3Vy
cmVudCBVUkkgb2YgdGhlIGNvbnRlbnRzIGRpc3BsYXllZCBieSB0aGUgQHdlYl92aWV3IiwKKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgTlVM
TCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgV0VCS0lUX1BBUkFNX1JFQURBQkxFKSk7CisKICNpZiBHVEtfQ0hFQ0tfVkVSU0lPTigyLDEw
LDApCiAgICAgLyoqCiAgICAgKiBXZWJLaXRXZWJWaWV3OmNvcHktdGFyZ2V0LWxpc3Q6CkBAIC0x
OTkyLDYgKzIwMzAsNDIgQEAgV2ViS2l0V2ViV2luZG93RmVhdHVyZXMqIHdlYmtpdF93ZWJfdmll
d19nZXRfd2luZG93X2ZlYXR1cmVzKFdlYktpdFdlYlZpZXcqIHdlYlYKIH0KIAogLyoqCisgKiB3
ZWJraXRfd2ViX3ZpZXdfZ2V0X3RpdGxlOgorICogQHdlYl92aWV3OiBhICNXZWJLaXRXZWJWaWV3
CisgKgorICogUmV0dXJucyB0aGUgQHdlYl92aWV3J3MgZG9jdW1lbnQgdGl0bGUKKyAqCisgKiBT
aW5jZTogMS4xLjIKKyAqCisgKiBSZXR1cm4gdmFsdWU6IHRoZSB0aXRsZSBvZiBAd2ViX3ZpZXcK
KyAqLworR19DT05TVF9SRVRVUk4gZ2NoYXIqIHdlYmtpdF93ZWJfdmlld19nZXRfdGl0bGUoV2Vi
S2l0V2ViVmlldyogd2ViVmlldykKK3sKKyAgICBnX3JldHVybl92YWxfaWZfZmFpbChXRUJLSVRf
SVNfV0VCX1ZJRVcod2ViVmlldyksIE5VTEwpOworCisgICAgV2ViS2l0V2ViVmlld1ByaXZhdGUq
IHByaXYgPSB3ZWJWaWV3LT5wcml2OworICAgIHJldHVybiBwcml2LT5tYWluRnJhbWUtPnByaXYt
PnRpdGxlOworfQorCisvKioKKyAqIHdlYmtpdF93ZWJfdmlld19nZXRfdXJpOgorICogQHdlYl92
aWV3OiBhICNXZWJLaXRXZWJWaWV3CisgKgorICogUmV0dXJucyB0aGUgY3VycmVudCBVUkkgb2Yg
dGhlIGNvbnRlbnRzIGRpc3BsYXllZCBieSB0aGUgQHdlYl92aWV3CisgKgorICogU2luY2U6IDEu
MS4yCisgKgorICogUmV0dXJuIHZhbHVlOiB0aGUgVVJJIG9mIEB3ZWJfdmlldworICovCitHX0NP
TlNUX1JFVFVSTiBnY2hhciogd2Via2l0X3dlYl92aWV3X2dldF91cmkoV2ViS2l0V2ViVmlldyog
d2ViVmlldykKK3sKKyAgICBnX3JldHVybl92YWxfaWZfZmFpbChXRUJLSVRfSVNfV0VCX1ZJRVco
d2ViVmlldyksIE5VTEwpOworCisgICAgV2ViS2l0V2ViVmlld1ByaXZhdGUqIHByaXYgPSB3ZWJW
aWV3LT5wcml2OworICAgIHJldHVybiBwcml2LT5tYWluRnJhbWUtPnByaXYtPnVyaTsKK30KKwor
LyoqCiAgKiB3ZWJraXRfd2ViX3ZpZXdfc2V0X21haW50YWluc19iYWNrX2ZvcndhcmRfbGlzdDoK
ICAqIEB3ZWJfdmlldzogYSAjV2ViS2l0V2ViVmlldwogICogQGZsYWc6IHRvIHRlbGwgdGhlIHZp
ZXcgdG8gbWFpbnRhaW4gYSBiYWNrIG9yIGZvcndhcmQgbGlzdApkaWZmIC0tZ2l0IGEvV2ViS2l0
L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5oIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vi
dmlldy5oCmluZGV4IDU0M2M3NzcuLjE0NTVhNzkgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvd2Vi
a2l0L3dlYmtpdHdlYnZpZXcuaAorKysgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3
LmgKQEAgLTEyNyw2ICsxMjcsMTIgQEAgd2Via2l0X3dlYl92aWV3X2dldF90eXBlICh2b2lkKTsK
IFdFQktJVF9BUEkgR3RrV2lkZ2V0ICoKIHdlYmtpdF93ZWJfdmlld19uZXcgKHZvaWQpOwogCitX
RUJLSVRfQVBJIEdfQ09OU1RfUkVUVVJOIGdjaGFyICoKK3dlYmtpdF93ZWJfdmlld19nZXRfdGl0
bGUgICAgICAgICAgICAgICAgICAgICAgIChXZWJLaXRXZWJWaWV3ICAgICAgICAqd2ViX3ZpZXcp
OworCitXRUJLSVRfQVBJIEdfQ09OU1RfUkVUVVJOIGdjaGFyICoKK3dlYmtpdF93ZWJfdmlld19n
ZXRfdXJpICAgICAgICAgICAgICAgICAgICAgICAgIChXZWJLaXRXZWJWaWV3ICAgICAgICAqd2Vi
X3ZpZXcpOworCiBXRUJLSVRfQVBJIHZvaWQKIHdlYmtpdF93ZWJfdmlld19zZXRfbWFpbnRhaW5z
X2JhY2tfZm9yd2FyZF9saXN0IChXZWJLaXRXZWJWaWV3ICAgICAgICAqd2ViX3ZpZXcsCiAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ2Jvb2xlYW4gICAg
ICAgICAgICAgIGZsYWcpOwo=
</data>
<flag name="review"
          id="14038"
          type_id="1"
          status="+"
          setter="aroben"
    />
          </attachment>
      

    </bug>

</bugzilla>