148051 2015-08-14 21:12:14 -0700 [JSC] Use (x + x) instead of (x * 2) when possible 2015-08-16 01:14:18 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin oldest_to_newest 1117890 0 benjamin 2015-08-14 21:12:14 -0700 [JSC] Use (x + x) instead of (x * 2) when possible 1117891 1 259081 benjamin 2015-08-14 21:19:50 -0700 Created attachment 259081 Patch 1117892 2 benjamin 2015-08-14 21:22:32 -0700 Conf#1 Conf#2 Octane: encrypt 0.19307+-0.00492 ? 0.19479+-0.00376 ? decrypt 3.21916+-0.04500 3.19699+-0.01128 deltablue x2 0.15060+-0.00200 0.15000+-0.00160 earley 0.30010+-0.00440 ? 0.30328+-0.00512 ? might be 1.0106x slower boyer 4.32425+-0.03066 ? 4.34306+-0.03307 ? navier-stokes x2 4.78825+-0.01134 4.78168+-0.01166 raytrace x2 1.94752+-0.02467 ? 1.95658+-0.03069 ? richards x2 0.09647+-0.00091 0.09622+-0.00052 splay x2 0.39069+-0.00391 0.38897+-0.00442 regexp x2 24.17738+-0.39770 ^ 23.41245+-0.21825 ^ definitely 1.0327x faster pdfjs x2 36.87037+-0.66745 36.80840+-0.47628 mandreel x2 42.98668+-0.73428 42.98298+-0.51815 gbemu x2 31.88557+-0.87645 ? 31.99621+-0.76491 ? closure 0.53169+-0.00176 0.52997+-0.00224 jquery 6.72329+-0.01997 ? 6.74090+-0.03508 ? box2d x2 9.52269+-0.07903 9.50500+-0.06250 zlib x2 384.55828+-4.04459 375.41807+-13.65940 might be 1.0243x faster typescript x2 627.55078+-18.46505 ? 632.15210+-8.83752 ? <geometric> 5.75506+-0.02504 5.73647+-0.02634 might be 1.0032x faster Conf#1 Conf#2 Kraken: ai-astar 222.032+-4.782 219.290+-5.384 might be 1.0125x faster audio-beat-detection 48.832+-0.176 ? 48.878+-0.185 ? audio-dft 89.394+-0.315 89.356+-0.374 audio-fft 33.654+-0.074 ? 33.838+-0.291 ? audio-oscillator 59.131+-0.377 59.045+-0.250 imaging-darkroom 57.616+-0.632 ? 57.961+-0.656 ? imaging-desaturate 52.292+-0.089 50.536+-2.017 might be 1.0348x faster imaging-gaussian-blur 79.488+-0.643 ? 79.663+-0.600 ? json-parse-financial 36.272+-0.226 ? 36.611+-0.296 ? json-stringify-tinderbox 23.461+-0.201 ^ 21.537+-0.569 ^ definitely 1.0893x faster stanford-crypto-aes 40.015+-0.246 ? 40.280+-0.607 ? stanford-crypto-ccm 32.646+-1.058 ? 32.968+-0.836 ? stanford-crypto-pbkdf2 90.473+-0.399 90.407+-0.272 stanford-crypto-sha256-iterative 35.099+-0.394 34.811+-0.290 <arithmetic> 64.315+-0.376 63.941+-0.365 might be 1.0058x faster Conf#1 Conf#2 Geomean of preferred means: <scaled-result> 19.2387+-0.0758 19.1517+-0.0592 might be 1.0045x faster 1117905 3 259081 saam 2015-08-14 23:17:20 -0700 Comment on attachment 259081 Patch r=me 1117943 4 259081 msaboff 2015-08-15 08:49:02 -0700 Comment on attachment 259081 Patch r=me 1118021 5 259081 benjamin 2015-08-16 01:14:13 -0700 Comment on attachment 259081 Patch Clearing flags on attachment: 259081 Committed r188519: <http://trac.webkit.org/changeset/188519> 1118022 6 benjamin 2015-08-16 01:14:18 -0700 All reviewed patches have been landed. Closing bug. 259081 2015-08-14 21:19:50 -0700 2015-08-16 01:14:13 -0700 Patch bug-148051-20150814211930.patch text/plain 6659 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4NDg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 YTgwNjZjYzhiYjkyNDQzMmY1MDdjYzE2Yjk4YTg2MTlkNzEzMzAyLi45ZGY2MmRkYWVlNjIzMjRl YmJlY2I2ZjBhNjYwYzc0YzI4YWUzODZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSw1MCBAQAogMjAxNS0wOC0xNCAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KIAorICAgICAgICBbSlNDXSBVc2UgKHggKyB4KSBpbnN0ZWFkIG9mICh4ICogMikgd2hl biBwb3NzaWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTQ4MDUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgV2hlbiBtdWx0aXBseWluZyBhIG51bWJlciBieSAyLCBKU0Mgd2FzIGxvYWRpbmcgYSBjb25z dGFudCAiMiIKKyAgICAgICAgaW4gcmVnaXN0ZXIgYW5kIG11bHRpcGx5aW5nIGl0IHdpdGggdGhl IGZpcnN0IG51bWJlcjoKKworICAgICAgICAgICAgbW92ICQweDQwMDAwMDAwMDAwMDAwMDAsICVy Y3gKKyAgICAgICAgICAgIG1vdmQgJXJjeCwgJXhtbTAKKyAgICAgICAgICAgIG11bHNkICV4bW0w LCAleG1tMQorCisgICAgICAgIFRoaXMgaXMgYSBwcm9ibGVtIGZvciBhIGZldyByZWFzb25zLgor ICAgICAgICAxKSAibW92ZCAlcmN4LCAleG1tMCIgb25seSBzZXQgaGFsZiBvZiBYTU0wLiBUaGlz IGluc3RydWN0aW9uCisgICAgICAgICAgIGhhcyB0byB3YWl0IGZvciBhbnkgcHJlY2VkaW5nIGlu c3RydWN0aW9uIG9uIFhNTTAgdG8gZmluaXNoCisgICAgICAgICAgIGJlZm9yZSBleGVjdXRpbmcu CisgICAgICAgIDIpIFRoZSBsb2FkIGFuZCB0cmFuc2Zvcm0gaXRzZWxmIGlzIGxhcmdlIGFuZCB1 bmVjZXNzYXJ5LgorCisgICAgICAgIFRvIGZpeCB0aGF0LCBJIGFkZGVkIGEgU3RyZW5ndGhSZWR1 Y3Rpb25QaGFzZSB0byB0cmFuc2Zvcm0KKyAgICAgICAgbXVsdGlwbGljYXRpb25zIGJ5IDIgaW50 byBhIGFkZGl0aW9uLgorCisgICAgICAgIFVuZm9ydHVuYXRlbHksIHRoYXQgdHVybmVkIHRoZSBj b2RlIGludG86CisgICAgICAgICAgICBtb3ZzZCAleG1tMCAleG1tMQorICAgICAgICAgICAgbXVs c2QgJXhtbTEgJXhtbTAKKworICAgICAgICBUaGUgcmVhc29uIGlzIEdlbmVyYXRpb25JbmZvOjpj YW5SZXVzZSgpIHdhcyBub3QgYWNjb3VudGluZworICAgICAgICBmb3Igbm9kZXMgdXNpbmcgb3Ro ZXIgbm9kZXMgbXVsdGlwbGUgdGltZXMuCisKKyAgICAgICAgQWZ0ZXIgZml4aW5nIHRoYXQgdG9v LCB3ZSBub3cgaGF2ZSB0aGUgbXVsdGlwbGljYXRpb25zIGJ5IDIKKyAgICAgICAgZG9uZSBhczoK KyAgICAgICAgICAgIGFkZHNkICV4bW0wICV4bW0wCisKKyAgICAgICAgKiBkZmcvREZHR2VuZXJh dGlvbkluZm8uaDoKKyAgICAgICAgKEpTQzo6REZHOjpHZW5lcmF0aW9uSW5mbzo6dXNlQ291bnQp OgorICAgICAgICAoSlNDOjpERkc6OkdlbmVyYXRpb25JbmZvOjpjYW5SZXVzZSk6IERlbGV0ZWQu CisgICAgICAgICogZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcDoKKyAgICAgICAgKEpTQzo6REZH OjpGUFJUZW1wb3Jhcnk6OkZQUlRlbXBvcmFyeSk6CisgICAgICAgICogZGZnL0RGR1NwZWN1bGF0 aXZlSklULmg6CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmNhblJldXNlKToK KyAgICAgICAgKEpTQzo6REZHOjpHUFJUZW1wb3Jhcnk6OkdQUlRlbXBvcmFyeSk6CisgICAgICAg ICogZGZnL0RGR1N0cmVuZ3RoUmVkdWN0aW9uUGhhc2UuY3BwOgorICAgICAgICAoSlNDOjpERkc6 OlN0cmVuZ3RoUmVkdWN0aW9uUGhhc2U6OmhhbmRsZU5vZGUpOgorCisyMDE1LTA4LTE0ICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCiAgICAgICAgIFtKU0NdIEF2b2lk IGdvaW5nIHRvIHNsb3cgcGF0aCB3aGVuIGNvbXBhcmluZyB1bmRlZmluZWQgYW5kIG51bGwKICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODA0NQogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0dlbmVyYXRpb25JbmZvLmgg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0dlbmVyYXRpb25JbmZvLmgKaW5kZXggYjMw ZjM1MDhkNzJkZWE3YWU0OWU3YjlhODJhMjU0YjIzMmQ4MjBhZC4uNjM5MGNkYWY0ODk5MTA3YmFk MTI2ZWZkZGYxZjk3MjYyMTZjMmU1YSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2RmZy9ERkdHZW5lcmF0aW9uSW5mby5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHR2VuZXJhdGlvbkluZm8uaApAQCAtMTg5LDEwICsxODksMTAgQEAgcHVibGljOgogICAgIC8v IFVzZWQgdG8gY2hlY2sgdGhlIG9wZXJhbmRzIG9mIG9wZXJhdGlvbnMgdG8gc2VlIGlmIHRoZXkg YXJlIG9uCiAgICAgLy8gdGhlaXIgbGFzdCB1c2U7IGluIHNvbWUgY2FzZXMgaXQgbWF5IGJlIHNh ZmUgdG8gcmV1c2UgdGhlIHNhbWUKICAgICAvLyBtYWNoaW5lIHJlZ2lzdGVyIGZvciB0aGUgcmVz dWx0IG9mIHRoZSBvcGVyYXRpb24uCi0gICAgYm9vbCBjYW5SZXVzZSgpCisgICAgdWludDMyX3Qg dXNlQ291bnQoKQogICAgIHsKICAgICAgICAgQVNTRVJUKG1fdXNlQ291bnQpOwotICAgICAgICBy ZXR1cm4gbV91c2VDb3VudCA9PSAxOworICAgICAgICByZXR1cm4gbV91c2VDb3VudDsKICAgICB9 CiAKICAgICAvLyBHZXQgdGhlIGZvcm1hdCBvZiB0aGUgdmFsdWUgaW4gbWFjaGluZSByZWdpc3Rl cnMgKG9yICdub25lJykuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RG R1NwZWN1bGF0aXZlSklULmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3Vs YXRpdmVKSVQuY3BwCmluZGV4IDQ4NGJmOGQ1MDA2ODg4ODE3Nzk5NWRkMmIxYWM5NzI0NTFmZGJm NDguLmY1NzkxZGI0NTAzYzc4ODg0OWQzNTc2YzhhOThjNzQ5NzYzYWY4NzUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCkBAIC0xMTg2LDYg KzExODYsOCBAQCBGUFJUZW1wb3Jhcnk6OkZQUlRlbXBvcmFyeShTcGVjdWxhdGl2ZUpJVCogaml0 LCBTcGVjdWxhdGVEb3VibGVPcGVyYW5kJiBvcDEsIFNwZQogICAgICAgICBtX2ZwciA9IG1faml0 LT5yZXVzZShvcDEuZnByKCkpOwogICAgIGVsc2UgaWYgKG1faml0LT5jYW5SZXVzZShvcDIubm9k ZSgpKSkKICAgICAgICAgbV9mcHIgPSBtX2ppdC0+cmV1c2Uob3AyLmZwcigpKTsKKyAgICBlbHNl IGlmIChtX2ppdC0+Y2FuUmV1c2Uob3AxLm5vZGUoKSwgb3AyLm5vZGUoKSkgJiYgb3AxLmZwcigp ID09IG9wMi5mcHIoKSkKKyAgICAgICAgbV9mcHIgPSBtX2ppdC0+cmV1c2Uob3AxLmZwcigpKTsK ICAgICBlbHNlCiAgICAgICAgIG1fZnByID0gbV9qaXQtPmZwckFsbG9jYXRlKCk7CiB9CmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmggYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmgKaW5kZXggNTQ1ZmYy YTZlYmQxMGVlZjgyYjFmZTdjMjJjY2U5ZjcxN2VkZDE0YS4uY2EwNzk5MjY2ZGE1MjAzNDM3YTNh NDk2MzNkYWIwNGQzMDY5NmI4NCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Rm Zy9ERkdTcGVjdWxhdGl2ZUpJVC5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH U3BlY3VsYXRpdmVKSVQuaApAQCAtMTYyLDcgKzE2MiwxMSBAQCBwdWJsaWM6CiAgICAgLy8gYW5k IGl0cyBtYWNoaW5lIHJlZ2lzdGVycyBtYXkgYmUgcmV1c2VkLgogICAgIGJvb2wgY2FuUmV1c2Uo Tm9kZSogbm9kZSkKICAgICB7Ci0gICAgICAgIHJldHVybiBnZW5lcmF0aW9uSW5mbyhub2RlKS5j YW5SZXVzZSgpOworICAgICAgICByZXR1cm4gZ2VuZXJhdGlvbkluZm8obm9kZSkudXNlQ291bnQo KSA9PSAxOworICAgIH0KKyAgICBib29sIGNhblJldXNlKE5vZGUqIG5vZGVBLCBOb2RlKiBub2Rl QikKKyAgICB7CisgICAgICAgIHJldHVybiBub2RlQSA9PSBub2RlQiAmJiBnZW5lcmF0aW9uSW5m byhub2RlQSkudXNlQ291bnQoKSA9PSAyOwogICAgIH0KICAgICBib29sIGNhblJldXNlKEVkZ2Ug bm9kZVVzZSkKICAgICB7CkBAIC0yNzE3LDYgKzI3MjEsOCBAQCBwdWJsaWM6CiAgICAgICAgICAg ICBtX2dwciA9IG1faml0LT5yZXVzZShvcDEuZ3ByKCkpOwogICAgICAgICBlbHNlIGlmIChtX2pp dC0+Y2FuUmV1c2Uob3AyLm5vZGUoKSkpCiAgICAgICAgICAgICBtX2dwciA9IG1faml0LT5yZXVz ZShvcDIuZ3ByKCkpOworICAgICAgICBlbHNlIGlmIChtX2ppdC0+Y2FuUmV1c2Uob3AxLm5vZGUo KSwgb3AyLm5vZGUoKSkgJiYgb3AxLmdwcigpID09IG9wMi5ncHIoKSkKKyAgICAgICAgICAgIG1f Z3ByID0gbV9qaXQtPnJldXNlKG9wMS5ncHIoKSk7CiAgICAgICAgIGVsc2UKICAgICAgICAgICAg IG1fZ3ByID0gbV9qaXQtPmFsbG9jYXRlKCk7CiAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdTdHJlbmd0aFJlZHVjdGlvblBoYXNlLmNwcCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9kZmcvREZHU3RyZW5ndGhSZWR1Y3Rpb25QaGFzZS5jcHAKaW5kZXggMDM1 MTVkNTJhZjUyODVlYTNkMmZjZWVjZTI5NzY3ZjAyN2JlMmJmYi4uMjEzMGI2MDI5ZGExZjM3NDMx NzVhZGJhZThlMmJjNmRlNDE2ZmU1MyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2RmZy9ERkdTdHJlbmd0aFJlZHVjdGlvblBoYXNlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvZGZnL0RGR1N0cmVuZ3RoUmVkdWN0aW9uUGhhc2UuY3BwCkBAIC0xMTQsMTAgKzExNCwz NiBAQCBwcml2YXRlOgogICAgICAgICAgICAgfQogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAg ICAgICAKLSAgICAgICAgY2FzZSBBcml0aE11bDoKKyAgICAgICAgY2FzZSBBcml0aE11bDogewog ICAgICAgICAgICAgaGFuZGxlQ29tbXV0YXRpdml0eSgpOworICAgICAgICAgICAgRWRnZSYgY2hp bGQyID0gbV9ub2RlLT5jaGlsZDIoKTsKKyAgICAgICAgICAgIGlmIChjaGlsZDItPmlzTnVtYmVy Q29uc3RhbnQoKSAmJiBjaGlsZDItPmFzTnVtYmVyKCkgPT0gMikgeworICAgICAgICAgICAgICAg IHN3aXRjaCAobV9ub2RlLT5iaW5hcnlVc2VLaW5kKCkpIHsKKyAgICAgICAgICAgICAgICBjYXNl IERvdWJsZVJlcFVzZToKKyAgICAgICAgICAgICAgICAgICAgLy8gSXQgaXMgYWx3YXlzIHZhbHVh YmxlIHRvIGdldCByaWQgb2YgYSBkb3VibGUgbXVsdGlwbGljYXRpb24gYnkgMi4KKyAgICAgICAg ICAgICAgICAgICAgLy8gV2Ugd29uJ3QgaGF2ZSBoYWxmLXJlZ2lzdGVyIGRlcGVuZGVuY2llcyBp c3N1ZXMgb24geDg2IGFuZCB3ZSB3b24ndCBoYXZlIHRvIGxvYWQgdGhlIGNvbnN0YW50cy4KKyAg ICAgICAgICAgICAgICAgICAgbV9ub2RlLT5zZXRPcChBcml0aEFkZCk7CisgICAgICAgICAgICAg ICAgICAgIGNoaWxkMi5zZXROb2RlKG1fbm9kZS0+Y2hpbGQxKCkubm9kZSgpKTsKKyAgICAgICAg ICAgICAgICAgICAgbV9jaGFuZ2VkID0gdHJ1ZTsKKyAgICAgICAgICAgICAgICAgICAgYnJlYWs7 CisjaWYgVVNFKEpTVkFMVUU2NCkKKyAgICAgICAgICAgICAgICBjYXNlIEludDUyUmVwVXNlOgor I2VuZGlmCisgICAgICAgICAgICAgICAgY2FzZSBJbnQzMlVzZToKKyAgICAgICAgICAgICAgICAg ICAgLy8gRm9yIGludGVnZXJzLCB3ZSBjYW4gb25seSBjb252ZXJ0IGNvbXBhdGlibGUgbW9kZXMu CisgICAgICAgICAgICAgICAgICAgIC8vIEFyaXRoQWRkIGRvZXMgaGFuZGxlIGRvIG5lZ2F0aXZl IHplcm8gY2hlY2sgZm9yIGV4YW1wbGUuCisgICAgICAgICAgICAgICAgICAgIGlmIChtX25vZGUt PmFyaXRoTW9kZSgpID09IEFyaXRoOjpDaGVja092ZXJmbG93IHx8IG1fbm9kZS0+YXJpdGhNb2Rl KCkgPT0gQXJpdGg6OlVuY2hlY2tlZCkgeworICAgICAgICAgICAgICAgICAgICAgICAgbV9ub2Rl LT5zZXRPcChBcml0aEFkZCk7CisgICAgICAgICAgICAgICAgICAgICAgICBjaGlsZDIuc2V0Tm9k ZShtX25vZGUtPmNoaWxkMSgpLm5vZGUoKSk7CisgICAgICAgICAgICAgICAgICAgICAgICBtX2No YW5nZWQgPSB0cnVlOworICAgICAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICAgICAgICAg IGJyZWFrOworICAgICAgICAgICAgICAgIGRlZmF1bHQ6CisgICAgICAgICAgICAgICAgICAgIGJy ZWFrOworICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgIH0KICAgICAgICAgICAgIGJyZWFr OwotICAgICAgICAgICAgCisgICAgICAgIH0KICAgICAgICAgY2FzZSBBcml0aFN1YjoKICAgICAg ICAgICAgIGlmIChtX25vZGUtPmNoaWxkMigpLT5pc0ludDMyQ29uc3RhbnQoKQogICAgICAgICAg ICAgICAgICYmIG1fbm9kZS0+aXNCaW5hcnlVc2VLaW5kKEludDMyVXNlKSkgewo=