148037 2015-08-14 13:17:03 -0700 Web Inspector: add support for running protocol-test.js tests on Windows 2015-12-23 15:25:49 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) PC All RESOLVED FIXED InRadar P2 Normal --- 137157 147093 1 bburg bfulgham achristensen bburg bfulgham graouts joepeck mattbaker nvasilyev ryanhaddad timothy webkit-bug-importer oldest_to_newest 1117736 0 bburg 2015-08-14 13:17:03 -0700 We currently don't implement TestRunner::inspectorTestStubURL() for Windows, so tests that use `protocol-test.js` cannot load the stub inspector frontend into an iframe. 1117737 1 webkit-bug-importer 2015-08-14 13:17:39 -0700 <rdar://problem/22292237> 1151124 2 bfulgham 2015-12-23 12:48:32 -0800 This is the cause of 'fast/dom/Window/property-access-on-cached-window-after-frame-removed.html' failing on Win 1151127 3 bfulgham 2015-12-23 12:49:05 -0800 *** Bug 151759 has been marked as a duplicate of this bug. *** 1151152 4 267856 bfulgham 2015-12-23 14:28:19 -0800 Created attachment 267856 Patch 1151154 5 267856 simon.fraser 2015-12-23 14:37:57 -0800 Comment on attachment 267856 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=267856&action=review > Tools/DumpRenderTree/win/TestRunnerWin.cpp:1106 > + CFStringRef urlString = CFURLGetString(url.get()); You could lose this local variable. 1151155 6 bfulgham 2015-12-23 14:40:29 -0800 (In reply to comment #5) > Comment on attachment 267856 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=267856&action=review > > > Tools/DumpRenderTree/win/TestRunnerWin.cpp:1106 > > + CFStringRef urlString = CFURLGetString(url.get()); > > You could lose this local variable. Oh -- good idea! 1151162 7 bfulgham 2015-12-23 15:18:31 -0800 Looks like this requires a clean build on Windows. :-( 1151165 8 bfulgham 2015-12-23 15:25:49 -0800 Committed r194398: <http://trac.webkit.org/changeset/194398> 267856 2015-12-23 14:28:19 -0800 2015-12-23 14:37:57 -0800 Patch bug-148037-20151223144651.patch text/plain 1746 bfulgham SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE5NDM5NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE1LTEyLTIzICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29t PgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGFkZCBzdXBwb3J0IGZvciBydW5uaW5nIHByb3Rv Y29sLXRlc3QuanMgdGVzdHMgb24gV2luZG93cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4MDM3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yMjI5 MjIzNz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IER1bXBSZW5kZXJUcmVlL3dpbi9UZXN0UnVubmVyV2luLmNwcDoKKyAgICAgICAgKFRlc3RSdW5u ZXI6Omluc3BlY3RvclRlc3RTdHViVVJMKTogUHJvdmlkZSBpbXBsZW1lbnRhdGlvbi4KKwogMjAx NS0xMi0yMyAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBb V2luXSBVbnJldmlld2VkIGJ1aWxkIGZpeDogUmVjb2duaXplIFdpbmRvd3MgMTAgdmFyaWFudHMu CkluZGV4OiBUb29scy9EdW1wUmVuZGVyVHJlZS93aW4vVGVzdFJ1bm5lcldpbi5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gVG9vbHMvRHVtcFJlbmRlclRyZWUvd2luL1Rlc3RSdW5uZXJXaW4uY3BwCShyZXZp c2lvbiAxOTQzOTMpCisrKyBUb29scy9EdW1wUmVuZGVyVHJlZS93aW4vVGVzdFJ1bm5lcldpbi5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTEwOTUsMTEgKzEwOTUsMTYgQEAgdm9pZCBUZXN0UnVubmVy OjpldmFsdWF0ZUluV2ViSW5zcGVjdG9yKAogCiBKU1N0cmluZ1JlZiBUZXN0UnVubmVyOjppbnNw ZWN0b3JUZXN0U3R1YlVSTCgpCiB7Ci0gICAgLy8gRklYTUU6IEltcGxlbWVudCB0aGlzIHRvIHN1 cHBvcnQgV2ViIEluc3BlY3RvciB0ZXN0cyB1c2luZyBgcHJvdG9jb2wtdGVzdC5qc2AuCi0gICAg Ly8gU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDgwMjUuCi0g ICAgcHJpbnRmKCJFUlJPUjogVGVzdFJ1bm5lcjo6aW5zcGVjdG9yVGVzdFN0dWJVUkwoKSBub3Qg aW1wbGVtZW50ZWRcbiIpOworICAgIENGQnVuZGxlUmVmIHdlYmtpdEJ1bmRsZSA9IHdlYktpdEJ1 bmRsZSgpOworICAgIGlmICghd2Via2l0QnVuZGxlKQorICAgICAgICByZXR1cm4gbnVsbHB0cjsK IAotICAgIHJldHVybiBudWxscHRyOworICAgIFJldGFpblB0cjxDRlVSTFJlZj4gdXJsID0gYWRv cHRDRihDRkJ1bmRsZUNvcHlSZXNvdXJjZVVSTCh3ZWJraXRCdW5kbGUsIENGU1RSKCJUZXN0U3R1 YiIpLCBDRlNUUigiaHRtbCIpLCBDRlNUUigiV2ViSW5zcGVjdG9yVUkiKSkpOworICAgIGlmICgh dXJsKQorICAgICAgICByZXR1cm4gbnVsbHB0cjsKKworICAgIENGU3RyaW5nUmVmIHVybFN0cmlu ZyA9IENGVVJMR2V0U3RyaW5nKHVybC5nZXQoKSk7CisgICAgcmV0dXJuIEpTU3RyaW5nQ3JlYXRl V2l0aENGU3RyaW5nKHVybFN0cmluZyk7CiB9CiAKIHR5cGVkZWYgSGFzaE1hcDx1bnNpZ25lZCwg Q09NUHRyPElXZWJTY3JpcHRXb3JsZD4gPiBXb3JsZE1hcDsK