148030 2015-08-14 11:26:45 -0700 Remove unused multisampling code 2015-08-17 13:20:04 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen commit-queue dino kondapallykalyan noam roger_fong oldest_to_newest 1117676 0 achristensen 2015-08-14 11:26:45 -0700 Extensions3DOpenGLCommon.m_maySupportMultisampling is always true. 1117679 1 259010 achristensen 2015-08-14 11:28:04 -0700 Created attachment 259010 Patch 1118208 2 259010 commit-queue 2015-08-17 13:20:01 -0700 Comment on attachment 259010 Patch Clearing flags on attachment: 259010 Committed r188536: <http://trac.webkit.org/changeset/188536> 1118209 3 commit-queue 2015-08-17 13:20:04 -0700 All reviewed patches have been landed. Closing bug. 259010 2015-08-14 11:28:04 -0700 2015-08-17 13:20:01 -0700 Patch bug-148030-20150814112745.patch text/plain 5574 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4ODQ3OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDE1LTA4LTE0ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVtb3ZlIHVu dXNlZCBtdWx0aXNhbXBsaW5nIGNoZWNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNDgwMzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBObyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisgICAgICAgIEV4dGVuc2lv bnMzRE9wZW5HTENvbW1vbi5tX21heVN1cHBvcnRNdWx0aXNhbXBsaW5nIGlzIGFsd2F5cyB0cnVl LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvRXh0ZW5zaW9uczNELmg6CisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0V4dGVuc2lvbnMzRE9wZW5HTENvbW1vbi5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpFeHRlbnNpb25zM0RPcGVuR0xDb21tb246OkV4dGVuc2lvbnMz RE9wZW5HTENvbW1vbik6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0V4dGVu c2lvbnMzRE9wZW5HTENvbW1vbi5oOgorICAgICAgICAoV2ViQ29yZTo6RXh0ZW5zaW9uczNET3Bl bkdMQ29tbW9uOjppc0ltYWdpbmF0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6OkV4dGVuc2lvbnMz RE9wZW5HTENvbW1vbjo6dmVuZG9yKToKKyAgICAgICAgKFdlYkNvcmU6OkV4dGVuc2lvbnMzRE9w ZW5HTENvbW1vbjo6cmVxdWlyZXNCdWlsdEluRnVuY3Rpb25FbXVsYXRpb24pOgorICAgICAgICAo V2ViQ29yZTo6RXh0ZW5zaW9uczNET3BlbkdMQ29tbW9uOjpyZXF1aXJlc1Jlc3RyaWN0ZWRNYXhp bXVtVGV4dHVyZVNpemUpOgorICAgICAgICAoV2ViQ29yZTo6RXh0ZW5zaW9uczNET3BlbkdMQ29t bW9uOjptYXlTdXBwb3J0TXVsdGlzYW1wbGluZyk6IERlbGV0ZWQuCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3BlbkdMQ29tbW9uLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDNEOjp2YWxpZGF0ZURlcHRoU3RlbmNpbCk6 CisKIDIwMTUtMDgtMTQgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAK ICAgICAgICAgRml4IHRoZSBNYXZlcmlja3MgYnVpbGQuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9FeHRlbnNpb25zM0QuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9FeHRlbnNpb25zM0QuaAkocmV2aXNpb24gMTg4NDc2KQor KysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRXh0ZW5zaW9uczNELmgJKHdvcmtp bmcgY29weSkKQEAgLTI1NSwxMyArMjU1LDYgQEAgcHVibGljOgogICAgIHZpcnR1YWwgYm9vbCBp c0ltYWdpbmF0aW9uKCkgPSAwOwogICAgIHZpcnR1YWwgU3RyaW5nIHZlbmRvcigpID0gMDsKIAot ICAgIC8vIElmIHRoaXMgbWV0aG9kIHJldHVybnMgZmFsc2UgdGhlbiB0aGUgc3lzdGVtICpkZWZp bml0ZWx5KiBkb2VzIG5vdCBzdXBwb3J0IG11bHRpc2FtcGxpbmcuCi0gICAgLy8gSXQgZG9lcyBu b3QgbmVjZXNzYXJpbHkgc2F5IHRoZSBzeXN0ZW0gZG9lcyBzdXBwb3J0IGl0IC0gY2FsbGVycyBt dXN0IGF0dGVtcHQgdG8gY29uc3RydWN0Ci0gICAgLy8gbXVsdGlzYW1wbGVkIHJlbmRlcmJ1ZmZl cnMgYW5kIGNoZWNrIGZyYW1lYnVmZmVyIGNvbXBsZXRlbmVzcy4KLSAgICAvLyBQb3J0cyBzaG91 bGQgaW1wbGVtZW50IHRoaXMgdG8gcmV0dXJuIGZhbHNlIG9uIGNvbmZpZ3VyYXRpb25zIHdoZXJl IGl0IGlzIGtub3duCi0gICAgLy8gdGhhdCBtdWx0aXNhbXBsaW5nIGlzIG5vdCBhdmFpbGFibGUu Ci0gICAgdmlydHVhbCBib29sIG1heVN1cHBvcnRNdWx0aXNhbXBsaW5nKCkgPSAwOwotCiAgICAg Ly8gU29tZSBjb25maWd1cmF0aW9ucyBoYXZlIGJ1Z3MgcmVnYXJkaW5nIGJ1aWx0LWluIGZ1bmN0 aW9ucyBpbiB0aGVpciBPcGVuR0wgZHJpdmVycwogICAgIC8vIHRoYXQgbXVzdCBiZSBhdm9pZGVk LiBQb3J0cyBzaG91bGQgaW1wbGVtZW50IHRoZXNlIGZsYWdzIG9uIHN1Y2ggY29uZmlndXJhdGlv bnMuCiAgICAgdmlydHVhbCBib29sIHJlcXVpcmVzQnVpbHRJbkZ1bmN0aW9uRW11bGF0aW9uKCkg PSAwOwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0V4dGVu c2lvbnMzRE9wZW5HTENvbW1vbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0V4dGVuc2lvbnMzRE9wZW5HTENvbW1vbi5jcHAJKHJldmlz aW9uIDE4ODQ3NikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9F eHRlbnNpb25zM0RPcGVuR0xDb21tb24uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01OCw3ICs1OCw2 IEBAIEV4dGVuc2lvbnMzRE9wZW5HTENvbW1vbjo6RXh0ZW5zaW9uczNET3AKICAgICAsIG1faXNB TUQoZmFsc2UpCiAgICAgLCBtX2lzSW50ZWwoZmFsc2UpCiAgICAgLCBtX2lzSW1hZ2luYXRpb24o ZmFsc2UpCi0gICAgLCBtX21heVN1cHBvcnRNdWx0aXNhbXBsaW5nKHRydWUpCiAgICAgLCBtX3Jl cXVpcmVzQnVpbHRJbkZ1bmN0aW9uRW11bGF0aW9uKGZhbHNlKQogICAgICwgbV9yZXF1aXJlc1Jl c3RyaWN0ZWRNYXhpbXVtVGV4dHVyZVNpemUoZmFsc2UpCiB7CkBAIC04MCwxNyArNzksOCBAQCBF eHRlbnNpb25zM0RPcGVuR0xDb21tb246OkV4dGVuc2lvbnMzRE9wCiAgICAgaWYgKG1faXNBTUQg fHwgbV9pc0ludGVsKQogICAgICAgICBtX3JlcXVpcmVzQnVpbHRJbkZ1bmN0aW9uRW11bGF0aW9u ID0gdHJ1ZTsKIAotICAgIC8vIEN1cnJlbnRseSBpbiBNYWMgd2Ugb25seSBhbGxvdyBtdWx0aXNh bXBsaW5nIGlmIHRoZSB2ZW5kb3IgaXMgTlZJRElBLAotICAgIC8vIG9yIGlmIHRoZSB2ZW5kb3Ig aXMgQU1EL0FUSSBhbmQgdGhlIHN5c3RlbSBpcyAxMC43LjIgYW5kIGFib3ZlLgotCi0gICAgYm9v bCBzeXN0ZW1TdXBwb3J0c011bHRpc2FtcGxpbmcgPSB0cnVlOwotCi0gICAgaWYgKG1faXNBTUQg JiYgIXN5c3RlbVN1cHBvcnRzTXVsdGlzYW1wbGluZykKLSAgICAgICAgbV9tYXlTdXBwb3J0TXVs dGlzYW1wbGluZyA9IGZhbHNlOwotCiAgICAgLy8gSW50ZWwgSEQgMzAwMCBkZXZpY2VzIGhhdmUg cHJvYmxlbXMgd2l0aCBsYXJnZSB0ZXh0dXJlcy4gPHJkYXI6Ly9wcm9ibGVtLzE2NjQ5MTQwPgot ICAgIGlmIChtX2lzSW50ZWwpCi0gICAgICAgIG1fcmVxdWlyZXNSZXN0cmljdGVkTWF4aW11bVRl eHR1cmVTaXplID0gbV9yZW5kZXJlci5zdGFydHNXaXRoKCJJbnRlbCBIRCBHcmFwaGljcyAzMDAw Iik7CisgICAgbV9yZXF1aXJlc1Jlc3RyaWN0ZWRNYXhpbXVtVGV4dHVyZVNpemUgPSBtX3JlbmRl cmVyLnN0YXJ0c1dpdGgoIkludGVsIEhEIEdyYXBoaWNzIDMwMDAiKTsKICNlbmRpZgogfQogCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvRXh0ZW5zaW9uczNE T3BlbkdMQ29tbW9uLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3Mvb3BlbmdsL0V4dGVuc2lvbnMzRE9wZW5HTENvbW1vbi5oCShyZXZpc2lvbiAxODg0NzYp CisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvRXh0ZW5zaW9uczNE T3BlbkdMQ29tbW9uLmgJKHdvcmtpbmcgY29weSkKQEAgLTY1LDcgKzY1LDYgQEAgcHVibGljOgog ICAgIHZpcnR1YWwgYm9vbCBpc0ltYWdpbmF0aW9uKCkgeyByZXR1cm4gbV9pc0ltYWdpbmF0aW9u OyB9CiAgICAgdmlydHVhbCBTdHJpbmcgdmVuZG9yKCkgeyByZXR1cm4gbV92ZW5kb3I7IH0KIAot ICAgIHZpcnR1YWwgYm9vbCBtYXlTdXBwb3J0TXVsdGlzYW1wbGluZygpIHsgcmV0dXJuIG1fbWF5 U3VwcG9ydE11bHRpc2FtcGxpbmc7IH0KICAgICB2aXJ0dWFsIGJvb2wgcmVxdWlyZXNCdWlsdElu RnVuY3Rpb25FbXVsYXRpb24oKSB7IHJldHVybiBtX3JlcXVpcmVzQnVpbHRJbkZ1bmN0aW9uRW11 bGF0aW9uOyB9CiAgICAgdmlydHVhbCBib29sIHJlcXVpcmVzUmVzdHJpY3RlZE1heGltdW1UZXh0 dXJlU2l6ZSgpIHsgcmV0dXJuIG1fcmVxdWlyZXNSZXN0cmljdGVkTWF4aW11bVRleHR1cmVTaXpl OyB9CiAKQEAgLTg3LDcgKzg2LDYgQEAgcHJvdGVjdGVkOgogICAgIGJvb2wgbV9pc0FNRDsKICAg ICBib29sIG1faXNJbnRlbDsKICAgICBib29sIG1faXNJbWFnaW5hdGlvbjsKLSAgICBib29sIG1f bWF5U3VwcG9ydE11bHRpc2FtcGxpbmc7CiAgICAgYm9vbCBtX3JlcXVpcmVzQnVpbHRJbkZ1bmN0 aW9uRW11bGF0aW9uOwogICAgIGJvb2wgbV9yZXF1aXJlc1Jlc3RyaWN0ZWRNYXhpbXVtVGV4dHVy ZVNpemU7CiAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9H cmFwaGljc0NvbnRleHQzRE9wZW5HTENvbW1vbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3BlbkdMQ29t bW9uLmNwcAkocmV2aXNpb24gMTg4NDc2KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3BlbkdMQ29tbW9uLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTMzLDcgKzEzMyw3IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0M0Q6OnZhbGlkYXRl RGVwdGhTdGUKICAgICAgICAgICAgIG1fYXR0cnMuc3RlbmNpbCA9IGZhbHNlOwogICAgIH0KICAg ICBpZiAobV9hdHRycy5hbnRpYWxpYXMpIHsKLSAgICAgICAgaWYgKCFleHRlbnNpb25zLT5tYXlT dXBwb3J0TXVsdGlzYW1wbGluZygpIHx8ICFleHRlbnNpb25zLT5zdXBwb3J0cygiR0xfQU5HTEVf ZnJhbWVidWZmZXJfbXVsdGlzYW1wbGUiKSB8fCBpc0dMRVMyQ29tcGxpYW50KCkpCisgICAgICAg IGlmICghZXh0ZW5zaW9ucy0+c3VwcG9ydHMoIkdMX0FOR0xFX2ZyYW1lYnVmZmVyX211bHRpc2Ft cGxlIikgfHwgaXNHTEVTMkNvbXBsaWFudCgpKQogICAgICAgICAgICAgbV9hdHRycy5hbnRpYWxp YXMgPSBmYWxzZTsKICAgICAgICAgZWxzZQogICAgICAgICAgICAgZXh0ZW5zaW9ucy0+ZW5zdXJl RW5hYmxlZCgiR0xfQU5HTEVfZnJhbWVidWZmZXJfbXVsdGlzYW1wbGUiKTsK