148025 2015-08-14 08:46:46 -0700 Web Inspector: add support for running inspector-test.js tests on Windows 2026-01-12 09:09:45 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) PC All NEW InRadar P2 Normal --- 137157 147093 1 bburg bfulgham achristensen bfulgham graouts inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1117633 0 bburg 2015-08-14 08:46:46 -0700 We currently do not load Test.html when running tests, leading tests to time out on Windows because the test page does not receive the "Test Inspector Loaded" signal. 1117634 1 webkit-bug-importer 2015-08-14 08:46:59 -0700 <rdar://problem/22287523> 1117637 2 bburg 2015-08-14 08:58:49 -0700 As a starting point, the existing Windows code specifies the page to load inside WebInspectorClient::openInspectorFrontend: RetainPtr<CFURLRef> htmlURLRef = adoptCF(CFBundleCopyResourceURL(webKitBundle(), CFSTR("Main"), CFSTR("html"), CFSTR("WebInspectorUI"))); The mac WK1 code does something like this, which could be copied to Windows. NSString *pagePath = isUnderTest ? [self inspectorTestPagePath] : [self inspectorPagePath]; 1117735 3 bburg 2015-08-14 13:15:38 -0700 To clarify, this bug deals with adding support for tests that use `inspector-test.js`. Another bug tracks `protocol-test.js`, since they use different mechanisms. 1151201 4 bfulgham 2015-12-23 15:52:16 -0800 It doesn't look like the "isUnderTest" flag is getting passed to WebKit on Windows. I'll have to see where that comes from. 1151415 5 bburg 2015-12-27 08:44:24 -0800 (In reply to comment #4) > It doesn't look like the "isUnderTest" flag is getting passed to WebKit on > Windows. I'll have to see where that comes from. I'm not sure why this isn't getting propagated. InspectorController has a m_isUnderTest flag, which is set via Internals::setInspectorIsUnderTest. When a frontend opens, it asks the inspected page's inspector controller whether it's under test. I couldn't find any obvious problems here by reading the code again, so you probably want to pause in a debugger inside the setter and getter to see what's going on.