148024 2015-08-14 02:16:26 -0700 [Win] Cleanups to PluginView::handleMouseEvent() 2015-08-17 10:41:55 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sungmann.cho sungmann.cho achristensen bfulgham commit-queue gyuyoung.kim oldest_to_newest 1117620 0 sungmann.cho 2015-08-14 02:16:26 -0700 SSIA 1117621 1 sungmann.cho 2015-08-14 02:39:46 -0700 1. Replace the raw values identifying specific mouse buttons with WebCore::MouseButton enum values. 2. Reindent if and switch statements. 1117622 2 258997 sungmann.cho 2015-08-14 02:42:58 -0700 Created attachment 258997 Patch 1118078 3 gyuyoung.kim 2015-08-16 20:04:18 -0700 CC'ing Alex, Brent who are responsible for Win port. 1118132 4 258997 achristensen 2015-08-17 09:56:06 -0700 Comment on attachment 258997 Patch Cleaner code! Yay! 1118148 5 258997 commit-queue 2015-08-17 10:41:50 -0700 Comment on attachment 258997 Patch Clearing flags on attachment: 258997 Committed r188525: <http://trac.webkit.org/changeset/188525> 1118149 6 commit-queue 2015-08-17 10:41:55 -0700 All reviewed patches have been landed. Closing bug. 258997 2015-08-14 02:42:58 -0700 2015-08-17 10:41:50 -0700 Patch bug-148024-20150814184239.patch text/plain 3819 sungmann.cho U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4NDQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3dp bi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L3dpbi9DaGFuZ2VMb2cKaW5kZXggZTIzOTY5YzQ5 YjU5MjQ0NmJiZDlmOGExOGEwODZmMGExMWY4ZmRhZi4uM2U3YWZiNWVhMWYwYThkOWI1YTQ3NzNk NTI0ZmNkYzFiMmRlMmNlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC93aW4vQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1 LTA4LTE0ICBTdW5nbWFubiBDaG8gIDxzdW5nbWFubi5jaG9AbmF2ZXJjb3JwLmNvbT4KKworICAg ICAgICBbV2luXSBDbGVhbnVwcyB0byBQbHVnaW5WaWV3OjpoYW5kbGVNb3VzZUV2ZW50KCkuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDgwMjQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAxLiBSZXBsYWNl IHRoZSByYXcgdmFsdWVzIGlkZW50aWZ5aW5nIHNwZWNpZmljIG1vdXNlIGJ1dHRvbnMgd2l0aAor ICAgICAgICAgICBXZWJDb3JlOjpNb3VzZUJ1dHRvbiBlbnVtIHZhbHVlcy4KKyAgICAgICAgMi4g UmVpbmRlbnQgaWYgYW5kIHN3aXRjaCBzdGF0ZW1lbnRzLgorCisgICAgICAgICogUGx1Z2lucy9Q bHVnaW5WaWV3V2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBsdWdpblZpZXc6OmhhbmRsZU1v dXNlRXZlbnQpOgorCiAyMDE1LTA4LTEzICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBw bGUuY29tPgogCiAgICAgICAgIFdpbmRvd3MgYnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC93aW4vUGx1Z2lucy9QbHVnaW5WaWV3V2luLmNwcCBiL1NvdXJjZS9XZWJLaXQvd2lu L1BsdWdpbnMvUGx1Z2luVmlld1dpbi5jcHAKaW5kZXggMTBkM2U5MmEzYzFmODFjZWRlYmJiY2Rl OTgxNGJhZTA3NzcxMzlmMS4uMDEwZWFlZDM0MDJmZWRkNGIzNzYzMTExY2ExYTQ2NjcwOWI4Yzc0 MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC93aW4vUGx1Z2lucy9QbHVnaW5WaWV3V2luLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0L3dpbi9QbHVnaW5zL1BsdWdpblZpZXdXaW4uY3BwCkBAIC02 MTcsNDcgKzYxNyw0NiBAQCB2b2lkIFBsdWdpblZpZXc6OmhhbmRsZU1vdXNlRXZlbnQoTW91c2VF dmVudCogZXZlbnQpCiAgICAgaWYgKGV2ZW50LT5zaGlmdEtleSgpKQogICAgICAgICBucEV2ZW50 LndQYXJhbSB8PSBNS19TSElGVDsKIAotICAgIGlmIChldmVudC0+dHlwZSgpID09IGV2ZW50TmFt ZXMoKS5tb3VzZW1vdmVFdmVudCB8fAotICAgICAgICBldmVudC0+dHlwZSgpID09IGV2ZW50TmFt ZXMoKS5tb3VzZW91dEV2ZW50IHx8IAotICAgICAgICBldmVudC0+dHlwZSgpID09IGV2ZW50TmFt ZXMoKS5tb3VzZW92ZXJFdmVudCkgeworICAgIGlmIChldmVudC0+dHlwZSgpID09IGV2ZW50TmFt ZXMoKS5tb3VzZW1vdmVFdmVudAorICAgICAgICB8fCBldmVudC0+dHlwZSgpID09IGV2ZW50TmFt ZXMoKS5tb3VzZW91dEV2ZW50CisgICAgICAgIHx8IGV2ZW50LT50eXBlKCkgPT0gZXZlbnROYW1l cygpLm1vdXNlb3ZlckV2ZW50KSB7CiAgICAgICAgIG5wRXZlbnQuZXZlbnQgPSBXTV9NT1VTRU1P VkU7CiAgICAgICAgIGlmIChldmVudC0+YnV0dG9uRG93bigpKQogICAgICAgICAgICAgc3dpdGNo IChldmVudC0+YnV0dG9uKCkpIHsKLSAgICAgICAgICAgICAgICBjYXNlIExlZnRCdXR0b246Ci0g ICAgICAgICAgICAgICAgICAgIG5wRXZlbnQud1BhcmFtIHw9IE1LX0xCVVRUT047Ci0gICAgICAg ICAgICAgICAgICAgIGJyZWFrOwotICAgICAgICAgICAgICAgIGNhc2UgTWlkZGxlQnV0dG9uOgot ICAgICAgICAgICAgICAgICAgICBucEV2ZW50LndQYXJhbSB8PSBNS19NQlVUVE9OOwotICAgICAg ICAgICAgICAgICAgICBicmVhazsKLSAgICAgICAgICAgICAgICBjYXNlIFJpZ2h0QnV0dG9uOgot ICAgICAgICAgICAgICAgICAgICBucEV2ZW50LndQYXJhbSB8PSBNS19SQlVUVE9OOworICAgICAg ICAgICAgY2FzZSBMZWZ0QnV0dG9uOgorICAgICAgICAgICAgICAgIG5wRXZlbnQud1BhcmFtIHw9 IE1LX0xCVVRUT047CisgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICBjYXNlIE1p ZGRsZUJ1dHRvbjoKKyAgICAgICAgICAgICAgICBucEV2ZW50LndQYXJhbSB8PSBNS19NQlVUVE9O OworICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgY2FzZSBSaWdodEJ1dHRvbjoK KyAgICAgICAgICAgICAgICBucEV2ZW50LndQYXJhbSB8PSBNS19SQlVUVE9OOwogICAgICAgICAg ICAgICAgIGJyZWFrOwogICAgICAgICAgICAgfQotICAgIH0KLSAgICBlbHNlIGlmIChldmVudC0+ dHlwZSgpID09IGV2ZW50TmFtZXMoKS5tb3VzZWRvd25FdmVudCkgeworICAgIH0gZWxzZSBpZiAo ZXZlbnQtPnR5cGUoKSA9PSBldmVudE5hbWVzKCkubW91c2Vkb3duRXZlbnQpIHsKICAgICAgICAg Zm9jdXNQbHVnaW5FbGVtZW50KCk7CiAgICAgICAgIHN3aXRjaCAoZXZlbnQtPmJ1dHRvbigpKSB7 Ci0gICAgICAgICAgICBjYXNlIDA6Ci0gICAgICAgICAgICAgICAgbnBFdmVudC5ldmVudCA9IFdN X0xCVVRUT05ET1dOOwotICAgICAgICAgICAgICAgIGJyZWFrOwotICAgICAgICAgICAgY2FzZSAx OgotICAgICAgICAgICAgICAgIG5wRXZlbnQuZXZlbnQgPSBXTV9NQlVUVE9ORE9XTjsKLSAgICAg ICAgICAgICAgICBicmVhazsKLSAgICAgICAgICAgIGNhc2UgMjoKLSAgICAgICAgICAgICAgICBu cEV2ZW50LmV2ZW50ID0gV01fUkJVVFRPTkRPV047Ci0gICAgICAgICAgICAgICAgYnJlYWs7Cisg ICAgICAgIGNhc2UgTGVmdEJ1dHRvbjoKKyAgICAgICAgICAgIG5wRXZlbnQuZXZlbnQgPSBXTV9M QlVUVE9ORE9XTjsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICBjYXNlIE1pZGRsZUJ1dHRv bjoKKyAgICAgICAgICAgIG5wRXZlbnQuZXZlbnQgPSBXTV9NQlVUVE9ORE9XTjsKKyAgICAgICAg ICAgIGJyZWFrOworICAgICAgICBjYXNlIFJpZ2h0QnV0dG9uOgorICAgICAgICAgICAgbnBFdmVu dC5ldmVudCA9IFdNX1JCVVRUT05ET1dOOworICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0K ICAgICB9IGVsc2UgaWYgKGV2ZW50LT50eXBlKCkgPT0gZXZlbnROYW1lcygpLm1vdXNldXBFdmVu dCkgewogICAgICAgICBzd2l0Y2ggKGV2ZW50LT5idXR0b24oKSkgewotICAgICAgICAgICAgY2Fz ZSAwOgotICAgICAgICAgICAgICAgIG5wRXZlbnQuZXZlbnQgPSBXTV9MQlVUVE9OVVA7Ci0gICAg ICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgICAgICBjYXNlIDE6Ci0gICAgICAgICAgICAgICAg bnBFdmVudC5ldmVudCA9IFdNX01CVVRUT05VUDsKLSAgICAgICAgICAgICAgICBicmVhazsKLSAg ICAgICAgICAgIGNhc2UgMjoKLSAgICAgICAgICAgICAgICBucEV2ZW50LmV2ZW50ID0gV01fUkJV VFRPTlVQOwotICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICBjYXNlIExlZnRCdXR0b246 CisgICAgICAgICAgICBucEV2ZW50LmV2ZW50ID0gV01fTEJVVFRPTlVQOworICAgICAgICAgICAg YnJlYWs7CisgICAgICAgIGNhc2UgTWlkZGxlQnV0dG9uOgorICAgICAgICAgICAgbnBFdmVudC5l dmVudCA9IFdNX01CVVRUT05VUDsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICBjYXNlIFJp Z2h0QnV0dG9uOgorICAgICAgICAgICAgbnBFdmVudC5ldmVudCA9IFdNX1JCVVRUT05VUDsKKyAg ICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAgICAgfSBlbHNlCiAgICAgICAgIHJldHVybjsK