148018 2015-08-13 23:08:27 -0700 [Win] The context menu on PluginView is displayed in wrong positions 2022-07-01 11:36:11 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 sungmann.cho sungmann.cho achristensen andersca ap bfulgham gyuyoung.kim oldest_to_newest 1117587 0 sungmann.cho 2015-08-13 23:08:27 -0700 On Windows, the context menu on PluginView is displayed in wrong positions. It is due to not taking the device scale factor into account when assembling WM_RBUTTONDOWN events. 1117591 1 258987 sungmann.cho 2015-08-13 23:16:04 -0700 Created attachment 258987 Patch 1117595 2 258988 sungmann.cho 2015-08-13 23:23:54 -0700 Created attachment 258988 simple flash content for testing 1118071 3 sungmann.cho 2015-08-16 18:58:48 -0700 This problem seems to occur when the value of "Make it easier to read what's on your screen" item in the display setting page is not equal to "Smaller - 100% (default)". 1118131 4 258987 achristensen 2015-08-17 09:54:42 -0700 Comment on attachment 258987 Patch Why don't the other events (WM_LBUTTONDOWN, WM_MBUTTONDOWN) have the same problem? Doing this here specifically for the right button only seems like the wrong thing to do. 1118154 5 258987 bfulgham 2015-08-17 10:49:53 -0700 Comment on attachment 258987 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258987&action=review > Source/WebKit/win/Plugins/PluginViewWin.cpp:657 > + npEvent.lParam = MAKELPARAM(point.x(), point.y()); This is correct if this event is being passed into WebCore, which wants to work in logical pixels. But it looks like this event is handed to the plugin, which may or may not be working in logical pixels. It could be that Flash is not high-DPI aware, and therefore needs the scaled pixel values -- but what happens if Flash is updated to recognize High-DPI? Also, It does seem like if the adjusted point is needed for the context menu, it's probably need for mouse down and other actions, as Alex pointed out. 1118574 6 achristensen 2015-08-18 11:44:29 -0700 Is this fixed by https://bugs.webkit.org/show_bug.cgi?id=148020 ? 1119757 7 259619 sungmann.cho 2015-08-21 09:13:10 -0700 Created attachment 259619 Patch 1119760 8 sungmann.cho 2015-08-21 09:21:38 -0700 (In reply to comment #6) > Is this fixed by https://bugs.webkit.org/show_bug.cgi?id=148020 ? No. The problem still occurs after landing of that patch. 1119768 9 259619 achristensen 2015-08-21 09:49:57 -0700 Comment on attachment 259619 Patch I'm not sure where the problem really is, but I really think that scaling only the right button event positions is not the right solution. 1119854 10 sungmann.cho 2015-08-21 12:14:32 -0700 (In reply to comment #5) > It could be that Flash is not high-DPI aware, and therefore needs the scaled pixel values -- > but what happens if Flash is updated to recognize High-DPI? This problem still occurs even after updating to the latest version of Flash (18.0.0.232). > Also, It does seem like if the adjusted point is needed for the context menu, > it's probably need for mouse down and other actions, as Alex pointed out. Things get even worse when we pass the adjusted point to other down events. When I tried to do so with the attached test content, I couldn't click any buttons or links on it. According to the codes in WebView::handleContextMenuEvent() (https://goo.gl/RI8Mvz), it seems that we are scaling the given logical point with the device scale factor only when invoking TrackPopupMenu(). Any thoughts on this? 1119874 11 bfulgham 2015-08-21 12:46:08 -0700 (In reply to comment #10) > > Also, It does seem like if the adjusted point is needed for the context menu, > > it's probably need for mouse down and other actions, as Alex pointed out. > > Things get even worse when we pass the adjusted point to other down events. > When I tried to do so with the attached test content, I couldn't click any > buttons or links on it. In general, the code in the WebKit layer (i.e., the stuff in Source/WebKit/win) work in terms of device (screen) pixels. So, position/size information received from Windows messages are device pixels, as are anything we send back to Windows via API or messages since Windows only understands device pixels. When we hand coordinates/sizes down to WebCore, we need to covert to "logical" pixels, so we have to adjust by the scaling factor. E.g., in a High DPI device one logical pixel maps to a group of 2x2 device pixels. So when we get a message and hand it to the plugin, we have to decide if the plugin wants to get device pixels or logical pixels -- and I'm not sure what Flash wants. Since the coordinates coming through HTMLPluginElement on their way to PluginViewWin are from WebCore, they are in logical units. If you have to scale the coordinates to get the context menu (which I assume is internal to Flash), then it doesn't make sense that you would not need to do this for all the other action as well! > According to the codes in WebView::handleContextMenuEvent() > (https://goo.gl/RI8Mvz), > it seems that we are scaling the given logical point with the device scale > factor > only when invoking TrackPopupMenu(). Any thoughts on this? Nearly all mouse events get scaled in the constructors for PlatformMouseEventWin. However, the context menu doesn't use that event object, so it was done manually. Is it possible that the plugin wants screen coordinates (i.e., referenced against the edge of the monitor), but we are handling it content coordinates (based on the plugin)? Maybe something was broken for Plugin handling when I made some of these other changes? 1880012 12 ap 2022-07-01 11:36:11 -0700 Mass closing plug-in bugs, as plug-in support has been removed from WebKit. Please comment and/or reopen if this still affects WebKit in some way. 258987 2015-08-13 23:16:04 -0700 2015-08-21 09:13:05 -0700 Patch bug-148018-20150814151546.patch text/plain 2142 sungmann.cho U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4NDM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3dp bi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L3dpbi9DaGFuZ2VMb2cKaW5kZXggNWZkNDZhNDFi ZjFhNDExOTM5ZjVjZDliM2VjMTJiNDBlYmEwNjc1Ny4uNjM5MWE2ZWQxOWJlMDhiNjhlOWI0NDZh NTE0MjlkNjYxNGIxYWMyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC93aW4vQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1 LTA4LTEzICBTdW5nbWFubiBDaG8gIDxzdW5nbWFubi5jaG9AbmF2ZXJjb3JwLmNvbT4KKworICAg ICAgICBbV2luXSBUaGUgY29udGV4dCBtZW51IG9uIFBsdWdpblZpZXcgaXMgZGlzcGxheWVkIGlu IHdyb25nIHBvc2l0aW9ucy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE0ODAxOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIE9uIFdpbmRvd3MsIHRoZSBjb250ZXh0IG1lbnUgb24gUGx1Z2luVmlldyBpcyBk aXNwbGF5ZWQgaW4gd3JvbmcgcG9zaXRpb25zLgorICAgICAgICBJdCBpcyBkdWUgdG8gbm90IHRh a2luZyB0aGUgZGV2aWNlIHNjYWxlIGZhY3RvciBpbnRvIGFjY291bnQgd2hlbiBhc3NlbWJsaW5n CisgICAgICAgIFdNX1JCVVRUT05ET1dOIGV2ZW50cy4KKworICAgICAgICAqIFBsdWdpbnMvUGx1 Z2luVmlld1dpbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3OjpoYW5kbGVNb3Vz ZUV2ZW50KToKKwogMjAxNS0wOC0xMiAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUu Y29tPgogCiAgICAgICAgIFVzZSBXVEY6Ok9wdGlvbmFsIGluIFdpbmRvd0ZlYXR1cmVzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L3dpbi9QbHVnaW5zL1BsdWdpblZpZXdXaW4uY3BwIGIvU291 cmNlL1dlYktpdC93aW4vUGx1Z2lucy9QbHVnaW5WaWV3V2luLmNwcAppbmRleCAxMGQzZTkyYTNj MWY4MWNlZGViYmJjZGU5ODE0YmFlMDc3NzEzOWYxLi45ZTBiY2M0YmVhMjQ5ZjVkMjdhZTliMzYy NzM0ZDA5NTAyZTJmNDhkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3dpbi9QbHVnaW5zL1Bs dWdpblZpZXdXaW4uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvd2luL1BsdWdpbnMvUGx1Z2luVmll d1dpbi5jcHAKQEAgLTQzLDYgKzQzLDcgQEAKICNpbmNsdWRlIDxXZWJDb3JlL0ZyYW1lTG9hZGVy Lmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9GcmFtZVRyZWUuaD4KICNpbmNsdWRlIDxXZWJDb3JlL0Zy YW1lVmlldy5oPgorI2luY2x1ZGUgPFdlYkNvcmUvR0RJVXRpbGl0aWVzLmg+CiAjaW5jbHVkZSA8 V2ViQ29yZS9HcmFwaGljc0NvbnRleHQuaD4KICNpbmNsdWRlIDxXZWJDb3JlL0hUTUxOYW1lcy5o PgogI2luY2x1ZGUgPFdlYkNvcmUvSFRNTFBsdWdJbkVsZW1lbnQuaD4KQEAgLTY0NCw2ICs2NDUs MTYgQEAgdm9pZCBQbHVnaW5WaWV3OjpoYW5kbGVNb3VzZUV2ZW50KE1vdXNlRXZlbnQqIGV2ZW50 KQogICAgICAgICAgICAgICAgIG5wRXZlbnQuZXZlbnQgPSBXTV9NQlVUVE9ORE9XTjsKICAgICAg ICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIGNhc2UgMjoKKyAgICAgICAgICAgICAgICBm bG9hdCBzY2FsZUZhY3RvcjsKKyAgICAgICAgICAgICAgICBpZiAoUGFnZSogcGFnZSA9IG1fcGFy ZW50RnJhbWUtPnBhZ2UoKSkKKyAgICAgICAgICAgICAgICAgICAgc2NhbGVGYWN0b3IgPSBwYWdl LT5kZXZpY2VTY2FsZUZhY3RvcigpOworICAgICAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAg ICAgICAgICAgc2NhbGVGYWN0b3IgPSBXZWJDb3JlOjpkZXZpY2VTY2FsZUZhY3RvckZvcldpbmRv dyhudWxscHRyKTsKKworICAgICAgICAgICAgICAgIEludFBvaW50IHBvaW50ID0gcDsKKyAgICAg ICAgICAgICAgICBwb2ludC5zY2FsZShzY2FsZUZhY3Rvciwgc2NhbGVGYWN0b3IpOworCisgICAg ICAgICAgICAgICAgbnBFdmVudC5sUGFyYW0gPSBNQUtFTFBBUkFNKHBvaW50LngoKSwgcG9pbnQu eSgpKTsKICAgICAgICAgICAgICAgICBucEV2ZW50LmV2ZW50ID0gV01fUkJVVFRPTkRPV047CiAg ICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0K 258988 2015-08-13 23:23:54 -0700 2015-08-13 23:23:54 -0700 simple flash content for testing flash-content.html text/html 1514 sungmann.cho PGh0bWw+DQo8Ym9keT4NCjxvYmplY3QgdHlwZT0iYXBwbGljYXRpb24veC1zaG9ja3dhdmUtZmxh c2giIGRhdGE9Imh0dHA6Ly9hZGltZy5jZ3YuY28ua3IvaW1hZ2VzL21vdmllX3NlbGVjdGlvbi9t b3ZpZV9zZWxlY3Rpb25fMDcwOS5zd2YiIHdpZHRoPSI3MzMiIGhlaWdodD0iMzg4Ij4NCiAgICA8 cGFyYW0gbmFtZT0ibW92aWUiIHZhbHVlPSJodHRwOi8vYWRpbWcuY2d2LmNvLmtyL2ltYWdlcy9t b3ZpZV9zZWxlY3Rpb24vbW92aWVfc2VsZWN0aW9uXzA3MDkuc3dmIj4NCiAgICA8cGFyYW0gbmFt ZT0icGxheSIgdmFsdWU9InRydWUiPg0KICAgIDxwYXJhbSBuYW1lPSJsb29wIiB2YWx1ZT0idHJ1 ZSI+DQogICAgPHBhcmFtIG5hbWU9Indtb2RlIiB2YWx1ZT0idHJhbnNwYXJlbnQiPg0KICAgIDxw YXJhbSBuYW1lPSJzY2FsZSIgdmFsdWU9InNob3dhbGwiPg0KICAgIDxwYXJhbSBuYW1lPSJtZW51 IiB2YWx1ZT0idHJ1ZSI+DQogICAgPHBhcmFtIG5hbWU9ImRldmljZWZvbnQiIHZhbHVlPSJmYWxz ZSI+DQogICAgPHBhcmFtIG5hbWU9ImFsbG93U2NyaXB0QWNjZXNzIiB2YWx1ZT0iYWx3YXlzIj4N CiAgICA8cGFyYW0gbmFtZT0iYWxsb3dGdWxsU2NyZWVuIiB2YWx1ZT0idHJ1ZSI+DQogICAgPHBh cmFtIG5hbWU9IkZsYXNoVmFycyIgdmFsdWU9ImltZ1VybD1odHRwOi8vYWRpbWcuY2d2LmNvLmty L2ltYWdlcy8yMDE1MDgvbWluaS83MzN4Mzg4LmpwZyZhbXA7Zmx2VXJsPUFELzIwMTUwOC9NSU5f NzM0XzM4OC5mbHYmYW1wO2NvdW50TGluaz1odHRwOi8vYWQuY2d2LmNvLmtyL05ldEluc2lnaHQv Y2xpY2svQ0dWL0NHVl8yMDE0MDEvbWFpbkBTZWxlY3Rpb25fTD9jbXBubm8lM2QxMjkyJTI2YWRz bm8lM2QxJTI2Y3R2bm8lM2QxOTkwMSUyNmxvY25vJTNkNTU3JTI2Y2xrbm8lM2QyNzM4NSUyNiZh bXA7ZGV0YWlsTGluaz1odHRwOi8vYWQuY2d2LmNvLmtyL05ldEluc2lnaHQvY2xpY2svQ0dWL0NH Vl8yMDE0MDEvbWFpbkBTZWxlY3Rpb25fTD9jbXBubm8lM2QxMjkyJTI2YWRzbm8lM2QxJTI2Y3R2 bm8lM2QxOTkwMSUyNmxvY25vJTNkNTU3JTI2Y2xrbm8lM2QyNzM4MyUyNiZhbXA7ZGV0YWlsTGlu a1RhcmdldD1fcGFyZW50JmFtcDtocExpbms9aHR0cDovL2FkLmNndi5jby5rci9OZXRJbnNpZ2h0 L2NsaWNrL0NHVi9DR1ZfMjAxNDAxL21haW5AU2VsZWN0aW9uX0w/Y21wbm5vJTNkMTI5MiUyNmFk c25vJTNkMSUyNmN0dm5vJTNkMTk5MDElMjZsb2NubyUzZDU1NyUyNmNsa25vJTNkMjczNzIlMjYm YW1wO2hwTGlua1RhcmdldD1fYmxhbmsmYW1wO3ZpZGVvTGluaz1odHRwOi8vYWQuY2d2LmNvLmty L05ldEluc2lnaHQvY2xpY2svQ0dWL0NHVl8yMDE0MDEvbWFpbkBTZWxlY3Rpb25fTD9jbXBubm8l M2QxMjkyJTI2YWRzbm8lM2QxJTI2Y3R2bm8lM2QxOTkwMSUyNmxvY25vJTNkNTU3JTI2Y2xrbm8l M2QyNzM4NCUyNiZhbXA7dmlkZW9MaW5rVGFyZ2V0PV9wYXJlbnQmYW1wO3RpY2tldExpbms9dHJ1 ZSI+DQo8L29iamVjdD4NCjwvYm9keT4NCjwvaHRtbD4= 259619 2015-08-21 09:13:10 -0700 2015-08-21 09:49:57 -0700 Patch bug-148018-20150822011304.patch text/plain 2099 sungmann.cho U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4NzU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3dp bi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L3dpbi9DaGFuZ2VMb2cKaW5kZXggNDdlNDE5ZmRk NzAwMmFjMzU1MDhhOTJjMmFmZDcyNWNiMTkxMGUxZi4uODQ4ZmFjYjIyZjI2ZjZmZTE5NWVjNmYz MjQ3NzU1MTJlYjNiYmJlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC93aW4vQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1 LTA4LTIxICBTdW5nbWFubiBDaG8gIDxzdW5nbWFubi5jaG9AbmF2ZXJjb3JwLmNvbT4KKworICAg ICAgICBbV2luXSBUaGUgY29udGV4dCBtZW51IG9uIFBsdWdpblZpZXcgaXMgZGlzcGxheWVkIGlu IHdyb25nIHBvc2l0aW9ucy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE0ODAxOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIE9uIFdpbmRvd3MsIHRoZSBjb250ZXh0IG1lbnUgb24gUGx1Z2luVmlldyBpcyBk aXNwbGF5ZWQgaW4gd3JvbmcgcG9zaXRpb25zLgorICAgICAgICBJdCBpcyBkdWUgdG8gbm90IHRh a2luZyB0aGUgZGV2aWNlIHNjYWxlIGZhY3RvciBpbnRvIGFjY291bnQgd2hlbiBhc3NlbWJsaW5n CisgICAgICAgIFdNX1JCVVRUT05ET1dOIGV2ZW50cy4KKworICAgICAgICAqIFBsdWdpbnMvUGx1 Z2luVmlld1dpbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3OjpoYW5kbGVNb3Vz ZUV2ZW50KToKKwogMjAxNS0wOC0yMCAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNv bT4KIAogICAgICAgICBbV2luXSBNaXNjZWxsYW5lb3VzIFdpbmRvd3MgQ2xlYW51cHMKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvd2luL1BsdWdpbnMvUGx1Z2luVmlld1dpbi5jcHAgYi9Tb3Vy Y2UvV2ViS2l0L3dpbi9QbHVnaW5zL1BsdWdpblZpZXdXaW4uY3BwCmluZGV4IDAxMGVhZWQzNDAy ZmVkZDRiMzc2MzExMWNhMWE0NjY3MDliOGM3NDAuLmRiZWNjZmFkN2M4ZDA1YTZkYTYwMzAwNDc3 ZGNlOWU4YTE2ZDQ4OGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvd2luL1BsdWdpbnMvUGx1 Z2luVmlld1dpbi5jcHAKKysrIGIvU291cmNlL1dlYktpdC93aW4vUGx1Z2lucy9QbHVnaW5WaWV3 V2luLmNwcApAQCAtNDMsNiArNDMsNyBAQAogI2luY2x1ZGUgPFdlYkNvcmUvRnJhbWVMb2FkZXIu aD4KICNpbmNsdWRlIDxXZWJDb3JlL0ZyYW1lVHJlZS5oPgogI2luY2x1ZGUgPFdlYkNvcmUvRnJh bWVWaWV3Lmg+CisjaW5jbHVkZSA8V2ViQ29yZS9HRElVdGlsaXRpZXMuaD4KICNpbmNsdWRlIDxX ZWJDb3JlL0dyYXBoaWNzQ29udGV4dC5oPgogI2luY2x1ZGUgPFdlYkNvcmUvSFRNTE5hbWVzLmg+ CiAjaW5jbHVkZSA8V2ViQ29yZS9IVE1MUGx1Z0luRWxlbWVudC5oPgpAQCAtNjQzLDYgKzY0NCwx NiBAQCB2b2lkIFBsdWdpblZpZXc6OmhhbmRsZU1vdXNlRXZlbnQoTW91c2VFdmVudCogZXZlbnQp CiAgICAgICAgICAgICBucEV2ZW50LmV2ZW50ID0gV01fTUJVVFRPTkRPV047CiAgICAgICAgICAg ICBicmVhazsKICAgICAgICAgY2FzZSBSaWdodEJ1dHRvbjoKKyAgICAgICAgICAgIGZsb2F0IHNj YWxlRmFjdG9yOworICAgICAgICAgICAgaWYgKFBhZ2UqIHBhZ2UgPSBtX3BhcmVudEZyYW1lLT5w YWdlKCkpCisgICAgICAgICAgICAgICAgc2NhbGVGYWN0b3IgPSBwYWdlLT5kZXZpY2VTY2FsZUZh Y3RvcigpOworICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgIHNjYWxlRmFjdG9yID0g V2ViQ29yZTo6ZGV2aWNlU2NhbGVGYWN0b3JGb3JXaW5kb3cobnVsbHB0cik7CisKKyAgICAgICAg ICAgIEludFBvaW50IHBvaW50ID0gcDsKKyAgICAgICAgICAgIHBvaW50LnNjYWxlKHNjYWxlRmFj dG9yLCBzY2FsZUZhY3Rvcik7CisKKyAgICAgICAgICAgIG5wRXZlbnQubFBhcmFtID0gTUFLRUxQ QVJBTShwb2ludC54KCksIHBvaW50LnkoKSk7CiAgICAgICAgICAgICBucEV2ZW50LmV2ZW50ID0g V01fUkJVVFRPTkRPV047CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQo=