147997 2015-08-13 15:52:37 -0700 AppScale: Assertion hit when hovering a webkit-queue bubble 2017-03-15 17:14:21 -0700 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Minor --- 1 aakash_jain aakash_jain commit-queue oldest_to_newest 1117432 0 aakash_jain 2015-08-13 15:52:37 -0700 console.assert(this.statusPageURL === data.status_page); Steps to reproduce: 1. Open https://build.webkit.org/dashboard 2. Open Web Inspector 3. Hover a commit queue or EWS bubble. 1117450 1 258950 aakash_jain 2015-08-13 16:22:25 -0700 Created attachment 258950 Proposed patch 1117459 2 258950 ap 2015-08-13 16:34:31 -0700 Comment on attachment 258950 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=258950&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:136 > + console.assert(this.statusPageURL.replace(/.*?:\/\//g, "") === data.status_page.replace(/.*?:\/\//g, "")); This replace removes anything before a colon, which I think is incorrect. E.g. "foo://bar://baz".replace(/.*?:\/\//g, "") -> "baz". How about something like "/^https?://" ? 1117466 3 258954 aakash_jain 2015-08-13 16:48:53 -0700 Created attachment 258954 Proposed patch good point. made the change. 1117474 4 258954 commit-queue 2015-08-13 17:01:46 -0700 Comment on attachment 258954 Proposed patch Clearing flags on attachment: 258954 Committed r188419: <http://trac.webkit.org/changeset/188419> 1117475 5 commit-queue 2015-08-13 17:01:51 -0700 All reviewed patches have been landed. Closing bug. 258950 2015-08-13 16:22:25 -0700 2015-08-13 16:48:53 -0700 Proposed patch patch-assertion.txt text/plain 1524 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cgICAg IChyZXZpc2lvbiAxODg0MTEpCisrKyBUb29scy9DaGFuZ2VMb2cgICAgICh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMTMgQEAKKzIwMTUtMDgtMTMgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5A YXBwbGUuY29tPgorCisgICAgICAgIEFwcFNjYWxlOiBBc3NlcnRpb24gaGl0IHdoZW4gaG92ZXJp bmcgYSB3ZWJraXQtcXVldWUgYnViYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNDc5OTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL0J1YmJsZVF1ZXVlLmpzOgorICAgICAg ICAoQnViYmxlUXVldWUucHJvdG90eXBlLmxvYWREZXRhaWxlZFN0YXR1cyk6IFN0cmlwIG9mZiBo dHRwKHMpIGJlZm9yZSBhc3NlcnRpbmcuCisKIDIwMTUtMDgtMTMgIERld2VpIFpodSAgPGRld2Vp X3podUBhcHBsZS5jb20+CiAKICAgICAgICAgUnVuIGJlbmNobWFyayBjdXN0b21pemVkIERyb21h ZW8gc2hvdWxkIG5vdCBhc3N1bWUgdGhlcmUgaXMgYW4gaW50ZXJuZXQgY29ubmVjdGlvbi4KSW5k ZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1Ymxp Y19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL0J1YmJsZVF1ZXVlLmpzCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1s L2Rhc2hib2FyZC9TY3JpcHRzL0J1YmJsZVF1ZXVlLmpzICAgICAgICAocmV2aXNpb24gMTg4NDA0 KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVi bGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvQnViYmxlUXVldWUuanMgICAgICAgICh3b3JraW5n IGNvcHkpCkBAIC0xMzMsNyArMTMzLDcgQEAgQnViYmxlUXVldWUucHJvdG90eXBlID0gewogICAg ICAgICAgICAgICAgIH0pOwogICAgICAgICAgICAgfQogCi0gICAgICAgICAgICBjb25zb2xlLmFz c2VydCh0aGlzLnN0YXR1c1BhZ2VVUkwgPT09IGRhdGEuc3RhdHVzX3BhZ2UpOworICAgICAgICAg ICAgY29uc29sZS5hc3NlcnQodGhpcy5zdGF0dXNQYWdlVVJMLnJlcGxhY2UoLy4qPzpcL1wvL2cs ICIiKSA9PT0gZGF0YS5zdGF0dXNfcGFnZS5yZXBsYWNlKC8uKj86XC9cLy9nLCAiIikpOwogICAg ICAgICAgICAgdGhpcy5fY2hhcnRzUGFnZVVSTCA9IGRhdGEuY2hhcnRzX3BhZ2U7CiAKICAgICAg ICAgICAgIHRoaXMuX2xvYWRlZERldGFpbGVkU3RhdHVzID0gdHJ1ZTsK 258954 2015-08-13 16:48:53 -0700 2015-08-13 17:01:46 -0700 Proposed patch patch-assertion1.txt text/plain 1530 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cgICAg IChyZXZpc2lvbiAxODg0MTEpCisrKyBUb29scy9DaGFuZ2VMb2cgICAgICh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMTMgQEAKKzIwMTUtMDgtMTMgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5A YXBwbGUuY29tPgorCisgICAgICAgIEFwcFNjYWxlOiBBc3NlcnRpb24gaGl0IHdoZW4gaG92ZXJp bmcgYSB3ZWJraXQtcXVldWUgYnViYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNDc5OTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL0J1YmJsZVF1ZXVlLmpzOgorICAgICAg ICAoQnViYmxlUXVldWUucHJvdG90eXBlLmxvYWREZXRhaWxlZFN0YXR1cyk6IFN0cmlwIG9mZiBo dHRwKHMpIGJlZm9yZSBhc3NlcnRpbmcuCisKIDIwMTUtMDgtMTMgIERld2VpIFpodSAgPGRld2Vp X3podUBhcHBsZS5jb20+CiAKICAgICAgICAgUnVuIGJlbmNobWFyayBjdXN0b21pemVkIERyb21h ZW8gc2hvdWxkIG5vdCBhc3N1bWUgdGhlcmUgaXMgYW4gaW50ZXJuZXQgY29ubmVjdGlvbi4KSW5k ZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1Ymxp Y19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL0J1YmJsZVF1ZXVlLmpzCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1s L2Rhc2hib2FyZC9TY3JpcHRzL0J1YmJsZVF1ZXVlLmpzICAgICAgICAocmV2aXNpb24gMTg4NDA0 KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVi bGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvQnViYmxlUXVldWUuanMgICAgICAgICh3b3JraW5n IGNvcHkpCkBAIC0xMzMsNyArMTMzLDcgQEAgQnViYmxlUXVldWUucHJvdG90eXBlID0gewogICAg ICAgICAgICAgICAgIH0pOwogICAgICAgICAgICAgfQogCi0gICAgICAgICAgICBjb25zb2xlLmFz c2VydCh0aGlzLnN0YXR1c1BhZ2VVUkwgPT09IGRhdGEuc3RhdHVzX3BhZ2UpOworICAgICAgICAg ICAgY29uc29sZS5hc3NlcnQodGhpcy5zdGF0dXNQYWdlVVJMLnJlcGxhY2UoL2h0dHBzPzpcL1wv L2csICIiKSA9PT0gZGF0YS5zdGF0dXNfcGFnZS5yZXBsYWNlKC9odHRwcz86XC9cLy9nLCAiIikp OwogICAgICAgICAgICAgdGhpcy5fY2hhcnRzUGFnZVVSTCA9IGRhdGEuY2hhcnRzX3BhZ2U7CiAK ICAgICAgICAgICAgIHRoaXMuX2xvYWRlZERldGFpbGVkU3RhdHVzID0gdHJ1ZTsK