147971 2015-08-12 23:19:00 -0700 REGRESSION (r188325): Web Inspector: Fix vertical spacing in CodeMirror 2015-08-13 04:50:09 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 nvasilyev nvasilyev bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1117190 0 nvasilyev 2015-08-12 23:19:00 -0700 Via https://bugs.webkit.org/show_bug.cgi?id=147109#c10 1117192 1 nvasilyev 2015-08-12 23:40:23 -0700 .CodeMirror pre { line-height: inherit; } Computed line-height for ".CodeMirror pre" has changed from 11px to 13px. Our new jump to definition feature isn't helpful here — it just highlights "line-height: inherit;". 1117193 2 nvasilyev 2015-08-12 23:53:48 -0700 https://github.com/WebKit/webkit/commit/860334772804d47022a6cbdafd633449fb0d124c#diff-e529b55c5da3924f8dedf9a33ba0708bL112 .CodeMirror { - line-height: 1; This caused the change in the line-height from 11 to 13px. 1117201 3 258883 nvasilyev 2015-08-13 00:22:31 -0700 Created attachment 258883 Patch 1117213 4 258883 commit-queue 2015-08-13 04:50:06 -0700 Comment on attachment 258883 Patch Clearing flags on attachment: 258883 Committed r188382: <http://trac.webkit.org/changeset/188382> 1117214 5 commit-queue 2015-08-13 04:50:09 -0700 All reviewed patches have been landed. Closing bug. 258883 2015-08-13 00:22:31 -0700 2015-08-13 04:50:06 -0700 Patch patch.txt text/plain 1492 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGM0MmRkZTEuLmM0OWRkNDEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTA4LTEyICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIxODgzMjUp OiBXZWIgSW5zcGVjdG9yOiBGaXggdmVydGljYWwgc3BhY2luZyBpbiBDb2RlTWlycm9yCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDc5NzEKKworICAg ICAgICByMTg4MzI1IGluY2Vhc2VkIGxpbmUtaGVpZ2h0IGJ5IDJweC4gUmVtb3ZlIHRvcCBhbmQg Ym90dG9tIDFweCBwYWRkaW5nCisgICAgICAgIHRvIGNvbXBlbnNhdGUgZm9yIGxpbmUtaGVpZ2h0 IGNoYW5nZXMuCisKKyAgICAgICAgSW4gdGhlIGZlYXR1cmUgd2UgbWF5IGhpZ2hsaWdodCB0aGUg YmFja2dyb3VkIG9mIHRleHQgdG9rZW5zIChlLmcuIGZvciB0aGUKKyAgICAgICAgaGVhdG1hcCBw cm9maWxlcikgc28gd2Ugd291bGQgd2FudCB0byBnZXQgcmlkIG9mIHRoZSBnYXBzIGJldHdlZW4g dGhlIGxpbmVzCisgICAgICAgIChjYXVzZWQgYnkgdGhlIHBhZGRpbmQpIHJlZ2FyZGxlc3Mgb2Yg dGhpcyByZWdyZXNzaW9uLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9Db2RlTWlycm9yT3ZlcnJpZGVzLmNzczoK KyAgICAgICAgKC5Db2RlTWlycm9yIHByZSk6CisKIDIwMTUtMDgtMTIgIEpvc2VwaCBQZWNvcmFy byAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBTb21ldGlt ZXMgQ1NTIHJlc291cmNlcyBkb24ndCB1cGRhdGUgYWZ0ZXIgZWRpdGluZyB2aWEgU3R5bGVzIHBh bmVsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9Db2RlTWlycm9yT3ZlcnJpZGVzLmNzcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL0NvZGVNaXJyb3JPdmVycmlkZXMuY3NzCmluZGV4IGM3YzAxNDUuLjc0NjZh M2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L0NvZGVNaXJyb3JPdmVycmlkZXMuY3NzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0NvZGVNaXJyb3JPdmVycmlkZXMuY3NzCkBAIC0zOCw3ICszOCw3IEBA CiB9CiAKIC5Db2RlTWlycm9yIHByZSB7Ci0gICAgcGFkZGluZzogMXB4IDNweCAxcHggN3B4Owor ICAgIHBhZGRpbmc6IDAgM3B4IDAgN3B4OwogfQogCiAuQ29kZU1pcnJvciAuQ29kZU1pcnJvci1z ZWxlY3RlZCB7Cg==