147970 2015-08-12 23:15:38 -0700 FilterOperation.h should not include FilterEffect.h 2016-03-28 10:53:27 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser commit-queue dino kondapallykalyan ossy simon.fraser oldest_to_newest 1117187 0 simon.fraser 2015-08-12 23:15:38 -0700 FilterOperation.h should not include FilterEffect.h 1117188 1 258880 simon.fraser 2015-08-12 23:17:04 -0700 Created attachment 258880 Patch 1117195 2 ap 2015-08-13 00:02:49 -0700 iOS is red. 1117241 3 258880 dbates 2015-08-13 09:31:39 -0700 Comment on attachment 258880 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258880&action=review > Source/WebCore/platform/graphics/filters/FilterOperation.cpp:69 > +void ReferenceFilterOperation::setFilterEffect(PassRefPtr<FilterEffect> filterEffect) We should change PassRefPtr<> to RefPtr<>&&. This can be done in a separate bug. 1117446 4 simon.fraser 2015-08-13 16:16:20 -0700 http://trac.webkit.org/changeset/188389 1117738 5 ossy 2015-08-14 13:17:49 -0700 (In reply to comment #4) > http://trac.webkit.org/changeset/188389 It broke the EFL build. 258880 2015-08-12 23:17:04 -0700 2016-03-28 10:53:27 -0700 Patch bug-147970-20150812231647.patch text/plain 3215 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4MzczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzkwMDA1ZjkwYWIxOGY2 M2RlMTM3MDgxODkwZTE1ODViNTY3ZDZkMC4uNGI3ZTVkZjU0MTExZmY2MmFkMzdjODhlOWNkZjYx OTdmZDA0ZTQ5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTA4LTEyICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEZpbHRlck9wZXJh dGlvbi5oIHNob3VsZCBub3QgaW5jbHVkZSBGaWx0ZXJFZmZlY3QuaAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ3OTcwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRmlsdGVyRWZmZWN0LmggcHVsbHMgaW4g bG90cyBvZiBKU0MgZ29vcCB2aWEgcnVudGltZS9VaW50OENsYW1wZWRBcnJheS5oLAorICAgICAg ICBzbyBtb3ZlIGl0cyBpbmNsdWRlIHRvIEZpbHRlck9wZXJhdGlvbi5jcHAuCisgICAgICAgIAor ICAgICAgICBDYXVzZXMgaW5jbHVkZSBibG9hdCBiZWNhdXNlIEZpbHRlck9wZXJhdGlvbi5oIGlz IHB1bGxlZCBpbiB2aWEgUmVuZGVyU3R5bGUuaC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2ZpbHRlcnMvRmlsdGVyT3BlcmF0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlZmVy ZW5jZUZpbHRlck9wZXJhdGlvbjo6c2V0RmlsdGVyRWZmZWN0KToKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9maWx0ZXJzL0ZpbHRlck9wZXJhdGlvbi5oOgorICAgICAgICAoV2ViQ29yZTo6 UmVmZXJlbmNlRmlsdGVyT3BlcmF0aW9uOjpzZXRGaWx0ZXJFZmZlY3QpOiBEZWxldGVkLgorCiAy MDE1LTA4LTEyICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAg IE1vdmUgUmVuZGVyQm94LXNwZWNpZmljIFNjcm9sbCBTbmFwIGNvZGUgZnJvbSBSZW5kZXJFbGVt ZW50IHRvIFJlbmRlckJveApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZmlsdGVycy9GaWx0ZXJPcGVyYXRpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZmlsdGVycy9GaWx0ZXJPcGVyYXRpb24uY3BwCmluZGV4IGIxODllMTRjZGNi NjRkZmE5Y2EyYTk1ZTE1ZjA2YTg0YTU5ZjdhMjMuLjFhMjEwYzU2Y2VkNWU1Yjg5MmNjNDkyZWU4 YmI5OTE2NmZmODVmMzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2ZpbHRlcnMvRmlsdGVyT3BlcmF0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0ZpbHRlck9wZXJhdGlvbi5jcHAKQEAgLTI4LDYgKzI4LDcg QEAKIAogI2luY2x1ZGUgIkFuaW1hdGlvblV0aWxpdGllcy5oIgogI2luY2x1ZGUgIkNhY2hlZFNW R0RvY3VtZW50UmVmZXJlbmNlLmgiCisjaW5jbHVkZSAiRmlsdGVyRWZmZWN0LmgiCiAKIG5hbWVz cGFjZSBXZWJDb3JlIHsKICAgICAKQEAgLTY1LDYgKzY2LDExIEBAIENhY2hlZFNWR0RvY3VtZW50 UmVmZXJlbmNlKiBSZWZlcmVuY2VGaWx0ZXJPcGVyYXRpb246OmdldE9yQ3JlYXRlQ2FjaGVkU1ZH RG9jdW1lCiAgICAgcmV0dXJuIG1fY2FjaGVkU1ZHRG9jdW1lbnRSZWZlcmVuY2UuZ2V0KCk7CiB9 CiAKK3ZvaWQgUmVmZXJlbmNlRmlsdGVyT3BlcmF0aW9uOjpzZXRGaWx0ZXJFZmZlY3QoUGFzc1Jl ZlB0cjxGaWx0ZXJFZmZlY3Q+IGZpbHRlckVmZmVjdCkKK3sKKyAgICBtX2ZpbHRlckVmZmVjdCA9 IGZpbHRlckVmZmVjdDsKK30KKwogUGFzc1JlZlB0cjxGaWx0ZXJPcGVyYXRpb24+IEJhc2ljQ29s b3JNYXRyaXhGaWx0ZXJPcGVyYXRpb246OmJsZW5kKGNvbnN0IEZpbHRlck9wZXJhdGlvbiogZnJv bSwgZG91YmxlIHByb2dyZXNzLCBib29sIGJsZW5kVG9QYXNzdGhyb3VnaCkKIHsKICAgICBpZiAo ZnJvbSAmJiAhZnJvbS0+aXNTYW1lVHlwZSgqdGhpcykpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0ZpbHRlck9wZXJhdGlvbi5oIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9GaWx0ZXJPcGVyYXRpb24uaAppbmRl eCBkZmI3NDZhOGIwNWFjM2RlZDlmOTk2ZDJmNGYzY2Q4NGIzMzVkMTQzLi4yMmQ4NDBmM2Y2Nzdl ZTI1YjE4MDY4YzI3MmFmYWRmMDJjZTljZDgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0ZpbHRlck9wZXJhdGlvbi5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvRmlsdGVyT3BlcmF0aW9uLmgKQEAgLTI3 LDcgKzI3LDYgQEAKICNkZWZpbmUgRmlsdGVyT3BlcmF0aW9uX2gKIAogI2luY2x1ZGUgIkNvbG9y LmgiCi0jaW5jbHVkZSAiRmlsdGVyRWZmZWN0LmgiCiAjaW5jbHVkZSAiTGF5b3V0U2l6ZS5oIgog I2luY2x1ZGUgIkxlbmd0aC5oIgogI2luY2x1ZGUgPHd0Zi9SZWZDb3VudGVkLmg+CkBAIC00NCw2 ICs0Myw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIC8vIENTUyBGaWx0ZXJzCiAKIGNsYXNzIENh Y2hlZFNWR0RvY3VtZW50UmVmZXJlbmNlOworY2xhc3MgRmlsdGVyRWZmZWN0OwogCiBjbGFzcyBG aWx0ZXJPcGVyYXRpb24gOiBwdWJsaWMgUmVmQ291bnRlZDxGaWx0ZXJPcGVyYXRpb24+IHsKIHB1 YmxpYzoKQEAgLTE4OCw3ICsxODgsNyBAQCBwdWJsaWM6CiAgICAgQ2FjaGVkU1ZHRG9jdW1lbnRS ZWZlcmVuY2UqIGdldE9yQ3JlYXRlQ2FjaGVkU1ZHRG9jdW1lbnRSZWZlcmVuY2UoKTsKIAogICAg IEZpbHRlckVmZmVjdCogZmlsdGVyRWZmZWN0KCkgY29uc3QgeyByZXR1cm4gbV9maWx0ZXJFZmZl Y3QuZ2V0KCk7IH0KLSAgICB2b2lkIHNldEZpbHRlckVmZmVjdChQYXNzUmVmUHRyPEZpbHRlckVm ZmVjdD4gZmlsdGVyRWZmZWN0KSB7IG1fZmlsdGVyRWZmZWN0ID0gZmlsdGVyRWZmZWN0OyB9Cisg ICAgdm9pZCBzZXRGaWx0ZXJFZmZlY3QoUGFzc1JlZlB0cjxGaWx0ZXJFZmZlY3Q+KTsKIAogcHJp dmF0ZToKICAgICBSZWZlcmVuY2VGaWx0ZXJPcGVyYXRpb24oY29uc3QgU3RyaW5nJiB1cmwsIGNv bnN0IFN0cmluZyYgZnJhZ21lbnQpOwo=