147963 2015-08-12 17:42:16 -0700 Move RenderBox-specific Scroll Snap code from RenderElement to RenderBox 2015-08-12 19:22:55 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 147596 1 bfulgham bfulgham bfulgham commit-queue esprehn+autocc glenn kondapallykalyan zalan oldest_to_newest 1117113 0 bfulgham 2015-08-12 17:42:16 -0700 Certain scroll snap routines were added to RenderElement before we decided that this code only applied to RenderBoxes. Rather than adding type checking in RenderElement to handle these objects, only do the RenderBox-specific logic in the RenderBox class. 1117118 1 258863 bfulgham 2015-08-12 17:49:24 -0700 Created attachment 258863 Patch 1117126 2 bfulgham 2015-08-12 18:20:44 -0700 Committed r188370: <http://trac.webkit.org/changeset/188370> 1117131 3 258863 zalan 2015-08-12 18:32:32 -0700 Comment on attachment 258863 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258863&action=review > Source/WebCore/rendering/RenderBox.h:638 > + void willBeRemovedFromTree() override; I'd write out 'virtual' here. 1117152 4 bfulgham 2015-08-12 19:20:20 -0700 (In reply to comment #3) > Comment on attachment 258863 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=258863&action=review > > > Source/WebCore/rendering/RenderBox.h:638 > > + void willBeRemovedFromTree() override; > > I'd write out 'virtual' here. Darin says we don't do that anymore. It's redundant with the 'override' declaration. 1117153 5 258863 zalan 2015-08-12 19:22:55 -0700 Comment on attachment 258863 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258863&action=review >>> Source/WebCore/rendering/RenderBox.h:638 >>> + void willBeRemovedFromTree() override; >> >> I'd write out 'virtual' here. > > Darin says we don't do that anymore. It's redundant with the 'override' declaration. Ok, thanks. Good to know. 258863 2015-08-12 17:49:24 -0700 2015-08-12 18:17:10 -0700 Patch bug-147963-20150812174907.patch text/plain 4388 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4ODM2NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE1LTA4LTEyICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIE1vdmUgUmVuZGVyQm94LXNw ZWNpZmljIFNjcm9sbCBTbmFwIGNvZGUgZnJvbSBSZW5kZXJFbGVtZW50IHRvIFJlbmRlckJveAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ3OTYzCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzOiBObyBjaGFuZ2UgaW4gZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIHJlbmRlcmluZy9S ZW5kZXJCb3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQm94OjpzdHlsZVdpbGxDaGFu Z2UpOiBSZW1vdmUgUmVuZGVyQm94LXNwZWNpZmljIGNvZGUuCisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJCb3g6OndpbGxCZVJlbW92ZWRGcm9tVHJlZSk6IERpdHRvLgorICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJCb3guaDoKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyRWxlbWVudC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJFbGVtZW50OjpzdHlsZVdpbGxDaGFuZ2UpOiBNb3Zl IGNvZGUgZnJvbSBSZW5kZXJFbGVtZW50IHRvCisgICAgICAgIGhhbmRsZSBTY3JvbGwgU25hcCBQ b2ludHMuCisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJFbGVtZW50Ojp3aWxsQmVSZW1vdmVkRnJv bVRyZWUpOiBBZGRlZCBuZXcgb3ZlcnJpZGUgdG8gaGFuZGxlCisgICAgICAgIHNjcm9sbC1zbmFw IHBvaW50IGxvZ2ljLgorCiAyMDE1LTA4LTEyICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxl LmNvbT4KIAogICAgICAgICBDYWNoZWRSZXNvdXJjZSBsZWFrIGluIHZhbGlkYXRpb24gY29kZQpJ bmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAJKHJldmlzaW9uIDE4ODM1 MCkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0zMTIsNiArMzEyLDE1IEBAIHZvaWQgUmVuZGVyQm94OjpzdHlsZVdpbGxDaGFuZ2Uo U3R5bGVEaWYKICAgICB9IGVsc2UgaWYgKGlzQm9keSgpKQogICAgICAgICB2aWV3KCkucmVwYWlu dFJvb3RDb250ZW50cygpOwogCisjaWYgRU5BQkxFKENTU19TQ1JPTExfU05BUCkKKyAgICBpZiAo IW5ld1N0eWxlLnNjcm9sbFNuYXBDb29yZGluYXRlcygpLmlzRW1wdHkoKSB8fCAob2xkU3R5bGUg JiYgIW9sZFN0eWxlLT5zY3JvbGxTbmFwQ29vcmRpbmF0ZXMoKS5pc0VtcHR5KCkpKSB7CisgICAg ICAgIGlmIChuZXdTdHlsZS5zY3JvbGxTbmFwQ29vcmRpbmF0ZXMoKS5pc0VtcHR5KCkpCisgICAg ICAgICAgICB2aWV3KCkudW5yZWdpc3RlckJveFdpdGhTY3JvbGxTbmFwQ29vcmRpbmF0ZXMoKnRo aXMpOworICAgICAgICBlbHNlCisgICAgICAgICAgICB2aWV3KCkucmVnaXN0ZXJCb3hXaXRoU2Ny b2xsU25hcENvb3JkaW5hdGVzKCp0aGlzKTsKKyAgICB9CisjZW5kaWYKKwogICAgIFJlbmRlckJv eE1vZGVsT2JqZWN0OjpzdHlsZVdpbGxDaGFuZ2UoZGlmZiwgbmV3U3R5bGUpOwogfQogCkBAIC00 MjksNiArNDM4LDE3IEBAIHZvaWQgUmVuZGVyQm94OjpzdHlsZURpZENoYW5nZShTdHlsZURpZmYK ICNlbmRpZgogfQogCit2b2lkIFJlbmRlckJveDo6d2lsbEJlUmVtb3ZlZEZyb21UcmVlKCkKK3sK KyNpZiBFTkFCTEUoQ1NTX1NDUk9MTF9TTkFQKQorICAgIGlmIChoYXNJbml0aWFsaXplZFN0eWxl KCkgJiYgIXN0eWxlKCkuc2Nyb2xsU25hcENvb3JkaW5hdGVzKCkuaXNFbXB0eSgpKQorICAgICAg ICB2aWV3KCkudW5yZWdpc3RlckJveFdpdGhTY3JvbGxTbmFwQ29vcmRpbmF0ZXMoKnRoaXMpOwor I2VuZGlmCisgICAgCisgICAgUmVuZGVyQm94TW9kZWxPYmplY3Q6OndpbGxCZVJlbW92ZWRGcm9t VHJlZSgpOworfQorICAgIAorCiAjaWYgRU5BQkxFKENTU19TSEFQRVMpCiB2b2lkIFJlbmRlckJv eDo6dXBkYXRlU2hhcGVPdXRzaWRlSW5mb0FmdGVyU3R5bGVDaGFuZ2UoY29uc3QgUmVuZGVyU3R5 bGUmIHN0eWxlLCBjb25zdCBSZW5kZXJTdHlsZSogb2xkU3R5bGUpCiB7CkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckJveC5oCShyZXZpc2lvbiAxODgzNTApCisrKyBTb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmgJKHdvcmtpbmcgY29weSkKQEAgLTYzNSw2ICs2MzUs OCBAQCBwcm90ZWN0ZWQ6CiAgICAgdmlydHVhbCB2b2lkIHN0eWxlRGlkQ2hhbmdlKFN0eWxlRGlm ZmVyZW5jZSwgY29uc3QgUmVuZGVyU3R5bGUqIG9sZFN0eWxlKSBvdmVycmlkZTsKICAgICB2aXJ0 dWFsIHZvaWQgdXBkYXRlRnJvbVN0eWxlKCkgb3ZlcnJpZGU7CiAKKyAgICB2b2lkIHdpbGxCZVJl bW92ZWRGcm9tVHJlZSgpIG92ZXJyaWRlOworCiAgICAgYm9vbCBjcmVhdGVzTmV3Rm9ybWF0dGlu Z0NvbnRleHQoKSBjb25zdDsKIAogICAgIC8vIFJldHVybnMgZmFsc2UgaWYgaXQgY291bGQgbm90 IGNoZWFwbHkgY29tcHV0ZSB0aGUgZXh0ZW50IChlLmcuIGZpeGVkIGJhY2tncm91bmQpLCBpbiB3 aGljaCBjYXNlIHRoZSByZXR1cm5lZCByZWN0IG1heSBiZSBpbmNvcnJlY3QuCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckVsZW1lbnQuY3BwCShyZXZpc2lvbiAxODgzNTAp CisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRWxlbWVudC5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTg5OSwxNyArODk5LDYgQEAgdm9pZCBSZW5kZXJFbGVtZW50OjpzdHlsZVdpbGxD aGFuZ2UoU3R5bAogICAgICAgICB9CiAgICAgfQogCi0jaWYgRU5BQkxFKENTU19TQ1JPTExfU05B UCkKLSAgICBpZiAoIW5ld1N0eWxlLnNjcm9sbFNuYXBDb29yZGluYXRlcygpLmlzRW1wdHkoKSB8 fCAob2xkU3R5bGUgJiYgIW9sZFN0eWxlLT5zY3JvbGxTbmFwQ29vcmRpbmF0ZXMoKS5pc0VtcHR5 KCkpKSB7Ci0gICAgICAgIGlmIChpczxSZW5kZXJCb3g+KCp0aGlzKSkgewotICAgICAgICAgICAg aWYgKG5ld1N0eWxlLnNjcm9sbFNuYXBDb29yZGluYXRlcygpLmlzRW1wdHkoKSkKLSAgICAgICAg ICAgICAgICB2aWV3KCkudW5yZWdpc3RlckJveFdpdGhTY3JvbGxTbmFwQ29vcmRpbmF0ZXMoZG93 bmNhc3Q8UmVuZGVyQm94PigqdGhpcykpOwotICAgICAgICAgICAgZWxzZQotICAgICAgICAgICAg ICAgIHZpZXcoKS5yZWdpc3RlckJveFdpdGhTY3JvbGxTbmFwQ29vcmRpbmF0ZXMoZG93bmNhc3Q8 UmVuZGVyQm94PigqdGhpcykpOwotICAgICAgICB9Ci0gICAgfQotI2VuZGlmCi0KICAgICBpZiAo aXNSb290KCkgfHwgaXNCb2R5KCkpCiAgICAgICAgIHZpZXcoKS5mcmFtZVZpZXcoKS51cGRhdGVF eHRlbmRCYWNrZ3JvdW5kSWZOZWNlc3NhcnkoKTsKIH0KQEAgLTEwNjQsMTQgKzEwNTMsNiBAQCB2 b2lkIFJlbmRlckVsZW1lbnQ6OndpbGxCZVJlbW92ZWRGcm9tVHJlCiAgICAgaWYgKGF1dG8qIGNv bnRhaW5lckZsb3dUaHJlYWQgPSBwYXJlbnQoKS0+cmVuZGVyTmFtZWRGbG93VGhyZWFkV3JhcHBl cigpKQogICAgICAgICBjb250YWluZXJGbG93VGhyZWFkLT5yZW1vdmVGbG93Q2hpbGQoKnRoaXMp OwogCi0gICAgCi0jaWYgRU5BQkxFKENTU19TQ1JPTExfU05BUCkKLSAgICBpZiAoIW1fc3R5bGUt PnNjcm9sbFNuYXBDb29yZGluYXRlcygpLmlzRW1wdHkoKSkgewotICAgICAgICBpZiAoaXM8UmVu ZGVyQm94PigqdGhpcykpCi0gICAgICAgICAgICB2aWV3KCkudW5yZWdpc3RlckJveFdpdGhTY3Jv bGxTbmFwQ29vcmRpbmF0ZXMoZG93bmNhc3Q8UmVuZGVyQm94PigqdGhpcykpOwotICAgIH0KLSNl bmRpZgotCiAgICAgUmVuZGVyT2JqZWN0Ojp3aWxsQmVSZW1vdmVkRnJvbVRyZWUoKTsKIH0KIAo=