147950 2015-08-12 13:31:29 -0700 DFG::ByteCodeParser should attempt constant folding on loads from structures that are DFG-watchable 2015-08-12 14:02:04 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo oldest_to_newest 1117042 0 fpizlo 2015-08-12 13:31:29 -0700 We accidentally broke the ByteCodeParser's constant folding of loads from constants with DFG-watchable structures in http://trac.webkit.org/changeset/188292. The constant folding would happen later, but there are some constant folding rules that only the ByteCodeParser is capable of, particularly with things like CreateThis. 1117046 1 258842 fpizlo 2015-08-12 13:38:50 -0700 Created attachment 258842 the patch 1117048 2 258842 msaboff 2015-08-12 13:41:00 -0700 Comment on attachment 258842 the patch r=me 1117060 3 fpizlo 2015-08-12 14:02:04 -0700 Landed in http://trac.webkit.org/changeset/188357 258842 2015-08-12 13:38:50 -0700 2015-08-12 13:41:00 -0700 the patch blah.patch text/plain 2733 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg4MzU0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBA CisyMDE1LTA4LTEyICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHOjpCeXRlQ29kZVBhcnNlciBzaG91bGQgYXR0ZW1wdCBjb25zdGFudCBmb2xkaW5nIG9uIGxv YWRzIGZyb20gc3RydWN0dXJlcyB0aGF0IGFyZSBERkctd2F0Y2hhYmxlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDc5NTAKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQcmV2aW91c2x5IHdlIHJlZHVjZWQg dGhlIGNvbnN0YW50IGZvbGRpbmcgcG93ZXIgb2YgQnl0ZUNvZGVQYXJzZXI6OmxvYWQoKSBiZWNh dXNlIHRoYXQgY29kZSB3YXMKKyAgICAgICAgcmVzcG9uc2libGUgZm9yIG1lbW9yeSBjb3JydXB0 aW9uLCBzaW5jZSBpdCB3b3VsZCBzb21ldGltZXMgaW5zdGFsbCB3YXRjaHBvaW50cyBvbiBzdHJ1 Y3R1cmVzIHRoYXQKKyAgICAgICAgd2VyZW4ndCBiZWluZyB0cmFjZWQuICBJdCBzZWVtZWQgbGlr ZSB0aGUgc2FmZXN0IGZpeCB3YXMgdG8gcmVtb3ZlIHRoZSBjb25zdGFudCBmb2xkaW5nIHJ1bGUK KyAgICAgICAgZW50aXJlbHkgc2luY2UgbGF0ZXIgcGhhc2VzIGFsc28gZG8gY29uc3RhbnQgZm9s ZGluZywgYW5kIHRoZXkgZG8gaXQgd2l0aG91dCBpbnRyb2R1Y2luZyB0aGUgYnVnLgorICAgICAg ICBXZWxsLCB0aGF0IGNoYW5nZSAoaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMTg4 MjkyKSBjYXVzZWQgYSBiaWcgcmVncmVzc2lvbiwgYmVjYXVzZSB3ZQorICAgICAgICBzdGlsbCBo YXZlIHNvbWUgY29uc3RhbnQgZm9sZGluZyBydWxlcyB0aGF0IG9ubHkgZXhpc3QgaW4gQnl0ZUNv ZGVQYXJzZXIsIGFuZCBzbyBCeXRlQ29kZVBhcnNlciBtdXN0CisgICAgICAgIGJlIG1heGltYWxs eSBhZ2dyZXNzaXZlIGluIGNvbnN0YW50LWZvbGRpbmcgd2hlbmV2ZXIgcG9zc2libGUuCisKKyAg ICAgICAgU28sIHRoaXMgY2hhbmdlIG5vdyBicmluZ3MgYmFjayB0aGF0IGNvbnN0YW50IGZvbGRp bmcgcnVsZSAtIGZvciBsb2FkcyBmcm9tIG9iamVjdCBjb25zdGFudHMgdGhhdAorICAgICAgICBo YXZlIERGRy13YXRjaGFibGUgc3RydWN0dXJlcyAtIGFuZCBpbXBsZW1lbnRzIGl0IHByb3Blcmx5 LCBieSBlbnN1cmluZyB0aGF0IHdlIG9ubHkgY2FsbCBpbnRvCisgICAgICAgIHRyeUdldENvbnN0 YW50UHJvcGVydHkoKSBpZiB3ZSBoYXZlIHJlZ2lzdGVyZWQgdGhlIHN0cnVjdHVyZSBzZXQuCisK KyAgICAgICAgKiBkZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwOgorICAgICAgICAoSlNDOjpERkc6 OkJ5dGVDb2RlUGFyc2VyOjpsb2FkKToKKwogMjAxNS0wOC0xMiAgR2VvZmZyZXkgR2FyZW4gIDxn Z2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJlLWxhbmQgcjE4ODMzOSwgc2luY2UgQWxleCBm aXhlZCBpdCBpbiByMTg4MzQxIGJ5IGxhbmRpbmcgdGhlIFdlYkNvcmUgaGFsZi4KSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwCShyZXZp c2lvbiAxODgzNDgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0J5dGVDb2RlUGFy c2VyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjU4MSw2ICsyNTgxLDE1IEBAIE5vZGUqIEJ5dGVD b2RlUGFyc2VyOjpsb2FkKAogICAgIGlmICghdmFyaWFudC5jb25kaXRpb25TZXQoKS5pc0VtcHR5 KCkpCiAgICAgICAgIGxvYWRlZFZhbHVlID0gbG9hZChsb2FkUHJlZGljdGlvbiwgdmFyaWFudC5j b25kaXRpb25TZXQoKSwgbG9hZE9wKTsKICAgICBlbHNlIHsKKyAgICAgICAgaWYgKG5lZWRTdHJ1 Y3R1cmVDaGVjayAmJiBiYXNlLT5oYXNDb25zdGFudCgpKSB7CisgICAgICAgICAgICAvLyBXZSBk aWQgZW1pdCBhIHN0cnVjdHVyZSBjaGVjay4gVGhhdCBtZWFucyB0aGF0IHdlIGhhdmUgYW4gb3Bw b3J0dW5pdHkgdG8gZG8gY29uc3RhbnQgZm9sZGluZworICAgICAgICAgICAgLy8gaGVyZSwgc2lu Y2Ugd2UgZGlkbid0IGRvIGl0IGFib3ZlLgorICAgICAgICAgICAgSlNWYWx1ZSBjb25zdGFudCA9 IG1fZ3JhcGgudHJ5R2V0Q29uc3RhbnRQcm9wZXJ0eSgKKyAgICAgICAgICAgICAgICBiYXNlLT5h c0pTVmFsdWUoKSwgdmFyaWFudC5zdHJ1Y3R1cmVTZXQoKSwgdmFyaWFudC5vZmZzZXQoKSk7Cisg ICAgICAgICAgICBpZiAoY29uc3RhbnQpCisgICAgICAgICAgICAgICAgcmV0dXJuIHdlYWtKU0Nv bnN0YW50KGNvbnN0YW50KTsKKyAgICAgICAgfQorICAgICAgICAKICAgICAgICAgbG9hZGVkVmFs dWUgPSBoYW5kbGVHZXRCeU9mZnNldCgKICAgICAgICAgICAgIGxvYWRQcmVkaWN0aW9uLCBiYXNl LCBpZGVudGlmaWVyTnVtYmVyLCB2YXJpYW50Lm9mZnNldCgpLCBsb2FkT3ApOwogICAgIH0K