147948 2015-08-12 13:04:34 -0700 Web Inspector: CRASH under WebInspector::closeFrontend for some protocol tests 2015-08-12 16:03:05 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 147954 1 bburg bburg bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1117029 0 bburg 2015-08-12 13:04:34 -0700 I think this is happening during teardown in some protocol tests, though I can't exactly pinpoint the conditions for reproducing the crash. It has not been appearing on the bots, but I have run into it hard in my current work on <https://webkit.org/b/147934> NOTES: The WKTR harness automatically calls WKInspectorClose at the end of a test run, but the real inspector may not have been opened at that point. Regardless, it sends a WebInspector::Close message on the frontend connection, which may have not been initialized. I think this can be solved with an early exit in WebInspector::closeFrontend(). 1117030 1 bburg 2015-08-12 13:04:58 -0700 <rdar://problem/18545278> 1117067 2 258846 bburg 2015-08-12 14:17:02 -0700 Created attachment 258846 Proposed Fix 1117069 3 bburg 2015-08-12 14:31:09 -0700 Adding this as a blocking bug, since it seems to be triggered by the refactoring. 1117076 4 258846 joepeck 2015-08-12 15:12:14 -0700 Comment on attachment 258846 Proposed Fix r=me 1117084 5 258846 commit-queue 2015-08-12 16:03:02 -0700 Comment on attachment 258846 Proposed Fix Clearing flags on attachment: 258846 Committed r188362: <http://trac.webkit.org/changeset/188362> 1117085 6 commit-queue 2015-08-12 16:03:05 -0700 All reviewed patches have been landed. Closing bug. 258846 2015-08-12 14:17:02 -0700 2015-08-12 16:03:02 -0700 Proposed Fix bug-147948-20150812141644.patch text/plain 2672 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4MzUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzVjNzdlOWEwNzY4YWZi YTRjMmZiNDc1MTJkOTJlN2RmYzIxMzc4Zi4uMzU4NjJiOWMzNmEzMjY4NWRmYWQzOTRkOTc1Y2E0 MWRmMjU4MzY1OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA4LTEyICBCcmlh biBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IENSQVNI IHVuZGVyIFdlYkluc3BlY3Rvcjo6Y2xvc2VGcm9udGVuZCBmb3Igc29tZSBwcm90b2NvbCB0ZXN0 cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ3OTQ4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQ cm9jZXNzL1dlYlBhZ2UvV2ViSW5zcGVjdG9yLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViSW5z cGVjdG9yOjpjbG9zZUZyb250ZW5kKTogRG9uJ3QgaW52YWxpZGF0ZSB0aGUgY2hhbm5lbCBpZiBp dCdzIG51bGwuCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkluc3BlY3Rvci5oOiBB ZGQgZGVmYXVsdCBtZW1iZXIgdmFyaWFibGUgdmFsdWVzLgorCiAyMDE1LTA4LTEyICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CiAKICAgICAgICAgRWxlbWVudCBpbnRlcmFjdGlv biBzaG91bGQgbm90IGJlIGNhbmNlbGVkIHdoZW4gdGhlIG1lbnUgaXMgYWxyZWFkeSBiZWluZyBz aG93bi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJJ bnNwZWN0b3IuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkluc3Bl Y3Rvci5jcHAKaW5kZXggOTA1MWY5OGRhZDA1M2YyYWFjYmEzNTkyZGVkMzQyMTQ1ZGEwNjRkMy4u ZTBhZDc1NDQ0NTg1ZDhhOWU3YTJlNzE2MzE1YTE1MTlmOTVlZmZiOSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkluc3BlY3Rvci5jcHAKKysrIGIvU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkluc3BlY3Rvci5jcHAKQEAgLTYwLDEx ICs2MCw2IEBAIFJlZjxXZWJJbnNwZWN0b3I+IFdlYkluc3BlY3Rvcjo6Y3JlYXRlKFdlYlBhZ2Uq IHBhZ2UpCiAKIFdlYkluc3BlY3Rvcjo6V2ViSW5zcGVjdG9yKFdlYlBhZ2UqIHBhZ2UpCiAgICAg OiBtX3BhZ2UocGFnZSkKLSAgICAsIG1fYXR0YWNoZWQoZmFsc2UpCi0gICAgLCBtX3ByZXZpb3Vz Q2FuQXR0YWNoKGZhbHNlKQotI2lmIEVOQUJMRShJTlNQRUNUT1JfU0VSVkVSKQotICAgICwgbV9y ZW1vdGVGcm9udGVuZENvbm5lY3RlZChmYWxzZSkKLSNlbmRpZgogewogfQogCkBAIC0xMDIsOCAr OTcsMTEgQEAgdm9pZCBXZWJJbnNwZWN0b3I6OmNsb3NlRnJvbnRlbmQoKQogewogICAgIFdlYlBy b2Nlc3M6OnNpbmdsZXRvbigpLnBhcmVudFByb2Nlc3NDb25uZWN0aW9uKCktPnNlbmQoTWVzc2Fn ZXM6OldlYkluc3BlY3RvclByb3h5OjpEaWRDbG9zZSgpLCBtX3BhZ2UtPnBhZ2VJRCgpKTsKIAot ICAgIG1fZnJvbnRlbmRDb25uZWN0aW9uLT5pbnZhbGlkYXRlKCk7Ci0gICAgbV9mcm9udGVuZENv bm5lY3Rpb24gPSBudWxscHRyOworICAgIC8vIElmIHdlIHRyaWVkIHRvIGNsb3NlIHRoZSBmcm9u dGVuZCBiZWZvcmUgaXQgd2FzIGNyZWF0ZWQsIHRoZW4gbm8gY29ubmVjdGlvbiBleGlzdHMgeWV0 LgorICAgIGlmIChtX2Zyb250ZW5kQ29ubmVjdGlvbikgeworICAgICAgICBtX2Zyb250ZW5kQ29u bmVjdGlvbi0+aW52YWxpZGF0ZSgpOworICAgICAgICBtX2Zyb250ZW5kQ29ubmVjdGlvbiA9IG51 bGxwdHI7CisgICAgfQogCiAgICAgbV9hdHRhY2hlZCA9IGZhbHNlOwogICAgIG1fcHJldmlvdXND YW5BdHRhY2ggPSBmYWxzZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9XZWJJbnNwZWN0b3IuaCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFn ZS9XZWJJbnNwZWN0b3IuaAppbmRleCAxNjRhYzY4MzUzNTFkNGU1NGE0ZjBhYWQzZjBkNDJlMjQ2 YTUyNDE1Li42MjQ4OGU4ZmI2OWIyYjc3MGVlNmE5ZjQ0NTY5MmExNjlmNTM1NjA2IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViSW5zcGVjdG9yLmgKKysr IGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkluc3BlY3Rvci5oCkBAIC0x MDUsMTAgKzEwNSwxMCBAQCBwcml2YXRlOgogCiAgICAgUmVmUHRyPElQQzo6Q29ubmVjdGlvbj4g bV9mcm9udGVuZENvbm5lY3Rpb247CiAKLSAgICBib29sIG1fYXR0YWNoZWQ7Ci0gICAgYm9vbCBt X3ByZXZpb3VzQ2FuQXR0YWNoOworICAgIGJvb2wgbV9hdHRhY2hlZCB7IGZhbHNlIH07CisgICAg Ym9vbCBtX3ByZXZpb3VzQ2FuQXR0YWNoIHsgZmFsc2UgfTsKICNpZiBFTkFCTEUoSU5TUEVDVE9S X1NFUlZFUikKLSAgICBib29sIG1fcmVtb3RlRnJvbnRlbmRDb25uZWN0ZWQ7CisgICAgYm9vbCBt X3JlbW90ZUZyb250ZW5kQ29ubmVjdGVkIHsgZmFsc2UgfTsKICNlbmRpZgogfTsKIAo=