147937 2015-08-12 10:25:56 -0700 Log actual PageCache retrieval success rate using diagnostic logging 2015-08-17 15:57:55 -0700 1 1 1 Unclassified WebKit History 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez barraclough commit-queue japhet kling koivisto rniwa oldest_to_newest 1116970 0 cdumez 2015-08-12 10:25:56 -0700 Log actual PageCache retrieval success rate using diagnostic logging. We currently only log how successful we are at saving entries into the cache, which is not the most interesting metric. 1116971 1 258827 cdumez 2015-08-12 10:28:48 -0700 Created attachment 258827 Patch 1118281 2 258827 commit-queue 2015-08-17 15:57:49 -0700 Comment on attachment 258827 Patch Clearing flags on attachment: 258827 Committed r188550: <http://trac.webkit.org/changeset/188550> 1118282 3 commit-queue 2015-08-17 15:57:55 -0700 All reviewed patches have been landed. Closing bug. 258827 2015-08-12 10:28:48 -0700 2015-08-17 15:57:49 -0700 Patch bug-147937-20150812102831.patch text/plain 4572 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4MzM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTc4NTdkZDRkMTEzNzRk ODY0MWYzMjRkODRmNTA4OGI2OTEwYjI2Ni4uOWY2MzFkZDM1ZjA1Yzc2OWZmY2RlZWU0MzczYWRi Y2MyMGRiZmYyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE1LTA4LTEyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgTG9nIGFjdHVhbCBQYWdlQ2Fj aGUgcmV0cmlldmFsIHN1Y2Nlc3MgcmF0ZSB1c2luZyBkaWFnbm9zdGljIGxvZ2dpbmcKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NzkzNworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIExvZyBhY3R1YWwgUGFn ZUNhY2hlIHJldHJpZXZhbCBzdWNjZXNzIHJhdGUgdXNpbmcgZGlhZ25vc3RpYyBsb2dnaW5nLgor ICAgICAgICBQcmV2aW91c2x5LCB3ZSB3b3VsZCBvbmx5IGxvZyBob3cgc3VjY2Vzc2Z1bCB3ZSBh cmUgYXQgc2F2aW5nIGVudHJpZXMKKyAgICAgICAgaW50byB0aGUgY2FjaGUsIHdoaWNoIGlzIG5v dCB0aGUgbW9zdCBpbnRlcmVzdGluZyBtZXRyaWMuCisKKyAgICAgICAgKiBoaXN0b3J5L1BhZ2VD YWNoZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjYW5DYWNoZVBhZ2UpOgorICAgICAgICAqIGxv YWRlci9GcmFtZUxvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlcjo6Y29u dGludWVMb2FkQWZ0ZXJOYXZpZ2F0aW9uUG9saWN5KToKKyAgICAgICAgKiBwYWdlL0RpYWdub3N0 aWNMb2dnaW5nS2V5cy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEaWFnbm9zdGljTG9nZ2luZ0tl eXM6OmNhbkNhY2hlS2V5KToKKyAgICAgICAgKiBwYWdlL0RpYWdub3N0aWNMb2dnaW5nS2V5cy5o OgorCiAyMDE1LTA4LTEyICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24u ZnI+CiAKICAgICAgICAgUmVtb3ZlIHByb21pc2UgYXR0cmlidXRlIHNwZWNpZmljIGhhbmRsaW5n IGZyb20gYmluZGluZyBnZW5lcmF0b3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2hpc3Rv cnkvUGFnZUNhY2hlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2hpc3RvcnkvUGFnZUNhY2hlLmNwcApp bmRleCA5ZGNmNjA1MDJlYzFiMDdjNDdjMDRhNDUzOTRlODUyYTAwODJjOWViLi5iNjMxMGQzMGEz YmU1Yjg2YTE2YzFmMjczZWYzOGFkN2RmMzM1NjUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9oaXN0b3J5L1BhZ2VDYWNoZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaGlzdG9yeS9QYWdl Q2FjaGUuY3BwCkBAIC0yNjIsNyArMjYyLDcgQEAgc3RhdGljIGJvb2wgY2FuQ2FjaGVQYWdlKFBh Z2UmIHBhZ2UpCiAgICAgZWxzZQogICAgICAgICBQQ0xPRygiIFBhZ2UgQ0FOTk9UIGJlIGNhY2hl ZFxuLS0tLS0tLS0iKTsKIAotICAgIGRpYWdub3N0aWNMb2dnaW5nQ2xpZW50LmxvZ0RpYWdub3N0 aWNNZXNzYWdlV2l0aFJlc3VsdChEaWFnbm9zdGljTG9nZ2luZ0tleXM6OnBhZ2VDYWNoZUtleSgp LCBlbXB0eVN0cmluZygpLCBpc0NhY2hlYWJsZSA/IERpYWdub3N0aWNMb2dnaW5nUmVzdWx0UGFz cyA6IERpYWdub3N0aWNMb2dnaW5nUmVzdWx0RmFpbCwgU2hvdWxkU2FtcGxlOjpZZXMpOworICAg IGRpYWdub3N0aWNMb2dnaW5nQ2xpZW50LmxvZ0RpYWdub3N0aWNNZXNzYWdlV2l0aFJlc3VsdChE aWFnbm9zdGljTG9nZ2luZ0tleXM6OnBhZ2VDYWNoZUtleSgpLCBEaWFnbm9zdGljTG9nZ2luZ0tl eXM6OmNhbkNhY2hlS2V5KCksIGlzQ2FjaGVhYmxlID8gRGlhZ25vc3RpY0xvZ2dpbmdSZXN1bHRQ YXNzIDogRGlhZ25vc3RpY0xvZ2dpbmdSZXN1bHRGYWlsLCBTaG91bGRTYW1wbGU6Olllcyk7CiAg ICAgcmV0dXJuIGlzQ2FjaGVhYmxlOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9s b2FkZXIvRnJhbWVMb2FkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVy LmNwcAppbmRleCA2MTFhYTQ4YTQ5YjQxZTc2MjNiZTcxMzFmNjEyYWM5YjJkY2UzN2ZiLi43NzA5 Njc0ZGVhNDUwZGNkMzYxM2Q4MTRlNjEwZTEzOTU0ZmMyMWFhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRl ci9GcmFtZUxvYWRlci5jcHAKQEAgLTI5OTMsOSArMjk5MywxNCBAQCB2b2lkIEZyYW1lTG9hZGVy Ojpjb250aW51ZUxvYWRBZnRlck5hdmlnYXRpb25Qb2xpY3koY29uc3QgUmVzb3VyY2VSZXF1ZXN0 JiByZXF1ZQogCiAgICAgc2V0UG9saWN5RG9jdW1lbnRMb2FkZXIoMCk7CiAKLSAgICBpZiAoaXNC YWNrRm9yd2FyZExvYWRUeXBlKHR5cGUpICYmIGhpc3RvcnkoKS5wcm92aXNpb25hbEl0ZW0oKS0+ aXNJblBhZ2VDYWNoZSgpKSB7Ci0gICAgICAgIGxvYWRQcm92aXNpb25hbEl0ZW1Gcm9tQ2FjaGVk UGFnZSgpOwotICAgICAgICByZXR1cm47CisgICAgaWYgKGlzQmFja0ZvcndhcmRMb2FkVHlwZSh0 eXBlKSkgeworICAgICAgICBhdXRvJiBkaWFnbm9zdGljTG9nZ2luZ0NsaWVudCA9IG1fZnJhbWUu bWFpbkZyYW1lKCkuZGlhZ25vc3RpY0xvZ2dpbmdDbGllbnQoKTsKKyAgICAgICAgaWYgKGhpc3Rv cnkoKS5wcm92aXNpb25hbEl0ZW0oKS0+aXNJblBhZ2VDYWNoZSgpKSB7CisgICAgICAgICAgICBk aWFnbm9zdGljTG9nZ2luZ0NsaWVudC5sb2dEaWFnbm9zdGljTWVzc2FnZVdpdGhSZXN1bHQoRGlh Z25vc3RpY0xvZ2dpbmdLZXlzOjpwYWdlQ2FjaGVLZXkoKSwgRGlhZ25vc3RpY0xvZ2dpbmdLZXlz OjpyZXRyaWV2YWxLZXkoKSwgRGlhZ25vc3RpY0xvZ2dpbmdSZXN1bHRQYXNzLCBTaG91bGRTYW1w bGU6Olllcyk7CisgICAgICAgICAgICBsb2FkUHJvdmlzaW9uYWxJdGVtRnJvbUNhY2hlZFBhZ2Uo KTsKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQorICAgICAgICBkaWFnbm9zdGljTG9n Z2luZ0NsaWVudC5sb2dEaWFnbm9zdGljTWVzc2FnZVdpdGhSZXN1bHQoRGlhZ25vc3RpY0xvZ2dp bmdLZXlzOjpwYWdlQ2FjaGVLZXkoKSwgRGlhZ25vc3RpY0xvZ2dpbmdLZXlzOjpyZXRyaWV2YWxL ZXkoKSwgRGlhZ25vc3RpY0xvZ2dpbmdSZXN1bHRGYWlsLCBTaG91bGRTYW1wbGU6Olllcyk7CiAg ICAgfQogCiAgICAgaWYgKCFmb3JtU3RhdGUpIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvRGlhZ25vc3RpY0xvZ2dpbmdLZXlzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRGlh Z25vc3RpY0xvZ2dpbmdLZXlzLmNwcAppbmRleCA5Y2NjMmUzYWUyNzZmMDFkYTUwNWI2YmJlNjc0 NjYzZDEwMjE2MWQyLi45N2M1ZTg1NTZjODVmMjZmYmQ5MjIyNjVhNzQxNzMxMmUzNjEyZDVmIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RpYWdub3N0aWNMb2dnaW5nS2V5cy5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9EaWFnbm9zdGljTG9nZ2luZ0tleXMuY3BwCkBAIC0y OTgsNiArMjk4LDExIEBAIFN0cmluZyBEaWFnbm9zdGljTG9nZ2luZ0tleXM6OmJhY2tOYXZpZ2F0 aW9uS2V5KCkKICAgICByZXR1cm4gQVNDSUlMaXRlcmFsKCJiYWNrTmF2aWdhdGlvbiIpOwogfQog CitTdHJpbmcgRGlhZ25vc3RpY0xvZ2dpbmdLZXlzOjpjYW5DYWNoZUtleSgpCit7CisgICAgcmV0 dXJuIEFTQ0lJTGl0ZXJhbCgiY2FuQ2FjaGUiKTsKK30KKwogU3RyaW5nIERpYWdub3N0aWNMb2dn aW5nS2V5czo6Y2FjaGVDb250cm9sTm9TdG9yZUtleSgpCiB7CiAgICAgcmV0dXJuIEFTQ0lJTGl0 ZXJhbCgiY2FjaGVDb250cm9sTm9TdG9yZSIpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGFnZS9EaWFnbm9zdGljTG9nZ2luZ0tleXMuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRGlhZ25v c3RpY0xvZ2dpbmdLZXlzLmgKaW5kZXggZWFhYmU3NTAyNDdlODQ5MDA4YzYyNzExZTAyMzY5ZTU4 NTgwOTQ3OC4uN2E1NGFmNTdlNzM1ODgyMTAzYmIzZDRhZTBmNDRjYzkyNzZhOTUzZiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9EaWFnbm9zdGljTG9nZ2luZ0tleXMuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9wYWdlL0RpYWdub3N0aWNMb2dnaW5nS2V5cy5oCkBAIC0zNyw2ICszNyw3 IEBAIHB1YmxpYzoKICAgICBXRUJDT1JFX0VYUE9SVCBzdGF0aWMgU3RyaW5nIGJhY2tOYXZpZ2F0 aW9uS2V5KCk7CiAgICAgV0VCQ09SRV9FWFBPUlQgc3RhdGljIFN0cmluZyBjYWNoZUNvbnRyb2xO b1N0b3JlS2V5KCk7CiAgICAgc3RhdGljIFN0cmluZyBjYWNoZWRSZXNvdXJjZVJldmFsaWRhdGlv bktleSgpOworICAgIHN0YXRpYyBTdHJpbmcgY2FuQ2FjaGVLZXkoKTsKICAgICBzdGF0aWMgU3Ry aW5nIGNhbm5vdFN1c3BlbmRBY3RpdmVET01PYmplY3RzS2V5KCk7CiAgICAgV0VCQ09SRV9FWFBP UlQgc3RhdGljIFN0cmluZyBkZWx0YUtleSgpOwogICAgIHN0YXRpYyBTdHJpbmcgZGVuaWVkQnlD bGllbnRLZXkoKTsK