147922 2015-08-11 22:05:36 -0700 Web Inspector: Disabling attribute styles should not be possible 2015-08-11 22:46:13 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 hi hi bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1116867 0 hi 2015-08-11 22:05:36 -0700 Currently, clicking a style icon in the Rules panel adds comments around every line in that style to "disable" that rule. This should not be possible for any type of style other than inline, author, user, inspector, and inherited rules. Currently, it allows toggling of everything other than UserAgent, but this needs to be changed to the list above. 1116868 1 258803 hi 2015-08-11 22:07:24 -0700 Created attachment 258803 Patch 1116869 2 258803 timothy 2015-08-11 22:10:20 -0700 Comment on attachment 258803 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258803&action=review > Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.js:103 > + if (style.editable && (style.type === WebInspector.CSSStyleDeclaration.Type.Rule || style.type === WebInspector.CSSStyleDeclaration.Type.Inline) Would style.editable be enough? 1116872 3 hi 2015-08-11 22:16:13 -0700 (In reply to comment #2) > Comment on attachment 258803 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=258803&action=review > > > Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.js:103 > > + if (style.editable && (style.type === WebInspector.CSSStyleDeclaration.Type.Rule || style.type === WebInspector.CSSStyleDeclaration.Type.Inline) > > Would style.editable be enough? Ha I can't believe I didn't think of that. It works exactly as described. 1116873 4 258805 hi 2015-08-11 22:17:43 -0700 Created attachment 258805 Patch 1116883 5 258805 commit-queue 2015-08-11 22:46:10 -0700 Comment on attachment 258805 Patch Clearing flags on attachment: 258805 Committed r188326: <http://trac.webkit.org/changeset/188326> 1116884 6 commit-queue 2015-08-11 22:46:13 -0700 All reviewed patches have been landed. Closing bug. 258803 2015-08-11 22:07:24 -0700 2015-08-11 22:17:01 -0700 Patch bug-147922-20150811220708.patch text/plain 2126 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDc4OThmYTc3YWY2MzAzZmM1YTQzNjhkMDYxY2Nh Mzk0ZjJmOTNmMzAuLmNjMmE5MzUyMGE0ZDkzMmI4N2QxMGIyMmUxOGYxY2RjMWU3MTIwYzAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA4LTExICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBE aXNhYmxpbmcgYXR0cmlidXRlIHN0eWxlcyBzaG91bGQgbm90IGJlIHBvc3NpYmxlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDc5MjIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2Uv Vmlld3MvQ1NTU3R5bGVEZWNsYXJhdGlvblNlY3Rpb24uanM6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuQ1NTU3R5bGVEZWNsYXJhdGlvblNlY3Rpb24pOgorICAgICAgICBJbmNyZWFzZXMgdGhlIHNw ZWNpZmljaXR5IG9mIHRoZSBpZiBzdGF0ZW1lbnQgdGhhdCBhZGRzIHJ1bGUgZGlzYWJsZSBzdGF0 ZSB0b2dnbGluZyB0byB0aGUgaWNvbi4KKwogMjAxNS0wOC0xMSAgTWF0dCBCYWtlciAgPG1hdHRi YWtlckBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogQWRkIHRoZSBhYmlsaXR5 IHRvIGZpbHRlciBvdXQgdGFza3MgaW4gdGhlIFJlbmRlcmluZyBGcmFtZXMgdGltZWxpbmUKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NTU1N0 eWxlRGVjbGFyYXRpb25TZWN0aW9uLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvQ1NTU3R5bGVEZWNsYXJhdGlvblNlY3Rpb24uanMKaW5kZXggNTZkOWQ2MmQ3 YzlmOGViNTA0NDkzMjAyODhmZmNlOTExZjYyY2M1NC4uOWE4NzA5YmU0ZTM1ZTgyMTM3ZTIyNzNi NjVjOWE3NzM2MGQ4MDBmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvQ1NTU3R5bGVEZWNsYXJhdGlvblNlY3Rpb24uanMKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ1NTU3R5bGVEZWNsYXJhdGlvblNl Y3Rpb24uanMKQEAgLTk5LDggKzk5LDkgQEAgV2ViSW5zcGVjdG9yLkNTU1N0eWxlRGVjbGFyYXRp b25TZWN0aW9uID0gY2xhc3MgQ1NTU3R5bGVEZWNsYXJhdGlvblNlY3Rpb24gZXh0ZW4KICAgICAg ICAgICAgIGJyZWFrOwogICAgICAgICB9CiAKLSAgICAgICAgLy8gTWF0Y2hlcyBhbGwgc2l0dWF0 aW9ucyBleGNlcHQgZm9yIFVzZXIgQWdlbnQgc3R5bGVzLgotICAgICAgICBpZiAoIShzdHlsZS5v d25lclJ1bGUgJiYgc3R5bGUub3duZXJSdWxlLnR5cGUgPT09IFdlYkluc3BlY3Rvci5DU1NSdWxl LlR5cGUuVXNlckFnZW50KSkgeworICAgICAgICAvLyBNYXRjaGVzIGFsbCBJbmxpbmUgYW5kIFJ1 bGUgc3R5bGVzIGV4Y2VwdCBmb3IgVXNlciBBZ2VudC4KKyAgICAgICAgaWYgKHN0eWxlLmVkaXRh YmxlICYmIChzdHlsZS50eXBlID09PSBXZWJJbnNwZWN0b3IuQ1NTU3R5bGVEZWNsYXJhdGlvbi5U eXBlLlJ1bGUgfHwgc3R5bGUudHlwZSA9PT0gV2ViSW5zcGVjdG9yLkNTU1N0eWxlRGVjbGFyYXRp b24uVHlwZS5JbmxpbmUpCisgICAgICAgICAgICAmJiAhKHN0eWxlLm93bmVyUnVsZSAmJiBzdHls ZS5vd25lclJ1bGUudHlwZSA9PT0gV2ViSW5zcGVjdG9yLkNTU1J1bGUuVHlwZS5Vc2VyQWdlbnQp KSB7CiAgICAgICAgICAgICB0aGlzLl9pY29uRWxlbWVudC5jbGFzc0xpc3QuYWRkKCJ0b2dnbGUt YWJsZSIpOwogICAgICAgICAgICAgdGhpcy5faWNvbkVsZW1lbnQudGl0bGUgPSBXZWJJbnNwZWN0 b3IuVUlTdHJpbmcoIkNvbW1lbnQgQWxsIFByb3BlcnRpZXMiKTsKICAgICAgICAgICAgIHRoaXMu X2ljb25FbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoImNsaWNrIiwgdGhpcy5fdG9nZ2xlUnVsZU9u T2ZmLmJpbmQodGhpcykpOwo= 258805 2015-08-11 22:17:43 -0700 2015-08-11 22:46:10 -0700 Patch 147922.txt text/plain 1700 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDc4OThmYTcuLjFiNGI1YzkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA4LTExICBEZXZpbiBSb3Vzc28g IDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBEaXNhYmxpbmcg YXR0cmlidXRlIHN0eWxlcyBzaG91bGQgbm90IGJlIHBvc3NpYmxlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDc5MjIKKworICAgICAgICBSZXZpZXdl ZCBieSBUaW1vdGh5IEhhdGNoZXIuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0NT U1N0eWxlRGVjbGFyYXRpb25TZWN0aW9uLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNTU1N0 eWxlRGVjbGFyYXRpb25TZWN0aW9uKToKKyAgICAgICAgSW5jcmVhc2VzIHRoZSBzcGVjaWZpY2l0 eSBvZiB0aGUgaWYgc3RhdGVtZW50IHRoYXQgYWRkcyBydWxlIGRpc2FibGUgc3RhdGUgdG9nZ2xp bmcgdG8gdGhlIGljb24uCisKIDIwMTUtMDgtMTEgIE1hdHQgQmFrZXIgIDxtYXR0YmFrZXJAYXBw bGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEFkZCB0aGUgYWJpbGl0eSB0byBmaWx0 ZXIgb3V0IHRhc2tzIGluIHRoZSBSZW5kZXJpbmcgRnJhbWVzIHRpbWVsaW5lCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DU1NTdHlsZURlY2xh cmF0aW9uU2VjdGlvbi5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL0NTU1N0eWxlRGVjbGFyYXRpb25TZWN0aW9uLmpzCmluZGV4IDU2ZDlkNjIuLjQ1MWUxYzMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NT U1N0eWxlRGVjbGFyYXRpb25TZWN0aW9uLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL0NTU1N0eWxlRGVjbGFyYXRpb25TZWN0aW9uLmpzCkBAIC05OSw4 ICs5OSw3IEBAIFdlYkluc3BlY3Rvci5DU1NTdHlsZURlY2xhcmF0aW9uU2VjdGlvbiA9IGNsYXNz IENTU1N0eWxlRGVjbGFyYXRpb25TZWN0aW9uIGV4dGVuCiAgICAgICAgICAgICBicmVhazsKICAg ICAgICAgfQogCi0gICAgICAgIC8vIE1hdGNoZXMgYWxsIHNpdHVhdGlvbnMgZXhjZXB0IGZvciBV c2VyIEFnZW50IHN0eWxlcy4KLSAgICAgICAgaWYgKCEoc3R5bGUub3duZXJSdWxlICYmIHN0eWxl Lm93bmVyUnVsZS50eXBlID09PSBXZWJJbnNwZWN0b3IuQ1NTUnVsZS5UeXBlLlVzZXJBZ2VudCkp IHsKKyAgICAgICAgaWYgKHN0eWxlLmVkaXRhYmxlKSB7CiAgICAgICAgICAgICB0aGlzLl9pY29u RWxlbWVudC5jbGFzc0xpc3QuYWRkKCJ0b2dnbGUtYWJsZSIpOwogICAgICAgICAgICAgdGhpcy5f aWNvbkVsZW1lbnQudGl0bGUgPSBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkNvbW1lbnQgQWxsIFBy b3BlcnRpZXMiKTsKICAgICAgICAgICAgIHRoaXMuX2ljb25FbGVtZW50LmFkZEV2ZW50TGlzdGVu ZXIoImNsaWNrIiwgdGhpcy5fdG9nZ2xlUnVsZU9uT2ZmLmJpbmQodGhpcykpOwo=