147921 2015-08-11 21:38:41 -0700 CSSParserValueList argument should be a reference 2022-07-24 13:51:02 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 gyuyoung.kim gyuyoung.kim ahmad.saleem792 ap dbates rniwa simon.fraser zalan oldest_to_newest 1116860 0 gyuyoung.kim 2015-08-11 21:38:41 -0700 Argument of CSSParserValueList has been treated as it is non-null pointer. So it should be a reference. 1116861 1 258800 gyuyoung.kim 2015-08-11 21:39:41 -0700 Created attachment 258800 Patch 1116862 2 258801 gyuyoung.kim 2015-08-11 21:42:10 -0700 Created attachment 258801 Patch 1117229 3 258801 bfulgham 2015-08-13 08:52:50 -0700 Comment on attachment 258801 Patch r=me 1886374 4 ahmad.saleem792 2022-07-24 10:55:12 -0700 @bfulgham@webkit.org - it is r+ patch, has this landed or it got changed or fixed. There is no test case in the attached patch, which I can use to test it. Appreciate if you can update it accordingly as you needed. Thanks! 1886405 5 rniwa 2022-07-24 13:51:02 -0700 This is a change for old CSS parser. I'm pretty sure the patch is no longer relevant. 258800 2015-08-11 21:39:41 -0700 2015-08-11 21:42:06 -0700 Patch bug-147921-20150812133925.patch text/plain 6866 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4MzE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWNlM2JiYWNlODIyNjVm YTMzM2I5YWFjNjM1ZmRkZjkzNzkwYmYwNS4uNTYzNDY3YTYxYTNhOGNlYWVjMjdmNTExNDkyZWNm ZDQxY2FmZDdiMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACisyMDE1LTA4LTExICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBDU1NQYXJzZXJW YWx1ZUxpc3QgYXJndW1lbnQgc2hvdWxkIGJlIGEgcmVmZXJlbmNlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDc5MjEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBcmd1bWVudCBvZiBDU1NQYXJzZXJWYWx1 ZUxpc3QgaGFzIGJlZW4gdHJlYXRlZCBhcyBpdCBpcyBub24tbnVsbCBwb2ludGVyLiBTbyBpdCBz aG91bGQgYmUgYSByZWZlcmVuY2UuCisKKyAgICAgICAgKiBjc3MvQ1NTQ2FsY3VsYXRpb25WYWx1 ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjaGVja0RlcHRoQW5kSW5kZXgpOgorICAgICAgICAo V2ViQ29yZTo6Q1NTQ2FsY0V4cHJlc3Npb25Ob2RlUGFyc2VyOjpwYXJzZUNhbGMpOgorICAgICAg ICAoV2ViQ29yZTo6Q1NTQ2FsY0V4cHJlc3Npb25Ob2RlUGFyc2VyOjpvcGVyYXRvclZhbHVlKToK KyAgICAgICAgKFdlYkNvcmU6OkNTU0NhbGNFeHByZXNzaW9uTm9kZVBhcnNlcjo6cGFyc2VWYWx1 ZSk6CisgICAgICAgIChXZWJDb3JlOjpDU1NDYWxjRXhwcmVzc2lvbk5vZGVQYXJzZXI6OnBhcnNl VmFsdWVUZXJtKToKKyAgICAgICAgKFdlYkNvcmU6OkNTU0NhbGNFeHByZXNzaW9uTm9kZVBhcnNl cjo6cGFyc2VWYWx1ZU11bHRpcGxpY2F0aXZlRXhwcmVzc2lvbik6CisgICAgICAgIChXZWJDb3Jl OjpDU1NDYWxjRXhwcmVzc2lvbk5vZGVQYXJzZXI6OnBhcnNlQWRkaXRpdmVWYWx1ZUV4cHJlc3Np b24pOgorICAgICAgICAoV2ViQ29yZTo6Q1NTQ2FsY0V4cHJlc3Npb25Ob2RlUGFyc2VyOjpwYXJz ZVZhbHVlRXhwcmVzc2lvbik6CisgICAgICAgIChXZWJDb3JlOjpDU1NDYWxjVmFsdWU6OmNyZWF0 ZSk6CisKIDIwMTUtMDgtMTEgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUB3ZWJraXQub3Jn PgogCiAgICAgICAgIFJlZHVjZSB1c2Ugb2YgUGFzc1JlZlB0ciBpbiBXZWJDb3JlL2NzcwogICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ3ODIxCiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NDYWxjdWxhdGlvblZhbHVlLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2Nzcy9DU1NDYWxjdWxhdGlvblZhbHVlLmNwcAppbmRleCAzNjE0MmYxYmYw YmMwMjQ4MDc5M2I0MDlhY2MwN2M2OWE4YzM3NTU5Li5lYmQ4MGIwNmQwZWQ1MzdjY2Y1MzVmZmQ2 MmI0YmE5MGNkOGM4ZGM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTQ2FsY3Vs YXRpb25WYWx1ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0NhbGN1bGF0aW9uVmFs dWUuY3BwCkBAIC01NTksMjUgKzU1OSwyNSBAQCBwcml2YXRlOgogICAgIGNvbnN0IENhbGNPcGVy YXRvciBtX29wZXJhdG9yOwogfTsKIAotc3RhdGljIFBhcnNlU3RhdGUgY2hlY2tEZXB0aEFuZElu ZGV4KGludCogZGVwdGgsIHVuc2lnbmVkIGluZGV4LCBDU1NQYXJzZXJWYWx1ZUxpc3QqIHRva2Vu cykKK3N0YXRpYyBQYXJzZVN0YXRlIGNoZWNrRGVwdGhBbmRJbmRleChpbnQqIGRlcHRoLCB1bnNp Z25lZCBpbmRleCwgQ1NTUGFyc2VyVmFsdWVMaXN0JiB0b2tlbnMpCiB7CiAgICAgKCpkZXB0aCkr KzsKICAgICBpZiAoKmRlcHRoID4gbWF4RXhwcmVzc2lvbkRlcHRoKQogICAgICAgICByZXR1cm4g VG9vRGVlcDsKLSAgICBpZiAoaW5kZXggPj0gdG9rZW5zLT5zaXplKCkpCisgICAgaWYgKGluZGV4 ID49IHRva2Vucy5zaXplKCkpCiAgICAgICAgIHJldHVybiBOb01vcmVUb2tlbnM7CiAgICAgcmV0 dXJuIE9LOwogfQogCiBjbGFzcyBDU1NDYWxjRXhwcmVzc2lvbk5vZGVQYXJzZXIgewogcHVibGlj OgotICAgIFJlZlB0cjxDU1NDYWxjRXhwcmVzc2lvbk5vZGU+IHBhcnNlQ2FsYyhDU1NQYXJzZXJW YWx1ZUxpc3QqIHRva2VucykKKyAgICBSZWZQdHI8Q1NTQ2FsY0V4cHJlc3Npb25Ob2RlPiBwYXJz ZUNhbGMoQ1NTUGFyc2VyVmFsdWVMaXN0JiB0b2tlbnMpCiAgICAgewogICAgICAgICB1bnNpZ25l ZCBpbmRleCA9IDA7CiAgICAgICAgIFZhbHVlIHJlc3VsdDsKICAgICAgICAgYm9vbCBvayA9IHBh cnNlVmFsdWVFeHByZXNzaW9uKHRva2VucywgMCwgJmluZGV4LCAmcmVzdWx0KTsKLSAgICAgICAg QVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT04oaW5kZXggPD0gdG9rZW5zLT5zaXplKCkp OwotICAgICAgICBpZiAoIW9rIHx8IGluZGV4ICE9IHRva2Vucy0+c2l6ZSgpKQorICAgICAgICBB U1NFUlRfV0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTihpbmRleCA8PSB0b2tlbnMuc2l6ZSgpKTsK KyAgICAgICAgaWYgKCFvayB8fCBpbmRleCAhPSB0b2tlbnMuc2l6ZSgpKQogICAgICAgICAgICAg cmV0dXJuIG51bGxwdHI7CiAgICAgICAgIHJldHVybiByZXN1bHQudmFsdWU7CiAgICAgfQpAQCAt NTg3LDIwICs1ODcsMjAgQEAgcHJpdmF0ZToKICAgICAgICAgUmVmUHRyPENTU0NhbGNFeHByZXNz aW9uTm9kZT4gdmFsdWU7CiAgICAgfTsKIAotICAgIGNoYXIgb3BlcmF0b3JWYWx1ZShDU1NQYXJz ZXJWYWx1ZUxpc3QqIHRva2VucywgdW5zaWduZWQgaW5kZXgpCisgICAgY2hhciBvcGVyYXRvclZh bHVlKENTU1BhcnNlclZhbHVlTGlzdCYgdG9rZW5zLCB1bnNpZ25lZCBpbmRleCkKICAgICB7Ci0g ICAgICAgIGlmIChpbmRleCA+PSB0b2tlbnMtPnNpemUoKSkKKyAgICAgICAgaWYgKGluZGV4ID49 IHRva2Vucy5zaXplKCkpCiAgICAgICAgICAgICByZXR1cm4gMDsKLSAgICAgICAgQ1NTUGFyc2Vy VmFsdWUqIHZhbHVlID0gdG9rZW5zLT52YWx1ZUF0KGluZGV4KTsKKyAgICAgICAgQ1NTUGFyc2Vy VmFsdWUqIHZhbHVlID0gdG9rZW5zLnZhbHVlQXQoaW5kZXgpOwogICAgICAgICBpZiAodmFsdWUt PnVuaXQgIT0gQ1NTUGFyc2VyVmFsdWU6Ok9wZXJhdG9yKQogICAgICAgICAgICAgcmV0dXJuIDA7 CiAKICAgICAgICAgcmV0dXJuIHZhbHVlLT5pVmFsdWU7CiAgICAgfQogCi0gICAgYm9vbCBwYXJz ZVZhbHVlKENTU1BhcnNlclZhbHVlTGlzdCogdG9rZW5zLCB1bnNpZ25lZCogaW5kZXgsIFZhbHVl KiByZXN1bHQpCisgICAgYm9vbCBwYXJzZVZhbHVlKENTU1BhcnNlclZhbHVlTGlzdCYgdG9rZW5z LCB1bnNpZ25lZCogaW5kZXgsIFZhbHVlKiByZXN1bHQpCiAgICAgewotICAgICAgICBDU1NQYXJz ZXJWYWx1ZSogcGFyc2VyVmFsdWUgPSB0b2tlbnMtPnZhbHVlQXQoKmluZGV4KTsKKyAgICAgICAg Q1NTUGFyc2VyVmFsdWUqIHBhcnNlclZhbHVlID0gdG9rZW5zLnZhbHVlQXQoKmluZGV4KTsKICAg ICAgICAgaWYgKHBhcnNlclZhbHVlLT51bml0ID09IENTU1BhcnNlclZhbHVlOjpPcGVyYXRvciB8 fCBwYXJzZXJWYWx1ZS0+dW5pdCA9PSBDU1NQYXJzZXJWYWx1ZTo6RnVuY3Rpb24pCiAgICAgICAg ICAgICByZXR1cm4gZmFsc2U7CiAKQEAgLTYxNSw3ICs2MTUsNyBAQCBwcml2YXRlOgogICAgICAg ICByZXR1cm4gdHJ1ZTsKICAgICB9CiAKLSAgICBib29sIHBhcnNlVmFsdWVUZXJtKENTU1BhcnNl clZhbHVlTGlzdCogdG9rZW5zLCBpbnQgZGVwdGgsIHVuc2lnbmVkKiBpbmRleCwgVmFsdWUqIHJl c3VsdCkKKyAgICBib29sIHBhcnNlVmFsdWVUZXJtKENTU1BhcnNlclZhbHVlTGlzdCYgdG9rZW5z LCBpbnQgZGVwdGgsIHVuc2lnbmVkKiBpbmRleCwgVmFsdWUqIHJlc3VsdCkKICAgICB7CiAgICAg ICAgIGlmIChjaGVja0RlcHRoQW5kSW5kZXgoJmRlcHRoLCAqaW5kZXgsIHRva2VucykgIT0gT0sp CiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CkBAIC02MzQsNyArNjM0LDcgQEAgcHJpdmF0ZToK ICAgICAgICAgcmV0dXJuIHBhcnNlVmFsdWUodG9rZW5zLCBpbmRleCwgcmVzdWx0KTsKICAgICB9 CiAKLSAgICBib29sIHBhcnNlVmFsdWVNdWx0aXBsaWNhdGl2ZUV4cHJlc3Npb24oQ1NTUGFyc2Vy VmFsdWVMaXN0KiB0b2tlbnMsIGludCBkZXB0aCwgdW5zaWduZWQqIGluZGV4LCBWYWx1ZSogcmVz dWx0KQorICAgIGJvb2wgcGFyc2VWYWx1ZU11bHRpcGxpY2F0aXZlRXhwcmVzc2lvbihDU1NQYXJz ZXJWYWx1ZUxpc3QmIHRva2VucywgaW50IGRlcHRoLCB1bnNpZ25lZCogaW5kZXgsIFZhbHVlKiBy ZXN1bHQpCiAgICAgewogICAgICAgICBpZiAoY2hlY2tEZXB0aEFuZEluZGV4KCZkZXB0aCwgKmlu ZGV4LCB0b2tlbnMpICE9IE9LKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwpAQCAtNjQyLDcg KzY0Miw3IEBAIHByaXZhdGU6CiAgICAgICAgIGlmICghcGFyc2VWYWx1ZVRlcm0odG9rZW5zLCBk ZXB0aCwgaW5kZXgsIHJlc3VsdCkpCiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICAg ICAgd2hpbGUgKCppbmRleCA8IHRva2Vucy0+c2l6ZSgpIC0gMSkgeworICAgICAgICB3aGlsZSAo KmluZGV4IDwgdG9rZW5zLnNpemUoKSAtIDEpIHsKICAgICAgICAgICAgIGNoYXIgb3BlcmF0b3JD aGFyYWN0ZXIgPSBvcGVyYXRvclZhbHVlKHRva2VucywgKmluZGV4KTsKICAgICAgICAgICAgIGlm IChvcGVyYXRvckNoYXJhY3RlciAhPSBDYWxjTXVsdGlwbHkgJiYgb3BlcmF0b3JDaGFyYWN0ZXIg IT0gQ2FsY0RpdmlkZSkKICAgICAgICAgICAgICAgICBicmVhazsKQEAgLTY1NywxMSArNjU3LDEx IEBAIHByaXZhdGU6CiAgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICB9CiAK LSAgICAgICAgQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT04oKmluZGV4IDw9IHRva2Vu cy0+c2l6ZSgpKTsKKyAgICAgICAgQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT04oKmlu ZGV4IDw9IHRva2Vucy5zaXplKCkpOwogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CiAKLSAg ICBib29sIHBhcnNlQWRkaXRpdmVWYWx1ZUV4cHJlc3Npb24oQ1NTUGFyc2VyVmFsdWVMaXN0KiB0 b2tlbnMsIGludCBkZXB0aCwgdW5zaWduZWQqIGluZGV4LCBWYWx1ZSogcmVzdWx0KQorICAgIGJv b2wgcGFyc2VBZGRpdGl2ZVZhbHVlRXhwcmVzc2lvbihDU1NQYXJzZXJWYWx1ZUxpc3QmIHRva2Vu cywgaW50IGRlcHRoLCB1bnNpZ25lZCogaW5kZXgsIFZhbHVlKiByZXN1bHQpCiAgICAgewogICAg ICAgICBpZiAoY2hlY2tEZXB0aEFuZEluZGV4KCZkZXB0aCwgKmluZGV4LCB0b2tlbnMpICE9IE9L KQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwpAQCAtNjY5LDcgKzY2OSw3IEBAIHByaXZhdGU6 CiAgICAgICAgIGlmICghcGFyc2VWYWx1ZU11bHRpcGxpY2F0aXZlRXhwcmVzc2lvbih0b2tlbnMs IGRlcHRoLCBpbmRleCwgcmVzdWx0KSkKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKIAotICAg ICAgICB3aGlsZSAoKmluZGV4IDwgdG9rZW5zLT5zaXplKCkgLSAxKSB7CisgICAgICAgIHdoaWxl ICgqaW5kZXggPCB0b2tlbnMuc2l6ZSgpIC0gMSkgewogICAgICAgICAgICAgY2hhciBvcGVyYXRv ckNoYXJhY3RlciA9IG9wZXJhdG9yVmFsdWUodG9rZW5zLCAqaW5kZXgpOwogICAgICAgICAgICAg aWYgKG9wZXJhdG9yQ2hhcmFjdGVyICE9IENhbGNBZGQgJiYgb3BlcmF0b3JDaGFyYWN0ZXIgIT0g Q2FsY1N1YnRyYWN0KQogICAgICAgICAgICAgICAgIGJyZWFrOwpAQCAtNjg0LDExICs2ODQsMTEg QEAgcHJpdmF0ZToKICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAgIH0KIAot ICAgICAgICBBU1NFUlRfV0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTigqaW5kZXggPD0gdG9rZW5z LT5zaXplKCkpOworICAgICAgICBBU1NFUlRfV0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTigqaW5k ZXggPD0gdG9rZW5zLnNpemUoKSk7CiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0KIAotICAg IGJvb2wgcGFyc2VWYWx1ZUV4cHJlc3Npb24oQ1NTUGFyc2VyVmFsdWVMaXN0KiB0b2tlbnMsIGlu dCBkZXB0aCwgdW5zaWduZWQqIGluZGV4LCBWYWx1ZSogcmVzdWx0KQorICAgIGJvb2wgcGFyc2VW YWx1ZUV4cHJlc3Npb24oQ1NTUGFyc2VyVmFsdWVMaXN0JiB0b2tlbnMsIGludCBkZXB0aCwgdW5z aWduZWQqIGluZGV4LCBWYWx1ZSogcmVzdWx0KQogICAgIHsKICAgICAgICAgcmV0dXJuIHBhcnNl QWRkaXRpdmVWYWx1ZUV4cHJlc3Npb24odG9rZW5zLCBkZXB0aCwgaW5kZXgsIHJlc3VsdCk7CiAg ICAgfQpAQCAtNzU3LDcgKzc1Nyw3IEBAIFJlZlB0cjxDU1NDYWxjVmFsdWU+IENTU0NhbGNWYWx1 ZTo6Y3JlYXRlKENTU1BhcnNlclN0cmluZyBuYW1lLCBDU1NQYXJzZXJWYWx1ZUxpCiAgICAgUmVm UHRyPENTU0NhbGNFeHByZXNzaW9uTm9kZT4gZXhwcmVzc2lvbjsKIAogICAgIGlmIChuYW1lLmVx dWFsSWdub3JpbmdDYXNlKCJjYWxjKCIpIHx8IG5hbWUuZXF1YWxJZ25vcmluZ0Nhc2UoIi13ZWJr aXQtY2FsYygiKSkKLSAgICAgICAgZXhwcmVzc2lvbiA9IHBhcnNlci5wYXJzZUNhbGMoJnBhcnNl clZhbHVlTGlzdCk7CisgICAgICAgIGV4cHJlc3Npb24gPSBwYXJzZXIucGFyc2VDYWxjKHBhcnNl clZhbHVlTGlzdCk7CiAKICAgICByZXR1cm4gZXhwcmVzc2lvbiA/IGFkb3B0UmVmKG5ldyBDU1ND YWxjVmFsdWUoZXhwcmVzc2lvbi5yZWxlYXNlTm9uTnVsbCgpLCByYW5nZSAhPSBDYWxjdWxhdGlv blJhbmdlQWxsKSkgOiBudWxscHRyOwogfQo= 258801 2015-08-11 21:42:10 -0700 2015-08-13 08:52:50 -0700 Patch bug-147921-20150812134154.patch text/plain 6821 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4MzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGM1ZDgyZTJiMjVhMzQ3 OGYzZDM5NWEyZGZiNzU4NTdjYzFhZTE2YS4uMmFhZDQ2M2VmZWQzYWE4MzQwOTRmNGJhYWUzNGU1 M2VkNzVkNGI4MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE1LTA4LTExICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBDU1NQYXJzZXJW YWx1ZUxpc3QgYXJndW1lbnQgc2hvdWxkIGJlIGEgcmVmZXJlbmNlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDc5MjEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBcmd1bWVudCBvZiBDU1NQYXJzZXJWYWx1 ZUxpc3QgaGFzIGJlZW4gdHJlYXRlZCBhcyBpdCBpcyBub24tbnVsbCBwb2ludGVyLiBTbyBpdCBz aG91bGQgYmUgYSByZWZlcmVuY2UuCisKKyAgICAgICAgKiBjc3MvQ1NTQ2FsY3VsYXRpb25WYWx1 ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjaGVja0RlcHRoQW5kSW5kZXgpOgorICAgICAgICAo V2ViQ29yZTo6Q1NTQ2FsY0V4cHJlc3Npb25Ob2RlUGFyc2VyOjpwYXJzZUNhbGMpOgorICAgICAg ICAoV2ViQ29yZTo6Q1NTQ2FsY0V4cHJlc3Npb25Ob2RlUGFyc2VyOjpvcGVyYXRvclZhbHVlKToK KyAgICAgICAgKFdlYkNvcmU6OkNTU0NhbGNFeHByZXNzaW9uTm9kZVBhcnNlcjo6cGFyc2VWYWx1 ZSk6CisgICAgICAgIChXZWJDb3JlOjpDU1NDYWxjRXhwcmVzc2lvbk5vZGVQYXJzZXI6OnBhcnNl VmFsdWVUZXJtKToKKyAgICAgICAgKFdlYkNvcmU6OkNTU0NhbGNFeHByZXNzaW9uTm9kZVBhcnNl cjo6cGFyc2VWYWx1ZU11bHRpcGxpY2F0aXZlRXhwcmVzc2lvbik6CisgICAgICAgIChXZWJDb3Jl OjpDU1NDYWxjRXhwcmVzc2lvbk5vZGVQYXJzZXI6OnBhcnNlQWRkaXRpdmVWYWx1ZUV4cHJlc3Np b24pOgorICAgICAgICAoV2ViQ29yZTo6Q1NTQ2FsY0V4cHJlc3Npb25Ob2RlUGFyc2VyOjpwYXJz ZVZhbHVlRXhwcmVzc2lvbik6CisgICAgICAgIChXZWJDb3JlOjpDU1NDYWxjVmFsdWU6OmNyZWF0 ZSk6CisKIDIwMTUtMDgtMTEgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAg ICAgICBEaXNjb25uZWN0IExheW91dFN0YXRlRGlzYWJsZXIgbG9naWMgYW5kIFJlbmRlclZpZXcg cG9pbnRlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NDYWxjdWxhdGlvblZh bHVlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NDYWxjdWxhdGlvblZhbHVlLmNwcAppbmRl eCAzNjE0MmYxYmYwYmMwMjQ4MDc5M2I0MDlhY2MwN2M2OWE4YzM3NTU5Li5lYmQ4MGIwNmQwZWQ1 MzdjY2Y1MzVmZmQ2MmI0YmE5MGNkOGM4ZGM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9j c3MvQ1NTQ2FsY3VsYXRpb25WYWx1ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0Nh bGN1bGF0aW9uVmFsdWUuY3BwCkBAIC01NTksMjUgKzU1OSwyNSBAQCBwcml2YXRlOgogICAgIGNv bnN0IENhbGNPcGVyYXRvciBtX29wZXJhdG9yOwogfTsKIAotc3RhdGljIFBhcnNlU3RhdGUgY2hl Y2tEZXB0aEFuZEluZGV4KGludCogZGVwdGgsIHVuc2lnbmVkIGluZGV4LCBDU1NQYXJzZXJWYWx1 ZUxpc3QqIHRva2VucykKK3N0YXRpYyBQYXJzZVN0YXRlIGNoZWNrRGVwdGhBbmRJbmRleChpbnQq IGRlcHRoLCB1bnNpZ25lZCBpbmRleCwgQ1NTUGFyc2VyVmFsdWVMaXN0JiB0b2tlbnMpCiB7CiAg ICAgKCpkZXB0aCkrKzsKICAgICBpZiAoKmRlcHRoID4gbWF4RXhwcmVzc2lvbkRlcHRoKQogICAg ICAgICByZXR1cm4gVG9vRGVlcDsKLSAgICBpZiAoaW5kZXggPj0gdG9rZW5zLT5zaXplKCkpCisg ICAgaWYgKGluZGV4ID49IHRva2Vucy5zaXplKCkpCiAgICAgICAgIHJldHVybiBOb01vcmVUb2tl bnM7CiAgICAgcmV0dXJuIE9LOwogfQogCiBjbGFzcyBDU1NDYWxjRXhwcmVzc2lvbk5vZGVQYXJz ZXIgewogcHVibGljOgotICAgIFJlZlB0cjxDU1NDYWxjRXhwcmVzc2lvbk5vZGU+IHBhcnNlQ2Fs YyhDU1NQYXJzZXJWYWx1ZUxpc3QqIHRva2VucykKKyAgICBSZWZQdHI8Q1NTQ2FsY0V4cHJlc3Np b25Ob2RlPiBwYXJzZUNhbGMoQ1NTUGFyc2VyVmFsdWVMaXN0JiB0b2tlbnMpCiAgICAgewogICAg ICAgICB1bnNpZ25lZCBpbmRleCA9IDA7CiAgICAgICAgIFZhbHVlIHJlc3VsdDsKICAgICAgICAg Ym9vbCBvayA9IHBhcnNlVmFsdWVFeHByZXNzaW9uKHRva2VucywgMCwgJmluZGV4LCAmcmVzdWx0 KTsKLSAgICAgICAgQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT04oaW5kZXggPD0gdG9r ZW5zLT5zaXplKCkpOwotICAgICAgICBpZiAoIW9rIHx8IGluZGV4ICE9IHRva2Vucy0+c2l6ZSgp KQorICAgICAgICBBU1NFUlRfV0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTihpbmRleCA8PSB0b2tl bnMuc2l6ZSgpKTsKKyAgICAgICAgaWYgKCFvayB8fCBpbmRleCAhPSB0b2tlbnMuc2l6ZSgpKQog ICAgICAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAgICAgICAgIHJldHVybiByZXN1bHQudmFsdWU7 CiAgICAgfQpAQCAtNTg3LDIwICs1ODcsMjAgQEAgcHJpdmF0ZToKICAgICAgICAgUmVmUHRyPENT U0NhbGNFeHByZXNzaW9uTm9kZT4gdmFsdWU7CiAgICAgfTsKIAotICAgIGNoYXIgb3BlcmF0b3JW YWx1ZShDU1NQYXJzZXJWYWx1ZUxpc3QqIHRva2VucywgdW5zaWduZWQgaW5kZXgpCisgICAgY2hh ciBvcGVyYXRvclZhbHVlKENTU1BhcnNlclZhbHVlTGlzdCYgdG9rZW5zLCB1bnNpZ25lZCBpbmRl eCkKICAgICB7Ci0gICAgICAgIGlmIChpbmRleCA+PSB0b2tlbnMtPnNpemUoKSkKKyAgICAgICAg aWYgKGluZGV4ID49IHRva2Vucy5zaXplKCkpCiAgICAgICAgICAgICByZXR1cm4gMDsKLSAgICAg ICAgQ1NTUGFyc2VyVmFsdWUqIHZhbHVlID0gdG9rZW5zLT52YWx1ZUF0KGluZGV4KTsKKyAgICAg ICAgQ1NTUGFyc2VyVmFsdWUqIHZhbHVlID0gdG9rZW5zLnZhbHVlQXQoaW5kZXgpOwogICAgICAg ICBpZiAodmFsdWUtPnVuaXQgIT0gQ1NTUGFyc2VyVmFsdWU6Ok9wZXJhdG9yKQogICAgICAgICAg ICAgcmV0dXJuIDA7CiAKICAgICAgICAgcmV0dXJuIHZhbHVlLT5pVmFsdWU7CiAgICAgfQogCi0g ICAgYm9vbCBwYXJzZVZhbHVlKENTU1BhcnNlclZhbHVlTGlzdCogdG9rZW5zLCB1bnNpZ25lZCog aW5kZXgsIFZhbHVlKiByZXN1bHQpCisgICAgYm9vbCBwYXJzZVZhbHVlKENTU1BhcnNlclZhbHVl TGlzdCYgdG9rZW5zLCB1bnNpZ25lZCogaW5kZXgsIFZhbHVlKiByZXN1bHQpCiAgICAgewotICAg ICAgICBDU1NQYXJzZXJWYWx1ZSogcGFyc2VyVmFsdWUgPSB0b2tlbnMtPnZhbHVlQXQoKmluZGV4 KTsKKyAgICAgICAgQ1NTUGFyc2VyVmFsdWUqIHBhcnNlclZhbHVlID0gdG9rZW5zLnZhbHVlQXQo KmluZGV4KTsKICAgICAgICAgaWYgKHBhcnNlclZhbHVlLT51bml0ID09IENTU1BhcnNlclZhbHVl OjpPcGVyYXRvciB8fCBwYXJzZXJWYWx1ZS0+dW5pdCA9PSBDU1NQYXJzZXJWYWx1ZTo6RnVuY3Rp b24pCiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAKQEAgLTYxNSw3ICs2MTUsNyBAQCBwcml2 YXRlOgogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CiAKLSAgICBib29sIHBhcnNlVmFsdWVU ZXJtKENTU1BhcnNlclZhbHVlTGlzdCogdG9rZW5zLCBpbnQgZGVwdGgsIHVuc2lnbmVkKiBpbmRl eCwgVmFsdWUqIHJlc3VsdCkKKyAgICBib29sIHBhcnNlVmFsdWVUZXJtKENTU1BhcnNlclZhbHVl TGlzdCYgdG9rZW5zLCBpbnQgZGVwdGgsIHVuc2lnbmVkKiBpbmRleCwgVmFsdWUqIHJlc3VsdCkK ICAgICB7CiAgICAgICAgIGlmIChjaGVja0RlcHRoQW5kSW5kZXgoJmRlcHRoLCAqaW5kZXgsIHRv a2VucykgIT0gT0spCiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CkBAIC02MzQsNyArNjM0LDcg QEAgcHJpdmF0ZToKICAgICAgICAgcmV0dXJuIHBhcnNlVmFsdWUodG9rZW5zLCBpbmRleCwgcmVz dWx0KTsKICAgICB9CiAKLSAgICBib29sIHBhcnNlVmFsdWVNdWx0aXBsaWNhdGl2ZUV4cHJlc3Np b24oQ1NTUGFyc2VyVmFsdWVMaXN0KiB0b2tlbnMsIGludCBkZXB0aCwgdW5zaWduZWQqIGluZGV4 LCBWYWx1ZSogcmVzdWx0KQorICAgIGJvb2wgcGFyc2VWYWx1ZU11bHRpcGxpY2F0aXZlRXhwcmVz c2lvbihDU1NQYXJzZXJWYWx1ZUxpc3QmIHRva2VucywgaW50IGRlcHRoLCB1bnNpZ25lZCogaW5k ZXgsIFZhbHVlKiByZXN1bHQpCiAgICAgewogICAgICAgICBpZiAoY2hlY2tEZXB0aEFuZEluZGV4 KCZkZXB0aCwgKmluZGV4LCB0b2tlbnMpICE9IE9LKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNl OwpAQCAtNjQyLDcgKzY0Miw3IEBAIHByaXZhdGU6CiAgICAgICAgIGlmICghcGFyc2VWYWx1ZVRl cm0odG9rZW5zLCBkZXB0aCwgaW5kZXgsIHJlc3VsdCkpCiAgICAgICAgICAgICByZXR1cm4gZmFs c2U7CiAKLSAgICAgICAgd2hpbGUgKCppbmRleCA8IHRva2Vucy0+c2l6ZSgpIC0gMSkgeworICAg ICAgICB3aGlsZSAoKmluZGV4IDwgdG9rZW5zLnNpemUoKSAtIDEpIHsKICAgICAgICAgICAgIGNo YXIgb3BlcmF0b3JDaGFyYWN0ZXIgPSBvcGVyYXRvclZhbHVlKHRva2VucywgKmluZGV4KTsKICAg ICAgICAgICAgIGlmIChvcGVyYXRvckNoYXJhY3RlciAhPSBDYWxjTXVsdGlwbHkgJiYgb3BlcmF0 b3JDaGFyYWN0ZXIgIT0gQ2FsY0RpdmlkZSkKICAgICAgICAgICAgICAgICBicmVhazsKQEAgLTY1 NywxMSArNjU3LDExIEBAIHByaXZhdGU6CiAgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwog ICAgICAgICB9CiAKLSAgICAgICAgQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT04oKmlu ZGV4IDw9IHRva2Vucy0+c2l6ZSgpKTsKKyAgICAgICAgQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1Q TElDQVRJT04oKmluZGV4IDw9IHRva2Vucy5zaXplKCkpOwogICAgICAgICByZXR1cm4gdHJ1ZTsK ICAgICB9CiAKLSAgICBib29sIHBhcnNlQWRkaXRpdmVWYWx1ZUV4cHJlc3Npb24oQ1NTUGFyc2Vy VmFsdWVMaXN0KiB0b2tlbnMsIGludCBkZXB0aCwgdW5zaWduZWQqIGluZGV4LCBWYWx1ZSogcmVz dWx0KQorICAgIGJvb2wgcGFyc2VBZGRpdGl2ZVZhbHVlRXhwcmVzc2lvbihDU1NQYXJzZXJWYWx1 ZUxpc3QmIHRva2VucywgaW50IGRlcHRoLCB1bnNpZ25lZCogaW5kZXgsIFZhbHVlKiByZXN1bHQp CiAgICAgewogICAgICAgICBpZiAoY2hlY2tEZXB0aEFuZEluZGV4KCZkZXB0aCwgKmluZGV4LCB0 b2tlbnMpICE9IE9LKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwpAQCAtNjY5LDcgKzY2OSw3 IEBAIHByaXZhdGU6CiAgICAgICAgIGlmICghcGFyc2VWYWx1ZU11bHRpcGxpY2F0aXZlRXhwcmVz c2lvbih0b2tlbnMsIGRlcHRoLCBpbmRleCwgcmVzdWx0KSkKICAgICAgICAgICAgIHJldHVybiBm YWxzZTsKIAotICAgICAgICB3aGlsZSAoKmluZGV4IDwgdG9rZW5zLT5zaXplKCkgLSAxKSB7Cisg ICAgICAgIHdoaWxlICgqaW5kZXggPCB0b2tlbnMuc2l6ZSgpIC0gMSkgewogICAgICAgICAgICAg Y2hhciBvcGVyYXRvckNoYXJhY3RlciA9IG9wZXJhdG9yVmFsdWUodG9rZW5zLCAqaW5kZXgpOwog ICAgICAgICAgICAgaWYgKG9wZXJhdG9yQ2hhcmFjdGVyICE9IENhbGNBZGQgJiYgb3BlcmF0b3JD aGFyYWN0ZXIgIT0gQ2FsY1N1YnRyYWN0KQogICAgICAgICAgICAgICAgIGJyZWFrOwpAQCAtNjg0 LDExICs2ODQsMTEgQEAgcHJpdmF0ZToKICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAg ICAgICAgIH0KIAotICAgICAgICBBU1NFUlRfV0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTigqaW5k ZXggPD0gdG9rZW5zLT5zaXplKCkpOworICAgICAgICBBU1NFUlRfV0lUSF9TRUNVUklUWV9JTVBM SUNBVElPTigqaW5kZXggPD0gdG9rZW5zLnNpemUoKSk7CiAgICAgICAgIHJldHVybiB0cnVlOwog ICAgIH0KIAotICAgIGJvb2wgcGFyc2VWYWx1ZUV4cHJlc3Npb24oQ1NTUGFyc2VyVmFsdWVMaXN0 KiB0b2tlbnMsIGludCBkZXB0aCwgdW5zaWduZWQqIGluZGV4LCBWYWx1ZSogcmVzdWx0KQorICAg IGJvb2wgcGFyc2VWYWx1ZUV4cHJlc3Npb24oQ1NTUGFyc2VyVmFsdWVMaXN0JiB0b2tlbnMsIGlu dCBkZXB0aCwgdW5zaWduZWQqIGluZGV4LCBWYWx1ZSogcmVzdWx0KQogICAgIHsKICAgICAgICAg cmV0dXJuIHBhcnNlQWRkaXRpdmVWYWx1ZUV4cHJlc3Npb24odG9rZW5zLCBkZXB0aCwgaW5kZXgs IHJlc3VsdCk7CiAgICAgfQpAQCAtNzU3LDcgKzc1Nyw3IEBAIFJlZlB0cjxDU1NDYWxjVmFsdWU+ IENTU0NhbGNWYWx1ZTo6Y3JlYXRlKENTU1BhcnNlclN0cmluZyBuYW1lLCBDU1NQYXJzZXJWYWx1 ZUxpCiAgICAgUmVmUHRyPENTU0NhbGNFeHByZXNzaW9uTm9kZT4gZXhwcmVzc2lvbjsKIAogICAg IGlmIChuYW1lLmVxdWFsSWdub3JpbmdDYXNlKCJjYWxjKCIpIHx8IG5hbWUuZXF1YWxJZ25vcmlu Z0Nhc2UoIi13ZWJraXQtY2FsYygiKSkKLSAgICAgICAgZXhwcmVzc2lvbiA9IHBhcnNlci5wYXJz ZUNhbGMoJnBhcnNlclZhbHVlTGlzdCk7CisgICAgICAgIGV4cHJlc3Npb24gPSBwYXJzZXIucGFy c2VDYWxjKHBhcnNlclZhbHVlTGlzdCk7CiAKICAgICByZXR1cm4gZXhwcmVzc2lvbiA/IGFkb3B0 UmVmKG5ldyBDU1NDYWxjVmFsdWUoZXhwcmVzc2lvbi5yZWxlYXNlTm9uTnVsbCgpLCByYW5nZSAh PSBDYWxjdWxhdGlvblJhbmdlQWxsKSkgOiBudWxscHRyOwogfQo=