147916 2015-08-11 17:45:09 -0700 Web Inspector: TimelineView data not cleared when recording is reset 2015-08-11 23:05:32 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mattbaker mattbaker bburg commit-queue graouts hi joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1116802 0 mattbaker 2015-08-11 17:45:09 -0700 * SUMMARY TimelineView data not cleared when recording is reset. * STEPS TO REPRODUCE 1. Record a timeline 2. When finished, clear the recording 3. Switch to a different timeline view (overview -> specific timeline, timelines -> rendering frames, etc) => Data grid is empty, but tree outline contains timeline records 1116803 1 258787 mattbaker 2015-08-11 17:50:16 -0700 Created attachment 258787 [Patch] Proposed Fix 1116896 2 258787 commit-queue 2015-08-11 23:05:29 -0700 Comment on attachment 258787 [Patch] Proposed Fix Clearing flags on attachment: 258787 Committed r188330: <http://trac.webkit.org/changeset/188330> 1116897 3 commit-queue 2015-08-11 23:05:32 -0700 All reviewed patches have been landed. Closing bug. 258787 2015-08-11 17:50:16 -0700 2015-08-11 23:05:29 -0700 [Patch] Proposed Fix bug-147916-20150811175000.patch text/plain 5194 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4MzExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA5 YTA1MDhlN2UyMjU5OWFiYTEwYTViODUwNjBkNTg5YzE3YzQwNTBlLi4zNmNjNjY1MjczZjFkMDVi YmRjZGZiN2M4OTUzMGNhYzQ0OWY5YTJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyOCBAQAorMjAxNS0wOC0xMSAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVGltZWxpbmVWaWV3IGRhdGEgbm90IGNsZWFyZWQg d2hlbiByZWNvcmRpbmcgaXMgcmVzZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE0NzkxNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEVhY2ggZGVyaXZlZCB0aW1lbGluZSB2aWV3IG1haW50YWlucyBhIHNl cGFyYXRlIGFycmF5IG9mIHRpbWVsaW5lIHJlY29yZHMuIFRoZXNlIHdlcmVuJ3QKKyAgICAgICAg Y2xlYXJlZCBvbiByZXNldCwgc28gc3dpdGNoaW5nIHRvIGEgdGltZWxpbmUgdmlldyBhZnRlciBj bGVhcmluZyB0aGUgcmVjb3JkaW5nIGNhdXNlZAorICAgICAgICB0aGUgdmlldyB0byBwb3B1bGF0 ZSBpdHMgdHJlZSBvdXRsaW5lLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9MYXlv dXRUaW1lbGluZVZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuTGF5b3V0VGltZWxpbmVW aWV3LnNldCBjb2x1bW5zKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5MYXlvdXRUaW1lbGluZVZp ZXcpOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvTmV0d29ya1RpbWVsaW5lVmlldy5q czoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5OZXR3b3JrVGltZWxpbmVWaWV3LnNldCBjb2x1bW5z KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5OZXR3b3JrVGltZWxpbmVWaWV3KToKKyAgICAgICAg KiBVc2VySW50ZXJmYWNlL1ZpZXdzL092ZXJ2aWV3VGltZWxpbmVWaWV3LmpzOgorICAgICAgICAo V2ViSW5zcGVjdG9yLk92ZXJ2aWV3VGltZWxpbmVWaWV3LnByb3RvdHlwZS5yZXNldCk6CisgICAg ICAgIChXZWJJbnNwZWN0b3IuT3ZlcnZpZXdUaW1lbGluZVZpZXcucHJvdG90eXBlLl9wcm9jZXNz UGVuZGluZ1JlcHJlc2VudGVkT2JqZWN0cyk6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3 cy9SZW5kZXJpbmdGcmFtZVRpbWVsaW5lVmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5S ZW5kZXJpbmdGcmFtZVRpbWVsaW5lVmlldy5wcm90b3R5cGUucmVzZXQpOgorICAgICAgICAqIFVz ZXJJbnRlcmZhY2UvVmlld3MvU2NyaXB0VGltZWxpbmVWaWV3LmpzOgorICAgICAgICAoV2ViSW5z cGVjdG9yLlNjcmlwdFRpbWVsaW5lVmlldy5wcm90b3R5cGUucmVzZXQpOgorCiAyMDE1LTA4LTEx ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFtXaW5dIFN3 aXRjaCBXaW5kb3dzIGJ1aWxkIHRvIFZpc3VhbCBTdHVkaW8gMjAxNQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTGF5b3V0VGltZWxpbmVWaWV3 LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTGF5b3V0VGlt ZWxpbmVWaWV3LmpzCmluZGV4IGFlMmU4ZDg5YjA2MzczYzYxNzczZDc5YWVmM2ViODU2NmEzOTY2 ZWUuLmM4NTY4ODlkOGJlYTc1YmM5ODA0N2U2ZGVhN2UyZDUwYTliNDE5YTggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xheW91dFRpbWVsaW5l Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9M YXlvdXRUaW1lbGluZVZpZXcuanMKQEAgLTE1NCw2ICsxNTQsOCBAQCBXZWJJbnNwZWN0b3IuTGF5 b3V0VGltZWxpbmVWaWV3ID0gY2xhc3MgTGF5b3V0VGltZWxpbmVWaWV3IGV4dGVuZHMgV2ViSW5z cGVjdG9yLgogICAgICAgICB0aGlzLl9oaWRlSGlnaGxpZ2h0SWZOZWVkZWQoKTsKIAogICAgICAg ICB0aGlzLl9kYXRhR3JpZC5yZXNldCgpOworCisgICAgICAgIHRoaXMuX3BlbmRpbmdSZWNvcmRz ID0gW107CiAgICAgfQogCiAgICAgLy8gUHJvdGVjdGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OZXR3b3JrVGltZWxpbmVWaWV3LmpzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTmV0d29ya1RpbWVsaW5l Vmlldy5qcwppbmRleCBlM2M1YmI3N2Y4MzI0MGRmZmE0OTZhNTM3YzE4OGMwNzM5MGFiZWYyLi4y YmI0MDM2YmQyMWVhZDVlMzlmMGNiMzExMmY4ZjY1Nzg1Y2ViMzliIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OZXR3b3JrVGltZWxpbmVWaWV3 LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05ldHdv cmtUaW1lbGluZVZpZXcuanMKQEAgLTE0OCw2ICsxNDgsOCBAQCBXZWJJbnNwZWN0b3IuTmV0d29y a1RpbWVsaW5lVmlldyA9IGNsYXNzIE5ldHdvcmtUaW1lbGluZVZpZXcgZXh0ZW5kcyBXZWJJbnNw ZWN0bwogICAgICAgICBzdXBlci5yZXNldCgpOwogCiAgICAgICAgIHRoaXMuX2RhdGFHcmlkLnJl c2V0KCk7CisKKyAgICAgICAgdGhpcy5fcGVuZGluZ1JlY29yZHMgPSBbXTsKICAgICB9CiAKICAg ICAvLyBQcm90ZWN0ZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL092ZXJ2aWV3VGltZWxpbmVWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT3ZlcnZpZXdUaW1lbGluZVZpZXcuanMKaW5kZXggZDU2 MjRlMDg1ZDVlMjM3ZjVlOTkzNGU5YzRkMDNhOTI1NDYxOTY3Ny4uMmZiZDUxOTA4YjU1NjQzODFi NjVmMmMyNTE1OTM4Yjk0YzhjMzE5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvT3ZlcnZpZXdUaW1lbGluZVZpZXcuanMKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT3ZlcnZpZXdUaW1lbGluZVZpZXcu anMKQEAgLTE0Miw2ICsxNDIsMTMgQEAgV2ViSW5zcGVjdG9yLk92ZXJ2aWV3VGltZWxpbmVWaWV3 ID0gY2xhc3MgT3ZlcnZpZXdUaW1lbGluZVZpZXcgZXh0ZW5kcyBXZWJJbnNwZWMKICAgICAgICAg cmV0dXJuIHBhdGhDb21wb25lbnRzOwogICAgIH0KIAorICAgIHJlc2V0KCkKKyAgICB7CisgICAg ICAgIHN1cGVyLnJlc2V0KCk7CisKKyAgICAgICAgdGhpcy5fcGVuZGluZ1JlcHJlc2VudGVkT2Jq ZWN0cyA9IFtdOworICAgIH0KKwogICAgIC8vIFByb3RlY3RlZAogCiAgICAgdHJlZUVsZW1lbnRQ YXRoQ29tcG9uZW50U2VsZWN0ZWQoZXZlbnQpCkBAIC0zMDYsNyArMzEzLDcgQEAgV2ViSW5zcGVj dG9yLk92ZXJ2aWV3VGltZWxpbmVWaWV3ID0gY2xhc3MgT3ZlcnZpZXdUaW1lbGluZVZpZXcgZXh0 ZW5kcyBXZWJJbnNwZWMKIAogICAgIF9wcm9jZXNzUGVuZGluZ1JlcHJlc2VudGVkT2JqZWN0cygp CiAgICAgewotICAgICAgICBpZiAoIXRoaXMuX3BlbmRpbmdSZXByZXNlbnRlZE9iamVjdHMgfHwg IXRoaXMuX3BlbmRpbmdSZXByZXNlbnRlZE9iamVjdHMubGVuZ3RoKQorICAgICAgICBpZiAoIXRo aXMuX3BlbmRpbmdSZXByZXNlbnRlZE9iamVjdHMubGVuZ3RoKQogICAgICAgICAgICAgcmV0dXJu OwogCiAgICAgICAgIGZvciAodmFyIHJlcHJlc2VudGVkT2JqZWN0IG9mIHRoaXMuX3BlbmRpbmdS ZXByZXNlbnRlZE9iamVjdHMpIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL1JlbmRlcmluZ0ZyYW1lVGltZWxpbmVWaWV3LmpzIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUmVuZGVyaW5nRnJhbWVUaW1lbGlu ZVZpZXcuanMKaW5kZXggNDVmZTBiOTgxZmVhZmM5YWE3YTNhZjcwYjM3MTE5ZmY4M2YxN2Q2Yi4u OTMwYzlkMzI1ZDQyY2QzOTdjMDc2Mzc5MjYyM2I3NzRhZGVkOTVlMiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUmVuZGVyaW5nRnJhbWVUaW1l bGluZVZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvUmVuZGVyaW5nRnJhbWVUaW1lbGluZVZpZXcuanMKQEAgLTE4OSw2ICsxODksOCBAQCBXZWJJ bnNwZWN0b3IuUmVuZGVyaW5nRnJhbWVUaW1lbGluZVZpZXcgPSBjbGFzcyBSZW5kZXJpbmdGcmFt ZVRpbWVsaW5lVmlldyBleHRlbgogICAgICAgICBzdXBlci5yZXNldCgpOwogCiAgICAgICAgIHRo aXMuX2RhdGFHcmlkLnJlc2V0KCk7CisKKyAgICAgICAgdGhpcy5fcGVuZGluZ1JlY29yZHMgPSBb XTsKICAgICB9CiAKICAgICAvLyBQcm90ZWN0ZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NjcmlwdFRpbWVsaW5lVmlldy5qcyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NjcmlwdFRpbWVsaW5lVmlldy5q cwppbmRleCBmZjA0OTJlNzAzMTg0ODFmZWE4M2Y0MDlhYWViNDJmOGE3N2Y0NTEwLi45ZjVlMTM1 MDBmNjg5YjU2M2IwODI4Mzg0MGZhMjNlNDI3MDcxNzQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TY3JpcHRUaW1lbGluZVZpZXcuanMKKysr IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2NyaXB0VGltZWxp bmVWaWV3LmpzCkBAIC0xNjIsNiArMTYyLDggQEAgV2ViSW5zcGVjdG9yLlNjcmlwdFRpbWVsaW5l VmlldyA9IGNsYXNzIFNjcmlwdFRpbWVsaW5lVmlldyBleHRlbmRzIFdlYkluc3BlY3Rvci4KICAg ICAgICAgc3VwZXIucmVzZXQoKTsKIAogICAgICAgICB0aGlzLl9kYXRhR3JpZC5yZXNldCgpOwor CisgICAgICAgIHRoaXMuX3BlbmRpbmdSZWNvcmRzID0gW107CiAgICAgfQogCiAgICAgLy8gUHJv dGVjdGVkCg==