147913 2015-08-11 16:40:10 -0700 Web Inspector: DOM Node should have context menu to scroll it into view on the inspected page 2015-08-12 12:04:03 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 joepeck joepeck bburg graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1116784 0 joepeck 2015-08-11 16:40:10 -0700 * SUMMARY DOM Node should have context menu to scroll it into view on the inspected page * NOTES - Chrome and Firefox both have this. 1116786 1 258780 joepeck 2015-08-11 16:44:57 -0700 Created attachment 258780 [PATCH] Proposed Fix 1116800 2 258780 hi 2015-08-11 17:33:19 -0700 Comment on attachment 258780 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=258780&action=review > Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:1377 > + var node = this.representedObject; NIT: Aren't we using let now? By the way, this doesn't apply to TOT. 1116829 3 258780 timothy 2015-08-11 19:31:52 -0700 Comment on attachment 258780 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=258780&action=review > Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:672 > + contextMenu.appendItem(WebInspector.UIString("Scroll Into View"), this._scrollIntoView.bind(this)); Should we only show this context menu item in the console and object trees? Showing it in the Elements tab seems silly. 1116844 4 nvasilyev 2015-08-11 20:24:18 -0700 (In reply to comment #3) > Comment on attachment 258780 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=258780&action=review > > > Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:672 > > + contextMenu.appendItem(WebInspector.UIString("Scroll Into View"), this._scrollIntoView.bind(this)); > > Should we only show this context menu item in the console and object trees? > Showing it in the Elements tab seems silly. I don't think it's silly. When I inspect CodeMirror I see lots of similar looking nodes — it's not always clear if the selected element is invisible or just out of the screen. 1116847 5 timothy 2015-08-11 20:45:56 -0700 Oh, it scrolls the page not the DOM tree. Not silly at all. 1116849 6 258780 timothy 2015-08-11 20:47:58 -0700 Comment on attachment 258780 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=258780&action=review > Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:670 > + var node = this.representedObject; Let here too. 1116986 7 joepeck 2015-08-12 11:26:31 -0700 (In reply to comment #2) > Comment on attachment 258780 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=258780&action=review > > > Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:1377 > > + var node = this.representedObject; > > NIT: Aren't we using let now? > > By the way, this doesn't apply to TOT. This doesn't apply to ToT because of localizedString changes and svn-apply doesn't deal with binary diffs well. 1117008 8 joepeck 2015-08-12 12:04:03 -0700 http://trac.webkit.org/changeset/188343 258780 2015-08-11 16:44:57 -0700 2015-08-12 12:03:57 -0700 [PATCH] Proposed Fix scroll-into-view.patch text/plain 5263 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDk0YjZmN2IuLjAwMGFiZjQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMxIEBACiAyMDE1LTA4LTExICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRE9NIE5v ZGUgc2hvdWxkIGhhdmUgY29udGV4dCBtZW51IHRvIHNjcm9sbCBpdCBpbnRvIHZpZXcgb24gdGhl IGluc3BlY3RlZCBwYWdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNDc5MTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIExvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qczoKKyAg ICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVFbGVtZW50LmpzOgorICAgICAgICAo V2ViSW5zcGVjdG9yLkRPTVRyZWVFbGVtZW50LnByb3RvdHlwZS5fdXBkYXRlQ2hpbGRyZW4uc2V0 IGNvbnRpbnVlKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5ET01UcmVlRWxlbWVudC5wcm90b3R5 cGUuX3BvcHVsYXRlTm9kZUNvbnRleHRNZW51KToKKyAgICAgICAgQWRkIGEgY29udGV4dCBtZW51 IGl0ZW0gdG8gc2Nyb2xsIGludG8gdmlldyBmb3IgZWxlbWVudCBub2Rlcy4KKworICAgICAgICAo V2ViSW5zcGVjdG9yLkRPTVRyZWVFbGVtZW50LnByb3RvdHlwZS5fc2Nyb2xsSW50b1ZpZXcucmVz b2x2ZWROb2RlLnNjcm9sbEludG9WaWV3KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5ET01UcmVl RWxlbWVudC5wcm90b3R5cGUuX3Njcm9sbEludG9WaWV3LnJlc29sdmVkTm9kZSk6CisgICAgICAg IChXZWJJbnNwZWN0b3IuRE9NVHJlZUVsZW1lbnQucHJvdG90eXBlLl9zY3JvbGxJbnRvVmlldyk6 CisgICAgICAgIENhbGwgc2Nyb2xsSW50b1ZpZXdJZk5lZWRlZCBvbiB0aGUgcmVhbCBOb2RlLgor CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVlT3V0bGluZS5qczoKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5ET01UcmVlT3V0bGluZS5wcm90b3R5cGUucG9wdWxhdGVDb250ZXh0 TWVudSk6CisgICAgICAgIFJlbW92ZSB1bnVzZWQgcGFyYW1ldGVyLgorCisgICAgICAgICogVXNl ckludGVyZmFjZS9WaWV3cy9PYmplY3RUcmVlQmFzZVRyZWVFbGVtZW50LmpzOgorICAgICAgICAo V2ViSW5zcGVjdG9yLk9iamVjdFRyZWVCYXNlVHJlZUVsZW1lbnQucHJvdG90eXBlLl9hcHBlbmRN ZW51c0l0ZW1zRm9yT2JqZWN0KToKKyAgICAgICAgQWRkIGNvbnRleHQgbWVudSBmb3IgTm9kZXMg aW4gT2JqZWN0VHJlZXMuCisKKzIwMTUtMDgtMTEgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJv QGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBXYXRjaCBFeHByZXNzaW9ucwog ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ3OTA0CiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRpb25zL2VuLmxwcm9q L2xvY2FsaXplZFN0cmluZ3MuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvTG9jYWxpemF0aW9u cy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzCmluZGV4IDhhZWJjODkxY2IxMTdjMGNhZjMy MWE4YjJjYTNjMWJiODcyZGM4MTcuLmJlMWZkMDk2OGJhYzViMWIyNTgxMjI5YTgzNzA1MmU1ZjI0 ZTZlOTAgMTAwNjQ0CkdJVCBiaW5hcnkgcGF0Y2gKZGVsdGEgOTIKemNtZG5mJCtEQDdXa2RhRyZ0 ISVvaEoxemBBWEglUldYTk1FMHJDX1chV2MzY1FXP3FfbG8oPXhKWDtgRVZoQ295ClF0OUo1Jik4 P0J5UGE5aFQwMEU+SDJtazs4CgpkZWx0YSAxNApXY21kbmcjaj5aOVdrZGJ4JjBrTzNTXkB3enVt XjFiCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvRE9NVHJlZUVsZW1lbnQuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9ET01UcmVlRWxlbWVudC5qcwppbmRleCBkN2YxOWQ2Li4yNjIzZjVmIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVlRWxl bWVudC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9E T01UcmVlRWxlbWVudC5qcwpAQCAtNjY2LDYgKzY2NiwxMCBAQCBXZWJJbnNwZWN0b3IuRE9NVHJl ZUVsZW1lbnQgPSBjbGFzcyBET01UcmVlRWxlbWVudCBleHRlbmRzIFdlYkluc3BlY3Rvci5UcmVl RWxlbQogICAgICAgICBjb250ZXh0TWVudS5hcHBlbmRJdGVtKFdlYkluc3BlY3Rvci5VSVN0cmlu ZygiQ29weSBhcyBIVE1MIiksIHRoaXMuX2NvcHlIVE1MLmJpbmQodGhpcykpOwogICAgICAgICBp ZiAodGhpcy5lZGl0YWJsZSkKICAgICAgICAgICAgIGNvbnRleHRNZW51LmFwcGVuZEl0ZW0oV2Vi SW5zcGVjdG9yLlVJU3RyaW5nKCJEZWxldGUgTm9kZSIpLCB0aGlzLnJlbW92ZS5iaW5kKHRoaXMp KTsKKworICAgICAgICB2YXIgbm9kZSA9IHRoaXMucmVwcmVzZW50ZWRPYmplY3Q7CisgICAgICAg IGlmIChub2RlLm5vZGVUeXBlKCkgPT09IE5vZGUuRUxFTUVOVF9OT0RFKQorICAgICAgICAgICAg Y29udGV4dE1lbnUuYXBwZW5kSXRlbShXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlNjcm9sbCBJbnRv IFZpZXciKSwgdGhpcy5fc2Nyb2xsSW50b1ZpZXcuYmluZCh0aGlzKSk7CiAgICAgfQogCiAgICAg X3N0YXJ0RWRpdGluZygpCkBAIC0xMzU0LDYgKzEzNTgsMjYgQEAgV2ViSW5zcGVjdG9yLkRPTVRy ZWVFbGVtZW50ID0gY2xhc3MgRE9NVHJlZUVsZW1lbnQgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuVHJl ZUVsZW0KICAgICAgICAgdGhpcy5yZXByZXNlbnRlZE9iamVjdC5yZW1vdmVOb2RlKHJlbW92ZU5v ZGVDYWxsYmFjayk7CiAgICAgfQogCisgICAgX3Njcm9sbEludG9WaWV3KCkKKyAgICB7CisgICAg ICAgIGZ1bmN0aW9uIHJlc29sdmVkTm9kZShvYmplY3QpCisgICAgICAgIHsKKyAgICAgICAgICAg IGlmICghb2JqZWN0KQorICAgICAgICAgICAgICAgIHJldHVybjsKKworICAgICAgICAgICAgZnVu Y3Rpb24gc2Nyb2xsSW50b1ZpZXcoKQorICAgICAgICAgICAgeworICAgICAgICAgICAgICAgIHRo aXMuc2Nyb2xsSW50b1ZpZXdJZk5lZWRlZCh0cnVlKTsKKyAgICAgICAgICAgIH0KKworICAgICAg ICAgICAgb2JqZWN0LmNhbGxGdW5jdGlvbihzY3JvbGxJbnRvVmlldywgdW5kZWZpbmVkLCBmYWxz ZSwgZnVuY3Rpb24oKSB7fSk7CisgICAgICAgICAgICBvYmplY3QucmVsZWFzZSgpOworICAgICAg ICB9CisKKyAgICAgICAgdmFyIG5vZGUgPSB0aGlzLnJlcHJlc2VudGVkT2JqZWN0OworICAgICAg ICBXZWJJbnNwZWN0b3IuUmVtb3RlT2JqZWN0LnJlc29sdmVOb2RlKG5vZGUsICIiLCByZXNvbHZl ZE5vZGUpOworICAgIH0KKwogICAgIF9lZGl0QXNIVE1MKCkKICAgICB7CiAgICAgICAgIHZhciB0 cmVlT3V0bGluZSA9IHRoaXMudHJlZU91dGxpbmU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVlT3V0bGluZS5qcyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVPdXRsaW5lLmpzCmluZGV4 IDMzYTUwNjMuLmY4ZTVlZjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVPdXRsaW5lLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVPdXRsaW5lLmpzCkBAIC0yNjYsNyArMjY2 LDcgQEAgV2ViSW5zcGVjdG9yLkRPTVRyZWVPdXRsaW5lID0gY2xhc3MgRE9NVHJlZU91dGxpbmUg ZXh0ZW5kcyBXZWJJbnNwZWN0b3IuVHJlZU91dGwKICAgICAgICAgfSBlbHNlIGlmIChjb21tZW50 Tm9kZSAmJiB0cmVlRWxlbWVudC5fcG9wdWxhdGVOb2RlQ29udGV4dE1lbnUpIHsKICAgICAgICAg ICAgIGlmIChwb3B1bGF0ZWQpCiAgICAgICAgICAgICAgICAgY29udGV4dE1lbnUuYXBwZW5kU2Vw YXJhdG9yKCk7Ci0gICAgICAgICAgICB0cmVlRWxlbWVudC5fcG9wdWxhdGVOb2RlQ29udGV4dE1l bnUoY29udGV4dE1lbnUsIHRleHROb2RlKTsKKyAgICAgICAgICAgIHRyZWVFbGVtZW50Ll9wb3B1 bGF0ZU5vZGVDb250ZXh0TWVudShjb250ZXh0TWVudSk7CiAgICAgICAgICAgICBwb3B1bGF0ZWQg PSB0cnVlOwogICAgICAgICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL09iamVjdFRyZWVCYXNlVHJlZUVsZW1lbnQuanMgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9PYmplY3RUcmVlQmFzZVRyZWVFbGVt ZW50LmpzCmluZGV4IDc1ZjE2YjYuLmQ4NGQ2N2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL09iamVjdFRyZWVCYXNlVHJlZUVsZW1lbnQuanMK KysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT2JqZWN0VHJl ZUJhc2VUcmVlRWxlbWVudC5qcwpAQCAtMjQ2LDYgKzI0NiwxMSBAQCBXZWJJbnNwZWN0b3IuT2Jq ZWN0VHJlZUJhc2VUcmVlRWxlbWVudCA9IGNsYXNzIE9iamVjdFRyZWVCYXNlVHJlZUVsZW1lbnQg ZXh0ZW5kcwogICAgICAgICAgICAgICAgIH0pOwogICAgICAgICAgICAgfSk7CiAKKyAgICAgICAg ICAgIGNvbnRleHRNZW51LmFwcGVuZEl0ZW0oV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJTY3JvbGwg SW50byBWaWV3IiksIGZ1bmN0aW9uKCkgeworICAgICAgICAgICAgICAgIGZ1bmN0aW9uIHNjcm9s bEludG9WaWV3KCkgeyB0aGlzLnNjcm9sbEludG9WaWV3SWZOZWVkZWQodHJ1ZSk7IH0KKyAgICAg ICAgICAgICAgICByZXNvbHZlZFZhbHVlLmNhbGxGdW5jdGlvbihzY3JvbGxJbnRvVmlldywgdW5k ZWZpbmVkLCBmYWxzZSwgZnVuY3Rpb24oKSB7fSk7CisgICAgICAgICAgICB9KTsKKwogICAgICAg ICAgICAgY29udGV4dE1lbnUuYXBwZW5kU2VwYXJhdG9yKCk7CiAKICAgICAgICAgICAgIGNvbnRl eHRNZW51LmFwcGVuZEl0ZW0oV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJSZXZlYWwgaW4gRE9NIFRy ZWUiKSwgZnVuY3Rpb24oKSB7Cg==