147905 2015-08-11 15:19:33 -0700 Fix names of Lock tests: should be "Contended", not "Contented". 2015-08-11 16:23:39 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam commit-queue oldest_to_newest 1116744 0 mark.lam 2015-08-11 15:19:33 -0700 We're testing the behavior of lock contention (i.e. when threads contend), not whether the locks are happy (contented). 1116747 1 258769 mark.lam 2015-08-11 15:29:03 -0700 Created attachment 258769 the fix. 1116751 2 258769 saam 2015-08-11 15:30:56 -0700 Comment on attachment 258769 the fix. r=me 1116773 3 258769 commit-queue 2015-08-11 16:23:37 -0700 Comment on attachment 258769 the fix. Clearing flags on attachment: 258769 Committed r188309: <http://trac.webkit.org/changeset/188309> 1116774 4 commit-queue 2015-08-11 16:23:39 -0700 All reviewed patches have been landed. Closing bug. 258769 2015-08-11 15:29:03 -0700 2015-08-11 16:23:37 -0700 the fix. bug-147905.patch text/plain 3287 mark.lam SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4ODMwMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIwIEBACisyMDE1LTA4LTExICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKwor ICAgICAgICBGaXggbmFtZXMgb2YgTG9jayB0ZXN0czogc2hvdWxkIGJlICJDb250ZW5kZWQiLCBu b3QgIkNvbnRlbnRlZCIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNDc5MDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBXZSdyZSB0ZXN0aW5nIHRoZSBiZWhhdmlvciBvZiBsb2NrIGNvbnRlbnRpb24gKGku ZS4gd2hlbiB0aHJlYWRzIGNvbnRlbmQpLCBub3QKKyAgICAgICAgd2hldGhlciB0aGUgbG9ja3Mg YXJlIGhhcHB5IChjb250ZW50ZWQpLgorCisgICAgICAgICogU2NyaXB0cy9ydW4tZ3RrLXRlc3Rz OgorICAgICAgICAoVGVzdFJ1bm5lcik6CisgICAgICAgIChUZXN0UnVubmVyLl9faW5pdF9fKTog RGVsZXRlZC4KKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9Mb2NrLmNwcDoKKyAg ICAgICAgKFRlc3RXZWJLaXRBUEk6OnJ1bkxvY2tUZXN0KToKKyAgICAgICAgKFRlc3RXZWJLaXRB UEk6OlRFU1QpOgorCiAyMDE1LTA4LTExICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUu Y29tPgogCiAgICAgICAgIFtXaW5dIFN3aXRjaCBXaW5kb3dzIGJ1aWxkIHRvIFZpc3VhbCBTdHVk aW8gMjAxNQpJbmRleDogVG9vbHMvU2NyaXB0cy9ydW4tZ3RrLXRlc3RzCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFRvb2xzL1NjcmlwdHMvcnVuLWd0ay10ZXN0cwkocmV2aXNpb24gMTg4MzAxKQorKysgVG9vbHMv U2NyaXB0cy9ydW4tZ3RrLXRlc3RzCSh3b3JraW5nIGNvcHkpCkBAIC04MSw3ICs4MSw3IEBAIGNs YXNzIFRlc3RSdW5uZXI6CiAgICAgXQogCiAgICAgU0xPVyA9IFsKLSAgICAgICAgIldURl9Mb2Nr LkNvbnRlbnRlZFNob3J0U2VjdGlvbiIsCisgICAgICAgICJXVEZfTG9jay5Db250ZW5kZWRTaG9y dFNlY3Rpb24iLAogICAgIF0KIAogICAgIGRlZiBfX2luaXRfXyhzZWxmLCBvcHRpb25zLCB0ZXN0 cz1bXSk6CkluZGV4OiBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9Mb2NrLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9Mb2NrLmNwcAkocmV2aXNp b24gMTg4MzAxKQorKysgVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvTG9jay5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTY4LDYyICs2OCw2MiBAQCB2b2lkIHJ1bkxvY2tUZXN0KHVuc2lnbmVk IG51bVRocmVhZEdyb3VwCiAgICAgICAgIEVYUEVDVF9FUShleHBlY3RlZCwgd29yZHNbdGhyZWFk R3JvdXBJbmRleF0pOwogfQogCi1URVNUKFdURl9Mb2NrLCBVbmNvbnRlbnRlZFNob3J0U2VjdGlv bikKK1RFU1QoV1RGX0xvY2ssIFVuY29udGVuZGVkU2hvcnRTZWN0aW9uKQogewogICAgIHJ1bkxv Y2tUZXN0PExvY2s+KDEsIDEsIDEsIDEwMDAwMDAwKTsKIH0KIAotVEVTVChXVEZfTG9jaywgVW5j b250ZW50ZWRMb25nU2VjdGlvbikKK1RFU1QoV1RGX0xvY2ssIFVuY29udGVuZGVkTG9uZ1NlY3Rp b24pCiB7CiAgICAgcnVuTG9ja1Rlc3Q8TG9jaz4oMSwgMSwgMTAwMDAsIDEwMDApOwogfQogCi1U RVNUKFdURl9Mb2NrLCBDb250ZW50ZWRTaG9ydFNlY3Rpb24pCitURVNUKFdURl9Mb2NrLCBDb250 ZW5kZWRTaG9ydFNlY3Rpb24pCiB7CiAgICAgcnVuTG9ja1Rlc3Q8TG9jaz4oMSwgMTAsIDEsIDEw MDAwMDAwKTsKIH0KIAotVEVTVChXVEZfTG9jaywgQ29udGVudGVkTG9uZ1NlY3Rpb24pCitURVNU KFdURl9Mb2NrLCBDb250ZW5kZWRMb25nU2VjdGlvbikKIHsKICAgICBydW5Mb2NrVGVzdDxMb2Nr PigxLCAxMCwgMTAwMDAsIDEwMDAwKTsKIH0KIAotVEVTVChXVEZfTG9jaywgTWFueUNvbnRlbnRl ZFNob3J0U2VjdGlvbnMpCitURVNUKFdURl9Mb2NrLCBNYW55Q29udGVuZGVkU2hvcnRTZWN0aW9u cykKIHsKICAgICBydW5Mb2NrVGVzdDxMb2NrPigxMCwgMTAsIDEsIDUwMDAwMCk7CiB9CiAKLVRF U1QoV1RGX0xvY2ssIE1hbnlDb250ZW50ZWRMb25nU2VjdGlvbnMpCitURVNUKFdURl9Mb2NrLCBN YW55Q29udGVuZGVkTG9uZ1NlY3Rpb25zKQogewogICAgIHJ1bkxvY2tUZXN0PExvY2s+KDEwLCAx MCwgMTAwMDAsIDEwMDApOwogfQogCi1URVNUKFdURl9CeXRlTG9jaywgVW5jb250ZW50ZWRTaG9y dFNlY3Rpb24pCitURVNUKFdURl9CeXRlTG9jaywgVW5jb250ZW5kZWRTaG9ydFNlY3Rpb24pCiB7 CiAgICAgcnVuTG9ja1Rlc3Q8Qnl0ZUxvY2s+KDEsIDEsIDEsIDEwMDAwMDAwKTsKIH0KIAotVEVT VChXVEZfQnl0ZUxvY2ssIFVuY29udGVudGVkTG9uZ1NlY3Rpb24pCitURVNUKFdURl9CeXRlTG9j aywgVW5jb250ZW5kZWRMb25nU2VjdGlvbikKIHsKICAgICBydW5Mb2NrVGVzdDxCeXRlTG9jaz4o MSwgMSwgMTAwMDAsIDEwMDApOwogfQogCi1URVNUKFdURl9CeXRlTG9jaywgQ29udGVudGVkU2hv cnRTZWN0aW9uKQorVEVTVChXVEZfQnl0ZUxvY2ssIENvbnRlbmRlZFNob3J0U2VjdGlvbikKIHsK ICAgICBydW5Mb2NrVGVzdDxCeXRlTG9jaz4oMSwgMTAsIDEsIDEwMDAwMDAwKTsKIH0KIAotVEVT VChXVEZfQnl0ZUxvY2ssIENvbnRlbnRlZExvbmdTZWN0aW9uKQorVEVTVChXVEZfQnl0ZUxvY2ss IENvbnRlbmRlZExvbmdTZWN0aW9uKQogewogICAgIHJ1bkxvY2tUZXN0PEJ5dGVMb2NrPigxLCAx MCwgMTAwMDAsIDEwMDAwKTsKIH0KIAotVEVTVChXVEZfQnl0ZUxvY2ssIE1hbnlDb250ZW50ZWRT aG9ydFNlY3Rpb25zKQorVEVTVChXVEZfQnl0ZUxvY2ssIE1hbnlDb250ZW5kZWRTaG9ydFNlY3Rp b25zKQogewogICAgIHJ1bkxvY2tUZXN0PEJ5dGVMb2NrPigxMCwgMTAsIDEsIDUwMDAwMCk7CiB9 CiAKLVRFU1QoV1RGX0J5dGVMb2NrLCBNYW55Q29udGVudGVkTG9uZ1NlY3Rpb25zKQorVEVTVChX VEZfQnl0ZUxvY2ssIE1hbnlDb250ZW5kZWRMb25nU2VjdGlvbnMpCiB7CiAgICAgcnVuTG9ja1Rl c3Q8Qnl0ZUxvY2s+KDEwLCAxMCwgMTAwMDAsIDEwMDApOwogfQo=