147896 2015-08-11 13:14:43 -0700 REGRESSION (r188053): Sometimes unable to save an image from Google Search/imgur via long press 2015-08-11 13:42:17 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin enrica oldest_to_newest 1116667 0 bdakin 2015-08-11 13:14:43 -0700 Sometimes unable to save an image from Google Search/imgur via long press Regression from http://trac.webkit.org/changeset/188053 1116678 1 258747 bdakin 2015-08-11 13:25:37 -0700 Created attachment 258747 Patch 1116683 2 258747 enrica 2015-08-11 13:33:59 -0700 Comment on attachment 258747 Patch Looks good to me. Thanks for fixing this! 1116684 3 bdakin 2015-08-11 13:36:44 -0700 Thank you! http://trac.webkit.org/changeset/188285 1116688 4 bdakin 2015-08-11 13:42:17 -0700 rdar://problem/22206433 258747 2015-08-11 13:25:37 -0700 2015-08-11 13:33:59 -0700 Patch for-review.txt text/plain 4088 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4ODI4MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMzIEBACisyMDE1LTA4LTExICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTg4MDUzKTog U29tZXRpbWVzIHVuYWJsZSB0byBzYXZlIGFuIGltYWdlIGZyb20gR29vZ2xlIFNlYXJjaC8KKyAg ICAgICAgaW1ndXIgdmlhIGxvbmcgcHJlc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0Nzg5NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzE4ODA1 MyBhZGRlZCBjb2RlIHRvIGNhbGwgY2xlYW51cFNoZWV0IHdoZW4gCisgICAgICAgIHRoZSBsb25n IHByZXNzIGdlc3R1cmUgaXMgY2FuY2VsbGVkLiBIb3dldmVyLCB0aGUgZ2VzdHVyZSB3aWxsIGJl IGNhbGxlZCB3aXRoIAorICAgICAgICB0aGUgY2FuY2VsbGVkIHN0YXRlIHdoZW4gdGhlbiB1c2Vy IHRhcHMgYW4gaXRlbSBpbiB0aGUgYWN0aW9uIHNoZWV0IChzdWNoIGFzIAorICAgICAgICDigJxz YXZlIGltYWdl4oCdKSwgYW5kIHNvbWV0aW1lcyB0aGUg4oCcY2FuY2Vs4oCdIGNvbWVzIGluIGJl Zm9yZSB0aGUgaW1hZ2UgaGFzIGJlZW4gCisgICAgICAgIHNhdmVkLiBUaGF0IGlzIGEgcHJvYmxl bSBiZWNhdXNlIHdlIG5lZWQgdG8gYXZvaWQgY2xlYW5pbmcgdXAgdGhlIHNoZWV0IHVudGlsIAor ICAgICAgICBhZnRlciB0aGUgaW1hZ2UgaXMgc2F2ZWQuIEJlZm9yZSB0aGF0IHBhdGNoLCB3ZSBu ZXZlciBjbGVhbmVkIHVwIHRoZSBzaGVldCBvbiAKKyAgICAgICAgY2FuY2VsLCBzbyB0aGlzIHBh dGNoIGdvZXMgYmFjayB0byB0aGF0IGJlaGF2aW9yLiBXZSBhbHNvIGhhdmUgdG8gcmVtb3ZlIHNv bWUgCisgICAgICAgIGFzc2VydGlvbnMgdGhhdCBhc3N1bWUgdGhhdCBldmVyeXRoaW5nIHdpbGwg YmUgdG90YWxseSBjbGVhbmVkIHVwIHdoZW4gYSBuZXcgCisgICAgICAgIHNoZWV0IGlzIGNyZWF0 ZWQsIGJ1dCB0aGF0IGlzIG5vdCBuZWNlc3NhcmlseSB0cnVlIGR1ZSB0byBpbnRlcmFjdGlvbnMg CisgICAgICAgIGJldHdlZW4gdGhlIHByZXZpZXcgZ2VzdHVyZSBhbmQgdGhlIGxvbmcgcHJlc3Mg Z2VzdHVyZS4gCisKKyAgICAgICAgUmVtb3ZlIGFzc2VydGlvbnMuCisgICAgICAgICogVUlQcm9j ZXNzL2lvcy9XS0FjdGlvblNoZWV0QXNzaXN0YW50Lm1tOgorICAgICAgICAoLVtXS0FjdGlvblNo ZWV0QXNzaXN0YW50IF9jcmVhdGVTaGVldFdpdGhFbGVtZW50QWN0aW9uczpzaG93TGlua1RpdGxl Ol0pOgorICAgICAgICAoLVtXS0FjdGlvblNoZWV0QXNzaXN0YW50IHNob3dJbWFnZVNoZWV0XSk6 CisgICAgICAgICgtW1dLQWN0aW9uU2hlZXRBc3Npc3RhbnQgc2hvd0xpbmtTaGVldF0pOgorICAg ICAgICAoLVtXS0FjdGlvblNoZWV0QXNzaXN0YW50IHNob3dEYXRhRGV0ZWN0b3JzU2hlZXRdKToK KworICAgICAgICBSZXZlcnQgdGhlIHBhcnQgb2YgRW5yaWNh4oCZcyBwYXRjaCB0aGF0IGNhbGxl ZCBjbGVhbnVwU2hlZXQgd2hlbiB0aGUgZ2VzdHVyZSBpcyBjYW5jZWxsZWQuCisgICAgICAgICog VUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAgICgtW1dL Q29udGVudFZpZXcgX2xvbmdQcmVzc1JlY29nbml6ZWQ6XSk6CisKIDIwMTUtMDgtMTEgIEFuZGVy cyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgdW52ZXJz aW9uZWQgY2xpZW50IHN0cnVjdHMgZnJvbSB0aGUgQyBTUEkKSW5kZXg6IFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9pb3MvV0tBY3Rpb25TaGVldEFzc2lzdGFudC5tbQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQWN0aW9uU2hlZXRBc3Npc3RhbnQubW0JKHJl dmlzaW9uIDE4ODIzMSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tBY3Rpb25T aGVldEFzc2lzdGFudC5tbQkod29ya2luZyBjb3B5KQpAQCAtMjA2LDcgKzIwNiw2IEBAIC0gKHZv aWQpdXBkYXRlU2hlZXRQb3NpdGlvbgogCiAtICh2b2lkKV9jcmVhdGVTaGVldFdpdGhFbGVtZW50 QWN0aW9uczooTlNBcnJheSAqKWFjdGlvbnMgc2hvd0xpbmtUaXRsZTooQk9PTClzaG93TGlua1Rp dGxlCiB7Ci0gICAgQVNTRVJUKCFfaW50ZXJhY3Rpb25TaGVldCk7CiAgICAgYXV0byBkZWxlZ2F0 ZSA9IF9kZWxlZ2F0ZS5nZXQoKTsKICAgICBpZiAoIWRlbGVnYXRlKQogICAgICAgICByZXR1cm47 CkBAIC0yNjMsNyArMjYyLDYgQEAgLSAodm9pZClfY3JlYXRlU2hlZXRXaXRoRWxlbWVudEFjdGlv bnM6KAogCiAtICh2b2lkKXNob3dJbWFnZVNoZWV0CiB7Ci0gICAgQVNTRVJUKCFfaW50ZXJhY3Rp b25TaGVldCk7CiAgICAgQVNTRVJUKCFfZWxlbWVudEluZm8pOwogCiAgICAgYXV0byBkZWxlZ2F0 ZSA9IF9kZWxlZ2F0ZS5nZXQoKTsKQEAgLTM3Myw3ICszNzEsNiBAQCAtIChSZXRhaW5QdHI8TlNB cnJheT4pZGVmYXVsdEFjdGlvbnNGb3JJCiAKIC0gKHZvaWQpc2hvd0xpbmtTaGVldAogewotICAg IEFTU0VSVCghX2ludGVyYWN0aW9uU2hlZXQpOwogICAgIEFTU0VSVCghX2VsZW1lbnRJbmZvKTsK IAogICAgIGF1dG8gZGVsZWdhdGUgPSBfZGVsZWdhdGUuZ2V0KCk7CkBAIC00MDYsOCArNDAzLDYg QEAgLSAodm9pZClzaG93TGlua1NoZWV0CiAKIC0gKHZvaWQpc2hvd0RhdGFEZXRlY3RvcnNTaGVl dAogewotICAgIEFTU0VSVCghX2ludGVyYWN0aW9uU2hlZXQpOwotCiAgICAgYXV0byBkZWxlZ2F0 ZSA9IF9kZWxlZ2F0ZS5nZXQoKTsKICAgICBpZiAoIWRlbGVnYXRlKQogICAgICAgICByZXR1cm47 CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFj dGlvbi5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29u dGVudFZpZXdJbnRlcmFjdGlvbi5tbQkocmV2aXNpb24gMTg4MjMxKQorKysgU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0JKHdvcmtpbmcgY29w eSkKQEAgLTEwODMsMjIgKzEwODMsMTMgQEAgLSAodm9pZClfbG9uZ1ByZXNzUmVjb2duaXplZDoo VUlMb25nUHJlcwogCiAgICAgX2xhc3RJbnRlcmFjdGlvbkxvY2F0aW9uID0gZ2VzdHVyZVJlY29n bml6ZXIuc3RhcnRQb2ludDsKIAotICAgIHN3aXRjaCAoW2dlc3R1cmVSZWNvZ25pemVyIHN0YXRl XSkgewotICAgIGNhc2UgVUlHZXN0dXJlUmVjb2duaXplclN0YXRlQmVnYW46Ci0gICAgeworICAg IGlmIChbZ2VzdHVyZVJlY29nbml6ZXIgc3RhdGVdID09IFVJR2VzdHVyZVJlY29nbml6ZXJTdGF0 ZUJlZ2FuKSB7CiAgICAgICAgIFNFTCBhY3Rpb24gPSBbc2VsZiBfYWN0aW9uRm9yTG9uZ1ByZXNz XTsKICAgICAgICAgaWYgKGFjdGlvbikgewogICAgICAgICAgICAgW3NlbGYgcGVyZm9ybVNlbGVj dG9yOmFjdGlvbl07CiAgICAgICAgICAgICBbc2VsZiBfY2FuY2VsTG9uZ1ByZXNzR2VzdHVyZVJl Y29nbml6ZXJdOwogICAgICAgICB9CiAgICAgfQotICAgICAgICBicmVhazsKLSAgICBjYXNlIFVJ R2VzdHVyZVJlY29nbml6ZXJTdGF0ZUNhbmNlbGxlZDoKLSAgICAgICAgW19hY3Rpb25TaGVldEFz c2lzdGFudCBjbGVhbnVwU2hlZXRdOwotICAgICAgICBicmVhazsKLSAgICBkZWZhdWx0OgotICAg ICAgICBicmVhazsKLSAgICB9CiB9CiAKIC0gKHZvaWQpX3NpbmdsZVRhcFJlY29nbml6ZWQ6KFVJ VGFwR2VzdHVyZVJlY29nbml6ZXIgKilnZXN0dXJlUmVjb2duaXplcgo=