147884 2015-08-11 11:04:07 -0700 webkit-patch should not explode when $EDITOR is set incorrectly 2015-08-11 12:16:07 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bburg burg burg commit-queue glenn oldest_to_newest 1116590 0 bburg 2015-08-11 11:04:07 -0700 STEPS TO REPRODUCE: EDITOR=asdfjkl Tools/Scripts/webkit-patch upload -b <some-bug> EXPECTED: * Complains about not being able to edit changelogs, and gets on with life. ACTUAL: * A big, long, useless stack trace, and cannot continue uploading patch. Traceback (most recent call last): File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkit-patch", line 84, in <module> main() File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkit-patch", line 79, in main WebKitPatch(os.path.abspath(__file__)).main() File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main result = command.check_arguments_and_execute(options, args, self) File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 54, in execute self._sequence.run_and_handle_errors(tool, options, state) File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors self._run(tool, options, state) File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run step(tool, options).run(state) File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkitpy/tool/steps/editchangelog.py", line 35, in run self._tool.user.edit_changelog(absolute_paths) File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkitpy/common/system/user.py", line 148, in edit_changelog self.edit(files) File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkitpy/common/system/user.py", line 129, in edit subprocess.call(args + files) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 522, in call return Popen(*popenargs, **kwargs).wait() File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 710, in __init__ errread, errwrite) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 1335, in _execute_child raise child_exception 1116597 1 258728 burg 2015-08-11 11:13:42 -0700 Created attachment 258728 Proposed Fix 1116633 2 258728 commit-queue 2015-08-11 12:16:03 -0700 Comment on attachment 258728 Proposed Fix Clearing flags on attachment: 258728 Committed r188270: <http://trac.webkit.org/changeset/188270> 1116634 3 commit-queue 2015-08-11 12:16:07 -0700 All reviewed patches have been landed. Closing bug. 258728 2015-08-11 11:13:42 -0700 2015-08-11 12:16:03 -0700 Proposed Fix bug-147884-20150811111326.patch text/plain 1555 burg U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4MjU0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzMxOWY3NjM4ZWZiMjhlMzMyNWExMjBkM2IzZDZhZDBk MTU1MGRkMC4uYmZhYTdkMGQxNGMxNTdlNGJlZDk5ODA4MDQxYmFlMjI2MTkwZWI0YSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE1LTA4LTExICBCcmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgorCisgICAgICAg IHdlYmtpdC1wYXRjaCBzaG91bGQgbm90IGV4cGxvZGUgd2hlbiAkRURJVE9SIGlzIHNldCBpbmNv cnJlY3RseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTQ3ODg0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg SWYgJEVESVRPUiBkb2Vzbid0IGV4aXN0LCBsb2cgYSB3YXJuaW5nIGFuZCBjb250aW51ZS4KKwor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS91c2VyLnB5OiAKKyAgICAg ICAgKFVzZXIuZWRpdCk6CisgICAgICAgIChVc2VyLmVkaXRfY2hhbmdlbG9nKToKKwogMjAxNS0w OC0xMCAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAg ICAgIEFub3RoZXIgYnVpbGQgZml4IGFmdGVyIHIxODgyMzkuCmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vdXNlci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvY29tbW9uL3N5c3RlbS91c2VyLnB5CmluZGV4IGM0OTQyOWMwZDJjODM3YmJkNzM0Y2Y3 MmZlNWZjMjUwYjZhNGU3ZTAuLjFjNTlmYWI0MWI3NTE1MmZlMjk4NjUwZjI4ZmI4YjBjMjcxYmUw MGYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS91c2Vy LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS91c2VyLnB5CkBA IC0xMjYsNyArMTI2LDEwIEBAIGNsYXNzIFVzZXIob2JqZWN0KToKICAgICAgICAgZWRpdG9yID0g b3MuZW52aXJvbi5nZXQoIkVESVRPUiIpIG9yICJ2aSIKICAgICAgICAgYXJncyA9IHNobGV4LnNw bGl0KGVkaXRvcikKICAgICAgICAgIyBOb3RlOiBOb3QgdGhyZWFkIHNhZmU6IGh0dHA6Ly9idWdz LnB5dGhvbi5vcmcvaXNzdWUyMzIwCi0gICAgICAgIHN1YnByb2Nlc3MuY2FsbChhcmdzICsgZmls ZXMpCisgICAgICAgIHRyeToKKyAgICAgICAgICAgIHN1YnByb2Nlc3MuY2FsbChhcmdzICsgZmls ZXMpCisgICAgICAgIGV4Y2VwdCBPU0Vycm9yLCBlOgorICAgICAgICAgICAgX2xvZy53YXJuKCJU aGVyZSB3YXMgYSBwcm9ibGVtIGVkaXRpbmcgdGhlIENoYW5nZUxvZyB1c2luZyBlZGl0b3IgJyVz JzogJXMuIiAlIChlZGl0b3IsIGUpKQogCiAgICAgZGVmIF93YXJuX2lmX2FwcGxpY2F0aW9uX2lz X3hjb2RlKHNlbGYsIGVkaXRfYXBwbGljYXRpb24pOgogICAgICAgICBpZiAiWGNvZGUiIGluIGVk aXRfYXBwbGljYXRpb246Cg==