147849 2015-08-10 15:45:53 -0700 jsc-tailcall: REGRESSION: DFGByteCodeParser fails when a tail call is inside a ternary 2015-09-14 10:59:11 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 basile_clement basile_clement msaboff oldest_to_newest 1116365 0 basile_clement 2015-08-10 15:45:53 -0700 DFGByteCodeParser erroneously assumes that a tail call is always followed by a return. But it can also be followed by a jump to a return in return c ? f() : 0;. 1116647 1 258736 basile_clement 2015-08-11 12:37:09 -0700 Created attachment 258736 Patch 1116652 2 basile_clement 2015-08-11 12:44:11 -0700 I guess we should make the tests in tail-call-recognize.js run enough to be compiled in all tiers. 1116661 3 258736 msaboff 2015-08-11 13:02:41 -0700 Comment on attachment 258736 Patch r=me 1116665 4 basile_clement 2015-08-11 13:09:32 -0700 Committed r188282 <http://trac.webkit.org/changeset/188282>. 1125645 5 258736 ossy 2015-09-14 10:59:11 -0700 Comment on attachment 258736 Patch Cleared review? from attachment 258736 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 258736 2015-08-11 12:37:09 -0700 2015-09-14 10:59:11 -0700 Patch bug-147849-20150811123654.patch text/plain 3445 basile_clement U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4MTQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh YjdiZGQ5ODBiZmFkYWFmNzUwNDRjZWZhYzdmN2JiNzE0OTVmZWJkLi5iN2Y2YTczY2VkZWRlODIw NzZhNzVmYTljZWJhMjg5NWY2MDkyMWFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNS0wOC0xMSAgQmFzaWxlIENsZW1lbnQgIDxiYXNpbGVfY2xlbWVudEBh cHBsZS5jb20+CisKKyAgICAgICAganNjLXRhaWxjYWxsOiBSRUdSRVNTSU9OOiBERkdCeXRlQ29k ZVBhcnNlciBmYWlscyB3aGVuIGEgdGFpbCBjYWxsIGlzIGluc2lkZSBhIHRlcm5hcnkKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0Nzg0OQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIHdlcmUgYXNzdW1p bmcgdGhhdCBhIHRhaWwgY2FsbCBjb3VsZCBvbmx5IGJlIGZvbGxvd2VkIGJ5IGEgcmV0dXJuLgor ICAgICAgICBCdXQgaXQgY291bGQgYWxzbyBiZSBmb2xsb3dlZCBieSBhIGp1bXAgdG8gYSByZXR1 cm4gd2hlbiB0aGUgdGFpbCBjYWxsCisgICAgICAgIGlzIGluc2lkZSBhIHRlcm5hcnkgZXhwcmVz c2lvbi4KKworICAgICAgICAqIGRmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHA6CisgICAgICAgIChK U0M6OkRGRzo6Qnl0ZUNvZGVQYXJzZXI6OnBhcnNlQmxvY2spOgorCiAyMDE1LTA4LTA3ICBNaWNo YWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIFJv bGxvdXQgcjE4ODA3MiBhcyB0aGVyZSBhcmUgY3Jhc2hlcyB3aXRoIHJlbGVhc2UgYnVpbGRzLgpk aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdCeXRlQ29kZVBhcnNlci5j cHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcAppbmRl eCA2ZGEzNDFlMmU1NmY0OGVmM2VhNDBmY2ZmN2NjMDNjNGQyN2RkNTEzLi4xYWQ4MTgyNzExNDM4 NzA5Zjc0NmVlNmY0MmUyNTMzOTZhNDRlMjU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcApAQCAtMjY5NCw3ICsyNjk0LDExIEBAIGJvb2wg Qnl0ZUNvZGVQYXJzZXI6OnBhcnNlQmxvY2sodW5zaWduZWQgbGltaXQpCiAgICAgICAgICAgICAv LyBsb2dpYyByZWxpZXMgb24gZXZlcnkgYnl0ZWNvZGUgcmVzdWx0aW5nIGluIG9uZSBvciBtb3Jl IG5vZGVzLCB3aGljaCB3b3VsZAogICAgICAgICAgICAgLy8gYmUgdHJ1ZSBhbnl3YXkgZXhjZXB0 IGZvciBvcF9sb29wX2hpbnQsIHdoaWNoIGVtaXRzIGEgUGhhbnRvbSB0byBmb3JjZSB0aGlzCiAg ICAgICAgICAgICAvLyB0byBiZSB0cnVlLgotICAgICAgICAgICAgaWYgKCFtX2N1cnJlbnRCbG9j ay0+aXNFbXB0eSgpKQorICAgICAgICAgICAgLy8gV2UgYWxzbyBkb24ndCBpbnNlcnQgYSBqdW1w IGlmIHRoZSBibG9jayBhbHJlYWR5IGhhcyBhIHRlcm1pbmFsLAorICAgICAgICAgICAgLy8gd2hp Y2ggY291bGQgaGFwcGVuIGFmdGVyIGEgdGFpbCBjYWxsLgorICAgICAgICAgICAgQVNTRVJUKG1f Y3VycmVudEJsb2NrLT5pc0VtcHR5KCkgfHwgIW1fY3VycmVudEJsb2NrLT50ZXJtaW5hbCgpCisg ICAgICAgICAgICAgICAgfHwgbV9jdXJyZW50QmxvY2stPnRlcm1pbmFsKCktPm9wKCkgPT0gVGFp bENhbGwgfHwgbV9jdXJyZW50QmxvY2stPnRlcm1pbmFsKCktPm9wKCkgPT0gVGFpbENhbGxWYXJh cmdzKTsKKyAgICAgICAgICAgIGlmICghbV9jdXJyZW50QmxvY2stPmlzRW1wdHkoKSAmJiAhbV9j dXJyZW50QmxvY2stPnRlcm1pbmFsKCkpCiAgICAgICAgICAgICAgICAgYWRkVG9HcmFwaChKdW1w LCBPcEluZm8obV9jdXJyZW50SW5kZXgpKTsKICAgICAgICAgICAgIHJldHVybiBzaG91bGRDb250 aW51ZVBhcnNpbmc7CiAgICAgICAgIH0KQEAgLTMyNTYsNiArMzI2MCwxMiBAQCBib29sIEJ5dGVD b2RlUGFyc2VyOjpwYXJzZUJsb2NrKHVuc2lnbmVkIGxpbWl0KQogICAgICAgICAvLyA9PT0gQmxv Y2sgdGVybWluYXRvcnMuID09PQogCiAgICAgICAgIGNhc2Ugb3Bfam1wOiB7CisgICAgICAgICAg ICBpZiAobV9jdXJyZW50QmxvY2stPnRlcm1pbmFsKCkpIHsKKyAgICAgICAgICAgICAgICAvLyBX ZSBjb3VsZCBiZSB0aGUgZHVtbXkganVtcCB0byBhIHJldHVybiBhZnRlciBhIG5vbi1pbmxpbmVk LCBub24tZW11bGF0ZWQgdGFpbCBjYWxsIGluIGEgdGVybmFyeSBvcGVyYXRvcgorICAgICAgICAg ICAgICAgIE5vZGUqIHRlcm1pbmFsID0gbV9jdXJyZW50QmxvY2stPnRlcm1pbmFsKCk7CisgICAg ICAgICAgICAgICAgQVNTRVJUX1VOVVNFRCh0ZXJtaW5hbCwgdGVybWluYWwtPm9wKCkgPT0gVGFp bENhbGwgfHwgdGVybWluYWwtPm9wKCkgPT0gVGFpbENhbGxWYXJhcmdzKTsKKyAgICAgICAgICAg ICAgICBMQVNUX09QQ09ERShvcF9yZXQpOworICAgICAgICAgICAgfQogICAgICAgICAgICAgaW50 IHJlbGF0aXZlT2Zmc2V0ID0gY3VycmVudEluc3RydWN0aW9uWzFdLnUub3BlcmFuZDsKICAgICAg ICAgICAgIGFkZFRvR3JhcGgoSnVtcCwgT3BJbmZvKG1fY3VycmVudEluZGV4ICsgcmVsYXRpdmVP ZmZzZXQpKTsKICAgICAgICAgICAgIGlmIChyZWxhdGl2ZU9mZnNldCA8PSAwKQpAQCAtMzQyOCw3 ICszNDM4LDcgQEAgYm9vbCBCeXRlQ29kZVBhcnNlcjo6cGFyc2VCbG9jayh1bnNpZ25lZCBsaW1p dCkKICAgICAgICAgICAgIGlmIChtX2N1cnJlbnRCbG9jay0+dGVybWluYWwoKSkgewogICAgICAg ICAgICAgICAgIC8vIFdlIGNvdWxkIGJlIHRoZSBkdW1teSByZXR1cm4gYWZ0ZXIgYSBub24taW5s aW5lZCwgbm9uLWVtdWxhdGVkIHRhaWwgY2FsbAogICAgICAgICAgICAgICAgIE5vZGUqIHRlcm1p bmFsID0gbV9jdXJyZW50QmxvY2stPnRlcm1pbmFsKCk7Ci0gICAgICAgICAgICAgICAgQVNTRVJU X1VOVVNFRCh0ZXJtaW5hbCwgdGVybWluYWwtPm9wKCkgPT0gUmV0dXJuIHx8IHRlcm1pbmFsLT5v cCgpID09IFRhaWxDYWxsIHx8IHRlcm1pbmFsLT5vcCgpID09IFRhaWxDYWxsVmFyYXJncyk7Cisg ICAgICAgICAgICAgICAgQVNTRVJUX1VOVVNFRCh0ZXJtaW5hbCwgdGVybWluYWwtPm9wKCkgPT0g VGFpbENhbGwgfHwgdGVybWluYWwtPm9wKCkgPT0gVGFpbENhbGxWYXJhcmdzKTsKICAgICAgICAg ICAgICAgICBMQVNUX09QQ09ERShvcF9yZXQpOwogICAgICAgICAgICAgfQogICAgICAgICAgICAg aWYgKGlubGluZUNhbGxGcmFtZSgpKSB7Cg==