147837 2015-08-10 12:43:00 -0700 Web Inspector: Invalid selectors should be rejected when editing rules 2015-08-10 13:34:15 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 hi hi bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1116288 0 hi 2015-08-10 12:43:00 -0700 For some reason the backend changes for https://bugs.webkit.org/show_bug.cgi?id=147230 did not get committed and, as such, it does not work. 1116289 1 258638 hi 2015-08-10 12:43:31 -0700 Created attachment 258638 Patch 1116312 2 258638 commit-queue 2015-08-10 13:34:12 -0700 Comment on attachment 258638 Patch Clearing flags on attachment: 258638 Committed r188222: <http://trac.webkit.org/changeset/188222> 1116313 3 commit-queue 2015-08-10 13:34:15 -0700 All reviewed patches have been landed. Closing bug. 258638 2015-08-10 12:43:31 -0700 2015-08-10 13:34:12 -0700 Patch 147230.txt text/plain 2884 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5MDZhNTVhLi5kMWE0YWNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTUtMDctMjMgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAg ICAgIFdlYiBJbnNwZWN0b3I6IEludmFsaWQgc2VsZWN0b3JzIGNhbiBiZSBhcHBsaWVkIHRvIHRo ZSBzdHlsZXNoZWV0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNDcyMzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JTdHlsZVNoZWV0LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OmlzVmFsaWRTZWxlY3Rvckxpc3RTdHJpbmcpOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVj dG9yU3R5bGVTaGVldDo6c2V0UnVsZVNlbGVjdG9yKToKKyAgICAgICAgTm93IGNoZWNrcyB0byBz ZWUgdGhhdCB0aGUgc3VwcGxpZWQgc2VsZWN0b3IgaXMgdmFsaWQgYmVmb3JlIHRyeWluZyB0byBj b21taXQgaXQgdG8gdGhlIHJ1bGUuCisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JTdHlsZVNo ZWV0OjphZGRSdWxlKToKKyAgICAgICAgKFdlYkNvcmU6OmNoZWNrU3R5bGVSdWxlU2VsZWN0b3Ip OiBEZWxldGVkLgorCiAyMDE1LTA3LTI3ICBQZXIgQXJuZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29r LmNvbT4KIAogICAgICAgICBbQ3VybF0gQ3Jhc2ggaW4gQ3VybERvd25sb2FkOjpkaWRSZWNlaXZl SGVhZGVyIHdoZW4gZG93bmxvYWRpbmcgZmlsZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9JbnNwZWN0b3JTdHlsZVNoZWV0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9JbnNwZWN0b3JTdHlsZVNoZWV0LmNwcAppbmRleCA0OWQ5MjFhMC4uNTE1MzkwZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclN0eWxlU2hlZXQuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JTdHlsZVNoZWV0LmNwcApA QCAtNjM3LDE1ICs2MzcsMzAgQEAgU3RyaW5nIEluc3BlY3RvclN0eWxlU2hlZXQ6OnJ1bGVTZWxl Y3Rvcihjb25zdCBJbnNwZWN0b3JDU1NJZCYgaWQsIEV4Y2VwdGlvbkNvZGUKICAgICByZXR1cm4g cnVsZS0+c2VsZWN0b3JUZXh0KCk7CiB9CiAKK3N0YXRpYyBib29sIGlzVmFsaWRTZWxlY3Rvckxp c3RTdHJpbmcoY29uc3QgU3RyaW5nJiBzZWxlY3RvciwgRG9jdW1lbnQqIGRvY3VtZW50KQorewor ICAgIENTU1NlbGVjdG9yTGlzdCBzZWxlY3Rvckxpc3Q7CisgICAgY3JlYXRlQ1NTUGFyc2VyKGRv Y3VtZW50KS0+cGFyc2VTZWxlY3RvcihzZWxlY3Rvciwgc2VsZWN0b3JMaXN0KTsKKyAgICByZXR1 cm4gc2VsZWN0b3JMaXN0LmlzVmFsaWQoKTsKK30KKwogYm9vbCBJbnNwZWN0b3JTdHlsZVNoZWV0 OjpzZXRSdWxlU2VsZWN0b3IoY29uc3QgSW5zcGVjdG9yQ1NTSWQmIGlkLCBjb25zdCBTdHJpbmcm IHNlbGVjdG9yLCBFeGNlcHRpb25Db2RlJiBlYykKIHsKICAgICBpZiAoIWNoZWNrUGFnZVN0eWxl U2hlZXQoZWMpKQogICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICAvLyBJZiB0aGUgc2VsZWN0 b3IgaXMgaW52YWxpZCwgZG8gbm90IHByb2NlZWQgYW55IGZ1cnRoZXIuCisgICAgaWYgKCFpc1Zh bGlkU2VsZWN0b3JMaXN0U3RyaW5nKHNlbGVjdG9yLCBtX3BhZ2VTdHlsZVNoZWV0LT5vd25lckRv Y3VtZW50KCkpKSB7CisgICAgICAgIGVjID0gU1lOVEFYX0VSUjsKKyAgICAgICAgcmV0dXJuIGZh bHNlOworICAgIH0KKwogICAgIENTU1N0eWxlUnVsZSogcnVsZSA9IHJ1bGVGb3JJZChpZCk7CiAg ICAgaWYgKCFydWxlKSB7CiAgICAgICAgIGVjID0gTk9UX0ZPVU5EX0VSUjsKICAgICAgICAgcmV0 dXJuIGZhbHNlOwogICAgIH0KKwogICAgIENTU1N0eWxlU2hlZXQqIHN0eWxlU2hlZXQgPSBydWxl LT5wYXJlbnRTdHlsZVNoZWV0KCk7CiAgICAgaWYgKCFzdHlsZVNoZWV0IHx8ICFlbnN1cmVQYXJz ZWREYXRhUmVhZHkoKSkgewogICAgICAgICBlYyA9IE5PVF9GT1VORF9FUlI7CkBAIC02NzEsMTgg KzY4NiwxMSBAQCBib29sIEluc3BlY3RvclN0eWxlU2hlZXQ6OnNldFJ1bGVTZWxlY3Rvcihjb25z dCBJbnNwZWN0b3JDU1NJZCYgaWQsIGNvbnN0IFN0cmluZwogICAgIHJldHVybiB0cnVlOwogfQog Ci1zdGF0aWMgYm9vbCBjaGVja1N0eWxlUnVsZVNlbGVjdG9yKERvY3VtZW50KiBkb2N1bWVudCwg Y29uc3QgU3RyaW5nJiBzZWxlY3RvcikKLXsKLSAgICBDU1NTZWxlY3Rvckxpc3Qgc2VsZWN0b3JM aXN0OwotICAgIGNyZWF0ZUNTU1BhcnNlcihkb2N1bWVudCktPnBhcnNlU2VsZWN0b3Ioc2VsZWN0 b3IsIHNlbGVjdG9yTGlzdCk7Ci0gICAgcmV0dXJuIHNlbGVjdG9yTGlzdC5pc1ZhbGlkKCk7Ci19 Ci0KIENTU1N0eWxlUnVsZSogSW5zcGVjdG9yU3R5bGVTaGVldDo6YWRkUnVsZShjb25zdCBTdHJp bmcmIHNlbGVjdG9yLCBFeGNlcHRpb25Db2RlJiBlYykKIHsKICAgICBpZiAoIWNoZWNrUGFnZVN0 eWxlU2hlZXQoZWMpKQogICAgICAgICByZXR1cm4gbnVsbHB0cjsKLSAgICBpZiAoIWNoZWNrU3R5 bGVSdWxlU2VsZWN0b3IobV9wYWdlU3R5bGVTaGVldC0+b3duZXJEb2N1bWVudCgpLCBzZWxlY3Rv cikpIHsKKyAgICBpZiAoIWlzVmFsaWRTZWxlY3Rvckxpc3RTdHJpbmcoc2VsZWN0b3IsIG1fcGFn ZVN0eWxlU2hlZXQtPm93bmVyRG9jdW1lbnQoKSkpIHsKICAgICAgICAgZWMgPSBTWU5UQVhfRVJS OwogICAgICAgICByZXR1cm4gbnVsbHB0cjsKICAgICB9Cg==