147836 2015-08-10 12:35:23 -0700 A focused node should not be assisted when handling touch events synchronously 2020-03-10 13:20:05 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=208880 InRadar P2 Normal --- 147946 1 wenson_hsieh webkit-unassigned cmarcelo commit-queue dbates enrica esprehn+autocc kangil.han webkit-bug-importer oldest_to_newest 1116285 0 258637 wenson_hsieh 2015-08-10 12:35:23 -0700 Created attachment 258637 Try to tap, scroll, or zoom in the pink square, and the keyboard will deploy when it shouldn't Currently, when a node is focused programmatically (either through element.focus() or the autofocus attribute) and we interact with a region that has touch event handlers (ontouchstart, etc.) the focused node will be refocused and assisted. 1116286 1 wenson_hsieh 2015-08-10 12:36:50 -0700 <rdar://problem/22204108> 1116307 2 258646 wenson_hsieh 2015-08-10 13:32:48 -0700 Created attachment 258646 Patch 1117038 3 258646 wenson_hsieh 2015-08-12 13:24:49 -0700 Comment on attachment 258646 Patch This approach is insufficient. More specifically, it will not handle the case where the developer calls preventDefault() on a touch event but we still want to show the keyboard. 1117321 4 258915 wenson_hsieh 2015-08-13 12:33:10 -0700 Created attachment 258915 Patch 1117340 5 258915 enrica 2015-08-13 13:15:57 -0700 Comment on attachment 258915 Patch It would be nice to add some manual tests to this patch. It is not possible to have the automatic tests but at least having the manual ones would be helpful. Make sure you test the most popular frameworks that use touch handlers to make sure none of them relies on the wrong behavior we had before. 1117365 6 wenson_hsieh 2015-08-13 13:49:07 -0700 Got it. I'll try out Sencha touch and fastclick (the two libraries Ben mentioned yesterday) and make sure they still work. Simon also looked at this patch and advised me to leave out the manual tests, since they are ignored most of the time. However, I think it will be nice to still include them, since I'll be working on an automated framework for testing forms on iOS soon, and (at some point) I'll probably go through the manual tests directory and convert as many as I can to automated tests (including this one). It'll be helpful to have them all in one place. In any case, the test case still lives in the Radar, so we can always go back and consult it if necessary! 1117412 7 wenson_hsieh 2015-08-13 14:49:11 -0700 Committed r188405: <http://trac.webkit.org/changeset/188405> 258637 2015-08-10 12:35:23 -0700 2015-08-10 12:35:23 -0700 Try to tap, scroll, or zoom in the pink square, and the keyboard will deploy when it shouldn't keyboard-on-interaction.html text/html 802 wenson_hsieh PGh0bWw+Cgo8aGVhZD4KICAgIDxtZXRhIG5hbWU9InZpZXdwb3J0IiBjb250ZW50PSJ3aWR0aD1k ZXZpY2Utd2lkdGgsIGluaXRpYWwtc2NhbGU9MSI+CiAgICA8c2NyaXB0PgogICAgICAgIGZ1bmN0 aW9uIHRvdWNoVGVzdChldmVudCkgewogICAgICAgICAgICBjb25zb2xlLmxvZygiVG91Y2ggZXZl bnQgb24gIiArIGV2ZW50LnRhcmdldCk7CiAgICAgICAgfQogICAgPC9zY3JpcHQ+CgogICAgPHN0 eWxlPgogICAgICAgIGRpdiB7CiAgICAgICAgICAgIHRvcDogMzAwcHg7CiAgICAgICAgICAgIGxl ZnQ6IDEwMHB4OwogICAgICAgICAgICB3aWR0aDogMjAwcHg7CiAgICAgICAgICAgIGhlaWdodDog MjAwcHg7CiAgICAgICAgICAgIGJhY2tncm91bmQtY29sb3I6ICNGRkFBQUE7CiAgICAgICAgICAg IHBvc2l0aW9uOiBhYnNvbHV0ZTsKICAgICAgICAgICAgcGFkZGluZzogMTBweDsKICAgICAgICB9 CgogICAgICAgIGlucHV0OmZvY3VzIHsKICAgICAgICAgICAgb3V0bGluZTogbm9uZTsKICAgICAg ICAgICAgYm9yZGVyOiAxcHggc29saWQgIzREOTBGRTsKICAgICAgICB9CiAgICA8L3N0eWxlPgoK PC9oZWFkPgoKPGJvZHkgc3R5bGU9Im1hcmdpbjogMDsiPgogICAgPGRpdiBvbnRvdWNoc3RhcnQ9 InRvdWNoVGVzdChldmVudCkiPgogICAgICAgIDxwPlRhcCwgc2Nyb2xsIG9yIGJlZ2luIGEgcGlu Y2gtdG8tem9vbSBnZXN0dXJlIGluIHRoaXMgc3F1YXJlIHRvIHNob3cgdGhlIGtleWJvYXJkLjwv cD4KICAgIDwvZGl2PgogICAgPGlucHV0IGF1dG9mb2N1cz48L2lucHV0Pgo8L2JvZHk+Cgo8L2h0 bWw+Cg== 258646 2015-08-10 13:32:48 -0700 2015-08-12 13:24:49 -0700 Patch bug-147836-20150810133234.patch text/plain 2839 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4MTgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZmY1NmU0NTYyMTc0ZWE0 NmMyMGJjODJmMzgxY2IyYjc5ZTE1MjBkMC4uMTZmYzFkY2U4OGI4NmUzMTA2MDJjNDA0MGZhNWE2 ZWU4NDFiMzU4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTA4LTEwICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIEEgZm9jdXNlZCBu b2RlIHNob3VsZCBub3QgYmUgYXNzaXN0ZWQgd2hlbiBoYW5kbGluZyB0b3VjaCBldmVudHMgc3lu Y2hyb25vdXNseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTQ3ODM2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yMjIwNDEwOD4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcG9uIHJlY2VpdmluZyBhIHN5 bmNocm9ub3VzIHRvdWNoIGV2ZW50LCB3ZSBzaG91bGQgbm90IGFzc2lzdCB0aGUgY3VycmVudGx5 IGZvY3VzZWQgbm9kZS4gSW5zdGVhZCwKKyAgICAgICAgd2UgZGVmZXIgbm9kZSBhc3Npc3RhbmNl IHRvIFdlYlBhZ2U6OmNvbW1pdFBvdGVudGlhbFRhcCwgd2hlbiB3ZSdyZSBjZXJ0YWluIHRoYXQg dGhlIHVzZXIgYWN0dWFsbHkKKyAgICAgICAgdGFwcGVkIG9uIHRoZSBmaWVsZC4gVGhpcyBhbHNv IGZpeGVzIGlzc3VlcyB3aXRoIHVzZXIgdHJpZ2dlcmVkIHpvb20vc2Nyb2xsIGludG8gdGhlIGFz c2lzdGVkIGZpZWxkCisgICAgICAgIG9jY3VycmluZyBzaW11bHRhbmVvdXNseSBhcyB0aGUgcG90 ZW50aWFsIHRhcCBub2RlIGlzIGNvbXB1dGVkLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQ YWdlL1dlYlBhZ2UuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpkaXNwYXRjaFRvdWNo RXZlbnQpOiBSZW1vdmVkIGxvZ2ljIHRvIHJlZm9jdXMgdGhlIGN1cnJlbnRseSBmb2N1c2VkIG5v ZGUgdXBvbgorICAgICAgICAgICAgcmVjZWl2aW5nIGEgc3luY2hyb25vdXMgdG91Y2ggZXZlbnQu CisKIDIwMTUtMDgtMDcgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAg ICBMaWdodHdlaWdodCBsb2NrcyBzaG91bGQgYmUgYWRhcHRpdmUKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAppbmRleCBkYjc3ZDEwODU5N2U1NjE3Zjkw ZTdhNjk4ZDFmNjgzNzYwM2E5ZDA0Li45YTZiOTJkMmVjMDMxYTNkMzFkMjYzYTI2ODY5ZGM2ZmIw OWFjOWEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2Vi UGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2Uu Y3BwCkBAIC0yMTkwLDI1ICsyMTkwLDkgQEAgc3RhdGljIGJvb2wgaGFuZGxlVG91Y2hFdmVudChj b25zdCBXZWJUb3VjaEV2ZW50JiB0b3VjaEV2ZW50LCBQYWdlKiBwYWdlKQogI2lmIEVOQUJMRShJ T1NfVE9VQ0hfRVZFTlRTKQogdm9pZCBXZWJQYWdlOjpkaXNwYXRjaFRvdWNoRXZlbnQoY29uc3Qg V2ViVG91Y2hFdmVudCYgdG91Y2hFdmVudCwgYm9vbCYgaGFuZGxlZCkKIHsKLSAgICBSZWZQdHI8 RnJhbWU+IG9sZEZvY3VzZWRGcmFtZSA9IG1fcGFnZS0+Zm9jdXNDb250cm9sbGVyKCkuZm9jdXNl ZEZyYW1lKCk7Ci0gICAgUmVmUHRyPEVsZW1lbnQ+IG9sZEZvY3VzZWRFbGVtZW50ID0gb2xkRm9j dXNlZEZyYW1lID8gb2xkRm9jdXNlZEZyYW1lLT5kb2N1bWVudCgpLT5mb2N1c2VkRWxlbWVudCgp IDogbnVsbHB0cjsKLSAgICBtX3VzZXJJc0ludGVyYWN0aW5nID0gdHJ1ZTsKLQogICAgIG1fbGFz dEludGVyYWN0aW9uTG9jYXRpb24gPSB0b3VjaEV2ZW50LnBvc2l0aW9uKCk7CiAgICAgQ3VycmVu dEV2ZW50IGN1cnJlbnRFdmVudCh0b3VjaEV2ZW50KTsKICAgICBoYW5kbGVkID0gaGFuZGxlVG91 Y2hFdmVudCh0b3VjaEV2ZW50LCBtX3BhZ2UuZ2V0KCkpOwotCi0gICAgUmVmUHRyPEZyYW1lPiBu ZXdGb2N1c2VkRnJhbWUgPSBtX3BhZ2UtPmZvY3VzQ29udHJvbGxlcigpLmZvY3VzZWRGcmFtZSgp OwotICAgIFJlZlB0cjxFbGVtZW50PiBuZXdGb2N1c2VkRWxlbWVudCA9IG5ld0ZvY3VzZWRGcmFt ZSA/IG5ld0ZvY3VzZWRGcmFtZS0+ZG9jdW1lbnQoKS0+Zm9jdXNlZEVsZW1lbnQoKSA6IG51bGxw dHI7Ci0KLSAgICAvLyBJZiB0aGUgZm9jdXMgaGFzIG5vdCBjaGFuZ2VkLCB3ZSBuZWVkIHRvIG5v dGlmeSB0aGUgY2xpZW50IGFueXdheSwgc2luY2UgaXQgbWlnaHQgYmUKLSAgICAvLyBuZWNlc3Nh cnkgdG8gc3RhcnQgYXNzaXN0aW5nIHRoZSBub2RlLgotICAgIC8vIElmIHRoZSBub2RlIGhhcyBi ZWVuIGZvY3VzZWQgYnkgSmF2YVNjcmlwdCB3aXRob3V0IHVzZXIgaW50ZXJhY3Rpb24sIHRoZQot ICAgIC8vIGtleWJvYXJkIGlzIG5vdCBvbiBzY3JlZW4uCi0gICAgaWYgKG5ld0ZvY3VzZWRFbGVt ZW50ICYmIG5ld0ZvY3VzZWRFbGVtZW50ID09IG9sZEZvY3VzZWRFbGVtZW50KQotICAgICAgICBl bGVtZW50RGlkRm9jdXMobmV3Rm9jdXNlZEVsZW1lbnQuZ2V0KCkpOwotCi0gICAgbV91c2VySXNJ bnRlcmFjdGluZyA9IGZhbHNlOwogfQogCiB2b2lkIFdlYlBhZ2U6OnRvdWNoRXZlbnRTeW5jKGNv bnN0IFdlYlRvdWNoRXZlbnQmIHRvdWNoRXZlbnQsIGJvb2wmIGhhbmRsZWQpCg== 258915 2015-08-13 12:33:10 -0700 2015-08-13 13:15:57 -0700 Patch bug-147836-20150813123253.patch text/plain 10272 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4MjU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTg5NzY0NjQ4Nzc4OWU2 N2I0MDYyMTkzMzlkYzBlMDM4MWZlMDIxMC4uOTBlYzkyMWY0YThjODU2NDc5NzE1ZjE3NWNjYWY4 ZjM5NTM3ZDZjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE1LTA4LTEzICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIEEgZm9jdXNlZCBu b2RlIHNob3VsZCBub3QgYmUgYXNzaXN0ZWQgd2hlbiBoYW5kbGluZyB0b3VjaCBldmVudHMgc3lu Y2hyb25vdXNseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTQ3ODM2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yMjIwNDEwOD4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlcyBpbnRlcmFjdGlvbiB3 aXRoIHRvdWNoIGhhbmRsZXJzIG5vIGxvbmdlciBhc3Npc3QgdGhlIGN1cnJlbnRseSBmb2N1c2Vk IGVsZW1lbnQgaW4gdGhlCisgICAgICAgIGdlbmVyYWwgY2FzZS4gQWRkZWQgcGx1bWJpbmcgdG8g cmVhc3Npc3QgYSBjdXJyZW50bHkgZm9jdXNlZCBub2RlIHdoZW4gZGlzcGF0Y2hpbmcgdG91Y2gg ZXZlbnRzLAorICAgICAgICBzbyB0aGF0IGFuIGlucHV0IHRoYXQgcHJvZ3JhbW1hdGljYWxseSBm b2N1c2VzIGl0c2VsZiBhbmQgcHJldmVudHMgZGVmYXVsdCBvbiBhIHRvdWNoIGV2ZW50IHdpbGwK KyAgICAgICAgYmUgcHJvcGVybHkgYXNzaXN0ZWQgd2hlbiBpdCBoYXMgYmVlbiBwcm9ncmFtbWF0 aWNhbGx5IGZvY3VzZWQgKGVpdGhlciB0aHJvdWdoIEphdmFzY3JpcHQgb3IgdGhlCisgICAgICAg IGF1dG9mb2N1cyBhdHRyaWJ1dGUpIHByaW9yIHRvIHJlY2VpdmluZyB0aGUgdG91Y2ggZXZlbnQu IFRoaXMgcGF0Y2ggYWxzbyByZW1vdmVzIHRoZSBub3cKKyAgICAgICAgdW5uZWNlc3Nhcnkgc3Bl Y2lhbC1jYXNpbmcgb2YgdGhlIEdtYWlsIHNldHRpbmdzIGFwcCB0aGF0IGN1cnJlbnRseSBtYWtl cyB0aGUga2V5Ym9hcmQgZGVwbG95CisgICAgICAgIHVwb24gYXV0b2ZvY3VzLgorCisgICAgICAg ICogZG9tL0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVudDo6Zm9jdXMpOiBO b3RpZmllcyB0aGUgY2hyb21lIGNsaWVudCB0aGF0IHRoZSBlbGVtZW50IGhhcyByZWZvY3VzZWQg YmVmb3JlCisgICAgICAgICAgICByZXR1cm5pbmcgZWFybHkuCisgICAgICAgICogcGFnZS9DaHJv bWVDbGllbnQuaDogUmVmb2N1c2luZyBhbiBlbGVtZW50IGRvZXMgbm90aGluZyBieSBkZWZhdWx0 LgorICAgICAgICAqIHBsYXRmb3JtL1J1bnRpbWVBcHBsaWNhdGlvbkNoZWNrc0lPUy5oOiBSZW1v dmVkIHNwZWNpYWwgY2FzaW5nIGZvciBHbWFpbCBBZGQgQWNjb3VudC4KKyAgICAgICAgKiBwbGF0 Zm9ybS9SdW50aW1lQXBwbGljYXRpb25DaGVja3NJT1MubW06IFNlZSBhYm92ZS4KKyAgICAgICAg KFdlYkNvcmU6OmFwcGxpY2F0aW9uSXNHbWFpbEFkZEFjY291bnRPbklPUyk6IFNlZSBhYm92ZS4K KwogMjAxNS0wOC0xMSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAg IFtXZWJJRExdIEFsbCBpbnRlcmZhY2Ugb2JqZWN0cyBtdXN0IGhhdmUgYSBwcm9wZXJ0eSBuYW1l ZCAibmFtZSIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9X ZWJLaXQyL0NoYW5nZUxvZwppbmRleCAwYWEzNTViZWU5ZDYwNzA0MGNiNTk2MGRlMDZmNWYxZDE5 N2Y2NmUyLi5iZDQ2MjQ4YjVmYWJjNjNiMjZiODJhNmU4ZGMxM2QzNzYzMWRkZmQ5IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMzAgQEAKKzIwMTUtMDgtMTMgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9o c2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgQSBmb2N1c2VkIG5vZGUgc2hvdWxkIG5vdCBiZSBh c3Npc3RlZCB3aGVuIGhhbmRsaW5nIHRvdWNoIGV2ZW50cyBzeW5jaHJvbm91c2x5CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDc4MzYKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzIyMjA0MTA4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIE1ha2VzIGludGVyYWN0aW9uIHdpdGggdG91Y2ggaGFuZGxlcnMg bm8gbG9uZ2VyIGFzc2lzdCB0aGUgY3VycmVudGx5IGZvY3VzZWQgZWxlbWVudCBpbiB0aGUKKyAg ICAgICAgZ2VuZXJhbCBjYXNlLiBBZGRlZCBwbHVtYmluZyB0byByZWFzc2lzdCBhIGN1cnJlbnRs eSBmb2N1c2VkIG5vZGUgd2hlbiBkaXNwYXRjaGluZyB0b3VjaCBldmVudHMsCisgICAgICAgIHNv IHRoYXQgYW4gaW5wdXQgdGhhdCBwcm9ncmFtbWF0aWNhbGx5IGZvY3VzZXMgaXRzZWxmIGFuZCBw cmV2ZW50cyBkZWZhdWx0IG9uIGEgdG91Y2ggZXZlbnQgd2lsbAorICAgICAgICBiZSBwcm9wZXJs eSBhc3Npc3RlZCB3aGVuIGl0IGhhcyBiZWVuIHByb2dyYW1tYXRpY2FsbHkgZm9jdXNlZCAoZWl0 aGVyIHRocm91Z2ggSmF2YXNjcmlwdCBvciB0aGUKKyAgICAgICAgYXV0b2ZvY3VzIGF0dHJpYnV0 ZSkgcHJpb3IgdG8gcmVjZWl2aW5nIHRoZSB0b3VjaCBldmVudC4gVGhpcyBwYXRjaCBhbHNvIHJl bW92ZXMgdGhlIG5vdworICAgICAgICB1bm5lY2Vzc2FyeSBzcGVjaWFsLWNhc2luZyBvZiB0aGUg R21haWwgc2V0dGluZ3MgYXBwIHRoYXQgY3VycmVudGx5IG1ha2VzIHRoZSBrZXlib2FyZCBkZXBs b3kKKyAgICAgICAgdXBvbiBhdXRvZm9jdXMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dL Q29udGVudFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBfc3Rh cnRBc3Npc3RpbmdOb2RlOnVzZXJJc0ludGVyYWN0aW5nOmJsdXJQcmV2aW91c05vZGU6dXNlck9i amVjdDpdKTogUmVtb3ZlZAorICAgICAgICAgICAgc3BlY2lhbCBjYXNlIHRvIGF2b2lkIHRoZSBl YXJseSByZXR1cm4gZm9yIEdtYWlsIEFkZCBBY2NvdW50LgorICAgICAgICAqIFdlYlByb2Nlc3Mv V2ViQ29yZVN1cHBvcnQvV2ViQ2hyb21lQ2xpZW50Lmg6IEFkZGVkIGEgaGFuZGxlciBmb3IgcmVm b2N1c2luZyBhbiBlbGVtZW50LgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQv aW9zL1dlYkNocm9tZUNsaWVudElPUy5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViQ2hyb21lQ2xp ZW50OjplbGVtZW50RGlkUmVmb2N1cyk6IE1ha2VzIHJlZm9jdXNpbmcgYW4gZWxlbWVudCB0cmln Z2VyIGlucHV0CisgICAgICAgICAgICBhc3Npc3RhbmNlIG9uIGlPUy4KKyAgICAgICAgKiBXZWJQ cm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OmRp c3BhdGNoVG91Y2hFdmVudCk6IFJlbW92ZXMgbG9naWMgdG8gZm9jdXMgdGhlIGN1cnJlbnRseSBm b2N1c2VkIGVsZW1lbnQgdXBvbgorICAgICAgICAgICAgcmVjZWl2aW5nIGEgdG91Y2ggZXZlbnQu CisKIDIwMTUtMDgtMTEgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAg ICBSZXZlcnRlZCByMTg4MjU1LCBiZWNhdXNlIGl0IHR1cm5lZCBvdXQgdGhhdCBkZWxlZ2F0ZXMg ZG8gbm9ub3QgbmVlZCB0aGlzIGluZm9ybWF0aW9uLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvZG9tL0VsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCmluZGV4 IGRiZDkwOTc2ZWQ4MjYxODEzYjQzN2Q1MmE5ZjI1ZmZjN2ZmODQ2OGEuLjBjOTVkZjdlNWVhNWFk YzA5OGY4NTMxYjNjMTI0Mzg3MDVlMTQ3MjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9FbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKQEAgLTIx MTcsOCArMjExNywxMiBAQCB2b2lkIEVsZW1lbnQ6OmZvY3VzKGJvb2wgcmVzdG9yZVByZXZpb3Vz U2VsZWN0aW9uLCBGb2N1c0RpcmVjdGlvbiBkaXJlY3Rpb24pCiAgICAgaWYgKCFpbkRvY3VtZW50 KCkpCiAgICAgICAgIHJldHVybjsKIAotICAgIGlmIChkb2N1bWVudCgpLmZvY3VzZWRFbGVtZW50 KCkgPT0gdGhpcykKKyAgICBpZiAoZG9jdW1lbnQoKS5mb2N1c2VkRWxlbWVudCgpID09IHRoaXMp IHsKKyAgICAgICAgaWYgKGRvY3VtZW50KCkucGFnZSgpKQorICAgICAgICAgICAgZG9jdW1lbnQo KS5wYWdlKCktPmNocm9tZSgpLmNsaWVudCgpLmVsZW1lbnREaWRSZWZvY3VzKHRoaXMpOworCiAg ICAgICAgIHJldHVybjsKKyAgICB9CiAKICAgICAvLyBJZiB0aGUgc3R5bGVzaGVldHMgaGF2ZSBh bHJlYWR5IGJlZW4gbG9hZGVkIHdlIGNhbiByZWxpYWJseSBjaGVjayBpc0ZvY3VzYWJsZS4KICAg ICAvLyBJZiBub3QsIHdlIGNvbnRpbnVlIGFuZCBzZXQgdGhlIGZvY3VzZWQgbm9kZSBvbiB0aGUg Zm9jdXMgY29udHJvbGxlciBiZWxvdyBzbwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFn ZS9DaHJvbWVDbGllbnQuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvQ2hyb21lQ2xpZW50LmgKaW5k ZXggZWUwZmI0OGFmOGM4MzhlZjk2MGViZTIyZTdjN2FlOTczNzljZmYwYS4uZjZhOGVkZTE2MTRl YTg4MDI2NzZhZTk5NDg2MThkNDVmNTQ3YjIzZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGFnZS9DaHJvbWVDbGllbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0Nocm9tZUNsaWVu dC5oCkBAIC0yODEsNiArMjgxLDcgQEAgcHVibGljOgogICAgICAgICAKICAgICB2aXJ0dWFsIHZv aWQgZWxlbWVudERpZEZvY3VzKGNvbnN0IE5vZGUqKSB7IH07CiAgICAgdmlydHVhbCB2b2lkIGVs ZW1lbnREaWRCbHVyKGNvbnN0IE5vZGUqKSB7IH07CisgICAgdmlydHVhbCB2b2lkIGVsZW1lbnRE aWRSZWZvY3VzKGNvbnN0IE5vZGUqKSB7IH07CiAgICAgCiAgICAgdmlydHVhbCBib29sIHNob3Vs ZFBhaW50RW50aXJlQ29udGVudHMoKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQogICAgIHZpcnR1 YWwgYm9vbCBoYXNTdGFibGVQYWdlU2NhbGVGYWN0b3IoKSBjb25zdCB7IHJldHVybiB0cnVlOyB9 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9SdW50aW1lQXBwbGljYXRpb25D aGVja3NJT1MuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1J1bnRpbWVBcHBsaWNhdGlvbkNo ZWNrc0lPUy5oCmluZGV4IDY5MWM4Y2JiZmRlNzdjNDU2MDc3MjhiMGM3ZjA0MTYzODYxZDYxZTgu Ljc3YThkYTkzMGNlNTM3Yjk3ODNiZDNhMDVkYTk4MjJhYWNjOGYwNzcgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL1J1bnRpbWVBcHBsaWNhdGlvbkNoZWNrc0lPUy5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1J1bnRpbWVBcHBsaWNhdGlvbkNoZWNrc0lPUy5oCkBA IC00Myw3ICs0Myw2IEBAIGJvb2wgYXBwbGljYXRpb25Jc01BU0goKTsKIFdFQkNPUkVfRVhQT1JU IGJvb2wgYXBwbGljYXRpb25Jc1RoZUVjb25vbWlzdE9uSVBob25lKCk7CiBib29sIGFwcGxpY2F0 aW9uSXNXZWJQcm9jZXNzKCk7CiBib29sIGFwcGxpY2F0aW9uSXNJQm9va3NPbklPUygpOwotV0VC Q09SRV9FWFBPUlQgYm9vbCBhcHBsaWNhdGlvbklzR21haWxBZGRBY2NvdW50T25JT1MoKTsKIAog fSAvLyBuYW1lc3BhY2UgV2ViQ29yZQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9SdW50aW1lQXBwbGljYXRpb25DaGVja3NJT1MubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9SdW50aW1lQXBwbGljYXRpb25DaGVja3NJT1MubW0KaW5kZXggMWE1NDFiYjI2MGI3ZDU1 YzFlMDgwZDZiNDIyNThlOTExNWFjZjk0ZS4uNDYyOWY0NDUwNWMwYjdhNmU1MGFkZjQzNjkwZGU0 MTQ5YmFjMThhYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vUnVudGltZUFw cGxpY2F0aW9uQ2hlY2tzSU9TLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1J1bnRp bWVBcHBsaWNhdGlvbkNoZWNrc0lPUy5tbQpAQCAtMTIyLDEyICsxMjIsNiBAQCBib29sIGFwcGxp Y2F0aW9uSXNJQm9va3NPbklPUygpCiAgICAgcmV0dXJuIGlzSUJvb2tzT25JT1M7CiB9CiAKLWJv b2wgYXBwbGljYXRpb25Jc0dtYWlsQWRkQWNjb3VudE9uSU9TKCkKLXsKLSAgICBzdGF0aWMgY29u c3QgYm9vbCBpc0dtYWlsQWRkQWNjb3VudE9uSU9TID0gW1tbTlNCdW5kbGUgbWFpbkJ1bmRsZV0g YnVuZGxlSWRlbnRpZmllcl0gaXNFcXVhbFRvU3RyaW5nOkAiY29tLmFwcGxlLnNvY2lhbC5TTEdv b2dsZUF1dGguU0xHb29nbGVBdXRoU2VydmljZSJdOwotICAgIHJldHVybiBpc0dtYWlsQWRkQWNj b3VudE9uSU9TOwotfQotCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAKICNlbmRpZiAvLyBQTEFU Rk9STShJT1MpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29u dGVudFZpZXdJbnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tD b250ZW50Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4IDFkZTVmNGVmODIxOThhN2Y4ZGE5ZDI3NmJj ZGFjNTA5NTM1MDhmYTMuLjkxZjY1ZGViOTUyYmI2ZGJmN2ZmZjI5YjQ5NTc2MmEyNzY0NDI4Nzgg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0lu dGVyYWN0aW9uLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50 Vmlld0ludGVyYWN0aW9uLm1tCkBAIC0zMDIxLDcgKzMwMjEsNyBAQCAtICh2b2lkKV9zdGFydEFz c2lzdGluZ05vZGU6KGNvbnN0IEFzc2lzdGVkTm9kZUluZm9ybWF0aW9uJilpbmZvcm1hdGlvbiB1 c2VySXNJbgogewogICAgIC8vIEZJWE1FOiBUaGlzIGlzIGEgdGVtcG9yYXJ5IHdvcmthcm91bmQg Zm9yIDxyZGFyOi8vcHJvYmxlbS8yMjEyNjUxOD4uIFRoZSByZWFsIGZpeCB3aWxsIGludm9sdmUg cmVmYWN0b3JpbmcKICAgICAvLyB0aGUgd2F5IHdlIGFzc2lzdCBwcm9ncmFtbWF0aWNhbGx5IGZv Y3VzZWQgbm9kZXMuCi0gICAgaWYgKCFhcHBsaWNhdGlvbklzR21haWxBZGRBY2NvdW50T25JT1Mo KSAmJiAhdXNlcklzSW50ZXJhY3RpbmcgJiYgIV90ZXh0U2VsZWN0aW9uQXNzaXN0YW50KQorICAg IGlmICghdXNlcklzSW50ZXJhY3RpbmcgJiYgIV90ZXh0U2VsZWN0aW9uQXNzaXN0YW50KQogICAg ICAgICByZXR1cm47CiAKICAgICBpZiAoYmx1clByZXZpb3VzTm9kZSkKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViQ2hyb21lQ2xpZW50Lmgg Yi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkNocm9tZUNsaWVu dC5oCmluZGV4IGMxZWQzODc2ZTg5OTNiNWVkN2Y0ZGNiZjNhMmZkNzU2MmM0YzkzNWUuLjIwOTUy ZDFlYjEyN2U5NWYwZDk2ZWNjZmE3ZTBjNDE3ZDhhMDMyZWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViQ2hyb21lQ2xpZW50LmgKKysrIGIv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJDaHJvbWVDbGllbnQu aApAQCAtMjQzLDYgKzI0Myw3IEBAIHByaXZhdGU6CiAjaWYgUExBVEZPUk0oSU9TKQogICAgIHZp cnR1YWwgdm9pZCBlbGVtZW50RGlkRm9jdXMoY29uc3QgV2ViQ29yZTo6Tm9kZSopIG92ZXJyaWRl OwogICAgIHZpcnR1YWwgdm9pZCBlbGVtZW50RGlkQmx1cihjb25zdCBXZWJDb3JlOjpOb2RlKikg b3ZlcnJpZGU7CisgICAgdmlydHVhbCB2b2lkIGVsZW1lbnREaWRSZWZvY3VzKGNvbnN0IFdlYkNv cmU6Ok5vZGUqKSBvdmVycmlkZTsKICNlbmRpZgogCiAjaWYgUExBVEZPUk0oSU9TKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9pb3MvV2ViQ2hy b21lQ2xpZW50SU9TLm1tIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9y dC9pb3MvV2ViQ2hyb21lQ2xpZW50SU9TLm1tCmluZGV4IGEyNTU5MWVjZGFjNzNiZjA3MDIyMTAx YjA4YTVlNmM5YzY2ZTBmMTYuLmMyNDIxYzkyNGZmNDI1MTI0MmZmOGNmZTdjOTI5ZWIzMGU1Yjkw NjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQv aW9zL1dlYkNocm9tZUNsaWVudElPUy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYkNvcmVTdXBwb3J0L2lvcy9XZWJDaHJvbWVDbGllbnRJT1MubW0KQEAgLTU0LDYgKzU0LDEx IEBAIHZvaWQgV2ViQ2hyb21lQ2xpZW50OjplbGVtZW50RGlkQmx1cihjb25zdCBXZWJDb3JlOjpO b2RlKiBub2RlKQogICAgIG1fcGFnZS0+ZWxlbWVudERpZEJsdXIoY29uc3RfY2FzdDxXZWJDb3Jl OjpOb2RlKj4obm9kZSkpOwogfQogCit2b2lkIFdlYkNocm9tZUNsaWVudDo6ZWxlbWVudERpZFJl Zm9jdXMoY29uc3QgV2ViQ29yZTo6Tm9kZSogbm9kZSkKK3sKKyAgICBlbGVtZW50RGlkRm9jdXMo bm9kZSk7Cit9CisKIHZvaWQgV2ViQ2hyb21lQ2xpZW50OjpkaWRSZWNlaXZlTW9iaWxlRG9jVHlw ZShib29sIGlzTW9iaWxlRG9jdHlwZSkKIHsKICAgICBtX3BhZ2UtPmRpZFJlY2VpdmVNb2JpbGVE b2NUeXBlKGlzTW9iaWxlRG9jdHlwZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvV2ViUGFnZS5jcHAKaW5kZXggZGI3N2QxMDg1OTdlNTYxN2Y5MGU3YTY5OGQxZjY4Mzc2 MDNhOWQwNC4uZTI3OThjMWQyYjNjMWE1ODA3ODBiN2FmMjZkMGNhNTIzZDAzZDhiMSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcApAQCAtMjE5MCwy NCArMjE5MCwxMiBAQCBzdGF0aWMgYm9vbCBoYW5kbGVUb3VjaEV2ZW50KGNvbnN0IFdlYlRvdWNo RXZlbnQmIHRvdWNoRXZlbnQsIFBhZ2UqIHBhZ2UpCiAjaWYgRU5BQkxFKElPU19UT1VDSF9FVkVO VFMpCiB2b2lkIFdlYlBhZ2U6OmRpc3BhdGNoVG91Y2hFdmVudChjb25zdCBXZWJUb3VjaEV2ZW50 JiB0b3VjaEV2ZW50LCBib29sJiBoYW5kbGVkKQogewotICAgIFJlZlB0cjxGcmFtZT4gb2xkRm9j dXNlZEZyYW1lID0gbV9wYWdlLT5mb2N1c0NvbnRyb2xsZXIoKS5mb2N1c2VkRnJhbWUoKTsKLSAg ICBSZWZQdHI8RWxlbWVudD4gb2xkRm9jdXNlZEVsZW1lbnQgPSBvbGRGb2N1c2VkRnJhbWUgPyBv bGRGb2N1c2VkRnJhbWUtPmRvY3VtZW50KCktPmZvY3VzZWRFbGVtZW50KCkgOiBudWxscHRyOwog ICAgIG1fdXNlcklzSW50ZXJhY3RpbmcgPSB0cnVlOwogCiAgICAgbV9sYXN0SW50ZXJhY3Rpb25M b2NhdGlvbiA9IHRvdWNoRXZlbnQucG9zaXRpb24oKTsKICAgICBDdXJyZW50RXZlbnQgY3VycmVu dEV2ZW50KHRvdWNoRXZlbnQpOwogICAgIGhhbmRsZWQgPSBoYW5kbGVUb3VjaEV2ZW50KHRvdWNo RXZlbnQsIG1fcGFnZS5nZXQoKSk7CiAKLSAgICBSZWZQdHI8RnJhbWU+IG5ld0ZvY3VzZWRGcmFt ZSA9IG1fcGFnZS0+Zm9jdXNDb250cm9sbGVyKCkuZm9jdXNlZEZyYW1lKCk7Ci0gICAgUmVmUHRy PEVsZW1lbnQ+IG5ld0ZvY3VzZWRFbGVtZW50ID0gbmV3Rm9jdXNlZEZyYW1lID8gbmV3Rm9jdXNl ZEZyYW1lLT5kb2N1bWVudCgpLT5mb2N1c2VkRWxlbWVudCgpIDogbnVsbHB0cjsKLQotICAgIC8v IElmIHRoZSBmb2N1cyBoYXMgbm90IGNoYW5nZWQsIHdlIG5lZWQgdG8gbm90aWZ5IHRoZSBjbGll bnQgYW55d2F5LCBzaW5jZSBpdCBtaWdodCBiZQotICAgIC8vIG5lY2Vzc2FyeSB0byBzdGFydCBh c3Npc3RpbmcgdGhlIG5vZGUuCi0gICAgLy8gSWYgdGhlIG5vZGUgaGFzIGJlZW4gZm9jdXNlZCBi eSBKYXZhU2NyaXB0IHdpdGhvdXQgdXNlciBpbnRlcmFjdGlvbiwgdGhlCi0gICAgLy8ga2V5Ym9h cmQgaXMgbm90IG9uIHNjcmVlbi4KLSAgICBpZiAobmV3Rm9jdXNlZEVsZW1lbnQgJiYgbmV3Rm9j dXNlZEVsZW1lbnQgPT0gb2xkRm9jdXNlZEVsZW1lbnQpCi0gICAgICAgIGVsZW1lbnREaWRGb2N1 cyhuZXdGb2N1c2VkRWxlbWVudC5nZXQoKSk7Ci0KICAgICBtX3VzZXJJc0ludGVyYWN0aW5nID0g ZmFsc2U7CiB9CiAK