147817 2015-08-09 14:28:28 -0700 AX: Address follow-up comments in bug 145684 2015-08-10 09:01:41 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 145684 1 jcraig webkit-unassigned commit-queue webkit-bug-importer oldest_to_newest 1116120 0 jcraig 2015-08-09 14:28:28 -0700 AX: Address follow-up comments in bug 145684 1116121 1 jcraig 2015-08-09 14:30:42 -0700 >> LayoutTests/http/tests/contentextensions/text-track-blocked-expected.txt:18 >> + RenderButton {BUTTON} at (0,230) size 320x10 [bgcolor=#C0C0C0] [border: (2px outset #C0C0C0)] > > It's weird that we still get a border even with appearance none. I wonder if we should be explicit about border: none !important? It doesn't really matter since the opacity is 0. I can address it in the follow up bug if you think it is better. >> LayoutTests/media/video-controls-show-on-kb-or-ax-event.html:32 >> + } > > No braces required here. 1116140 2 258601 jcraig 2015-08-09 16:59:43 -0700 Created attachment 258601 patch 1116218 3 258601 commit-queue 2015-08-10 09:01:38 -0700 Comment on attachment 258601 patch Clearing flags on attachment: 258601 Committed r188213: <http://trac.webkit.org/changeset/188213> 1116219 4 commit-queue 2015-08-10 09:01:41 -0700 All reviewed patches have been landed. Closing bug. 258601 2015-08-09 16:59:43 -0700 2015-08-10 09:01:38 -0700 patch webkit147817.diff text/plain 4745 jcraig SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4ODIwMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE1LTA4LTA5ICBKYW1lcyBD cmFpZyAgPGpjcmFpZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IEFkZHJlc3MgZm9sbG93LXVw IGNvbW1lbnRzIGluIGJ1ZyAxNDU2ODQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE0NzgxNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE1pbm9yIGNsZWFudXAgYW5kIHN0eWxlIHVwZGF0ZXMgcmVxdWVzdGVk IGJ5IERlYW4uCisgICAgICAgIFVwZGF0ZWQgRXhpc3RpbmcgVGVzdCBFeHBlY3RhdGlvbnMuCisK KyAgICAgICAgKiBNb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmNzczoK KyAgICAgICAgKHZpZGVvOjotd2Via2l0LW1lZGlhLXNob3ctY29udHJvbHMpOgorICAgICAgICAq IE1vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzaU9TLmNzczoKKyAgICAgICAgKHZp ZGVvOjotd2Via2l0LW1lZGlhLXNob3ctY29udHJvbHMpOgorCiAyMDE1LTA4LTA5ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFtNYWNdIEFsd2F5cyBy ZXF1aXJlIEV4dGVybmFsRGV2aWNlQXV0b1BsYXlDYW5kaWRhdGUgZmxhZyB0byBBaXJQbGF5IGF1 dG9tYXRpY2FsbHkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9t ZWRpYUNvbnRyb2xzQXBwbGUuY3NzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL01vZHVs ZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUuY3NzCShyZXZpc2lvbiAxODgxOTYp CisrKyBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0Fw cGxlLmNzcwkod29ya2luZyBjb3B5KQpAQCAtMTE5LDYgKzExOSw4IEBAIHZpZGVvOjotd2Via2l0 LW1lZGlhLXNob3ctY29udHJvbHMgewogICAgIHdpZHRoOiAxMDAlOwogICAgIGhlaWdodDogMTBw eDsKICAgICBvcGFjaXR5OiAwOworICAgIGJvcmRlcjogMDsKKyAgICBiYWNrZ3JvdW5kOiBub25l OwogICAgIC13ZWJraXQtYXBwZWFyYW5jZTogbm9uZTsKIH0KIApJbmRleDogU291cmNlL1dlYkNv cmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNpT1MuY3NzCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzaU9T LmNzcwkocmV2aXNpb24gMTg4MTk2KQorKysgU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNv bnRyb2xzL21lZGlhQ29udHJvbHNpT1MuY3NzCSh3b3JraW5nIGNvcHkpCkBAIC0xNDUsNiArMTQ1 LDggQEAgdmlkZW86Oi13ZWJraXQtbWVkaWEtc2hvdy1jb250cm9scyB7CiAgICAgd2lkdGg6IDEw MCU7CiAgICAgaGVpZ2h0OiAxMHB4OwogICAgIG9wYWNpdHk6IDA7CisgICAgYm9yZGVyOiAwOwor ICAgIGJhY2tncm91bmQ6IG5vbmU7CiAgICAgLXdlYmtpdC1hcHBlYXJhbmNlOiBub25lOwogfQog CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCShyZXZpc2lvbiAxODgyMDEpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdv cmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAxNS0wOC0wOSAgSmFtZXMgQ3JhaWcgIDxq Y3JhaWdAYXBwbGUuY29tPgorCisgICAgICAgIEFYOiBBZGRyZXNzIGZvbGxvdy11cCBjb21tZW50 cyBpbiBidWcgMTQ1Njg0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNDc4MTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBNaW5vciBjbGVhbnVwIGFuZCBzdHlsZSB1cGRhdGVzIHJlcXVlc3RlZCBieSBEZWFu LgorCisgICAgICAgICogaHR0cC90ZXN0cy9jb250ZW50ZXh0ZW5zaW9ucy90ZXh0LXRyYWNrLWJs b2NrZWQtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIG1lZGlhL3ZpZGVvLWNvbnRyb2xzLXNob3ct b24ta2Itb3ItYXgtZXZlbnQuaHRtbDoKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvbWVkaWEvdHJh Y2svdHJhY2stY3VlLXJlbmRlcmluZy1ob3Jpem9udGFsLWV4cGVjdGVkLnR4dDoKKwogMjAxNS0w OC0wOSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFJlZ3Jlc3Np b24ocjE4ODEwNSk6IFNlZW1zIHRvIGhhdmUgY2F1c2VkIGNyYXNoZXMgZHVyaW5nIFBMVCBvbiBz b21lIGlQYWRzCkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2NvbnRlbnRleHRlbnNpb25z L3RleHQtdHJhY2stYmxvY2tlZC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvaHR0cC90ZXN0cy9jb250ZW50ZXh0ZW5zaW9ucy90ZXh0LXRyYWNrLWJsb2NrZWQtZXhwZWN0 ZWQudHh0CShyZXZpc2lvbiAxODgxOTYpCisrKyBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2NvbnRl bnRleHRlbnNpb25zL3RleHQtdHJhY2stYmxvY2tlZC1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29w eSkKQEAgLTE1LDQgKzE1LDQgQEAgbGF5ZXIgYXQgKDgsMjYpIHNpemUgMzIweDI0MAogbGF5ZXIg YXQgKDgsMjYpIHNpemUgMzIweDI0MAogICBSZW5kZXJGbGV4aWJsZUJveCB7RElWfSBhdCAoMCww KSBzaXplIDMyMHgyNDAKIGxheWVyIGF0ICg4LDI1Nikgc2l6ZSAzMjB4MTAKLSAgUmVuZGVyQnV0 dG9uIHtCVVRUT059IGF0ICgwLDIzMCkgc2l6ZSAzMjB4MTAgW2JnY29sb3I9I0MwQzBDMF0gW2Jv cmRlcjogKDJweCBvdXRzZXQgI0MwQzBDMCldCisgIFJlbmRlckJ1dHRvbiB7QlVUVE9OfSBhdCAo MCwyMzApIHNpemUgMzIweDEwCkluZGV4OiBMYXlvdXRUZXN0cy9tZWRpYS92aWRlby1jb250cm9s cy1zaG93LW9uLWtiLW9yLWF4LWV2ZW50Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv bWVkaWEvdmlkZW8tY29udHJvbHMtc2hvdy1vbi1rYi1vci1heC1ldmVudC5odG1sCShyZXZpc2lv biAxODgxOTYpCisrKyBMYXlvdXRUZXN0cy9tZWRpYS92aWRlby1jb250cm9scy1zaG93LW9uLWti LW9yLWF4LWV2ZW50Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTI3LDkgKzI3LDggQEAKICAgICAg ICAgICAgIGlmIChidXR0b24pIHsKICAgICAgICAgICAgICAgICBidXR0b24uZm9jdXMoKTsKICAg ICAgICAgICAgICAgICBldmVudFNlbmRlci5rZXlEb3duKCcgJyk7IC8vIFVzZSBrZXlib2FyZCB0 byBwcmVzcyB0aGUgc2VsZWN0ZWQgYnV0dG9uLgotICAgICAgICAgICAgfSBlbHNlIHsKKyAgICAg ICAgICAgIH0gZWxzZQogICAgICAgICAgICAgICAgIHJlc3VsdC5pbm5lckhUTUwgKz0gJ0ZBSUw6 ICJTaG93IENvbnRyb2xzIiBidXR0b24gaXMgbm90IGF2YWlsYWJsZS48YnI+JzsJCi0gICAgICAg ICAgICB9CiAKICAgICAgICAgICAgIC8vIFZlcmlmaWVzIHRoZSB0b29sYmFyIGlzIGJhY2sgaW4g dGhlIERPTS4KICAgICAgICAgICAgIHZhciBjb250cm9scyA9IHJvb3QuZmlyc3RDaGlsZC5xdWVy eVNlbGVjdG9yKCdbcm9sZT0idG9vbGJhciJdJyk7CkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9y bS9tYWMvbWVkaWEvdHJhY2svdHJhY2stY3VlLXJlbmRlcmluZy1ob3Jpem9udGFsLWV4cGVjdGVk LnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvbWVkaWEvdHJhY2sv dHJhY2stY3VlLXJlbmRlcmluZy1ob3Jpem9udGFsLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMTg4 MTk2KQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL21lZGlhL3RyYWNrL3RyYWNrLWN1ZS1y ZW5kZXJpbmctaG9yaXpvbnRhbC1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTYxLDQg KzYxLDQgQEAgbGF5ZXIgYXQgKDgsMjIwKSBzaXplIDMyMHgxNAogICAgICAgICBSZW5kZXJUZXh0 IHsjdGV4dH0gYXQgKDAsMCkgc2l6ZSAyNzV4MTQKICAgICAgICAgICB0ZXh0IHJ1biBhdCAoMCww KSB3aWR0aCAyNzU6ICJDdWUgNjogc2hvdWxkIGJlIG9uIHRvcCBvZiBib3R0b20gcG9zaXRpb25l ZCBjdWUgNS4iCiBsYXllciBhdCAoOCwyMzgpIHNpemUgMzIweDEwCi0gIFJlbmRlckJ1dHRvbiB7 QlVUVE9OfSBhdCAoMCwyMzApIHNpemUgMzIweDEwIFtiZ2NvbG9yPSNDMEMwQzBdIFtib3JkZXI6 ICgycHggb3V0c2V0ICNDMEMwQzApXQorICBSZW5kZXJCdXR0b24ge0JVVFRPTn0gYXQgKDAsMjMw KSBzaXplIDMyMHgxMAo=