147780 2015-08-07 04:23:41 -0700 [GTK] Crash when the web view is destroyed while the screensaver DBUs proxy is being created 2015-08-10 01:28:17 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned berto commit-queue gustavo mcatanzaro mrobinson pnormand svillar zan oldest_to_newest 1115717 0 cgarcia 2015-08-07 04:23:41 -0700 We should cancel the screenSaverInhibitCancellable on dispose. I also noticved that we are leaking the cancellable object because I forgot to use adoptGRef(). 1115719 1 cgarcia 2015-08-07 04:25:45 -0700 Program received signal SIGSEGV, Segmentation fault. 0x00007ffff33f07d7 in screenSaverProxyCreatedCallback(_GObject*, _GAsyncResult*, _WebKitWebViewBase*) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 (gdb) bt #0 0x00007ffff33f07d7 in screenSaverProxyCreatedCallback(_GObject*, _GAsyncResult*, _WebKitWebViewBase*) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #1 0x00007ffff5923f89 in g_task_return_now (task=0x83e0d0) at gtask.c:1106 #2 0x00007ffff592478e in g_task_return (task=0x83e0d0, type=<optimized out>) at gtask.c:1164 #3 0x00007ffff597c90b in init_second_async_cb (source_object=0x6e8740, res=0x83e270, user_data=user_data@entry=0x83e0d0) at gdbusproxy.c:1807 #4 0x00007ffff5923f89 in g_task_return_now (task=0x83e270) at gtask.c:1106 #5 0x00007ffff592478e in g_task_return (task=0x83e270, type=<optimized out>) at gtask.c:1164 #6 0x00007ffff597c15e in async_init_start_service_by_name_cb (connection=<optimized out>, res=0x83e340, user_data=user_data@entry=0x83e270) at gdbusproxy.c:1645 #7 0x00007ffff5923f89 in g_task_return_now (task=0x83e340) at gtask.c:1106 #8 0x00007ffff592478e in g_task_return (task=0x83e340, type=<optimized out>) at gtask.c:1164 #9 0x00007ffff59716e8 in g_dbus_connection_call_done (source=<optimized out>, result=0x8d9000, user_data=user_data@entry=0x83e340) at gdbusconnection.c:5399 #10 0x00007ffff5923f89 in g_task_return_now (task=0x8d9000) at gtask.c:1106 #11 0x00007ffff5923fc9 in complete_in_idle_cb (task=0x8d9000) at gtask.c:1120 #12 0x00007ffff7675bdd in g_main_dispatch (context=0x678790) at gmain.c:3122 #13 g_main_context_dispatch (context=context@entry=0x678790) at gmain.c:3737 #14 0x00007ffff7675f78 in g_main_context_iterate (context=0x678790, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at gmain.c:3808 #15 0x00007ffff7676292 in g_main_loop_run (loop=0x7b4310) at gmain.c:4002 #16 0x0000000000408097 in testWebViewSubmitForm(FormClientTest*, void const*) () #17 0x00007ffff769a923 in test_case_run (tc=0x7ad190) at gtestutils.c:2124 #18 g_test_run_suite_internal (suite=suite@entry=0x7ada20, path=path@entry=0x7ffff771925e "") at gtestutils.c:2185 #19 0x00007ffff769aaf2 in g_test_run_suite_internal (suite=suite@entry=0x7ada00, path=<optimized out>, path@entry=0x7ffff771925e "") at gtestutils.c:2196 #20 0x00007ffff769aaf2 in g_test_run_suite_internal (suite=suite@entry=0x7ad9a0, path=<optimized out>, path@entry=0x7ffff771925e "") at gtestutils.c:2196 #21 0x00007ffff769ae3b in g_test_run_suite (suite=0x7ad9a0) at gtestutils.c:2249 #22 0x00007ffff769ae71 in g_test_run () at gtestutils.c:1553 #23 0x0000000000407a95 in main () 1115720 2 258482 cgarcia 2015-08-07 04:26:12 -0700 Created attachment 258482 Patch 1115721 3 cgarcia 2015-08-07 04:27:19 -0700 Btw, before you ask, it's safe to call g_cancellable_cancel with NULL or on an already cancelled cancellable, so we don't need any checks. 1115722 4 commit-queue 2015-08-07 04:28:17 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1116187 5 cgarcia 2015-08-10 01:28:17 -0700 Committed r188208: <http://trac.webkit.org/changeset/188208> 258482 2015-08-07 04:26:12 -0700 2015-08-09 23:50:22 -0700 Patch wk2-screensaver-cancel.diff text/plain 3123 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1N2ZlYTNjLi45ZDI1YmVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEg QEAKIDIwMTUtMDgtMDcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFtHVEtdIENyYXNoIHdoZW4gdGhlIHdlYiB2aWV3IGlzIGRlc3Ryb3llZCB3 aGlsZSB0aGUgc2NyZWVuc2F2ZXIgREJVcyBwcm94eSBpcyBiZWluZyBjcmVhdGVkCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDc3ODAKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBzaG91bGQgY2FuY2Vs IHRoZSBzY3JlZW5TYXZlckluaGliaXRDYW5jZWxsYWJsZSBvbgorICAgICAgICBkaXNwb3NlLiBB bHNvIHVzZSBhZG9wdEdSZWYoKSB3aGVuIGNyZWF0aW5nIHRoZSBjYW5jZWxsYWJsZSBvYmplY3QK KyAgICAgICAgdG8gbm90IGxlYWsgaXQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9X ZWJLaXRXZWJWaWV3QmFzZS5jcHA6CisgICAgICAgICh3ZWJraXRXZWJWaWV3QmFzZURpc3Bvc2Up OgorICAgICAgICAod2Via2l0V2ViVmlld0Jhc2VTZW5kSW5oaWJpdE1lc3NhZ2VUb1NjcmVlblNh dmVyKToKKyAgICAgICAgKHdlYmtpdFdlYlZpZXdCYXNlSW5oaWJpdFNjcmVlblNhdmVyKToKKwor MjAxNS0wOC0wNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisK ICAgICAgICAgVW5yZXZpZXdlZC4gRml4IEdUSysgY29tcGlsZSB3YXJuaW5nIGFsc28gaW50cm9k dWNlZCBpbiByMTg4MTIxLgogCiAgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0SW5z dGFsbE1pc3NpbmdNZWRpYVBsdWdpbnNQZXJtaXNzaW9uUmVxdWVzdC5jcHA6CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAK aW5kZXggYmRkZTMxNi4uMTg4NDc1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcApAQCAtNDUwLDYgKzQ1MCw3IEBA IHZvaWQgd2Via2l0V2ViVmlld0Jhc2VDaGlsZE1vdmVSZXNpemUoV2ViS2l0V2ViVmlld0Jhc2Uq IHdlYlZpZXcsIEd0a1dpZGdldCogY2hpCiBzdGF0aWMgdm9pZCB3ZWJraXRXZWJWaWV3QmFzZURp c3Bvc2UoR09iamVjdCogZ29iamVjdCkKIHsKICAgICBXZWJLaXRXZWJWaWV3QmFzZSogd2ViVmll dyA9IFdFQktJVF9XRUJfVklFV19CQVNFKGdvYmplY3QpOworICAgIGdfY2FuY2VsbGFibGVfY2Fu Y2VsKHdlYlZpZXctPnByaXYtPnNjcmVlblNhdmVySW5oaWJpdENhbmNlbGxhYmxlLmdldCgpKTsK ICAgICB3ZWJraXRXZWJWaWV3QmFzZVNldFRvcGxldmVsT25TY3JlZW5XaW5kb3cod2ViVmlldywg bnVsbHB0cik7CiAgICAgd2ViVmlldy0+cHJpdi0+cGFnZVByb3h5LT5jbG9zZSgpOwogICAgIEdf T0JKRUNUX0NMQVNTKHdlYmtpdF93ZWJfdmlld19iYXNlX3BhcmVudF9jbGFzcyktPmRpc3Bvc2Uo Z29iamVjdCk7CkBAIC0xMTM0LDcgKzExMzUsNyBAQCBzdGF0aWMgdm9pZCB3ZWJraXRXZWJWaWV3 QmFzZVNlbmRJbmhpYml0TWVzc2FnZVRvU2NyZWVuU2F2ZXIoV2ViS2l0V2ViVmlld0Jhc2UqCiAg ICAgQVNTRVJUKHByaXYtPnNjcmVlblNhdmVyUHJveHkpOwogICAgIHByaXYtPnNjcmVlblNhdmVy Q29va2llID0gMDsKICAgICBpZiAoIXByaXYtPnNjcmVlblNhdmVySW5oaWJpdENhbmNlbGxhYmxl KQotICAgICAgICBwcml2LT5zY3JlZW5TYXZlckluaGliaXRDYW5jZWxsYWJsZSA9IGdfY2FuY2Vs bGFibGVfbmV3KCk7CisgICAgICAgIHByaXYtPnNjcmVlblNhdmVySW5oaWJpdENhbmNlbGxhYmxl ID0gYWRvcHRHUmVmKGdfY2FuY2VsbGFibGVfbmV3KCkpOwogICAgIGdfZGJ1c19wcm94eV9jYWxs KHByaXYtPnNjcmVlblNhdmVyUHJveHkuZ2V0KCksICJJbmhpYml0IiwgZ192YXJpYW50X25ldygi KHNzKSIsIGdfZ2V0X3ByZ25hbWUoKSwgXygiV2Vic2l0ZSBydW5uaW5nIGluIGZ1bGxzY3JlZW4g bW9kZSIpKSwKICAgICAgICAgR19EQlVTX0NBTExfRkxBR1NfTk9ORSwgLTEsIHByaXYtPnNjcmVl blNhdmVySW5oaWJpdENhbmNlbGxhYmxlLmdldCgpLCByZWludGVycHJldF9jYXN0PEdBc3luY1Jl YWR5Q2FsbGJhY2s+KHNjcmVlblNhdmVySW5oaWJpdGVkQ2FsbGJhY2spLCB3ZWJWaWV3QmFzZSk7 CiB9CkBAIC0xMTYyLDcgKzExNjMsNyBAQCBzdGF0aWMgdm9pZCB3ZWJraXRXZWJWaWV3QmFzZUlu aGliaXRTY3JlZW5TYXZlcihXZWJLaXRXZWJWaWV3QmFzZSogd2ViVmlld0Jhc2UpCiAgICAgICAg IHJldHVybjsKICAgICB9CiAKLSAgICBwcml2LT5zY3JlZW5TYXZlckluaGliaXRDYW5jZWxsYWJs ZSA9IGdfY2FuY2VsbGFibGVfbmV3KCk7CisgICAgcHJpdi0+c2NyZWVuU2F2ZXJJbmhpYml0Q2Fu Y2VsbGFibGUgPSBhZG9wdEdSZWYoZ19jYW5jZWxsYWJsZV9uZXcoKSk7CiAgICAgZ19kYnVzX3By b3h5X25ld19mb3JfYnVzKEdfQlVTX1RZUEVfU0VTU0lPTiwgc3RhdGljX2Nhc3Q8R0RCdXNQcm94 eUZsYWdzPihHX0RCVVNfUFJPWFlfRkxBR1NfRE9fTk9UX0xPQURfUFJPUEVSVElFUyB8IEdfREJV U19QUk9YWV9GTEFHU19ET19OT1RfQ09OTkVDVF9TSUdOQUxTKSwKICAgICAgICAgbnVsbHB0ciwg Im9yZy5mcmVlZGVza3RvcC5TY3JlZW5TYXZlciIsICIvU2NyZWVuU2F2ZXIiLCAib3JnLmZyZWVk ZXNrdG9wLlNjcmVlblNhdmVyIiwgcHJpdi0+c2NyZWVuU2F2ZXJJbmhpYml0Q2FuY2VsbGFibGUu Z2V0KCksCiAgICAgICAgIHJlaW50ZXJwcmV0X2Nhc3Q8R0FzeW5jUmVhZHlDYWxsYmFjaz4oc2Ny ZWVuU2F2ZXJQcm94eUNyZWF0ZWRDYWxsYmFjayksIHdlYlZpZXdCYXNlKTsK