147777 2015-08-07 02:59:42 -0700 [GTK] WTF unit tests are timing out in the bots 2015-08-12 08:20:52 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned fpizlo ggaren oldest_to_newest 1115706 0 cgarcia 2015-08-07 02:59:42 -0700 It's because WTF_Lock tests, they actually pass, but they are slower than our timeout. $ time bin/TestWebKitAPI/WTF/TestWTF --gtest_filter=WTF_Lock.* **PASS** WTF_Lock.UncontentedShortSection **PASS** WTF_Lock.UncontentedLongSection **PASS** WTF_Lock.ContentedShortSection **PASS** WTF_Lock.ContentedLongSection **PASS** WTF_Lock.ManyContentedShortSections **PASS** WTF_Lock.ManyContentedLongSections real 0m15.656s user 0m51.736s sys 0m36.848s We need a way to mark tests as slow and use a longer timeout like WTR does. I don't know if these tests are supposed to be so slow, though. Filip? 1115713 1 258479 cgarcia 2015-08-07 03:29:32 -0700 Created attachment 258479 Patch Marking WTF_Lock.ContentedShortSection as slow seems to be enough 1115749 2 258479 fpizlo 2015-08-07 07:44:29 -0700 Comment on attachment 258479 Patch Alternatively you could just make the tests run for less time. In each test, the number of iterations is the last argument to the runTest template. 1115763 3 cgarcia 2015-08-07 08:28:22 -0700 Committed r188125: <http://trac.webkit.org/changeset/188125> 1116183 4 cgarcia 2015-08-10 01:03:13 -0700 Unfortunately this was not enough for the bots, that seem to be slower than my laptop: $ time (../../Tools/jhbuild/jhbuild-wrapper --gtk run xvfb-run bin/TestWebKitAPI/WTF/TestWTF --gtest_filter=WTF_Lock.*) **PASS** WTF_Lock.UncontentedShortSection **PASS** WTF_Lock.UncontentedLongSection **PASS** WTF_Lock.ContentedShortSection **PASS** WTF_Lock.ContentedLongSection **PASS** WTF_Lock.ManyContentedShortSections **PASS** WTF_Lock.ManyContentedLongSections real 0m43.051s user 3m32.349s sys 1m44.799s 1116952 5 cgarcia 2015-08-12 08:20:52 -0700 (In reply to comment #4) > Unfortunately this was not enough for the bots, that seem to be slower than > my laptop: > > $ time (../../Tools/jhbuild/jhbuild-wrapper --gtk run xvfb-run > bin/TestWebKitAPI/WTF/TestWTF --gtest_filter=WTF_Lock.*) > **PASS** WTF_Lock.UncontentedShortSection > **PASS** WTF_Lock.UncontentedLongSection > **PASS** WTF_Lock.ContentedShortSection > **PASS** WTF_Lock.ContentedLongSection > **PASS** WTF_Lock.ManyContentedShortSections > **PASS** WTF_Lock.ManyContentedLongSections > > real 0m43.051s > user 3m32.349s > sys 1m44.799s Increased the timeout for slow tests to timeout * 5 and it stills times out . . . Maybe we should just try to make the test faster. 258479 2015-08-07 03:29:32 -0700 2015-08-07 07:44:29 -0700 Patch rgt-slow-tests.diff text/plain 1838 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5NmVj NjNlLi5jZjE0ODY3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMjAgQEAKIDIwMTUtMDgtMDcgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCisgICAgICAgIFtHVEtdIFdURiB1bml0IHRlc3RzIGFy ZSB0aW1pbmcgb3V0IGluIHRoZSBib3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNDc3NzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBZGQgYSB3YXkgdG8gbWFyayBnb29nbGUgdW5pdCB0ZXN0cyBhcyBz bG93IGFuZCBhZGQKKyAgICAgICAgV1RGX0xvY2suQ29udGVudGVkU2hvcnRTZWN0aW9uIHRvIHRo ZSBsaXN0LiBJbiBjYXNlIG9mIHNsb3cgdGVzdAorICAgICAgICB3ZSB1c2UgdGhlIGRvdWJsZSBv ZiB0aGUgZ2l2ZW4gdGltZW91dCBmb3IgdGhhdCBwYXJ0aWN1bGFyIHRlc3QuCisKKyAgICAgICAg KiBTY3JpcHRzL3J1bi1ndGstdGVzdHM6CisgICAgICAgIChUZXN0UnVubmVyKToKKyAgICAgICAg KFRlc3RSdW5uZXIuX3J1bl9nb29nbGVfdGVzdCk6CisKKzIwMTUtMDgtMDcgIENhcmxvcyBHYXJj aWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCiAgICAgICAgIFtHVEtdIHJ1bi1ndGst dGVzdHMgc2hvdWxkIG5vdCBzdG9wIHdoZW4gYSBnb29nbGUgdGVzdCBjYXNlIGZhaWxzCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDc3NzgKIApkaWZm IC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9ydW4tZ3RrLXRlc3RzIGIvVG9vbHMvU2NyaXB0cy9ydW4t Z3RrLXRlc3RzCmluZGV4IDcyMDVlNDQuLjIyZDlhZDIgMTAwNzU1Ci0tLSBhL1Rvb2xzL1Njcmlw dHMvcnVuLWd0ay10ZXN0cworKysgYi9Ub29scy9TY3JpcHRzL3J1bi1ndGstdGVzdHMKQEAgLTgw LDYgKzgwLDEwIEBAIGNsYXNzIFRlc3RSdW5uZXI6CiAgICAgICAgIFNraXBwZWRUZXN0KCJXZWJL aXQyL1Rlc3RXZWJLaXQyIiwgIldlYktpdDIuR2VvbG9jYXRpb25UcmFuc2l0aW9uVG9Mb3dBY2N1 cmFjeSIsICJUZXN0IGNhdXNlcyBjcmFzaCBvbiB0aGUgbmV4dCB0ZXN0IiwgMTI1MDY4KSwKICAg ICBdCiAKKyAgICBTTE9XID0gWworICAgICAgICAiV1RGX0xvY2suQ29udGVudGVkU2hvcnRTZWN0 aW9uIiwKKyAgICBdCisKICAgICBkZWYgX19pbml0X18oc2VsZiwgb3B0aW9ucywgdGVzdHM9W10p OgogICAgICAgICBzZWxmLl9vcHRpb25zID0gb3B0aW9ucwogCkBAIC0zNDAsNyArMzQ0LDEwIEBA IGNsYXNzIFRlc3RSdW5uZXI6CiAKICAgICBkZWYgX3J1bl9nb29nbGVfdGVzdChzZWxmLCB0ZXN0 X3Byb2dyYW0sIHN1YnRlc3QpOgogICAgICAgICB0ZXN0X2NvbW1hbmQgPSBbdGVzdF9wcm9ncmFt LCAnLS1ndGVzdF9maWx0ZXI9JXMnICUgKHN1YnRlc3QpXQotICAgICAgICByZXR1cm4gc2VsZi5f cnVuX3Rlc3RfY29tbWFuZCh0ZXN0X2NvbW1hbmQsIHNlbGYuX29wdGlvbnMudGltZW91dCkKKyAg ICAgICAgdGltZW91dCA9IHNlbGYuX29wdGlvbnMudGltZW91dAorICAgICAgICBpZiBzdWJ0ZXN0 IGluIFRlc3RSdW5uZXIuU0xPVzoKKyAgICAgICAgICAgIHRpbWVvdXQgKj0gMgorICAgICAgICBy ZXR1cm4gc2VsZi5fcnVuX3Rlc3RfY29tbWFuZCh0ZXN0X2NvbW1hbmQsIHRpbWVvdXQpCiAKICAg ICBkZWYgX3J1bl9nb29nbGVfdGVzdF9zdWl0ZShzZWxmLCB0ZXN0X3Byb2dyYW0pOgogICAgICAg ICByZXRjb2RlID0gMAo=