147763 2015-08-06 19:47:28 -0700 AX: Bug 147737 is causing test failures in Mavericks WK1 2015-12-07 16:10:38 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 d_russell webkit-unassigned aboxhall apinheiro cfleizach commit-queue dmazzoni jcraig jdiggs mario mmaxfield samuel_white webkit-bug-importer oldest_to_newest 1115599 0 d_russell 2015-08-06 19:47:28 -0700 Some layout tests are failing in Mavericks WK1 1115610 1 mmaxfield 2015-08-06 20:18:22 -0700 This has been making our bots red for many revisions. Should we roll out the problem? 1115613 2 d_russell 2015-08-06 20:24:20 -0700 (In reply to comment #1) > This has been making our bots red for many revisions. Should we roll out the > problem? The change that led to this is only critical for El Cap+ so I have a patch that skips the test in Yosemite and Mavericks and a wraps the change in a 10.11+ macro. I'd rather have a fix that makes it work on Mavericks, but I think that will take longer and if you'd like this fixed now I can submit the patch I have right now. 1115618 3 258442 d_russell 2015-08-06 20:35:21 -0700 Created attachment 258442 Patch 1115658 4 258442 mmaxfield 2015-08-06 22:47:11 -0700 Comment on attachment 258442 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258442&action=review r=me to get the dashboard green > Source/WebCore/accessibility/AXObjectCache.cpp:132 > +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100 This macro is only defined if PLATFORM(MAC) > LayoutTests/platform/mac/TestExpectations:1310 > +webkit.org/b/147763 [ Mavericks ] accessibility/mac/loaded-notification.html [ Skip ] There should be no need to skip these tests with the #if guard above 1115676 5 cfleizach 2015-08-07 00:05:03 -0700 looks like iOS build failed to build for real here The following build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release-iphoneos/WebCore.build/Objects-normal/armv7/AXObjectCache.o accessibility/AXObjectCache.cpp normal armv7 c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) Fa 1115678 6 258466 d_russell 2015-08-07 00:33:40 -0700 Created attachment 258466 Patch 1115686 7 258466 commit-queue 2015-08-07 01:32:37 -0700 Comment on attachment 258466 Patch Clearing flags on attachment: 258466 Committed r188120: <http://trac.webkit.org/changeset/188120> 1115687 8 commit-queue 2015-08-07 01:32:41 -0700 All reviewed patches have been landed. Closing bug. 1147067 9 mmaxfield 2015-12-07 16:04:56 -0800 Removing Mavericks-specific lines from platform/mac/TestExpecations due to no longer supporting Mavericks. 1147070 10 webkit-bug-importer 2015-12-07 16:05:23 -0800 <rdar://problem/23792882> 1147085 11 mmaxfield 2015-12-07 16:10:38 -0800 Committed r193663: <http://trac.webkit.org/changeset/193663> 258442 2015-08-06 20:35:21 -0700 2015-08-07 00:33:35 -0700 Patch bug-147763-20150806203511.patch text/plain 2802 d_russell U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4MTAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDAxNmZjMGIzMTdmMTQ4 NWQ3ZjU5MzNmMTNjNjViMzAzOGM0MTk3Yy4uMzU4YjhiNWJhYjUzNDlmY2YwMmE5ZTQzY2ZjMjM3 NjRmNTlmNzQ3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTA4LTA2ICBEb3Vn IFJ1c3NlbGwgIDxkX3J1c3NlbGxAYXBwbGUuY29tPgorCisgICAgICAgIEFYOiBCdWcgMTQ3NzM3 IGlzIGNhdXNpbmcgdGVzdCBmYWlsdXJlcyBpbiBNYXZlcmlja3MgV0sxCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDc3NjMKKworICAgICAgICBSZXN0 cmljdCBjaGFuZ2UgbWFkZSBpbiAxNDc3MzcgdG8gRWxDYXBpdGFuKyBiZWNhdXNlIGl0IGlzIGNh dXNpbmcgdGVzdHMKKyAgICAgICAgdG8gZmFpbCBpbiBNYXZlcmlja3MuCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZXMgZmFpbGluZyB0ZXN0cy4K KworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpBWE9iamVjdENhY2hlOjpzZXRFbmhhbmNlZFVzZXJJbnRlcmZhY2VBY2Nlc3NpYmls aXR5KToKKwogMjAxNS0wOC0wNiAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJr aXQub3JnPgogCiAgICAgICAgIFtXaW5dIENNYWtlIGJ1aWxkIGZpeCBhZnRlciByMTg4MDk4Lgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5jcHAKaW5kZXgg ZWVmMjZiZGM2YzM5MWViZTc0OGQ2NGY0NTYwZjA2OTdhNGFlZGJiMC4uYjQwZWZjZDc2YzEzZDAx NjI4Y2NlOWFkZmZlNjM1N2U3NmE3MmUyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNj ZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3Np YmlsaXR5L0FYT2JqZWN0Q2FjaGUuY3BwCkBAIC0xMjksOCArMTI5LDEwIEBAIHZvaWQgQVhPYmpl Y3RDYWNoZTo6ZGlzYWJsZUFjY2Vzc2liaWxpdHkoKQogdm9pZCBBWE9iamVjdENhY2hlOjpzZXRF bmhhbmNlZFVzZXJJbnRlcmZhY2VBY2Nlc3NpYmlsaXR5KGJvb2wgZmxhZykKIHsKICAgICBnQWNj ZXNzaWJpbGl0eUVuaGFuY2VkVXNlckludGVyZmFjZUVuYWJsZWQgPSBmbGFnOworI2lmIF9fTUFD X09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxMTAwCiAgICAgaWYgKGZsYWcpCiAgICAg ICAgIGVuYWJsZUFjY2Vzc2liaWxpdHkoKTsKKyNlbmRpZgogfQogCiBBWE9iamVjdENhY2hlOjpB WE9iamVjdENhY2hlKERvY3VtZW50JiBkb2N1bWVudCkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA5OTk3NmNkMDk3Y2MxYWUw Y2ZjZmQzZDhhMDI1M2QyNTgwN2VjNTZkLi5lYzZlY2E2MzRlOTZjYTEwNmEwNGE3NTI1NDYxMWJi OTlhN2FkZjc4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTUtMDgtMDYgIERvdWcgUnVzc2Vs bCAgPGRfcnVzc2VsbEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IEJ1ZyAxNDc3MzcgaXMgY2F1 c2luZyB0ZXN0IGZhaWx1cmVzIGluIE1hdmVyaWNrcyBXSzEKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0Nzc2MworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlv bnM6CisKIDIwMTUtMDgtMDYgIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+ CiAKICAgICAgICAgVGhlIEpTT05QIHBhcnNlciBpbmNvcnJlY3RseSBwYXJzZXMgLTAgYXMgKzAu CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucyBi L0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDM3YWU4YWJi Y2ViODhmOTM2OTQzNGZlNDkzYTk3ZWZlNDM2OGFiMzEuLjBjMDQ5NTEyMTZiZGQ5ODY5N2YwYTUw MzY0ZWJjYTM3Nzg0YWRlMjYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9U ZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0 YXRpb25zCkBAIC0xMzA2LDMgKzEzMDYsNiBAQCBodHRwL3Rlc3RzL3NlY3VyaXR5L2NvbnRlbnRT ZWN1cml0eVBvbGljeS9tZWRpYS1zcmMtYWxsb3dlZC5odG1sIFsgU2tpcCBdCiAKICMgV0sxLW9u bHkgdGltZW91dC4KIHdlYmtpdC5vcmcvYi8xNDc2ODMgcGxhdGZvcm0vbWFjL2Zhc3Qvc2Nyb2xs aW5nL3Njcm9sbC1kaXYtd2l0aC1uZXN0ZWQtbm9uc2Nyb2xsYWJsZS1pZnJhbWUuaHRtbCBbIFNr aXAgXQorCit3ZWJraXQub3JnL2IvMTQ3NzYzIFsgTWF2ZXJpY2tzIF0gYWNjZXNzaWJpbGl0eS9t YWMvbG9hZGVkLW5vdGlmaWNhdGlvbi5odG1sIFsgU2tpcCBdCit3ZWJraXQub3JnL2IvMTQ3NzYz IFsgWW9zZW1pdGUgXSBhY2Nlc3NpYmlsaXR5L21hYy9sb2FkZWQtbm90aWZpY2F0aW9uLmh0bWwg WyBTa2lwIF0K 258466 2015-08-07 00:33:40 -0700 2015-08-07 01:32:37 -0700 Patch bug-147763-20150807003329.patch text/plain 2829 d_russell U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4MTAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDAxNmZjMGIzMTdmMTQ4 NWQ3ZjU5MzNmMTNjNjViMzAzOGM0MTk3Yy4uMzU4YjhiNWJhYjUzNDlmY2YwMmE5ZTQzY2ZjMjM3 NjRmNTlmNzQ3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTA4LTA2ICBEb3Vn IFJ1c3NlbGwgIDxkX3J1c3NlbGxAYXBwbGUuY29tPgorCisgICAgICAgIEFYOiBCdWcgMTQ3NzM3 IGlzIGNhdXNpbmcgdGVzdCBmYWlsdXJlcyBpbiBNYXZlcmlja3MgV0sxCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDc3NjMKKworICAgICAgICBSZXN0 cmljdCBjaGFuZ2UgbWFkZSBpbiAxNDc3MzcgdG8gRWxDYXBpdGFuKyBiZWNhdXNlIGl0IGlzIGNh dXNpbmcgdGVzdHMKKyAgICAgICAgdG8gZmFpbCBpbiBNYXZlcmlja3MuCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZXMgZmFpbGluZyB0ZXN0cy4K KworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpBWE9iamVjdENhY2hlOjpzZXRFbmhhbmNlZFVzZXJJbnRlcmZhY2VBY2Nlc3NpYmls aXR5KToKKwogMjAxNS0wOC0wNiAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJr aXQub3JnPgogCiAgICAgICAgIFtXaW5dIENNYWtlIGJ1aWxkIGZpeCBhZnRlciByMTg4MDk4Lgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5jcHAKaW5kZXgg ZWVmMjZiZGM2YzM5MWViZTc0OGQ2NGY0NTYwZjA2OTdhNGFlZGJiMC4uZjM3NDg5N2EwYjFiNGY2 NDQxY2Y2YjMzZDA2YjI4ZDIwYmE0MjA0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNj ZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3Np YmlsaXR5L0FYT2JqZWN0Q2FjaGUuY3BwCkBAIC0xMjksOCArMTI5LDEyIEBAIHZvaWQgQVhPYmpl Y3RDYWNoZTo6ZGlzYWJsZUFjY2Vzc2liaWxpdHkoKQogdm9pZCBBWE9iamVjdENhY2hlOjpzZXRF bmhhbmNlZFVzZXJJbnRlcmZhY2VBY2Nlc3NpYmlsaXR5KGJvb2wgZmxhZykKIHsKICAgICBnQWNj ZXNzaWJpbGl0eUVuaGFuY2VkVXNlckludGVyZmFjZUVuYWJsZWQgPSBmbGFnOworI2lmIFBMQVRG T1JNKE1BQykKKyNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTEwMAog ICAgIGlmIChmbGFnKQogICAgICAgICBlbmFibGVBY2Nlc3NpYmlsaXR5KCk7CisjZW5kaWYKKyNl bmRpZgogfQogCiBBWE9iamVjdENhY2hlOjpBWE9iamVjdENhY2hlKERvY3VtZW50JiBkb2N1bWVu dCkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwppbmRleCA5OTk3NmNkMDk3Y2MxYWUwY2ZjZmQzZDhhMDI1M2QyNTgwN2VjNTZkLi5lYzZl Y2E2MzRlOTZjYTEwNmEwNGE3NTI1NDYxMWJiOTlhN2FkZjc4IDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTUtMDgtMDYgIERvdWcgUnVzc2VsbCAgPGRfcnVzc2VsbEBhcHBsZS5jb20+CisKKyAg ICAgICAgQVg6IEJ1ZyAxNDc3MzcgaXMgY2F1c2luZyB0ZXN0IGZhaWx1cmVzIGluIE1hdmVyaWNr cyBXSzEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0 Nzc2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog cGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMTUtMDgtMDYgIEtlaXRoIE1pbGxl ciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgVGhlIEpTT05QIHBhcnNlciBp bmNvcnJlY3RseSBwYXJzZXMgLTAgYXMgKzAuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0 RXhwZWN0YXRpb25zCmluZGV4IDM3YWU4YWJiY2ViODhmOTM2OTQzNGZlNDkzYTk3ZWZlNDM2OGFi MzEuLjBjMDQ5NTEyMTZiZGQ5ODY5N2YwYTUwMzY0ZWJjYTM3Nzg0YWRlMjYgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRl c3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCkBAIC0xMzA2LDMgKzEzMDYsNiBAQCBo dHRwL3Rlc3RzL3NlY3VyaXR5L2NvbnRlbnRTZWN1cml0eVBvbGljeS9tZWRpYS1zcmMtYWxsb3dl ZC5odG1sIFsgU2tpcCBdCiAKICMgV0sxLW9ubHkgdGltZW91dC4KIHdlYmtpdC5vcmcvYi8xNDc2 ODMgcGxhdGZvcm0vbWFjL2Zhc3Qvc2Nyb2xsaW5nL3Njcm9sbC1kaXYtd2l0aC1uZXN0ZWQtbm9u c2Nyb2xsYWJsZS1pZnJhbWUuaHRtbCBbIFNraXAgXQorCit3ZWJraXQub3JnL2IvMTQ3NzYzIFsg TWF2ZXJpY2tzIF0gYWNjZXNzaWJpbGl0eS9tYWMvbG9hZGVkLW5vdGlmaWNhdGlvbi5odG1sIFsg U2tpcCBdCit3ZWJraXQub3JnL2IvMTQ3NzYzIFsgWW9zZW1pdGUgXSBhY2Nlc3NpYmlsaXR5L21h Yy9sb2FkZWQtbm90aWZpY2F0aW9uLmh0bWwgWyBTa2lwIF0K