147750 2015-08-06 15:07:22 -0700 Structures used for tryGetConstantProperty() should be registered first 2015-08-06 15:37:29 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo oldest_to_newest 1115472 0 fpizlo 2015-08-06 15:07:22 -0700 Patch forthcoming. 1115475 1 258406 fpizlo 2015-08-06 15:11:15 -0700 Created attachment 258406 the patch 1115485 2 258406 saam 2015-08-06 15:34:18 -0700 Comment on attachment 258406 the patch r=me 1115487 3 258406 msaboff 2015-08-06 15:34:51 -0700 Comment on attachment 258406 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=258406&action=review r=me > Source/JavaScriptCore/ChangeLog:9 > + (JSC::DFG::Graph::tryGetConstantProperty): Add an assertion that effect. This should catch the bug sooner. Should the wording be "to that effect"? 1115489 4 258406 fpizlo 2015-08-06 15:36:00 -0700 Comment on attachment 258406 the patch This was reviewed by both Michael and Saam. 1115490 5 fpizlo 2015-08-06 15:36:15 -0700 (In reply to comment #3) > Comment on attachment 258406 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=258406&action=review > > r=me > > > Source/JavaScriptCore/ChangeLog:9 > > + (JSC::DFG::Graph::tryGetConstantProperty): Add an assertion that effect. This should catch the bug sooner. > > Should the wording be "to that effect"? Yup, fixed. 1115491 6 fpizlo 2015-08-06 15:37:29 -0700 Landed in http://trac.webkit.org/changeset/188067 258406 2015-08-06 15:11:15 -0700 2015-08-06 15:36:00 -0700 the patch blah.patch text/plain 4500 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg4MDYzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBA CisyMDE1LTA4LTA2ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg U3RydWN0dXJlcyB1c2VkIGZvciB0cnlHZXRDb25zdGFudFByb3BlcnR5KCkgc2hvdWxkIGJlIHJl Z2lzdGVyZWQgZmlyc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE0Nzc1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogZGZnL0RGR0dyYXBoLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpHcmFwaDo6dHJ5 R2V0Q29uc3RhbnRQcm9wZXJ0eSk6IEFkZCBhbiBhc3NlcnRpb24gdGhhdCBlZmZlY3QuIFRoaXMg c2hvdWxkIGNhdGNoIHRoZSBidWcgc29vbmVyLgorICAgICAgICAqIGRmZy9ERkdHcmFwaC5oOgor ICAgICAgICAoSlNDOjpERkc6OkdyYXBoOjphZGRTdHJ1Y3R1cmVTZXQpOiBSZWdpc3RlciBzdHJ1 Y3R1cmVzIHdoZW4gd2UgbWFrZSBhIHN0cnVjdHVyZSBzZXQuIFRoYXQgZW5zdXJlcyB0aGF0IHdl IHdvbid0IGNhbGwgdHJ5R2V0Q29uc3RhbnRQcm9wZXJ0eSgpIG9uIGEgc3RydWN0dXJlIHRoYXQg aGFzbid0IGJlZW4gcmVnaXN0ZXJlZCB5ZXQuCisgICAgICAgICogZGZnL0RGR1N0cnVjdHVyZVJl Z2lzdHJhdGlvblBoYXNlLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpTdHJ1Y3R1cmVSZWdpc3Ry YXRpb25QaGFzZTo6cnVuKTogRG9uJ3QgcmVnaXN0ZXIgc3RydWN0dXJlIHNldHMgaGVyZSBhbnlt b3JlLiBSZWdpc3RlcmluZyB0aGVtIGJlZm9yZSB3ZSBnZXQgaGVyZSBtZWFucyB0aGVyZSBpcyBu byBjaGFuY2Ugb2YgdGhlIGNvZGUgYmVpbmcgRENFJ2QgYmVmb3JlIHRoZSBzdHJ1Y3R1cmVzIGdl dCByZWdpc3RlcmVkLgorICAgICAgICAoSlNDOjpERkc6OlN0cnVjdHVyZVJlZ2lzdHJhdGlvblBo YXNlOjpyZWdpc3RlclN0cnVjdHVyZXMpOgorICAgICAgICAoSlNDOjpERkc6OlN0cnVjdHVyZVJl Z2lzdHJhdGlvblBoYXNlOjpyZWdpc3RlclN0cnVjdHVyZSk6CisgICAgICAgIChKU0M6OkRGRzo6 U3RydWN0dXJlUmVnaXN0cmF0aW9uUGhhc2U6OmFzc2VydEFyZVJlZ2lzdGVyZWQpOgorICAgICAg ICAoSlNDOjpERkc6OlN0cnVjdHVyZVJlZ2lzdHJhdGlvblBoYXNlOjphc3NlcnRJc1JlZ2lzdGVy ZWQpOgorICAgICAgICAoSlNDOjpERkc6OnBlcmZvcm1TdHJ1Y3R1cmVSZWdpc3RyYXRpb24pOgor CiAyMDE1LTA4LTA2ICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCiAg ICAgICAgIFJlbW92ZSBVbnNwZWNpZmllZEJvb2xUeXBlIGZyb20gSlNDCkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGZnL0RGR0dyYXBoLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR0dyYXBoLmNwcAkocmV2aXNpb24gMTg3OTkxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwMDIs NiArMTAwMiw4IEBAIEpTVmFsdWUgR3JhcGg6OnRyeUdldENvbnN0YW50UHJvcGVydHkoCiAgICAg CiAgICAgZm9yICh1bnNpZ25lZCBpID0gc3RydWN0dXJlU2V0LnNpemUoKTsgaS0tOykgewogICAg ICAgICBTdHJ1Y3R1cmUqIHN0cnVjdHVyZSA9IHN0cnVjdHVyZVNldFtpXTsKKyAgICAgICAgYXNz ZXJ0SXNSZWdpc3RlcmVkKHN0cnVjdHVyZSk7CisgICAgICAgIAogICAgICAgICBXYXRjaHBvaW50 U2V0KiBzZXQgPSBzdHJ1Y3R1cmUtPnByb3BlcnR5UmVwbGFjZW1lbnRXYXRjaHBvaW50U2V0KG9m ZnNldCk7CiAgICAgICAgIGlmICghc2V0IHx8ICFzZXQtPmlzU3RpbGxWYWxpZCgpKQogICAgICAg ICAgICAgcmV0dXJuIEpTVmFsdWUoKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHR3JhcGguaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0dy YXBoLmgJKHJldmlzaW9uIDE4Nzk5MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH R3JhcGguaAkod29ya2luZyBjb3B5KQpAQCAtMzI1LDYgKzMyNSw4IEBAIHB1YmxpYzoKICAgICAK ICAgICBTdHJ1Y3R1cmVTZXQqIGFkZFN0cnVjdHVyZVNldChjb25zdCBTdHJ1Y3R1cmVTZXQmIHN0 cnVjdHVyZVNldCkKICAgICB7CisgICAgICAgIGZvciAoU3RydWN0dXJlKiBzdHJ1Y3R1cmUgOiBz dHJ1Y3R1cmVTZXQpCisgICAgICAgICAgICByZWdpc3RlclN0cnVjdHVyZShzdHJ1Y3R1cmUpOwog ICAgICAgICBtX3N0cnVjdHVyZVNldC5hcHBlbmQoc3RydWN0dXJlU2V0KTsKICAgICAgICAgcmV0 dXJuICZtX3N0cnVjdHVyZVNldC5sYXN0KCk7CiAgICAgfQpJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdTdHJ1Y3R1cmVSZWdpc3RyYXRpb25QaGFzZS5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTdHJ1Y3R1cmVSZWdpc3RyYXRpb25QaGFz ZS5jcHAJKHJldmlzaW9uIDE4Nzk5MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH U3RydWN0dXJlUmVnaXN0cmF0aW9uUGhhc2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01Nyw3ICs1 Nyw3IEBAIHB1YmxpYzoKICAgICAgICAgcmVnaXN0ZXJTdHJ1Y3R1cmUobV9ncmFwaC5tX3ZtLmdl dHRlclNldHRlclN0cnVjdHVyZS5nZXQoKSk7CiAgICAgICAgIAogICAgICAgICBmb3IgKEZyb3pl blZhbHVlKiB2YWx1ZSA6IG1fZ3JhcGgubV9mcm96ZW5WYWx1ZXMpCi0gICAgICAgICAgICBtX2dy YXBoLmFzc2VydElzUmVnaXN0ZXJlZCh2YWx1ZS0+c3RydWN0dXJlKCkpOworICAgICAgICAgICAg YXNzZXJ0SXNSZWdpc3RlcmVkKHZhbHVlLT5zdHJ1Y3R1cmUoKSk7CiAgICAgICAgIAogICAgICAg ICBmb3IgKEJsb2NrSW5kZXggYmxvY2tJbmRleCA9IG1fZ3JhcGgubnVtQmxvY2tzKCk7IGJsb2Nr SW5kZXgtLTspIHsKICAgICAgICAgICAgIEJhc2ljQmxvY2sqIGJsb2NrID0gbV9ncmFwaC5ibG9j ayhibG9ja0luZGV4KTsKQEAgLTY5LDcgKzY5LDcgQEAgcHVibGljOgogICAgICAgICAgICAgCiAg ICAgICAgICAgICAgICAgc3dpdGNoIChub2RlLT5vcCgpKSB7CiAgICAgICAgICAgICAgICAgY2Fz ZSBDaGVja1N0cnVjdHVyZToKLSAgICAgICAgICAgICAgICAgICAgcmVnaXN0ZXJTdHJ1Y3R1cmVz KG5vZGUtPnN0cnVjdHVyZVNldCgpKTsKKyAgICAgICAgICAgICAgICAgICAgYXNzZXJ0QXJlUmVn aXN0ZXJlZChub2RlLT5zdHJ1Y3R1cmVTZXQoKSk7CiAgICAgICAgICAgICAgICAgICAgIGJyZWFr OwogICAgICAgICAgICAgICAgIAogICAgICAgICAgICAgICAgIGNhc2UgTmV3T2JqZWN0OgpAQCAt MTQ1LDggKzE0NSw4IEBAIHB1YmxpYzoKIHByaXZhdGU6CiAgICAgdm9pZCByZWdpc3RlclN0cnVj dHVyZXMoY29uc3QgU3RydWN0dXJlU2V0JiBzZXQpCiAgICAgewotICAgICAgICBmb3IgKHVuc2ln bmVkIGkgPSBzZXQuc2l6ZSgpOyBpLS07KQotICAgICAgICAgICAgcmVnaXN0ZXJTdHJ1Y3R1cmUo c2V0W2ldKTsKKyAgICAgICAgZm9yIChTdHJ1Y3R1cmUqIHN0cnVjdHVyZSA6IHNldCkKKyAgICAg ICAgICAgIHJlZ2lzdGVyU3RydWN0dXJlKHN0cnVjdHVyZSk7CiAgICAgfQogICAgIAogICAgIHZv aWQgcmVnaXN0ZXJTdHJ1Y3R1cmUoU3RydWN0dXJlKiBzdHJ1Y3R1cmUpCkBAIC0xNTQsNiArMTU0 LDE4IEBAIHByaXZhdGU6CiAgICAgICAgIGlmIChzdHJ1Y3R1cmUpCiAgICAgICAgICAgICBtX2dy YXBoLnJlZ2lzdGVyU3RydWN0dXJlKHN0cnVjdHVyZSk7CiAgICAgfQorCisgICAgdm9pZCBhc3Nl cnRBcmVSZWdpc3RlcmVkKGNvbnN0IFN0cnVjdHVyZVNldCYgc2V0KQorICAgIHsKKyAgICAgICAg Zm9yIChTdHJ1Y3R1cmUqIHN0cnVjdHVyZSA6IHNldCkKKyAgICAgICAgICAgIGFzc2VydElzUmVn aXN0ZXJlZChzdHJ1Y3R1cmUpOworICAgIH0KKworICAgIHZvaWQgYXNzZXJ0SXNSZWdpc3RlcmVk KFN0cnVjdHVyZSogc3RydWN0dXJlKQorICAgIHsKKyAgICAgICAgaWYgKHN0cnVjdHVyZSkKKyAg ICAgICAgICAgIG1fZ3JhcGguYXNzZXJ0SXNSZWdpc3RlcmVkKHN0cnVjdHVyZSk7CisgICAgfQog fTsKIAogYm9vbCBwZXJmb3JtU3RydWN0dXJlUmVnaXN0cmF0aW9uKEdyYXBoJiBncmFwaCkK