147749 2015-08-06 14:59:47 -0700 The typedArrayLength function in FTLLowerDFGToLLVM is dead code. 2015-08-06 16:26:03 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keith_miller webkit-unassigned commit-queue oldest_to_newest 1115467 0 keith_miller 2015-08-06 14:59:47 -0700 the typedArrayLength function does not appear to be called anywhere and is dead code. Currently the typedArrayLength is compiled in compileGetArrayLength() rather than through this function. 1115470 1 258404 keith_miller 2015-08-06 15:03:55 -0700 Created attachment 258404 Patch 1115531 2 258404 commit-queue 2015-08-06 16:26:01 -0700 Comment on attachment 258404 Patch Clearing flags on attachment: 258404 Committed r188086: <http://trac.webkit.org/changeset/188086> 1115532 3 commit-queue 2015-08-06 16:26:03 -0700 All reviewed patches have been landed. Closing bug. 258404 2015-08-06 15:03:55 -0700 2015-08-06 16:26:01 -0700 Patch 0001-The-typedArrayLength-function-in-FTLLowerDFGToLLVM-i.patch text/plain 2144 keith_miller RnJvbSBiOGFlZTgyMGRhYmI2ZTZiNTk5YTRjMWQ2NzMwZDkwZjEwZWYxZjFhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLZWl0aCBNaWxsZXIgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+ CkRhdGU6IFRodSwgNiBBdWcgMjAxNSAxNTowMjoyNCAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIFRo ZSB0eXBlZEFycmF5TGVuZ3RoIGZ1bmN0aW9uIGluIEZUTExvd2VyREZHVG9MTFZNIGlzIGRlYWQK IGNvZGUuCgotLS0KIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAg ICAgIHwgMTMgKysrKysrKysrKysrKwogU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dl ckRGR1RvTExWTS5jcHAgfCAxMyAtLS0tLS0tLS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDEzIGlu c2VydGlvbnMoKyksIDEzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4 IDQ4YmU5OGMuLmMyMTdhODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFu Z2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE1LTA4LTA2ICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgor CisgICAgICAgIFRoZSB0eXBlZEFycmF5TGVuZ3RoIGZ1bmN0aW9uIGluIEZUTExvd2VyREZHVG9M TFZNIGlzIGRlYWQgY29kZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE0Nzc0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFJlbW92ZWQgZGVhZCBjb2RlIGVsaW1pbmF0aW9uLiB0aGUgVHlwZWRBcnJheSBs ZW5ndGggaXMgY29tcGlsZWQgaW4gY29tcGlsZUdldEFycmF5TGVuZ3RoKCkKKyAgICAgICAgdGh1 cyBubyBvbmUgY2FsbHMgdGhpcyBjb2RlLgorCisgICAgICAgICogZnRsL0ZUTExvd2VyREZHVG9M TFZNLmNwcDoKKyAgICAgICAgKEpTQzo6RlRMOjpERkc6Okxvd2VyREZHVG9MTFZNOjp0eXBlZEFy cmF5TGVuZ3RoKTogRGVsZXRlZC4KKwogMjAxNS0wNy0xNSAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxn aGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2luXSBGaXggYXJtdjcgYnVpbGQuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNwcCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0xMVk0uY3BwCmluZGV4IDBlMWVj MDkuLjE2ZmVkMWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93 ZXJERkdUb0xMVk0uY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJE RkdUb0xMVk0uY3BwCkBAIC02MjM5LDE5ICs2MjM5LDYgQEAgcHJpdmF0ZToKICAgICAgICAgICAg IG1fb3V0LnBoaShtX291dC5pbnRQdHIsIGZhc3RCdXR0ZXJmbHksIHNsb3dCdXR0ZXJmbHkpKTsK ICAgICB9CiAgICAgCi0gICAgTFZhbHVlIHR5cGVkQXJyYXlMZW5ndGgoRWRnZSBiYXNlRWRnZSwg QXJyYXlNb2RlIGFycmF5TW9kZSwgTFZhbHVlIGJhc2UpCi0gICAgewotICAgICAgICBKU0FycmF5 QnVmZmVyVmlldyogdmlldyA9IG1fZ3JhcGgudHJ5R2V0Rm9sZGFibGVWaWV3KHByb3ZlblZhbHVl KGJhc2VFZGdlKSwgYXJyYXlNb2RlKTsKLSAgICAgICAgaWYgKHZpZXcpCi0gICAgICAgICAgICBy ZXR1cm4gbV9vdXQuY29uc3RJbnQzMih2aWV3LT5sZW5ndGgoKSk7Ci0gICAgICAgIHJldHVybiBt X291dC5sb2FkMzJOb25OZWdhdGl2ZShiYXNlLCBtX2hlYXBzLkpTQXJyYXlCdWZmZXJWaWV3X2xl bmd0aCk7Ci0gICAgfQotICAgIAotICAgIExWYWx1ZSB0eXBlZEFycmF5TGVuZ3RoKEVkZ2UgYmFz ZUVkZ2UsIEFycmF5TW9kZSBhcnJheU1vZGUpCi0gICAgewotICAgICAgICByZXR1cm4gdHlwZWRB cnJheUxlbmd0aChiYXNlRWRnZSwgYXJyYXlNb2RlLCBsb3dDZWxsKGJhc2VFZGdlKSk7Ci0gICAg fQotICAgIAogICAgIExWYWx1ZSBib29saWZ5KEVkZ2UgZWRnZSkKICAgICB7CiAgICAgICAgIHN3 aXRjaCAoZWRnZS51c2VLaW5kKCkpIHsKLS0gCjIuNC40Cgo=