147748 2015-08-06 14:58:58 -0700 SQLStatementBackend doesn't need to be refcounted 2015-08-06 15:32:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 1115466 0 andersca 2015-08-06 14:58:58 -0700 SQLStatementBackend doesn't need to be refcounted 1115468 1 258403 andersca 2015-08-06 14:59:47 -0700 Created attachment 258403 Patch 1115476 2 258403 ggaren 2015-08-06 15:13:49 -0700 Comment on attachment 258403 Patch r=me 1115483 3 andersca 2015-08-06 15:32:29 -0700 Committed r188066: <http://trac.webkit.org/changeset/188066> 258403 2015-08-06 14:59:47 -0700 2015-08-06 15:13:49 -0700 Patch bug-147748-20150806145937.patch text/plain 6475 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4MDYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTJlM2QyMWVmZTA0MWNl MzU0N2Y2NGZlNjNkMGRkNWU4ZDBkNWMzYS4uZmNlN2Y0NDEzMjUzNWZkMTI3YTg1NDA3ZjQwZDNk ZmJkNjY2ODVkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTA4LTA2ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgU1FMU3RhdGVtZW50 QmFja2VuZCBkb2Vzbid0IG5lZWQgdG8gYmUgcmVmY291bnRlZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ3NzQ4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlcmUncyBubyBzaGFyZWQgb3duZXJzaGlw IG9mIFNRTFN0YXRlbWVudEJhY2tlbmQgc28gd2UgY2FuIGp1c3QgdXNlIHN0ZDo6dW5pcXVlX3B0 ci4KKworICAgICAgICAqIE1vZHVsZXMvd2ViZGF0YWJhc2UvU1FMU3RhdGVtZW50QmFja2VuZC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpTUUxTdGF0ZW1lbnRCYWNrZW5kOjpjcmVhdGUpOiBEZWxl dGVkLgorICAgICAgICAqIE1vZHVsZXMvd2ViZGF0YWJhc2UvU1FMU3RhdGVtZW50QmFja2VuZC5o OgorICAgICAgICAqIE1vZHVsZXMvd2ViZGF0YWJhc2UvU1FMVHJhbnNhY3Rpb25CYWNrZW5kLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlNRTFRyYW5zYWN0aW9uQmFja2VuZDo6ZW5xdWV1ZVN0YXRl bWVudEJhY2tlbmQpOgorICAgICAgICAoV2ViQ29yZTo6U1FMVHJhbnNhY3Rpb25CYWNrZW5kOjpl eGVjdXRlU1FMKToKKyAgICAgICAgKiBNb2R1bGVzL3dlYmRhdGFiYXNlL1NRTFRyYW5zYWN0aW9u QmFja2VuZC5oOgorCiAyMDE1LTA4LTA2ICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBw bGUuY29tPgogCiAgICAgICAgIERvIG5vdCBlbmZvcmNlICJjb250ZW50LWRpc3Bvc2l0aW9uOiBh dHRhY2htZW50IiBzYW5kYm94IHJlc3RyaWN0aW9ucyBvbiBhIE1lZGlhRG9jdW1lbnQKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZGF0YWJhc2UvU1FMU3RhdGVtZW50QmFj a2VuZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmRhdGFiYXNlL1NRTFN0YXRlbWVu dEJhY2tlbmQuY3BwCmluZGV4IGNlMTM3ZDJhYWE1OGZmNWMwMThkMGVhN2U4OTFiNzk0OTQ1MjNi NzkuLmE2MThmNjYxZjI1OWI2Yzc1MGMyNWM2MGNhOGNjNzA0MzI1M2UwMGEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZGF0YWJhc2UvU1FMU3RhdGVtZW50QmFja2VuZC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJkYXRhYmFzZS9TUUxTdGF0ZW1lbnRC YWNrZW5kLmNwcApAQCAtNzUsMTIgKzc1LDYgQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi1S ZWY8U1FMU3RhdGVtZW50QmFja2VuZD4gU1FMU3RhdGVtZW50QmFja2VuZDo6Y3JlYXRlKHN0ZDo6 dW5pcXVlX3B0cjxTUUxTdGF0ZW1lbnQ+IGZyb250ZW5kLAotICAgIGNvbnN0IFN0cmluZyYgc3Rh dGVtZW50LCBjb25zdCBWZWN0b3I8U1FMVmFsdWU+JiBhcmd1bWVudHMsIGludCBwZXJtaXNzaW9u cykKLXsKLSAgICByZXR1cm4gYWRvcHRSZWYoKm5ldyBTUUxTdGF0ZW1lbnRCYWNrZW5kKFdURjo6 bW92ZShmcm9udGVuZCksIHN0YXRlbWVudCwgYXJndW1lbnRzLCBwZXJtaXNzaW9ucykpOwotfQot CiBTUUxTdGF0ZW1lbnRCYWNrZW5kOjpTUUxTdGF0ZW1lbnRCYWNrZW5kKHN0ZDo6dW5pcXVlX3B0 cjxTUUxTdGF0ZW1lbnQ+IGZyb250ZW5kLAogICAgIGNvbnN0IFN0cmluZyYgc3RhdGVtZW50LCBj b25zdCBWZWN0b3I8U1FMVmFsdWU+JiBhcmd1bWVudHMsIGludCBwZXJtaXNzaW9ucykKICAgICA6 IG1fZnJvbnRlbmQoV1RGOjptb3ZlKGZyb250ZW5kKSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvd2ViZGF0YWJhc2UvU1FMU3RhdGVtZW50QmFja2VuZC5oIGIvU291cmNlL1dl YkNvcmUvTW9kdWxlcy93ZWJkYXRhYmFzZS9TUUxTdGF0ZW1lbnRCYWNrZW5kLmgKaW5kZXggN2U5 OGNhYTZjM2EwM2I3MDUwMzQ2YmFiZmY4MzEzNWI5ZDlmYTJiMS4uNTk1MTBiNTBiY2Q0MzRkMTE5 ZmU3NGJiOTBlMDEyNjcwMjJmOGY0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxl cy93ZWJkYXRhYmFzZS9TUUxTdGF0ZW1lbnRCYWNrZW5kLmgKKysrIGIvU291cmNlL1dlYkNvcmUv TW9kdWxlcy93ZWJkYXRhYmFzZS9TUUxTdGF0ZW1lbnRCYWNrZW5kLmgKQEAgLTQxLDExICs0MSwx MCBAQCBjbGFzcyBTUUxSZXN1bHRTZXQ7CiBjbGFzcyBTUUxTdGF0ZW1lbnQ7CiBjbGFzcyBTUUxU cmFuc2FjdGlvbkJhY2tlbmQ7CiAKLWNsYXNzIFNRTFN0YXRlbWVudEJhY2tlbmQgOiBwdWJsaWMg VGhyZWFkU2FmZVJlZkNvdW50ZWQ8U1FMU3RhdGVtZW50QmFja2VuZD4geworY2xhc3MgU1FMU3Rh dGVtZW50QmFja2VuZCB7CiBwdWJsaWM6Ci0gICAgc3RhdGljIFJlZjxTUUxTdGF0ZW1lbnRCYWNr ZW5kPiBjcmVhdGUoc3RkOjp1bmlxdWVfcHRyPFNRTFN0YXRlbWVudD4sCi0gICAgICAgIGNvbnN0 IFN0cmluZyYgc3FsU3RhdGVtZW50LCBjb25zdCBWZWN0b3I8U1FMVmFsdWU+JiBhcmd1bWVudHMs IGludCBwZXJtaXNzaW9ucyk7Ci0gICAgdmlydHVhbCB+U1FMU3RhdGVtZW50QmFja2VuZCgpOwor ICAgIFNRTFN0YXRlbWVudEJhY2tlbmQoc3RkOjp1bmlxdWVfcHRyPFNRTFN0YXRlbWVudD4sIGNv bnN0IFN0cmluZyYgc3RhdGVtZW50LCBjb25zdCBWZWN0b3I8U1FMVmFsdWU+JiBhcmd1bWVudHMs IGludCBwZXJtaXNzaW9ucyk7CisgICAgflNRTFN0YXRlbWVudEJhY2tlbmQoKTsKIAogICAgIGJv b2wgZXhlY3V0ZShEYXRhYmFzZSYpOwogICAgIGJvb2wgbGFzdEV4ZWN1dGlvbkZhaWxlZER1ZVRv UXVvdGEoKSBjb25zdDsKQEAgLTYxLDkgKzYwLDYgQEAgcHVibGljOgogICAgIFBhc3NSZWZQdHI8 U1FMUmVzdWx0U2V0PiBzcWxSZXN1bHRTZXQoKSBjb25zdDsKIAogcHJpdmF0ZToKLSAgICBTUUxT dGF0ZW1lbnRCYWNrZW5kKHN0ZDo6dW5pcXVlX3B0cjxTUUxTdGF0ZW1lbnQ+LCBjb25zdCBTdHJp bmcmIHN0YXRlbWVudCwKLSAgICAgICAgY29uc3QgVmVjdG9yPFNRTFZhbHVlPiYgYXJndW1lbnRz LCBpbnQgcGVybWlzc2lvbnMpOwotCiAgICAgdm9pZCBzZXRGYWlsdXJlRHVlVG9RdW90YSgpOwog ICAgIHZvaWQgY2xlYXJGYWlsdXJlRHVlVG9RdW90YSgpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL3dlYmRhdGFiYXNlL1NRTFRyYW5zYWN0aW9uQmFja2VuZC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmRhdGFiYXNlL1NRTFRyYW5zYWN0aW9uQmFja2VuZC5j cHAKaW5kZXggM2ZiNmFkMmQ5Zjg0NTVjNmRlMWU3MTc4MzkxYjk0NjQ5OGI0ZmQ5MC4uZDk1Yzkw YTQxYjhhMzM0YmRkNmQyNzRjZDc5MWEyMWNjYjA4MzE0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvTW9kdWxlcy93ZWJkYXRhYmFzZS9TUUxUcmFuc2FjdGlvbkJhY2tlbmQuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZGF0YWJhc2UvU1FMVHJhbnNhY3Rpb25CYWNrZW5k LmNwcApAQCAtNDYzLDEwICs0NjMsMTAgQEAgU1FMVHJhbnNhY3Rpb25CYWNrZW5kOjpTdGF0ZUZ1 bmN0aW9uIFNRTFRyYW5zYWN0aW9uQmFja2VuZDo6c3RhdGVGdW5jdGlvbkZvcihTUUwKICAgICBy ZXR1cm4gc3RhdGVGdW5jdGlvbnNbc3RhdGljX2Nhc3Q8aW50PihzdGF0ZSldOwogfQogCi12b2lk IFNRTFRyYW5zYWN0aW9uQmFja2VuZDo6ZW5xdWV1ZVN0YXRlbWVudEJhY2tlbmQoUGFzc1JlZlB0 cjxTUUxTdGF0ZW1lbnRCYWNrZW5kPiBzdGF0ZW1lbnRCYWNrZW5kKQordm9pZCBTUUxUcmFuc2Fj dGlvbkJhY2tlbmQ6OmVucXVldWVTdGF0ZW1lbnRCYWNrZW5kKHN0ZDo6dW5pcXVlX3B0cjxTUUxT dGF0ZW1lbnRCYWNrZW5kPiBzdGF0ZW1lbnRCYWNrZW5kKQogewogICAgIE11dGV4TG9ja2VyIGxv Y2tlcihtX3N0YXRlbWVudE11dGV4KTsKLSAgICBtX3N0YXRlbWVudFF1ZXVlLmFwcGVuZChzdGF0 ZW1lbnRCYWNrZW5kKTsKKyAgICBtX3N0YXRlbWVudFF1ZXVlLmFwcGVuZChXVEY6Om1vdmUoc3Rh dGVtZW50QmFja2VuZCkpOwogfQogCiB2b2lkIFNRTFRyYW5zYWN0aW9uQmFja2VuZDo6Y29tcHV0 ZU5leHRTdGF0ZUFuZENsZWFudXBJZk5lZWRlZCgpCkBAIC01MjUsMTMgKzUyNSwxMiBAQCBib29s IFNRTFRyYW5zYWN0aW9uQmFja2VuZDo6c2hvdWxkUGVyZm9ybVdoaWxlUGF1c2VkKCkgY29uc3QK IAogdm9pZCBTUUxUcmFuc2FjdGlvbkJhY2tlbmQ6OmV4ZWN1dGVTUUwoc3RkOjp1bmlxdWVfcHRy PFNRTFN0YXRlbWVudD4gc3RhdGVtZW50LCBjb25zdCBTdHJpbmcmIHNxbFN0YXRlbWVudCwgY29u c3QgVmVjdG9yPFNRTFZhbHVlPiYgYXJndW1lbnRzLCBpbnQgcGVybWlzc2lvbnMpCiB7Ci0gICAg UmVmUHRyPFNRTFN0YXRlbWVudEJhY2tlbmQ+IHN0YXRlbWVudEJhY2tlbmQ7Ci0gICAgc3RhdGVt ZW50QmFja2VuZCA9IFNRTFN0YXRlbWVudEJhY2tlbmQ6OmNyZWF0ZShXVEY6Om1vdmUoc3RhdGVt ZW50KSwgc3FsU3RhdGVtZW50LCBhcmd1bWVudHMsIHBlcm1pc3Npb25zKTsKKyAgICBhdXRvIHN0 YXRlbWVudEJhY2tlbmQgPSBzdGQ6Om1ha2VfdW5pcXVlPFNRTFN0YXRlbWVudEJhY2tlbmQ+KFdU Rjo6bW92ZShzdGF0ZW1lbnQpLCBzcWxTdGF0ZW1lbnQsIGFyZ3VtZW50cywgcGVybWlzc2lvbnMp OwogCiAgICAgaWYgKG1fZGF0YWJhc2UtPmRlbGV0ZWQoKSkKICAgICAgICAgc3RhdGVtZW50QmFj a2VuZC0+c2V0RGF0YWJhc2VEZWxldGVkRXJyb3IoKTsKIAotICAgIGVucXVldWVTdGF0ZW1lbnRC YWNrZW5kKHN0YXRlbWVudEJhY2tlbmQpOworICAgIGVucXVldWVTdGF0ZW1lbnRCYWNrZW5kKFdU Rjo6bW92ZShzdGF0ZW1lbnRCYWNrZW5kKSk7CiB9CiAKIHZvaWQgU1FMVHJhbnNhY3Rpb25CYWNr ZW5kOjpub3RpZnlEYXRhYmFzZVRocmVhZElzU2h1dHRpbmdEb3duKCkKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZGF0YWJhc2UvU1FMVHJhbnNhY3Rpb25CYWNrZW5kLmgg Yi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmRhdGFiYXNlL1NRTFRyYW5zYWN0aW9uQmFja2Vu ZC5oCmluZGV4IGE5MzIwNmQyYzc2MDllMzY5YzRkODEwM2RjMGVjNmQ2NjFmNTJjODYuLmUyYmZl OWFmN2RiNTUzYmJlMDgyNjUxYTk2MmVjMzQ2ZmQ2ZjM3OWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvd2ViZGF0YWJhc2UvU1FMVHJhbnNhY3Rpb25CYWNrZW5kLmgKKysrIGIv U291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJkYXRhYmFzZS9TUUxUcmFuc2FjdGlvbkJhY2tlbmQu aApAQCAtODYsNyArODYsNyBAQCBwcml2YXRlOgogCiAgICAgdm9pZCBkb0NsZWFudXAoKTsKIAot ICAgIHZvaWQgZW5xdWV1ZVN0YXRlbWVudEJhY2tlbmQoUGFzc1JlZlB0cjxTUUxTdGF0ZW1lbnRC YWNrZW5kPik7CisgICAgdm9pZCBlbnF1ZXVlU3RhdGVtZW50QmFja2VuZChzdGQ6OnVuaXF1ZV9w dHI8U1FMU3RhdGVtZW50QmFja2VuZD4pOwogCiAgICAgLy8gU3RhdGUgTWFjaGluZSBmdW5jdGlv bnM6CiAgICAgdmlydHVhbCBTdGF0ZUZ1bmN0aW9uIHN0YXRlRnVuY3Rpb25Gb3IoU1FMVHJhbnNh Y3Rpb25TdGF0ZSkgb3ZlcnJpZGU7CkBAIC0xMTMsNyArMTEzLDcgQEAgcHJpdmF0ZToKICAgICB2 b2lkIHJlbGVhc2VPcmlnaW5Mb2NrSWZOZWVkZWQoKTsKIAogICAgIFJlZlB0cjxTUUxUcmFuc2Fj dGlvbj4gbV9mcm9udGVuZDsgLy8gSGFzIGEgcmVmZXJlbmNlIGN5Y2xlLCBhbmQgd2lsbCBicmVh ayBpbiBkb0NsZWFudXAoKS4KLSAgICBSZWZQdHI8U1FMU3RhdGVtZW50QmFja2VuZD4gbV9jdXJy ZW50U3RhdGVtZW50QmFja2VuZDsKKyAgICBzdGQ6OnVuaXF1ZV9wdHI8U1FMU3RhdGVtZW50QmFj a2VuZD4gbV9jdXJyZW50U3RhdGVtZW50QmFja2VuZDsKIAogICAgIFJlZlB0cjxEYXRhYmFzZT4g bV9kYXRhYmFzZTsKICAgICBSZWZQdHI8U1FMVHJhbnNhY3Rpb25XcmFwcGVyPiBtX3dyYXBwZXI7 CkBAIC0xMjksNyArMTI5LDcgQEAgcHJpdmF0ZToKICAgICBib29sIG1faGFzVmVyc2lvbk1pc21h dGNoOwogCiAgICAgTXV0ZXggbV9zdGF0ZW1lbnRNdXRleDsKLSAgICBEZXF1ZTxSZWZQdHI8U1FM U3RhdGVtZW50QmFja2VuZD4+IG1fc3RhdGVtZW50UXVldWU7CisgICAgRGVxdWU8c3RkOjp1bmlx dWVfcHRyPFNRTFN0YXRlbWVudEJhY2tlbmQ+PiBtX3N0YXRlbWVudFF1ZXVlOwogCiAgICAgc3Rk Ojp1bmlxdWVfcHRyPFNRTGl0ZVRyYW5zYWN0aW9uPiBtX3NxbGl0ZVRyYW5zYWN0aW9uOwogICAg IFJlZlB0cjxPcmlnaW5Mb2NrPiBtX29yaWdpbkxvY2s7Cg==