147747 2015-08-06 14:35:07 -0700 jsc-tailcall: Stop saving and restoring all callee saves on vmEntry / exit for platforms with per function callee saves handling 2015-09-14 10:58:56 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 148666 P2 Normal --- 147639 147759 146845 1 msaboff msaboff basile_clement oldest_to_newest 1115452 0 msaboff 2015-08-06 14:35:07 -0700 We don't need to save and restore all possible callee save registers at VM entry time for the platforms that properly handle callee save registers on function entry and exit. Currently this is just the 64 bit platforms. 1115457 1 258399 msaboff 2015-08-06 14:40:18 -0700 Created attachment 258399 Patch 1115480 2 258399 basile_clement 2015-08-06 15:24:52 -0700 Comment on attachment 258399 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258399&action=review LGTM > Source/JavaScriptCore/llint/LowLevelInterpreter.asm:400 > +if C_LOOP or ARM64 or X86_64 or X86_64_WIN I'd add a comment stating that this is handled correctly by the engine on 64 bits platforms. 1115501 3 msaboff 2015-08-06 15:45:31 -0700 Committed r188072: <http://trac.webkit.org/changeset/188072> 1118376 4 msaboff 2015-08-17 19:31:19 -0700 Committed r188568: <http://trac.webkit.org/changeset/188568> 1118377 5 msaboff 2015-08-17 19:32:47 -0700 Relanded patch after fixes landed in change sets r188555 & r188556. 1122416 6 basile_clement 2015-08-31 18:10:42 -0700 *** This bug has been marked as a duplicate of bug 148666 *** 1125644 7 258399 ossy 2015-09-14 10:58:56 -0700 Comment on attachment 258399 Patch Cleared review? from attachment 258399 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 258399 2015-08-06 14:40:18 -0700 2015-09-14 10:58:56 -0700 Patch 147747.patch text/plain 4794 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg4MDYyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE1LTA4LTA2ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIGpzYy10YWlsY2FsbDogU3RvcCBzYXZpbmcgYW5kIHJlc3RvcmluZyBhbGwgY2FsbGVlIHNh dmVzIG9uIHZtRW50cnkgLyBleGl0IGZvciBwbGF0Zm9ybXMgd2l0aCBwZXIgZnVuY3Rpb24gY2Fs bGVlIHNhdmVzIGhhbmRsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNDc3NDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBSZW1vdmVkIHNhdmluZyBvZiBjYWxsZWUgc2F2ZSByZWdpc3RlcnMgYW5kIG1h dGVyaWFsaXphdGlvbiBvZiBzcGVjaWFsIHRhZyByZWdpc3RlcnMgZm9yCisgICAgICAgIDY0IGJp dCBwbGF0Zm9ybXMuCisKKyAgICAgICAgKiBsbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbToK KyAgICAgICAgKiBsbGludC9Mb3dMZXZlbEludGVycHJldGVyNjQuYXNtOgorCiAyMDE1LTA4LTA0 ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgogCiAgICAgICAgIGpzYy10YWls Y2FsbDogQWxpZ24gY2FsbGVlIHNhdmUgcmVnaXN0ZXJzIG5hbWVzIGFjcm9zcyBMTEludCBhbmQg SklUcwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0 ZXI2NC5hc20KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xl dmVsSW50ZXJwcmV0ZXI2NC5hc20JKHJldmlzaW9uIDE4Nzk2NCkKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyNjQuYXNtCSh3b3JraW5nIGNvcHkpCkBA IC0yMTUsOSArMjE1LDYgQEAgbWFjcm8gZG9WTUVudHJ5KG1ha2VDYWxsKQogICAgIGVuZAogICAg IHN0b3JlcCBjZnIsIFZNOjp0b3BWTUVudHJ5RnJhbWVbdm1dCiAKLSAgICBtb3ZlIFRhZ1R5cGVO dW1iZXIsIHRhZ1R5cGVOdW1iZXIKLSAgICBhZGRwIFRhZ0JpdFR5cGVPdGhlciwgdGFnVHlwZU51 bWJlciwgdGFnTWFzawotCiAgICAgY2hlY2tTdGFja1BvaW50ZXJBbGlnbm1lbnQoZXh0cmFUZW1w UmVnLCAweGJhZDBkYzAyKQogCiAgICAgbWFrZUNhbGwoZW50cnksIHQzKQpJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbQko cmV2aXNpb24gMTg3OTY0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVs SW50ZXJwcmV0ZXIuYXNtCSh3b3JraW5nIGNvcHkpCkBAIC0zOTcsMTggKzM5NywxNCBAQCBtYWNy byBjaGVja1N0YWNrUG9pbnRlckFsaWdubWVudCh0ZW1wUmVnCiAgICAgZW5kCiBlbmQKIAotaWYg Q19MT09QCitpZiBDX0xPT1Agb3IgQVJNNjQgb3IgWDg2XzY0IG9yIFg4Nl82NF9XSU4KICAgICBj b25zdCBDYWxsZWVTYXZlUmVnaXN0ZXJDb3VudCA9IDAKIGVsc2lmIEFSTSBvciBBUk12N19UUkFE SVRJT05BTCBvciBBUk12NwogICAgIGNvbnN0IENhbGxlZVNhdmVSZWdpc3RlckNvdW50ID0gNwot ZWxzaWYgQVJNNjQKLSAgICBjb25zdCBDYWxsZWVTYXZlUmVnaXN0ZXJDb3VudCA9IDEwCi1lbHNp ZiBTSDQgb3IgWDg2XzY0IG9yIE1JUFMKK2Vsc2lmIFNINCBvciBNSVBTCiAgICAgY29uc3QgQ2Fs bGVlU2F2ZVJlZ2lzdGVyQ291bnQgPSA1CiBlbHNpZiBYODYgb3IgWDg2X1dJTgogICAgIGNvbnN0 IENhbGxlZVNhdmVSZWdpc3RlckNvdW50ID0gMwotZWxzaWYgWDg2XzY0X1dJTgotICAgIGNvbnN0 IENhbGxlZVNhdmVSZWdpc3RlckNvdW50ID0gNwogZW5kCiAKIGNvbnN0IENhbGxlZVJlZ2lzdGVy U2F2ZVNpemUgPSBDYWxsZWVTYXZlUmVnaXN0ZXJDb3VudCAqIFB0clNpemUKQEAgLTQxOCwxNyAr NDE0LDExIEBAIGNvbnN0IENhbGxlZVJlZ2lzdGVyU2F2ZVNpemUgPSBDYWxsZWVTYXYKIGNvbnN0 IFZNRW50cnlUb3RhbEZyYW1lU2l6ZSA9IChDYWxsZWVSZWdpc3RlclNhdmVTaXplICsgc2l6ZW9m IFZNRW50cnlSZWNvcmQgKyBTdGFja0FsaWdubWVudCAtIDEpICYgflN0YWNrQWxpZ25tZW50TWFz awogCiBtYWNybyBwdXNoQ2FsbGVlU2F2ZXMoKQotICAgIGlmIENfTE9PUAorICAgIGlmIENfTE9P UCBvciBBUk02NCBvciBYODZfNjQgb3IgWDg2XzY0X1dJTgogICAgIGVsc2lmIEFSTSBvciBBUk12 N19UUkFESVRJT05BTAogICAgICAgICBlbWl0ICJwdXNoIHtyNC1yMTB9IgogICAgIGVsc2lmIEFS TXY3CiAgICAgICAgIGVtaXQgInB1c2gge3I0LXI2LCByOC1yMTF9IgotICAgIGVsc2lmIEFSTTY0 Ci0gICAgICAgIGVtaXQgInN0cCB4MjAsIHgxOSwgW3NwLCAjLTE2XSEiCi0gICAgICAgIGVtaXQg InN0cCB4MjIsIHgyMSwgW3NwLCAjLTE2XSEiCi0gICAgICAgIGVtaXQgInN0cCB4MjQsIHgyMywg W3NwLCAjLTE2XSEiCi0gICAgICAgIGVtaXQgInN0cCB4MjYsIHgyNSwgW3NwLCAjLTE2XSEiCi0g ICAgICAgIGVtaXQgInN0cCB4MjgsIHgyNywgW3NwLCAjLTE2XSEiCiAgICAgZWxzaWYgTUlQUwog ICAgICAgICBlbWl0ICJhZGRpdSAkc3AsICRzcCwgLTIwIgogICAgICAgICBlbWl0ICJzdyAkMjAs IDE2KCRzcCkiCkBAIC00NTAsMzUgKzQ0MCwxNSBAQCBtYWNybyBwdXNoQ2FsbGVlU2F2ZXMoKQog ICAgICAgICBlbWl0ICJwdXNoIGVzaSIKICAgICAgICAgZW1pdCAicHVzaCBlZGkiCiAgICAgICAg IGVtaXQgInB1c2ggZWJ4IgotICAgIGVsc2lmIFg4Nl82NAotICAgICAgICBlbWl0ICJwdXNoICVy MTIiCi0gICAgICAgIGVtaXQgInB1c2ggJXIxMyIKLSAgICAgICAgZW1pdCAicHVzaCAlcjE0Igot ICAgICAgICBlbWl0ICJwdXNoICVyMTUiCi0gICAgICAgIGVtaXQgInB1c2ggJXJieCIKLSAgICBl bHNpZiBYODZfNjRfV0lOCi0gICAgICAgIGVtaXQgInB1c2ggcjEyIgotICAgICAgICBlbWl0ICJw dXNoIHIxMyIKLSAgICAgICAgZW1pdCAicHVzaCByMTQiCi0gICAgICAgIGVtaXQgInB1c2ggcjE1 IgotICAgICAgICBlbWl0ICJwdXNoIHJieCIKLSAgICAgICAgZW1pdCAicHVzaCByZGkiCi0gICAg ICAgIGVtaXQgInB1c2ggcnNpIgogICAgIGVuZAogZW5kCiAKIG1hY3JvIHBvcENhbGxlZVNhdmVz KCkKLSAgICBpZiBDX0xPT1AKKyAgICBpZiBDX0xPT1Agb3IgQVJNNjQgb3IgWDg2XzY0IG9yIFg4 Nl82NF9XSU4KICAgICBlbHNpZiBBUk0gb3IgQVJNdjdfVFJBRElUSU9OQUwKICAgICAgICAgZW1p dCAicG9wIHtyNC1yMTB9IgogICAgIGVsc2lmIEFSTXY3CiAgICAgICAgIGVtaXQgInBvcCB7cjQt cjYsIHI4LXIxMX0iCi0gICAgZWxzaWYgQVJNNjQKLSAgICAgICAgZW1pdCAibGRwIHgyOCwgeDI3 LCBbc3BdLCAjMTYiCi0gICAgICAgIGVtaXQgImxkcCB4MjYsIHgyNSwgW3NwXSwgIzE2IgotICAg ICAgICBlbWl0ICJsZHAgeDI0LCB4MjMsIFtzcF0sICMxNiIKLSAgICAgICAgZW1pdCAibGRwIHgy MiwgeDIxLCBbc3BdLCAjMTYiCi0gICAgICAgIGVtaXQgImxkcCB4MjAsIHgxOSwgW3NwXSwgIzE2 IgogICAgIGVsc2lmIE1JUFMKICAgICAgICAgZW1pdCAibHcgJDE2LCAwKCRzcCkiCiAgICAgICAg IGVtaXQgImx3ICQxNywgNCgkc3ApIgpAQCAtNTAwLDIwICs0NzAsNiBAQCBtYWNybyBwb3BDYWxs ZWVTYXZlcygpCiAgICAgICAgIGVtaXQgInBvcCBlYngiCiAgICAgICAgIGVtaXQgInBvcCBlZGki CiAgICAgICAgIGVtaXQgInBvcCBlc2kiCi0gICAgZWxzaWYgWDg2XzY0Ci0gICAgICAgIGVtaXQg InBvcCAlcmJ4IgotICAgICAgICBlbWl0ICJwb3AgJXIxNSIKLSAgICAgICAgZW1pdCAicG9wICVy MTQiCi0gICAgICAgIGVtaXQgInBvcCAlcjEzIgotICAgICAgICBlbWl0ICJwb3AgJXIxMiIKLSAg ICBlbHNpZiBYODZfNjRfV0lOCi0gICAgICAgIGVtaXQgInBvcCByc2kiCi0gICAgICAgIGVtaXQg InBvcCByZGkiCi0gICAgICAgIGVtaXQgInBvcCByYngiCi0gICAgICAgIGVtaXQgInBvcCByMTUi Ci0gICAgICAgIGVtaXQgInBvcCByMTQiCi0gICAgICAgIGVtaXQgInBvcCByMTMiCi0gICAgICAg IGVtaXQgInBvcCByMTIiCiAgICAgZW5kCiBlbmQKIApAQCAtNTU5LDEwICs1MTUsOSBAQCBtYWNy byBwcmVzZXJ2ZUNhbGxlZVNhdmVzVXNlZEJ5TExJbnQoKQogICAgICAgICBzdG9yZXAgY3NyMywg LTE2W2Nmcl0KICAgICAgICAgc3RvcmVwIGNzcjAsIC0yNFtjZnJdCiAgICAgZWxzaWYgWDg2XzY0 X1dJTgotICAgICAgICBzdG9yZXAgdDQsIC04W2Nmcl0KLSAgICAgICAgc3RvcmVwIGNzcjYsIC0x NltjZnJdCi0gICAgICAgIHN0b3JlcCBjc3I1LCAtMjRbY2ZyXQotICAgICAgICBzdG9yZXAgY3Ny MCwgLTMyW2Nmcl0KKyAgICAgICAgc3RvcmVwIGNzcjYsIC04W2Nmcl0KKyAgICAgICAgc3RvcmVw IGNzcjUsIC0xNltjZnJdCisgICAgICAgIHN0b3JlcCBjc3IwLCAtMjRbY2ZyXQogICAgIGVuZAog ZW5kCiAK