147725 2015-08-06 00:13:54 -0700 [EFL] Use the non-overlay scrollbar 2015-09-02 18:47:19 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 140243 148701 148735 1 hs85.jeong hs85.jeong commit-queue gyuyoung.kim lucas.de.marchi ryuan.choi oldest_to_newest 1115302 0 hs85.jeong 2015-08-06 00:13:54 -0700 I think non-overlay scrollbar looks better than the overlay scrollbar and other ports do that. But I turned on the overlay scrollbar to draw the scrollbar when I uploaded the patch(http://trac.webkit.org/changeset/186829). Because non-overlay scrollbar has a problem(https://bugs.webkit.org/show_bug.cgi?id=140243). If /b/140243 is fixed, we can show the non-overlay scrollbar with this patch. 1115309 1 258358 hs85.jeong 2015-08-06 00:35:11 -0700 Created attachment 258358 Patch 1115310 2 ryuan.choi 2015-08-06 00:37:23 -0700 (In reply to comment #0) > I think non-overlay scrollbar looks better than the overlay scrollbar and > other ports do that. > But I turned on the overlay scrollbar to draw the scrollbar when I uploaded > the patch(http://trac.webkit.org/changeset/186829). > Because non-overlay scrollbar has a > problem(https://bugs.webkit.org/show_bug.cgi?id=140243). > If /b/140243 is fixed, we can show the non-overlay scrollbar with this patch. I think that it should be an optional via theme. 1115312 3 258359 hs85.jeong 2015-08-06 01:02:23 -0700 Created attachment 258359 Patch 1115313 4 hs85.jeong 2015-08-06 01:08:44 -0700 (In reply to comment #2) > (In reply to comment #0) > > I think non-overlay scrollbar looks better than the overlay scrollbar and > > other ports do that. > > But I turned on the overlay scrollbar to draw the scrollbar when I uploaded > > the patch(http://trac.webkit.org/changeset/186829). > > Because non-overlay scrollbar has a > > problem(https://bugs.webkit.org/show_bug.cgi?id=140243). > > If /b/140243 is fixed, we can show the non-overlay scrollbar with this patch. > > I think that it should be an optional via theme. I changed the condition to use the setting value. 1116178 5 258359 commit-queue 2015-08-09 23:51:16 -0700 Comment on attachment 258359 Patch Clearing flags on attachment: 258359 Committed r188206: <http://trac.webkit.org/changeset/188206> 1116179 6 commit-queue 2015-08-09 23:51:21 -0700 All reviewed patches have been landed. Closing bug. 1122747 7 gyuyoung.kim 2015-09-01 19:36:17 -0700 (In reply to comment #5) > Comment on attachment 258359 [details] > Patch > > Clearing flags on attachment: 258359 > > Committed r188206: <http://trac.webkit.org/changeset/188206> EFL API test has been broken since r188206. ERR<5605>:ecore_evas modules/ecore_evas/engines/x/ecore_evas_x.c:4493 ecore_evas_gl_x11_options_new_internal() evas_engine_info_set() init engine 'opengl_x11' failed. ERR<5605>:evas_main lib/evas/canvas/evas_gl.c:138 evas_gl_new() Evas GL engine not available. ERR<5605>: ../../Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:54 toEwkViewChecked() safety check failed: evasObject == NULL CRI<5605>: ../../Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:767 ewk_view_contents_size_get() no private data for object (nil) ../../Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:1208: Failure Value of: contentsWidth Actual: 790 Expected: environment->defaultWidth() Which is: 800 258358 2015-08-06 00:35:11 -0700 2015-08-06 01:02:15 -0700 Patch bug-147725-20150806163501.patch text/plain 1316 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4MDE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGVkZmI2ZmMxMGFmNmZh MjA1ODhjMDFkZjYzODYwZTA1ZjFiYjQzYS4uMjU3OGVjYTVlMDdkMGQ2N2U4MmZlYmYxNGJlM2Zl MWMzMTliMTljYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA4LTA2ICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBVc2Ug dGhlIG5vbi1vdmVybGF5IHNjcm9sbGJhcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQ3NzI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2UgdGhlcmUgaXMgbm8gYmVoYXZp b3IgY2hhbmdlLgorCisgICAgICAgICogcGxhdGZvcm0vZWZsL1Njcm9sbGJhclRoZW1lRWZsLmg6 CisKIDIwMTUtMDgtMDUgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAg ICBDcmFzaCB3aGVuIHJlbW92aW5nIGNoaWxkcmVuIG9mIGEgTWF0aE1MU2VsZWN0RWxlbWVudApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1Njcm9sbGJhclRoZW1lRWZs LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvU2Nyb2xsYmFyVGhlbWVFZmwuaAppbmRl eCA4YjYxMDRmZWE3Mzc3MDdkZDc0MjdkNWIyOGFhZmUxM2UzNTE4M2YzLi43MGNjYjAyNGM1NTYx N2JhNmUzZWRjMjNiOTY2MjdmZGI0NzQ4MGY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9lZmwvU2Nyb2xsYmFyVGhlbWVFZmwuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9lZmwvU2Nyb2xsYmFyVGhlbWVFZmwuaApAQCAtNDMsNyArNDMsNiBAQCBwdWJsaWM6CiAg ICAgdm9pZCBzZXRTY3JvbGxiYXJUaGlja25lc3MoaW50IHRoaWNrbmVzcykgeyBtX3Njcm9sbGJh clRoaWNrbmVzcyA9IHRoaWNrbmVzczsgfQogCiBwcm90ZWN0ZWQ6Ci0gICAgdmlydHVhbCBib29s IHVzZXNPdmVybGF5U2Nyb2xsYmFycygpIGNvbnN0IG92ZXJyaWRlIHsgcmV0dXJuIHRydWU7IH0K ICAgICB2aXJ0dWFsIGJvb2wgaGFzQnV0dG9ucyhTY3JvbGxiYXImKSBvdmVycmlkZSB7IHJldHVy biBmYWxzZTsgfQogICAgIHZpcnR1YWwgYm9vbCBoYXNUaHVtYihTY3JvbGxiYXImKSBvdmVycmlk ZTsKIAo= 258359 2015-08-06 01:02:23 -0700 2015-08-09 23:51:16 -0700 Patch bug-147725-20150806170213.patch text/plain 2385 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4MDE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGVkZmI2ZmMxMGFmNmZh MjA1ODhjMDFkZjYzODYwZTA1ZjFiYjQzYS4uYTlhYTJhZjM2MTkwNWY0MDVkYTA2N2ViYjQ3MDBj NWI0YmJiYjUzZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTA4LTA2ICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBVc2Ug dGhlIG5vbi1vdmVybGF5IHNjcm9sbGJhcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQ3NzI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2UgdGhlcmUgaXMgbm8gYmVoYXZp b3IgY2hhbmdlLgorCisgICAgICAgICogcGxhdGZvcm0vZWZsL1Njcm9sbGJhclRoZW1lRWZsLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGJhclRoZW1lRWZsOjp1c2VzT3ZlcmxheVNjcm9s bGJhcnMpOgorICAgICAgICBDaGFuZ2VkIHRoZSBjb25kaXRpb24gb2YgdGhlICd1c2VzT3Zlcmxh eVNjcm9sbGJhcnMnIHRvIHVzZSB0aGUKKyAgICAgICAgc2V0dGluZyB2YWx1ZS4KKyAgICAgICAg KiBwbGF0Zm9ybS9lZmwvU2Nyb2xsYmFyVGhlbWVFZmwuaDoKKwogMjAxNS0wOC0wNSAgQ2hyaXMg RHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIENyYXNoIHdoZW4gcmVtb3Zpbmcg Y2hpbGRyZW4gb2YgYSBNYXRoTUxTZWxlY3RFbGVtZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9lZmwvU2Nyb2xsYmFyVGhlbWVFZmwuY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZWZsL1Njcm9sbGJhclRoZW1lRWZsLmNwcAppbmRleCA1OWE0OWQwNDc0NWFhNjNm OWU3ZjExMWY1MWIzZWQxYmZlZWJlYjdiLi4yZTEzNWJhNDI2YWJiOGE4OGJmNWM2NWRlYzVhZjI4 MzMzMmE3OTU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvU2Nyb2xs YmFyVGhlbWVFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9TY3JvbGxi YXJUaGVtZUVmbC5jcHAKQEAgLTMzLDYgKzMzLDcgQEAKICNpbmNsdWRlICJOb3RJbXBsZW1lbnRl ZC5oIgogI2luY2x1ZGUgIlBhZ2UuaCIKICNpbmNsdWRlICJSZW5kZXJUaGVtZUVmbC5oIgorI2lu Y2x1ZGUgIlNldHRpbmdzLmgiCiAKICNpbmNsdWRlIDx3dGYvTmV2ZXJEZXN0cm95ZWQuaD4KIApA QCAtNjMsNiArNjQsMTEgQEAgaW50IFNjcm9sbGJhclRoZW1lRWZsOjpzY3JvbGxiYXJUaGlja25l c3MoU2Nyb2xsYmFyQ29udHJvbFNpemUpCiAgICAgcmV0dXJuIGRlZmF1bHRUaGlja25lc3M7CiB9 CiAKK2Jvb2wgU2Nyb2xsYmFyVGhlbWVFZmw6OnVzZXNPdmVybGF5U2Nyb2xsYmFycygpIGNvbnN0 Cit7CisgICAgcmV0dXJuIFNldHRpbmdzOjp1c2VzT3ZlcmxheVNjcm9sbGJhcnMoKTsKK30KKwog Ym9vbCBTY3JvbGxiYXJUaGVtZUVmbDo6aGFzVGh1bWIoU2Nyb2xsYmFyJiBzY3JvbGxiYXIpCiB7 CiAgICAgcmV0dXJuIHRodW1iTGVuZ3RoKHNjcm9sbGJhcikgPiAwOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1Njcm9sbGJhclRoZW1lRWZsLmggYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9lZmwvU2Nyb2xsYmFyVGhlbWVFZmwuaAppbmRleCA4YjYxMDRmZWE3Mzc3 MDdkZDc0MjdkNWIyOGFhZmUxM2UzNTE4M2YzLi40N2EwNzM4ZTQ5MTg4YzkwY2FlZDQ2NDhkMjk5 MGE3YzZmNTA4NjNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvU2Ny b2xsYmFyVGhlbWVFZmwuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvU2Nyb2xs YmFyVGhlbWVFZmwuaApAQCAtNDMsNyArNDMsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBzZXRTY3Jv bGxiYXJUaGlja25lc3MoaW50IHRoaWNrbmVzcykgeyBtX3Njcm9sbGJhclRoaWNrbmVzcyA9IHRo aWNrbmVzczsgfQogCiBwcm90ZWN0ZWQ6Ci0gICAgdmlydHVhbCBib29sIHVzZXNPdmVybGF5U2Ny b2xsYmFycygpIGNvbnN0IG92ZXJyaWRlIHsgcmV0dXJuIHRydWU7IH0KKyAgICB2aXJ0dWFsIGJv b2wgdXNlc092ZXJsYXlTY3JvbGxiYXJzKCkgY29uc3Qgb3ZlcnJpZGU7CiAgICAgdmlydHVhbCBi b29sIGhhc0J1dHRvbnMoU2Nyb2xsYmFyJikgb3ZlcnJpZGUgeyByZXR1cm4gZmFsc2U7IH0KICAg ICB2aXJ0dWFsIGJvb2wgaGFzVGh1bWIoU2Nyb2xsYmFyJikgb3ZlcnJpZGU7CiAK