147723 2015-08-05 22:54:09 -0700 [GTK] Fix build issue related to the generated WebKitFontFamilyNames.h 2015-08-06 22:15:32 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy achristensen achristensen calvaris cgarcia clopez commit-queue mrobinson ossy oldest_to_newest 1115282 0 ossy 2015-08-05 22:54:09 -0700 Now the build is broken on the GTK bot with the following error: In file included from ../../Source/WebCore/testing/Internals.cpp:35: In file included from ../../Source/WebCore/loader/cache/CachedResourceLoader.h:32: In file included from ../../Source/WebCore/loader/cache/CachedResourceRequest.h:30: In file included from ../../Source/WebCore/dom/Element.h:29: In file included from ../../Source/WebCore/dom/Document.h:38: In file included from ../../Source/WebCore/platform/graphics/FontSelector.h:29: In file included from ../../Source/WebCore/platform/graphics/FontRanges.h:29: In file included from ../../Source/WebCore/platform/graphics/Font.h:30: In file included from ../../Source/WebCore/platform/graphics/FontPlatformData.h:27: In file included from ../../Source/WebCore/platform/graphics/freetype/FontPlatformData.h:29: In file included from ../../Source/WebCore/platform/graphics/FontCache.h:33: ../../Source/WebCore/platform/graphics/FontDescription.h:31:10: fatal error: 'WebKitFontFamilyNames.h' file not found #include "WebKitFontFamilyNames.h" ^ The problem is that WebKitFontFamilyNames.h isn't yet generated, so it must be a dependency problem in the cmake build sysytem. I don't have time to work on this bug, I just reported to let you know and feel free to pick it up if you are interested in it. 1115283 1 ossy 2015-08-05 22:57:30 -0700 First time we can noticed this clean build failure: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Build%29/builds/61040, because the build #61039 caused a fresh SVN checkout. 1115284 2 ossy 2015-08-05 23:00:48 -0700 One more thing: It's strange that EFL doesn't have this build problem, but this codes are in common cmake code path as far as I know. 1115290 3 ossy 2015-08-05 23:10:33 -0700 +info: I checked the generated ninja file of GTK and EFL too and it seems that testing/MockCDM.cpp is the only one source file which has the WebKitFontFamilyNames.h dependency set on EFL. But no other cpp has set this dependency. Maybe because they are added to WebCoreTestSupport_SOURCES and not to WebCore_SOURCES variable. 1115311 4 cgarcia 2015-08-06 00:59:38 -0700 Looking at the log, it seems to me that r187997 could have introduced the issue, since it removes the WebCore dependency from a couple of targets. 1115329 5 calvaris 2015-08-06 04:43:12 -0700 (In reply to comment #4) > Looking at the log, it seems to me that r187997 could have introduced the > issue, since it removes the WebCore dependency from a couple of targets. It is definitely this revision, I bisected it. 1115438 6 258394 achristensen 2015-08-06 14:05:41 -0700 Created attachment 258394 Patch 1115440 7 achristensen 2015-08-06 14:08:17 -0700 Sorry! Brent even commented about that line in WebCore/CMakeLists.txt. I guess EWS doesn't do clean builds, which is where this problem arises. My bad. Does this patch fix it? Also, is it really necessary to have a dependency on ${WEBCORE_DIR}/CMakeLists.txt inside of CMakeLists.txt? It would save a lot of rebuilding time if that weren't there, but I'm not sure why it's there enough to remove it. 1115555 8 achristensen 2015-08-06 16:59:56 -0700 This seems to prevent me from running into the same issue on the partially-complete CMake build on mac. 1115602 9 258394 gyuyoung.kim 2015-08-06 19:58:50 -0700 Comment on attachment 258394 Patch EFL port also has same build error when building it from scratch. 1115649 10 258394 commit-queue 2015-08-06 22:15:26 -0700 Comment on attachment 258394 Patch Clearing flags on attachment: 258394 Committed r188116: <http://trac.webkit.org/changeset/188116> 1115650 11 commit-queue 2015-08-06 22:15:32 -0700 All reviewed patches have been landed. Closing bug. 258394 2015-08-06 14:05:41 -0700 2015-08-06 22:15:26 -0700 Patch bug-147723-20150806140532.patch text/plain 1678 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4ODA1NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA4LTA2ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IEdUSyBj bGVhbiBidWlsZCBhZnRlciByMTg3OTk3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNDc3MjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0OgorICAgICAgICByMTg3OTk3IG1hZGUg aXQgc28gV2ViQ29yZVRlc3RTdXBwb3J0IGRvZXMgbm90IGxpbmsgd2l0aCBXZWJDb3JlLCB3aGlj aCBpcyBuZWNlc3NhcnkgdG8gZ2V0IER1bXBSZW5kZXJUcmVlIHRvIGxpbmsuCisgICAgICAgIEl0 IGFsc28gbWFkZSBpdCBzbyBXZWJDb3JlVGVzdFN1cHBvcnQgaXMgbm8gbG9uZ2VyIGRlcGVuZGVu dCBvbiBXZWJDb3JlLCB3aGljaCBjYXVzZXMgaXQgdG8gYnVpbGQgYXQgdGhlIHNhbWUgdGltZS4K KyAgICAgICAgVGhpcyBjYXVzZWQgcHJvYmxlbXMgYmVjYXVzZSBXZWJDb3JlVGVzdFN1cHBvcnQg dXNlcyBoZWFkZXJzIHRoYXQgYXJlIGdlbmVyYXRlZCBmb3IgV2ViQ29yZSwgc3VjaCBhcyBXZWJL aXRGb250RmFtaWx5TmFtZXMuaC4KKyAgICAgICAgQWRkaW5nIGEgZGVwZW5kZW5jeSBtYWtlcyBp dCBzbyB0aGF0IFdlYkNvcmVUZXN0U3VwcG9ydCB3YWl0cyB1bnRpbCBXZWJDb3JlIGlzIGRvbmUg Y29tcGlsaW5nIGJlZm9yZSBjb21waWxpbmcsCisgICAgICAgIHdoaWNoIGlzIHdoYXQgaXQgdXNl ZCB0byBkbywgYnV0IGl0IGRvZXMgbm90IGNhdXNlIGxpbmtpbmcgcHJvYmxlbXMgd2l0aCBEdW1w UmVuZGVyVHJlZS4KKwogMjAxNS0wOC0wNiAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRA YXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBjb21tZW50IHRvIENTU1BhcnNlclN0cmluZwpJbmRl eDogU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvQ01ha2VMaXN0cy50eHQJKHJldmlzaW9uIDE4ODA1MykKKysrIFNvdXJjZS9XZWJDb3Jl L0NNYWtlTGlzdHMudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0zNjQxLDYgKzM2NDEsNyBAQCBpZiAo TVNWQykKIGVuZGlmICgpCiAKIGFkZF9saWJyYXJ5KFdlYkNvcmVUZXN0U3VwcG9ydCAke1dlYkNv cmVUZXN0U3VwcG9ydF9MSUJSQVJZX1RZUEV9ICR7V2ViQ29yZVRlc3RTdXBwb3J0X1NPVVJDRVN9 KQorYWRkX2RlcGVuZGVuY2llcyhXZWJDb3JlVGVzdFN1cHBvcnQgV2ViQ29yZSkKIHRhcmdldF9s aW5rX2xpYnJhcmllcyhXZWJDb3JlVGVzdFN1cHBvcnQgJHtXZWJDb3JlVGVzdFN1cHBvcnRfTElC UkFSSUVTfSkKIHNldF90YXJnZXRfcHJvcGVydGllcyhXZWJDb3JlVGVzdFN1cHBvcnQgUFJPUEVS VElFUyBGT0xERVIgIldlYkNvcmUiKQogCg==